Re: [Xen-devel] [v2 1/6] Port WARN_ON_ONCE() from Linux

2018-06-06 Thread Sameer Goel
On 05/25/2018 01:07 AM, Jan Beulich wrote: On 24.05.18 at 22:23, wrote: --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -11,6 +11,19 @@ #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) #define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0) +#define WARN_O

Re: [Xen-devel] [v2 1/6] Port WARN_ON_ONCE() from Linux

2018-05-25 Thread Jan Beulich
>>> On 24.05.18 at 22:23, wrote: > > On 05/24/2018 01:53 AM, Jan Beulich wrote: > On 24.05.18 at 02:46, wrote: >>> Port WARN_ON_ONCE macro from Linux. >> In such a case you should justify adjustments you've made: > I can add more details, but have mostly just changed variable names. The >

Re: [Xen-devel] [v2 1/6] Port WARN_ON_ONCE() from Linux

2018-05-24 Thread Sameer Goel
On 05/24/2018 01:53 AM, Jan Beulich wrote: On 24.05.18 at 02:46, wrote: Port WARN_ON_ONCE macro from Linux. In such a case you should justify adjustments you've made: I can add more details, but have mostly just changed variable names. The macro is self explanatory. Should I just change t

Re: [Xen-devel] [v2 1/6] Port WARN_ON_ONCE() from Linux

2018-05-24 Thread Jan Beulich
>>> On 24.05.18 at 02:46, wrote: > Port WARN_ON_ONCE macro from Linux. In such a case you should justify adjustments you've made: > --- a/xen/include/xen/lib.h > +++ b/xen/include/xen/lib.h > @@ -11,6 +11,19 @@ > #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) > #define WARN_ON(p)

[Xen-devel] [v2 1/6] Port WARN_ON_ONCE() from Linux

2018-05-23 Thread Sameer Goel
Port WARN_ON_ONCE macro from Linux. Signed-off-by: Sameer Goel Acked-by: Julien Grall --- xen/arch/arm/xen.lds.S | 1 + xen/arch/x86/xen.lds.S | 1 + xen/include/xen/lib.h | 13 + 3 files changed, 15 insertions(+) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S inde