On 06/02/2018 12:28 AM, Sameer Goel wrote:
On 5/31/2018 11:16 PM, Manish Jaggi wrote:
On 05/31/2018 09:27 PM, Sameer Goel wrote:
On 5/30/2018 10:13 PM, Manish Jaggi wrote:
On 05/31/2018 04:31 AM, Sameer Goel wrote:
+
+static int arm_smmu_iommu_domain_init(struct domain *d)
Where is iommu
On 5/31/2018 11:16 PM, Manish Jaggi wrote:
>
>
> On 05/31/2018 09:27 PM, Sameer Goel wrote:
>>
>> On 5/30/2018 10:13 PM, Manish Jaggi wrote:
>>>
>>> On 05/31/2018 04:31 AM, Sameer Goel wrote:
+
+static int arm_smmu_iommu_domain_init(struct domain *d)
>>> Where is iommu_domai
On 05/31/2018 09:27 PM, Sameer Goel wrote:
On 5/30/2018 10:13 PM, Manish Jaggi wrote:
On 05/31/2018 04:31 AM, Sameer Goel wrote:
+
+static int arm_smmu_iommu_domain_init(struct domain *d)
Where is iommu_domain initialized?
The function does not use a iommu_domain * variable
Please check i
On 5/30/2018 10:10 PM, Manish Jaggi wrote:
>
>
> On 05/31/2018 01:16 AM, Sameer Goel wrote:
>> Manish, I'll take another look at the variable names. I might not have
>> enough time :).
On 05/23/2018 10:48 PM, Manish Jaggi wrote:
> Hi Sameer,
>
> General Comment, please us
On 5/30/2018 10:13 PM, Manish Jaggi wrote:
>
>
> On 05/31/2018 04:31 AM, Sameer Goel wrote:
>> +
>> +static int arm_smmu_iommu_domain_init(struct domain *d)
> Where is iommu_domain initialized?
> The function does not use a iommu_domain * variable
>> Please check iommu.c 2 levels
On 05/31/2018 04:31 AM, Sameer Goel wrote:
+
+static int arm_smmu_iommu_domain_init(struct domain *d)
Where is iommu_domain initialized?
The function does not use a iommu_domain * variable
Please check iommu.c 2 levels up.
In this function do you see iommu_domain getting allocated or initial
On 05/31/2018 01:16 AM, Sameer Goel wrote:
Manish, I'll take another look at the variable names. I might not have enough
time :).
On 05/23/2018 10:48 PM, Manish Jaggi wrote:
Hi Sameer,
General Comment, please use appropriate variable names for XXX_domain
structures in code which is xen sp
+
+static int arm_smmu_iommu_domain_init(struct domain *d)
>>> Where is iommu_domain initialized?
>>> The function does not use a iommu_domain * variable
Please check iommu.c 2 levels up.
Thanks,
Sameer
>>>
>>
>
>
> ___
> Xen-devel mailing
Manish, I'll take another look at the variable names. I might not have enough
time :).
>>
>>
>> On 05/23/2018 10:48 PM, Manish Jaggi wrote:
>>> Hi Sameer,
>>>
>>> General Comment, please use appropriate variable names for XXX_domain
>>> structures in code which is xen specific.
>> I thought that
On 5/25/2018 1:10 AM, Jan Beulich wrote:
On 24.05.18 at 22:26, wrote:
>> On 05/24/2018 01:57 AM, Jan Beulich wrote:
>> On 24.05.18 at 02:46, wrote:
--- /dev/null
+++ b/xen/include/xen/linux_compat.h
>>> I continue to dislike the idea of having a header with these contents in
Hi,
On 25/05/18 05:41, Manish Jaggi wrote:
On 05/25/2018 01:59 AM, Sameer Goel wrote:
On 05/23/2018 10:48 PM, Manish Jaggi wrote:
Hi Sameer,
General Comment, please use appropriate variable names for XXX_domain
structures in code which is xen specific.
I thought that we had discussed th
>>> On 24.05.18 at 22:26, wrote:
> On 05/24/2018 01:57 AM, Jan Beulich wrote:
> On 24.05.18 at 02:46, wrote:
>>> --- /dev/null
>>> +++ b/xen/include/xen/linux_compat.h
>> I continue to dislike the idea of having a header with these contents in
> this location.
> As explained previously this
On 05/25/2018 01:59 AM, Sameer Goel wrote:
On 05/23/2018 10:48 PM, Manish Jaggi wrote:
Hi Sameer,
General Comment, please use appropriate variable names for XXX_domain
structures in code which is xen specific.
I thought that we had discussed this before on one of the RFCs.
Yes and no one
On 05/23/2018 10:48 PM, Manish Jaggi wrote:
Hi Sameer,
General Comment, please use appropriate variable names for XXX_domain
structures in code which is xen specific.
I thought that we had discussed this before on one of the RFCs. At this
point we are just using the format used for smmu-v2.
On 05/24/2018 01:57 AM, Jan Beulich wrote:
On 24.05.18 at 02:46, wrote:
--- /dev/null
+++ b/xen/include/xen/linux_compat.h
I continue to dislike the idea of having a header with these contents in this
location.
As explained previously this header can be used for the any driver that
we want
Can you please point out the specific instances? This patch is no
different than the last v1 patch. I have just added tasklets to it.
On 05/23/2018 10:48 PM, Manish Jaggi wrote:
Hi Sameer,
General Comment, please use appropriate variable names for XXX_domain
structures in code which is xen s
>>> On 24.05.18 at 02:46, wrote:
> --- /dev/null
> +++ b/xen/include/xen/linux_compat.h
I continue to dislike the idea of having a header with these contents in this
location.
Independent of that I'd prefer if new files used hyphens instead of underscores
in their names - just like for command l
Hi Sameer,
General Comment, please use appropriate variable names for XXX_domain
structures in code which is xen specific.
On 05/24/2018 06:16 AM, Sameer Goel wrote:
This driver follows an approach similar to smmu driver. The intent here
is to reuse as much Linux code as possible.
- Glue cod
This driver follows an approach similar to smmu driver. The intent here
is to reuse as much Linux code as possible.
- Glue code has been introduced to bridge the API calls.
- Called Linux functions from the Xen IOMMU function calls.
- Xen modifications are preceded by /*Xen: comment */
- xen/linux_
19 matches
Mail list logo
