Re: [Xen-devel] Xen Coding style and clang-format

Hi Tamas, On Thu, Aug 1, 2019 at 6:58 PM Tamas K Lengyel wrote: > > On Thu, Aug 1, 2019 at 4:06 AM Viktor Mitin wrote: > > > > On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin > > wrote: > > > > > > On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth > > > wrote: > > > > > > > Viktor: thank you for spend

Re: [Xen-devel] Xen Coding style and clang-format

On Thu, Aug 1, 2019 at 4:06 AM Viktor Mitin wrote: > > On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin > wrote: > > > > On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote: > > > > > Viktor: thank you for spending time on this > > > > > > I added an item to community call tomorrow and CC'ed you in th

Re: [Xen-devel] Xen Coding style and clang-format

On Wed, Jul 31, 2019 at 8:05 PM Viktor Mitin wrote: > > On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote: > > > Viktor: thank you for spending time on this > > > > I added an item to community call tomorrow and CC'ed you in the invite. So > > I think what we need to do is figure out a way on how

Re: [Xen-devel] Xen Coding style and clang-format

On Wed, Jul 31, 2019 at 7:27 PM Lars Kurth wrote: > Viktor: thank you for spending time on this > > I added an item to community call tomorrow and CC'ed you in the invite. So I > think what we need to do is figure out a way on how to make the coding > standard enforceable by a coding standard c

Re: [Xen-devel] Xen Coding style and clang-format

> On 31 Jul 2019, at 12:43, Viktor Mitin wrote: > > On Wed, Jul 31, 2019 at 2:25 PM Julien Grall > wrote: >> >> >> >> On 31/07/2019 12:16, Viktor Mitin wrote: >>> On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: On 7/29/19 1:21 PM, Viktor Mitin wrote: >

Re: [Xen-devel] Xen Coding style and clang-format

On Wed, Jul 31, 2019 at 2:25 PM Julien Grall wrote: > > > > On 31/07/2019 12:16, Viktor Mitin wrote: > > On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: > >> On 7/29/19 1:21 PM, Viktor Mitin wrote: > >>> On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: > On 7/29/19 10:13 AM, Viktor M

Re: [Xen-devel] Xen Coding style and clang-format

On 31/07/2019 12:16, Viktor Mitin wrote: On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: On 7/29/19 1:21 PM, Viktor Mitin wrote: On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: On 7/29/19 10:13 AM, Viktor Mitin wrote: On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: * -

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, On Mon, Jul 29, 2019 at 3:35 PM Julien Grall wrote: > > Hi Viktor, > > On 7/29/19 1:21 PM, Viktor Mitin wrote: > > On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: > >> On 7/29/19 10:13 AM, Viktor Mitin wrote: > >>> On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: > >> > >>> It

Re: [Xen-devel] Xen Coding style and clang-format

Hi Viktor, On 7/29/19 1:21 PM, Viktor Mitin wrote: On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: On 7/29/19 10:13 AM, Viktor Mitin wrote: On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: It is unknown how difficult it would be to implement that with clang-format, however, it can

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, On Mon, Jul 29, 2019 at 1:49 PM Julien Grall wrote: > > Hi, > > On 7/29/19 10:13 AM, Viktor Mitin wrote: > > On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: > >> > >> I have already done some testings a couple of weeks ago with the patch > >> [1]. I > >> have sent some comments r

Re: [Xen-devel] Xen Coding style and clang-format

Hi, On 7/29/19 10:13 AM, Viktor Mitin wrote: On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: I have already done some testings a couple of weeks ago with the patch [1]. I have sent some comments regarding the change made by the tools that require some attention. It would be good if someon

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, On Fri, Jul 26, 2019 at 3:50 PM Julien Grall wrote: > > I have already done some testings a couple of weeks ago with the patch [1]. I > have sent some comments regarding the change made by the tools that require > some > attention. It would be good if someone go through them and try t

Re: [Xen-devel] Xen Coding style and clang-format

> On 26 Jul 2019, at 15:17, Viktor Mitin wrote: > > On Fri, Jul 26, 2019 at 4:52 PM Lars Kurth wrote: thank you for putting this mail together and driving this forward. I added committers@ as well as Doug. I am going to let others respond first. I am assuming we are looking for

Re: [Xen-devel] Xen Coding style and clang-format

On Fri, Jul 26, 2019 at 4:52 PM Lars Kurth wrote: > >> thank you for putting this mail together and driving this forward. I added > >> committers@ as well as Doug. I am going to let others respond first. > >> I am assuming we are looking for some testing? > > > > Yes, you are right. > > The imple

Re: [Xen-devel] Xen Coding style and clang-format

> On 26 Jul 2019, at 14:45, Viktor Mitin wrote: > >> Hi Viktor, > > Hi Lars, > >> thank you for putting this mail together and driving this forward. I added >> committers@ as well as Doug. I am going to let others respond first. >> I am assuming we are looking for some testing? > > Yes, you

Re: [Xen-devel] Xen Coding style and clang-format

Hi Julien, > I have already done some testings a couple of weeks ago with the patch [1]. I > have sent some comments regarding the change made by the tools that require > some > attention. It would be good if someone go through them and try to address one > by > one. For convenience I have repli

Re: [Xen-devel] Xen Coding style and clang-format

> Hi Viktor, Hi Lars, > thank you for putting this mail together and driving this forward. I added > committers@ as well as Doug. I am going to let others respond first. > I am assuming we are looking for some testing? Yes, you are right. The implementation has been updated and retested with ne

Re: [Xen-devel] Xen Coding style and clang-format

On 26/07/2019 13:42, Lars Kurth wrote: Hi Viktor, Hi, thank you for putting this mail together and driving this forward. I added committers@ as well as Doug. I am going to let others respond first. I am assuming we are looking for some testing? I have already done some testings a couple

Re: [Xen-devel] Xen Coding style and clang-format

> On 26 Jul 2019, at 13:30, Viktor Mitin wrote: > > Hi All, > > The Xen Project has a coding standard in place, but like many > projects, the standard is only enforced through peer review. Such > mistakes slip through and code is imported from other projects which > may not follow the same sta

[Xen-devel] Xen Coding style and clang-format

Hi All, The Xen Project has a coding standard in place, but like many projects, the standard is only enforced through peer review. Such mistakes slip through and code is imported from other projects which may not follow the same standard. The goal would be to come up with a tool that can audit the