On Mon, Aug 06, 2018 at 11:16:49AM +0200, Roger Pau Monné wrote:
> On Sat, Aug 04, 2018 at 08:25:18PM +0200, Marek Marczykowski-Górecki wrote:
> > Hi,
> >
> > libxl__domain_build calls libxl__build_hvm for both
> > LIBXL_DOMAIN_TYPE_HVM and LIBXL_DOMAIN_TYPE_PVH, but libxl__build_hvm
> > uses
On Sat, Aug 04, 2018 at 08:25:18PM +0200, Marek Marczykowski-Górecki wrote:
> Hi,
>
> libxl__domain_build calls libxl__build_hvm for both
> LIBXL_DOMAIN_TYPE_HVM and LIBXL_DOMAIN_TYPE_PVH, but libxl__build_hvm
> uses fields from b_info->u.hvm, which looks like invalid thing to do.
> Should those
Hi,
libxl__domain_build calls libxl__build_hvm for both
LIBXL_DOMAIN_TYPE_HVM and LIBXL_DOMAIN_TYPE_PVH, but libxl__build_hvm
uses fields from b_info->u.hvm, which looks like invalid thing to do.
Should those field be moved out of that union?
Additionally I think some asserts in every function
