Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-19 Thread Julien Grall
On 19/02/2021 08:46, Jan Beulich wrote: On 18.02.2021 18:41, Julien Grall wrote: On 18/02/2021 17:04, Jan Beulich wrote: On 18.02.2021 14:19, Julien Grall wrote: On 18/02/2021 13:10, Jan Beulich wrote: On 17.02.2021 17:29, Julien Grall wrote: On 17/02/2021 15:13, Jan Beulich wrote:

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-19 Thread Jan Beulich
On 18.02.2021 18:41, Julien Grall wrote: > > > On 18/02/2021 17:04, Jan Beulich wrote: >> On 18.02.2021 14:19, Julien Grall wrote: >>> >>> >>> On 18/02/2021 13:10, Jan Beulich wrote: On 17.02.2021 17:29, Julien Grall wrote: > On 17/02/2021 15:13, Jan Beulich wrote: >> On 17.02.2021

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Julien Grall
On 18/02/2021 17:04, Jan Beulich wrote: On 18.02.2021 14:19, Julien Grall wrote: On 18/02/2021 13:10, Jan Beulich wrote: On 17.02.2021 17:29, Julien Grall wrote: On 17/02/2021 15:13, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c>

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Jan Beulich
On 18.02.2021 14:19, Julien Grall wrote: > > > On 18/02/2021 13:10, Jan Beulich wrote: >> On 17.02.2021 17:29, Julien Grall wrote: >>> On 17/02/2021 15:13, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c> +++

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Julien Grall
On 18/02/2021 13:10, Jan Beulich wrote: On 17.02.2021 17:29, Julien Grall wrote: On 17/02/2021 15:13, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c> +++ b/xen/drivers/passthrough/x86/iommu.c> @@ -149,6 +149,13 @@ int

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-18 Thread Jan Beulich
On 17.02.2021 17:29, Julien Grall wrote: > On 17/02/2021 15:13, Jan Beulich wrote: >> On 17.02.2021 15:24, Julien Grall wrote:> --- >> a/xen/drivers/passthrough/x86/iommu.c> +++ >> b/xen/drivers/passthrough/x86/iommu.c> @@ -149,6 +149,13 @@ int >> arch_iommu_domain_init(struct domain *d)> >

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-17 Thread Julien Grall
Hi Jan, On 17/02/2021 15:13, Jan Beulich wrote: On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c> +++ b/xen/drivers/passthrough/x86/iommu.c> @@ -149,6 +149,13 @@ int arch_iommu_domain_init(struct domain *d)> > void arch_iommu_domain_destroy(struct domain

Re: [for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-17 Thread Jan Beulich
On 17.02.2021 15:24, Julien Grall wrote:> --- a/xen/drivers/passthrough/x86/iommu.c> +++ b/xen/drivers/passthrough/x86/iommu.c> @@ -149,6 +149,13 @@ int arch_iommu_domain_init(struct domain *d)> > void arch_iommu_domain_destroy(struct domain *d)> {> +/*> + * There should be not

[for-4.15][PATCH v3 3/3] xen/iommu: x86: Harden the IOMMU page-table allocator

2021-02-17 Thread Julien Grall
From: Julien Grall At the moment, we are assuming that only iommu_map() can allocate IOMMU page-table. Given the complexity of the IOMMU framework, it would be sensible to have a check closer to the IOMMU allocator. This would avoid to leak IOMMU page-tables again in the future.