Re: PING Re: [PATCH 00/14] Use const whether we point to literal strings (take 1)

2021-05-18 Thread Julien Grall
Hi Wei, On 17/05/2021 19:41, Wei Liu wrote: On Mon, May 10, 2021 at 06:49:01PM +0100, Julien Grall wrote: Hi, Ian, Wei, Anthony, can I get some feedbacks on the tools side? I think this is moving to the right direction so Acked-by: Wei Liu Thanks! I had committed most of the tools code

Re: PING Re: [PATCH 00/14] Use const whether we point to literal strings (take 1)

2021-05-17 Thread Wei Liu
On Mon, May 10, 2021 at 06:49:01PM +0100, Julien Grall wrote: > Hi, > > Ian, Wei, Anthony, can I get some feedbacks on the tools side? I think this is moving to the right direction so Acked-by: Wei Liu

PING Re: [PATCH 00/14] Use const whether we point to literal strings (take 1)

2021-05-10 Thread Julien Grall
Hi, Ian, Wei, Anthony, can I get some feedbacks on the tools side? Cheers, On 05/04/2021 16:56, Julien Grall wrote: From: Julien Grall Hi all, By default, both Clang and GCC will happily compile C code where non-const char * point to literal strings. This means the following code will be