RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-09-02 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory > > Hi Henry, > > On 02/09/2022 02:28, Henry Wang wrote: > >> This is technically a change in behavior for Xen (we would panic rather > >>

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-09-02 Thread Julien Grall
Hi Henry, On 02/09/2022 02:28, Henry Wang wrote: This is technically a change in behavior for Xen (we would panic rather than continue). I am happy with the proposal. However, this doesn't seem to be explained in the commit message. That said, I think this should be split in a separate patch al

RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-09-01 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory > > Hi Henry, > > > Also, this commit introduces the logic to parse the reserved heap > > configuation in device tree by

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-09-01 Thread Julien Grall
Hi Henry, On 24/08/2022 08:31, Henry Wang wrote: This commit introduces the reserved heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. A new boolean field `xen_heap` in `struct membank` is added to store the configuration telling if the memory bank is reser

RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-30 Thread Henry Wang
Hi Michal, > -Original Message- > From: Michal Orzel > >> +printk("Checking for reserved heap in /chosen\n"); > >> +if ( address_cells < 1 || size_cells < 1 ) > > address_cells and size_cells cannot be negative so you could just check > if > > there are 0.

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-30 Thread Michal Orzel
M >>> To: Henry Wang >>> Cc: Michal Orzel ; xen-devel@lists.xenproject.org; >>> Stefano Stabellini ; Julien Grall ; >>> Bertrand Marquis ; Wei Chen >>> ; Volodymyr Babchuk >>> ; Penny Zheng >>> Subject: RE: [PATCH 1/2] docs, xen/arm: Introduce res

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-29 Thread Michal Orzel
g; >> Stefano Stabellini ; Julien Grall ; >> Bertrand Marquis ; Wei Chen >> ; Volodymyr Babchuk >> ; Penny Zheng >> Subject: RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory >> >> On Thu, 25 Aug 2022, Henry Wang wrote: >>>>>

RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-29 Thread Henry Wang
Hi Stefano, > -Original Message- > From: Stefano Stabellini > Subject: Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory > > On Wed, 24 Aug 2022, Henry Wang wrote: > > --- > > The name of the device tree property was chosen because we want to >

RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-29 Thread Henry Wang
Babchuk > ; Penny Zheng > Subject: RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory > > On Thu, 25 Aug 2022, Henry Wang wrote: > > > > const char *name, > > > >

RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-29 Thread Stefano Stabellini
On Thu, 25 Aug 2022, Henry Wang wrote: > > > const char *name, > > > u32 address_cells, u32 size_cells) > > > { > > > @@ -301,16 +303,40 @@ static void __init process_chosen_node(const > > void *fdt, int node, > > >

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-29 Thread Stefano Stabellini
On Wed, 24 Aug 2022, Henry Wang wrote: > This commit introduces the reserved heap memory, which is parts of RAM > reserved in the beginning of the boot time for heap. > > A new boolean field `xen_heap` in `struct membank` is added to store the > configuration telling if the memory bank is reserved

RE: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-24 Thread Henry Wang
Hi Michal, It is great to hear from you! Hope you are doing well. > -Original Message- > From: Michal Orzel > Subject: Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory > Hi Henry, > > +to parts of RAM reserved in the beginning for heap. The memory is >

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory

2022-08-24 Thread Michal Orzel
Hi Henry, On 24/08/2022 09:31, Henry Wang wrote: > diff --git a/docs/misc/arm/device-tree/booting.txt > b/docs/misc/arm/device-tree/booting.txt > index 98253414b8..e064f64d9a 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -378,3 +378,49 @@