RE: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-19 Thread Tian, Kevin
> From: Jan Beulich > Sent: Monday, April 11, 2022 5:36 PM > > Prior extension of these functions to enable per-device quarantine page > tables already didn't add more locking there, but merely left in place > what had been there before. But really locking is unnecessary here: > We're running wit

Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-12 Thread Jan Beulich
On 11.04.2022 12:01, Andrew Cooper wrote: > On 11/04/2022 10:35, Jan Beulich wrote: >> Prior extension of these functions to enable per-device quarantine page >> tables already didn't add more locking there, but merely left in place >> what had been there before. But really locking is unnecessary h

Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-12 Thread Jan Beulich
On 12.04.2022 14:54, Roger Pau Monné wrote: > On Tue, Apr 12, 2022 at 02:17:16PM +0200, Jan Beulich wrote: >> On 12.04.2022 13:05, Roger Pau Monné wrote: >>> On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote: Prior extension of these functions to enable per-device quarantine page >>>

Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-12 Thread Roger Pau Monné
On Tue, Apr 12, 2022 at 02:17:16PM +0200, Jan Beulich wrote: > On 12.04.2022 13:05, Roger Pau Monné wrote: > > On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote: > >> Prior extension of these functions to enable per-device quarantine page > >> tables already didn't add more locking there,

Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-12 Thread Jan Beulich
On 12.04.2022 13:05, Roger Pau Monné wrote: > On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote: >> Prior extension of these functions to enable per-device quarantine page >> tables already didn't add more locking there, but merely left in place >> what had been there before. But really l

Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-12 Thread Roger Pau Monné
On Mon, Apr 11, 2022 at 11:35:54AM +0200, Jan Beulich wrote: > Prior extension of these functions to enable per-device quarantine page > tables already didn't add more locking there, but merely left in place > what had been there before. But really locking is unnecessary here: > We're running with

Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-11 Thread Jan Beulich
On 11.04.2022 12:01, Andrew Cooper wrote: > On 11/04/2022 10:35, Jan Beulich wrote: >> Prior extension of these functions to enable per-device quarantine page >> tables already didn't add more locking there, but merely left in place >> what had been there before. But really locking is unnecessary h

Re: [PATCH 1/8] IOMMU/x86: drop locking from quarantine_init() hooks

2022-04-11 Thread Andrew Cooper
On 11/04/2022 10:35, Jan Beulich wrote: > Prior extension of these functions to enable per-device quarantine page > tables already didn't add more locking there, but merely left in place > what had been there before. But really locking is unnecessary here: > We're running with pcidevs_lock held (i.