RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-10 Thread Henry Wang
Hi Christian, > -Original Message- > From: Christian Lindig > Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add > 'make format' and remove tabs > > On 10 Nov 2022, at 09:25, Henry Wang wrote: > > > > Hi Christian, > > >

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-10 Thread Christian Lindig
> On 10 Nov 2022, at 09:25, Henry Wang wrote: > > Hi Christian, > >> -Original Message- >> From: Christian Lindig >> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add >> 'make format' and remove tabs >>>> Whi

RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-10 Thread Henry Wang
Hi Christian, > -Original Message- > From: Christian Lindig > Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add > 'make format' and remove tabs > >> While I understand the goal and support, this seems to be a bit too late > >> to

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-10 Thread Christian Lindig
> On 9 Nov 2022, at 02:40, Henry Wang wrote: > >> >> -Original Message- >> From: Julien Grall >> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add >> 'make format' and remove tabs >> While I understand the goal and support

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-09 Thread Edwin Torok
nal Message----- >>>> From: Julien Grall >>>> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add >>>> 'make format' and remove tabs >>>> While I understand the goal and support, this seems to be a bit too late >>>> to do i

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-09 Thread Edwin Torok
> On 9 Nov 2022, at 14:18, Edwin Torok wrote: > > > >> On 9 Nov 2022, at 02:40, Henry Wang wrote: >> >> Hi Julien, >> >>> -Original Message----- >>> From: Julien Grall >>> Subject: Re: [PATCH for-4.17 v3 07/15] C

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-09 Thread Edwin Torok
> On 9 Nov 2022, at 02:40, Henry Wang wrote: > > Hi Julien, > >> -Original Message- >> From: Julien Grall >> Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add >> 'make format' and remove tabs >> While I understand the go

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-09 Thread Edwin Torok
> On 9 Nov 2022, at 03:19, Henry Wang wrote: > > Hi Edwin, > >> -Original Message- >>> [1] >> AS8PR08MB7991145C8063D6939AFFED8F92829@AS8PR08MB7991.eurprd08 >> .prod.outlook.com >> >> >> Hmm I thought that is my Outlook rewriting the link, but the archive at >> lore.kernel.org seems

RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Henry Wang
Hi Edwin, > -Original Message- > > [1] > AS8PR08MB7991145C8063D6939AFFED8F92829@AS8PR08MB7991.eurprd08 > .prod.outlook.com > > > Hmm I thought that is my Outlook rewriting the link, but the archive at > lore.kernel.org seems to have this mangled URL as well which I cannot open. > Could

RE: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add > 'make format' and remove tabs > While I understand the goal and support, this seems to be a bit too late > to do it in Xen 4.17 (we are only

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Edwin Torok
> On 8 Nov 2022, at 17:26, Julien Grall wrote: > > > > On 08/11/2022 17:02, Edwin Torok wrote: >>> On 8 Nov 2022, at 16:03, Julien Grall wrote: >>> >>> Hi, >>> >>> On 08/11/2022 15:33, Edwin Török wrote: See CODING_STYLE: Xen uses spaces, not tabs. * OCaml code: Using

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Julien Grall
On 08/11/2022 17:02, Edwin Torok wrote: On 8 Nov 2022, at 16:03, Julien Grall wrote: Hi, On 08/11/2022 15:33, Edwin Török wrote: See CODING_STYLE: Xen uses spaces, not tabs. * OCaml code: Using `ocp-indent` for now to just make minimal modifications in tabs vs spaces and get the right

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Edwin Torok
> On 8 Nov 2022, at 16:03, Julien Grall wrote: > > Hi, > > On 08/11/2022 15:33, Edwin Török wrote: >> See CODING_STYLE: Xen uses spaces, not tabs. >> * OCaml code: >> Using `ocp-indent` for now to just make minimal modifications in >> tabs vs spaces and get the right indentation. >> We can

Re: [PATCH for-4.17 v3 07/15] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs

2022-11-08 Thread Julien Grall
Hi, On 08/11/2022 15:33, Edwin Török wrote: See CODING_STYLE: Xen uses spaces, not tabs. * OCaml code: Using `ocp-indent` for now to just make minimal modifications in tabs vs spaces and get the right indentation. We can introduce `ocamlformat` later. * C stubs: just replace tabs with