Re: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-17 Thread Jan Beulich
On 10.05.2022 04:27, Penny Zheng wrote: > @@ -2769,12 +2769,43 @@ int __init acquire_domstatic_pages(struct domain *d, > mfn_t smfn, > > return 0; > } > + > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */

Re: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-17 Thread Julien Grall
On 17/05/2022 07:24, Penny Zheng wrote: Hi Julien Hi Penny, +if ( unlikely(!page) ) +return INVALID_MFN; + +smfn = page_to_mfn(page); + +if ( acquire_domstatic_pages(d, smfn, 1, memflags) ) I am OK if we call acquire_domstatic_pages() for now. But long term, I think

RE: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-17 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Tuesday, May 17, 2022 2:29 AM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Andrew Cooper > ; George Dunlap ; > Jan Beulich ; Stefano Stabellini ; > Wei Liu > Subject: Re: [

Re: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap

2022-05-16 Thread Julien Grall
Hi Penny, On 10/05/2022 03:27, Penny Zheng wrote: When static domain populates memory through populate_physmap on runtime, Typo: s/when static/when a static/ or "when static domains populate" s/on runtime/at runtime/ other than allocating from heap, it shall retrieve reserved pages from