Re: [PATCH v4 09/18] xen/riscv: implement function to map memory in guest p2m

2025-09-19 Thread Jan Beulich
On 17.09.2025 23:55, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/p2m.c > +++ b/xen/arch/riscv/p2m.c > @@ -96,6 +96,41 @@ void __init gstage_mode_detect(void) > local_hfence_gvma_all(); > } > > +/* > + * Force a synchronous P2M TLB flush. > + * > + * Must be called with the p2m lock held.

Re: [PATCH v4 10/18] xen/riscv: implement p2m_set_range()

2025-09-19 Thread Jan Beulich
On 17.09.2025 23:55, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/p2m.c > +++ b/xen/arch/riscv/p2m.c > @@ -16,6 +16,7 @@ > #include > > unsigned long __ro_after_init gstage_mode; > +unsigned int __ro_after_init gstage_root_level; > > void __init gstage_mode_detect(void) > { > @@ -53,6 +5

Re: [PATCH v4 07/18] xen/riscv: add new p2m types and helper macros for type classification

2025-09-19 Thread Jan Beulich
On 17.09.2025 23:55, Oleksii Kurochko wrote: > - Extended p2m_type_t with additional types: p2m_mmio_direct, > p2m_ext_storage. > - Added macros to classify memory types: P2M_RAM_TYPES. > - Introduced helper predicates: p2m_is_ram(), p2m_is_any_ram(). > - Introduce arch_dt_passthrough() to tell h

Re: [PATCH v4 05/18] xen/riscv: add root page table allocation

2025-09-19 Thread Jan Beulich
On 17.09.2025 23:55, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/p2m.c > +++ b/xen/arch/riscv/p2m.c > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -95,6 +96,70 @@ void __init gstage_mode_detect(void) > local_hfence_gvma_all(

Re: [PATCH v4 03/18] xen/riscv: introduce things necessary for p2m initialization

2025-09-19 Thread Jan Beulich
On 17.09.2025 23:55, Oleksii Kurochko wrote: > Introduce the following things: > - Update p2m_domain structure, which describe per p2m-table state, with: > - lock to protect updates to p2m. > - pool with pages used to construct p2m. > - back pointer to domain structure. > - p2m_init() to init

Re: [PATCH v4 02/18] xen/riscv: introduce VMID allocation and manegement

2025-09-19 Thread Jan Beulich
On 17.09.2025 23:55, Oleksii Kurochko wrote: > @@ -151,6 +152,8 @@ void __init noreturn start_xen(unsigned long bootcpu_id, > > gstage_mode_detect(); > > +vmid_init(); Like for the earlier patch, I'm not convinced this is a function good to call from the top-level start_xen(). The two

Re: [PATCH v4] x86: make Viridian support optional

2025-09-19 Thread Jan Beulich
On 19.09.2025 18:31, Grygorii Strashko wrote: > --- a/xen/arch/x86/hvm/Kconfig > +++ b/xen/arch/x86/hvm/Kconfig > @@ -62,6 +62,17 @@ config ALTP2M > > If unsure, stay with defaults. > > +config VIRIDIAN > + bool "Hyper-V enlightenments for guests" if EXPERT > + depends on AMD_SV

Re: [XEN][PATCH v3] x86: make Viridian support optional

2025-09-19 Thread Jan Beulich
On 18.09.2025 19:17, Grygorii Strashko wrote: > On 18.09.25 18:41, Jan Beulich wrote: >> On 16.09.2025 15:41, Grygorii Strashko wrote: >>> --- a/xen/arch/x86/hvm/viridian/viridian.c >>> +++ b/xen/arch/x86/hvm/viridian/viridian.c >>> @@ -1116,14 +1116,14 @@ static int cf_check viridian_save_domain_c

Re: [XEN][PATCH v3] x86: make Viridian support optional

2025-09-19 Thread Grygorii Strashko
Hi Jan, Thank you for your comments. On 19.09.25 18:29, Jan Beulich wrote: On 18.09.2025 19:17, Grygorii Strashko wrote: On 18.09.25 18:41, Jan Beulich wrote: On 16.09.2025 15:41, Grygorii Strashko wrote: --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @

Re: [PATCH v6 00/16] dma-mapping: migrate to physical address-based API

2025-09-19 Thread Keith Busch
On Fri, Sep 12, 2025 at 12:03:27PM +0300, Leon Romanovsky wrote: > On Fri, Sep 12, 2025 at 12:25:38AM +0200, Marek Szyprowski wrote: > > > > > > This series does the core code and modern flows. A followup series > > > will give the same treatment to the legacy dma_ops implementation. > > > > Appli

Re: [PATCH v2 1/7] mm: remove arch_flush_lazy_mmu_mode()

2025-09-19 Thread Yeoreum Yun
Reviewed-by: Yeoreum Yun On Mon, Sep 08, 2025 at 08:39:25AM +0100, Kevin Brodsky wrote: > This function has only ever been used in arch/x86, so there is no > need for other architectures to implement it. Remove it from > linux/pgtable.h and all architectures besides x86. > > The arm64 implementat

Re: [PATCH v3 1/7] docs/devel: Do not unparent in instance_finalize()

2025-09-19 Thread Akihiko Odaki
you agree with above, I can queue this series with above touched up, then no need to repost. I guess I will rewrite this patch, restoring the VFIOQuirk example, and re-check if this whole section is structured logically and consistently. Regards, Akihiko Odaki

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-19 Thread Akihiko Odaki
On 2025/09/19 3:23, Peter Xu wrote: On Thu, Sep 18, 2025 at 12:20:49PM -0400, Peter Xu wrote: On Thu, Sep 18, 2025 at 05:29:34PM +0200, BALATON Zoltan wrote: On Thu, 18 Sep 2025, Peter Xu wrote: On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: Based-on: ("[PATCH v2 00/14] hw/pc

Re: [PATCH v3 1/7] xen/numa: Add per_node() variables paralleling per_cpu() variables

2025-09-19 Thread Jan Beulich
On 07.09.2025 18:15, Bernhard Kaindl wrote: > During the review of the 3rd commit of the NUMA claims v1 series, it > was found to be concerning (performance-wise) add add another array > like this that randomly written from all nodes: > > +/* Per-node counts of free pages */ > +static unsigned lon

Re: [PATCH v2 4/7] x86/xen: support nested lazy_mmu sections (again)

2025-09-19 Thread Jürgen Groß
On 08.09.25 09:39, Kevin Brodsky wrote: Commit 49147beb0ccb ("x86/xen: allow nesting of same lazy mode") originally introduced support for nested lazy sections (LAZY_MMU and LAZY_CPU). It later got reverted by commit c36549ff8d84 as its implementation turned out to be intolerant to preemption. N

Re: [PATCH v2 12/26] xen/domctl: wrap vcpu_affinity_domctl() with CONFIG_MGMT_HYPERCALLS

2025-09-19 Thread Jan Beulich
On 10.09.2025 09:38, Penny Zheng wrote: > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -1402,10 +1402,12 @@ int vcpu_set_hard_affinity(struct vcpu *v, const > cpumask_t *affinity) > return vcpu_set_affinity(v, affinity, v->sched_unit->cpu_hard_affinity); > } > > +#ifd

Re: [PATCH v2 2/3] CI: Update x86 to use Debian Trixie

2025-09-19 Thread Andrew Cooper
On 11/09/2025 4:06 am, Marek Marczykowski-Górecki wrote: > On Wed, Sep 10, 2025 at 11:23:12PM +0100, Andrew Cooper wrote: >> diff --git a/automation/build/debian/13-x86_64.dockerfile >> b/automation/build/debian/13-x86_64.dockerfile >> new file mode 100644 >> index ..20e9d2f3f52d >> --

Re: [PATCH v4 5/8] x86/emul: Make condition coverage warning non-fatal

2025-09-19 Thread dmukhin
On Fri, Sep 12, 2025 at 03:44:24PM +0100, Andrew Cooper wrote: > Randconfig with GCC-14 (Debian Trixie) found: > > In file included from arch/x86/x86_emulate/x86_emulate.c:11, >from arch/x86/x86_emulate.c:27: > arch/x86/x86_emulate/x86_emulate.c: In function 'x86_emulate':

Re: [PATCH v2 2/2] libacpi: Remove CPU hotplug and GPE handling from PVH DSDTs

2025-09-19 Thread Jan Beulich
On 11.09.2025 13:53, Alejandro Vallejo wrote: > PVH guests have no DM, so this causes the guest to fetch the online CPU > bitmap from an unbacked 0xaf00 PIO port when executing the GPE handler. > > Seeing how ACPI CPU hotplug is the only event delivered via GPE, remove > the GPE handler in additio

Re: [PATCH] xen/domain: introduce DOMID_ANY

2025-09-19 Thread Jan Beulich
On 16.09.2025 19:37, dmuk...@xen.org wrote: > --- a/xen/include/public/xen.h > +++ b/xen/include/public/xen.h > @@ -608,6 +608,9 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); > /* DOMID_INVALID is used to identify pages with unknown owner. */ > #define DOMID_INVALIDxen_mk_uint(0x7FF4) > > +/

Re: [PATCH v2 1/2] libacpi: Prevent CPU hotplug AML from corrupting memory

2025-09-18 Thread Alejandro Vallejo
On Thu Sep 11, 2025 at 5:04 PM CEST, Jan Beulich wrote: > On 11.09.2025 14:03, Andrew Cooper wrote: >> On 11/09/2025 12:53 pm, Alejandro Vallejo wrote: >>> CPU hotplug relies on the online CPU bitmap being provided on PIO 0xaf00 >>> by the device model. The GPE handler checks this and compares it a

Re: [PATCH v3 1/7] docs/devel: Do not unparent in instance_finalize()

2025-09-18 Thread Peter Xu
On Thu, Sep 18, 2025 at 04:03:49PM -0400, Peter Xu wrote: > On Wed, Sep 17, 2025 at 07:13:26PM +0900, Akihiko Odaki wrote: > > Children are automatically unparented so manually unparenting is > > unnecessary. > > > > Worse, automatic unparenting happens before the instance_finalize() > > callback

Re: [PATCH v1] automation: edit pipeline to prevent running non-selected jobs

2025-09-18 Thread Nicola Vetrini
On 2025-09-03 03:49, victorm.l...@amd.com wrote: From: Victor Lira Filtering jobs using the selected jobs regex is missing for qemu-export/yocto- jobs when running regular pipelines and eclair jobs when running scheduled pipelines. Add the missing rules to filter out those jobs, and set a defa

Re: [PATCH v3 1/7] docs/devel: Do not unparent in instance_finalize()

2025-09-18 Thread Peter Xu
On Wed, Sep 17, 2025 at 07:13:26PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the instance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callbac

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-18 Thread Peter Xu
On Wed, Sep 17, 2025 at 02:23:35PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 17, 2025 at 02:17:35PM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 17, 2025 at 09:24:04PM +0900, Akihiko Odaki wrote: > > > On 2025/09/17 20:57, Daniel P. Berrangé wrote: > > > > On Wed, Sep 17, 2025 at 07:13:25P

Re: [PATCH v2 2/7] mm: introduce local state for lazy_mmu sections

2025-09-18 Thread Alexander Gordeev
On Fri, Sep 12, 2025 at 03:02:15PM +0200, David Hildenbrand wrote: > How would that work with nesting? I feel like there is a fundamental problem > with nesting with what you describe but I might be wrong. My picture is - flush on each lazy_mmu_disable(), pause on lazy_mmu_pause() and honour only

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-18 Thread Peter Xu
On Thu, Sep 18, 2025 at 12:20:49PM -0400, Peter Xu wrote: > On Thu, Sep 18, 2025 at 05:29:34PM +0200, BALATON Zoltan wrote: > > On Thu, 18 Sep 2025, Peter Xu wrote: > > > On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: > > > > Based-on: > > > > ("[PATCH v2 00/14] hw/pci-host/raven c

Re: [PATCH v4 3/8] CI: Merge categories in debian/12-x86_64.dockerfile

2025-09-18 Thread Marek Marczykowski-Górecki
On Fri, Sep 12, 2025 at 03:44:22PM +0100, Andrew Cooper wrote: > cpio needs to be in Tools (general) now that it's used by the general build > script. Merge the rest of the test phase jobs into one group, to avoid being > overly fine-grain. > > No functional change. > > Signed-off-by: Andrew Coo

Re: [PATCH] libxl: preserve errno in libxl__xcinfo2xlinfo()

2025-09-18 Thread Anthony PERARD
On Wed, Aug 27, 2025 at 09:16:38PM -0400, Jason Andryuk wrote: > On 2025-08-27 01:57, Jan Beulich wrote: > > Callers observing errors elsewhere may be confused by the ENOSYS that > > the Flask operation would yield on a Flask-disabled hypervisor. > > > > Signed-off-by: Jan Beulich > > --- > > Of

Re: [PATCH v6 11/13] xen/arm: Add support for system suspend triggered by hardware domain

2025-09-18 Thread Jan Beulich
On 09.09.2025 10:14, Mykola Kvach wrote: > On Tue, Sep 9, 2025 at 9:57 AM Jan Beulich wrote: >> On 09.09.2025 08:29, Mykola Kvach wrote: >>> Then, in domain_shutdown(), we can call need_hwdom_shutdown() instead >>> of directly checking is_hardware_domain(d). This keeps the logic >>> readable and a

Re: WARN in xennet_disconnect_backend when frontend is paused during backend shutdown

2025-09-18 Thread Marek Marczykowski-Górecki
On Fri, Sep 12, 2025 at 11:49:12AM +0200, Jürgen Groß wrote: > On 11.09.25 17:11, Marek Marczykowski-Górecki wrote: > > Hi, > > > > The steps: > > 1. Have domU netfront ("untrusted" here) and domU netback > > ("sys-firewall-alt" here). > > 2. Pause frontend > > 3. Shutdown backend > > 4. Unpause f

Re: [XEN][PATCH v3] x86: make Viridian support optional

2025-09-18 Thread Grygorii Strashko
On 18.09.25 18:41, Jan Beulich wrote: On 16.09.2025 15:41, Grygorii Strashko wrote: --- a/xen/arch/x86/hvm/Kconfig +++ b/xen/arch/x86/hvm/Kconfig @@ -62,6 +62,16 @@ config ALTP2M If unsure, stay with defaults. +config HVM_VIRIDIAN I may have said so already on v1: I'm not quite c

Re: [XEN][PATCH v3] x86: make Viridian support optional

2025-09-18 Thread Grygorii Strashko
On 18.09.25 18:19, Jan Beulich wrote: On 18.09.2025 17:15, Grygorii Strashko wrote: On 16.09.25 16:41, Grygorii Strashko wrote: --- a/xen/arch/x86/hvm/Kconfig +++ b/xen/arch/x86/hvm/Kconfig @@ -62,6 +62,16 @@ config ALTP2M If unsure, stay with defaults. +config HVM_VIRIDIAN +

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-18 Thread Peter Xu
On Thu, Sep 18, 2025 at 05:29:34PM +0200, BALATON Zoltan wrote: > On Thu, 18 Sep 2025, Peter Xu wrote: > > On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: > > > Based-on: > > > ("[PATCH v2 00/14] hw/pci-host/raven clean ups") > > > > Could I ask why this is a dependency? > > It re

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-18 Thread BALATON Zoltan
On Thu, 18 Sep 2025, Peter Xu wrote: On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: Based-on: ("[PATCH v2 00/14] hw/pci-host/raven clean ups") Could I ask why this is a dependency? It removes an address_space usage from raven so this series does not have to change that and

Re: [PATCH v4 01/18] xen/riscv: detect and initialize G-stage mode

2025-09-18 Thread Jan Beulich
On 17.09.2025 23:55, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/p2m.c > @@ -0,0 +1,91 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > + > +unsigned long __ro_after_init gstage_

Re: [XEN][PATCH v3] x86: make Viridian support optional

2025-09-18 Thread Jan Beulich
On 16.09.2025 15:41, Grygorii Strashko wrote: > --- a/xen/arch/x86/hvm/Kconfig > +++ b/xen/arch/x86/hvm/Kconfig > @@ -62,6 +62,16 @@ config ALTP2M > > If unsure, stay with defaults. > > +config HVM_VIRIDIAN I may have said so already on v1: I'm not quite convinced of the need or useful

Re: [XEN][PATCH v3] x86: make Viridian support optional

2025-09-18 Thread Jan Beulich
On 18.09.2025 17:15, Grygorii Strashko wrote: > On 16.09.25 16:41, Grygorii Strashko wrote: >> --- a/xen/arch/x86/hvm/Kconfig >> +++ b/xen/arch/x86/hvm/Kconfig >> @@ -62,6 +62,16 @@ config ALTP2M >> >>If unsure, stay with defaults. >> >> +config HVM_VIRIDIAN >> +bool "Hyper-V enli

Re: [XEN][PATCH v3] x86: make Viridian support optional

2025-09-18 Thread Grygorii Strashko
Hi All, On 16.09.25 16:41, Grygorii Strashko wrote: From: Sergiy Kibrik Add config option HVM_VIRIDIAN that covers viridian code within HVM. Calls to viridian functions guarded by is_viridian_domain() and related macros. Having this option may be beneficial by reducing code footprint for syste

Re: [PATCH v1 4/4] tools: Allow building xen-hptool without CONFIG_MIGRATE

2025-09-18 Thread Jan Beulich
On 18.09.2025 14:16, Mykyta Poturai wrote: > --- a/config/arm64.mk > +++ b/config/arm64.mk > @@ -1,5 +1,6 @@ > CONFIG_ARM := y > CONFIG_ARM_64 := y > +CONFIG_HOTPLUG := y > > CONFIG_XEN_INSTALL_SUFFIX := > > --- a/config/x86_32.mk > +++ b/config/x86_32.mk > @@ -3,6 +3,7 @@ CONFIG_X86_32 := y

Re: [PATCH v1 3/4] arm/sysctl: Implement cpu hotplug ops

2025-09-18 Thread Jan Beulich
On 18.09.2025 15:35, Julien Grall wrote: > On 18/09/2025 13:16, Mykyta Poturai wrote: >> +static long cpu_hotplug_sysctl(struct xen_sysctl_cpu_hotplug *hotplug) >> +{ >> +bool up; >> + >> +switch (hotplug->op) { >> +case XEN_SYSCTL_CPU_HOTPLUG_ONLINE: >> +if ( hotplug->c

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-18 Thread Peter Xu
On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: > Based-on: > ("[PATCH v2 00/14] hw/pci-host/raven clean ups") Could I ask why this is a dependency? -- Peter Xu

Re: [PATCH v1 3/4] arm/sysctl: Implement cpu hotplug ops

2025-09-18 Thread Julien Grall
Hi Mykyta, On 18/09/2025 13:16, Mykyta Poturai wrote: Implement XEN_SYSCTL_CPU_HOTPLUG_* calls to allow for enabling/disabling CPU cores in runtime. Signed-off-by: Mykyta Poturai --- xen/arch/arm/sysctl.c | 67 +++ 1 file changed, 67 insertions(+) di

Re: [PATCH v1 1/4] arm/time: Use static irqaction

2025-09-18 Thread Julien Grall
Hi Mykyta, On 18/09/2025 13:16, Mykyta Poturai wrote: When stopping a core deinit_timer_interrupt is called in non-alloc context, which causes xfree in release_irq to fail an assert. To fix this, switch to a statically allocated irqaction that does not need to be freed in release_irq. > > Sign

Re: [PATCH v2 2/7] mm: introduce local state for lazy_mmu sections

2025-09-17 Thread Kevin Brodsky
ter_lazy_mmu_mode() {3}         arch_leave_lazy_mmu_mode() {4} With the approach this series takes, call {2} is made safe by passing a special parameter (say LAZY_MMU_FLUSH) that forces lazy_mmu to be fully exited - and call {3} will then re-enter lazy_mmu. This works regardless of whether __kasan_p

Re: [PATCH v4 7/8] CI: Update x86 to use Debian Trixie

2025-09-17 Thread Marek Marczykowski-Górecki
On Fri, Sep 12, 2025 at 03:44:26PM +0100, Andrew Cooper wrote: > With the exception of the custom IBT job, copy all Debian 12 jobs making > Debian 13 versions, then trim the Debian 12 ranconfig jobs. > > Update the test jobs using Debian 12 to use 13. > > Signed-off-by: Andrew Cooper > Reviewed-

Re: [PATCH] CI: Create initrd fragments explicitly as root

2025-09-17 Thread dmukhin
On Tue, Sep 09, 2025 at 06:15:27PM +0100, Andrew Cooper wrote: > We have a mix of root and non-root containers, and are trying to become > rootless. This can cause the local CPIO fragements to end up being user:user > in the test environment. > > Nothing seems to go wrong so far, but it's a trap

Re: [PATCH v2 21/21] x86/pvlocks: Move paravirt spinlock functions into own header

2025-09-17 Thread Juergen Gross
On 18.09.25 04:45, kernel test robot wrote: Hi Juergen, kernel test robot noticed the following build warnings: [auto build test WARNING on tip/sched/core] [also build test WARNING on kvm/queue kvm/next linus/master v6.17-rc6 next-20250917] [cannot apply to tip/x86/core kvm/linux-next] [If you

Re: [PATCH v2 21/21] x86/pvlocks: Move paravirt spinlock functions into own header

2025-09-17 Thread kernel test robot
Hi Juergen, kernel test robot noticed the following build errors: [auto build test ERROR on tip/sched/core] [also build test ERROR on kvm/queue kvm/next linus/master v6.17-rc6 next-20250917] [cannot apply to tip/x86/core kvm/linux-next] [If your patch is applied to the wrong git tree, kindly dro

Re: [PATCH v2 21/21] x86/pvlocks: Move paravirt spinlock functions into own header

2025-09-17 Thread kernel test robot
Hi Juergen, kernel test robot noticed the following build warnings: [auto build test WARNING on tip/sched/core] [also build test WARNING on kvm/queue kvm/next linus/master v6.17-rc6 next-20250917] [cannot apply to tip/x86/core kvm/linux-next] [If your patch is applied to the wrong git tree, kind

Re: [PATCH v2 01/21] x86/paravirt: Remove not needed includes of paravirt.h

2025-09-17 Thread kernel test robot
Hi Juergen, kernel test robot noticed the following build errors: [auto build test ERROR on tip/sched/core] [also build test ERROR on kvm/queue kvm/next linus/master v6.17-rc6 next-20250917] [cannot apply to tip/x86/core kvm/linux-next] [If your patch is applied to the wrong git tree, kindly dro

Re: [PATCH v9 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support

2025-09-17 Thread Stefano Stabellini
Hi all, Just a quick note to say that this series is committed. Oleksii M you might want to check that everything is in order. Cheers, Stefano On Mon, 8 Sep 2025, Oleksii Moisieiev wrote: > On 08/09/2025 17:31, Oleksii Kurochko wrote: > > Hello Oleksii, > > On 9/8/25 4:21 PM, Oleksii Moisieie

Re: [PATCH for-4.21 0/5] CI: Add Debian Trixie

2025-09-17 Thread Oleksii Kurochko
On 9/9/25 11:53 PM, Stefano Stabellini wrote: On Tue, 9 Sep 2025, Marek Marczykowski-Górecki wrote: On Sat, Aug 09, 2025 at 11:12:01PM +0100, Andrew Cooper wrote: I know it's past the last-post deadline, but Trixie was only released today. In terms of backports, we should at least go back to

Re: [PATCH v6 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation

2025-09-17 Thread Thomas Zimmermann
FYI, I significant number of these patches got a review already. I intent to merge these and then send out the others for each driver individually. Am 21.08.25 um 10:17 schrieb Thomas Zimmermann: Dumb-buffer pitch and size is specified by width, height, bits-per-pixel plus various hardware-spe

Re: [PATCH 1/2] x86/IO-APIC: drop setup_ioapic_ids_from_mpc()

2025-09-17 Thread Jason Andryuk
On 2025-09-03 03:55, Jan Beulich wrote: Along the lines of what b89f8f054f96 ("x86/apic: Drop sync_Arb_IDs()") said, the function is dead logic as well: All 64-bit capable Intel systems have (at least) xAPIC (if not x2APIC). Even if Eclair can't know it, such code is violating Misra rule 2.2 (de

Re: New Defects reported by Coverity Scan for XenProject

2025-09-17 Thread Jan Beulich
On 07.09.2025 16:37, scan-ad...@coverity.com wrote: > ** CID 1665362: Integer handling issues (INTEGER_OVERFLOW) > /xen/lib/find-next-bit.c: 104 in find_next_zero_bit() > > > _ > *** CID 1

Re: [PATCH] xen/vm_event: introduce vm_event_is_enabled()

2025-09-17 Thread Jan Beulich
On 12.09.2025 06:52, Penny Zheng wrote: > Function vm_event_is_enabled() is introduced to check if vm event is enabled, > and also make the checking conditional upon CONFIG_VM_EVENT, which could help > DCE a lot calls/codes, such as hvm_monitor_io(), etc when VM_EVENT=n. > In-place assertion of arc

Re: [RFC XEN PATCH] build: Require explicit .config update

2025-09-17 Thread Jan Beulich
On 17.09.2025 23:45, Anthony PERARD wrote: > From: Anthony PERARD > > It is sometime unwelcome for the config of the hypervisor to change. > > Make output will be something like that: > tools/kconfig/conf --syncconfig Kconfig > > *** The configuration requires explicit update. > > make[

Re: [PATCH v6 00/15] x86: introduce NS16550-compatible UART emulator

2025-09-17 Thread Oleksii Kurochko
On 9/8/25 11:04 AM, Mykola Kvach wrote: Hi Denis and Stefano I’d like to acknowledge the significant effort that went into this patch series -- it’s clear that a lot of work has been invested. On Sat, Sep 6, 2025 at 5:02 AM Stefano Stabellini wrote: Oleksii and all, I would like to conside

Re: [PATCH v2 2/2] libacpi: Remove CPU hotplug and GPE handling from PVH DSDTs

2025-09-17 Thread Alejandro Vallejo
On Thu Sep 11, 2025 at 5:07 PM CEST, Jan Beulich wrote: > On 11.09.2025 13:53, Alejandro Vallejo wrote: >> PVH guests have no DM, so this causes the guest to fetch the online CPU >> bitmap from an unbacked 0xaf00 PIO port when executing the GPE handler. >> >> Seeing how ACPI CPU hotplug is the onl

Re: [PATCH v2 2/2] libacpi: Remove CPU hotplug and GPE handling from PVH DSDTs

2025-09-17 Thread Jan Beulich
On 11.09.2025 17:36, Alejandro Vallejo wrote: > On Thu Sep 11, 2025 at 5:07 PM CEST, Jan Beulich wrote: >> On 11.09.2025 13:53, Alejandro Vallejo wrote: >>> --- >>> v2: >>> * Adjusted commit message >>> * All other tags except S-by moved to patch 1. >> >> This will want backporting; I expect fi

Re: [PATCH v11 4/5] vpci/msi: Implement cleanup function for MSI

2025-09-17 Thread Chen, Jiqian
cleanup_msi(). >> * Given the code in vpci_remove_registers() an error in the removal of >> registers would likely imply memory corruption, at which point it's >> best to fully disable the device. So, Rollback the last two modifications >> of v7. >> >

Re: [PATCH v9 0/4] xen/arm: scmi: introduce SCI SCMI SMC single-agent support

2025-09-17 Thread Oleksii Moisieiev
Hi Oleksii, On 08/09/2025 17:11, Oleksii Kurochko wrote: > Hello everyone, > Based on the message from the previous version, the MISRA issues have been > fixed, > and aside from one remaining documentation patch ("docs: arm: add docs for > SCMI > over SMC calls forwarding driver"), the patch ser

Re: [PATCH 2/3] efi: Protect against unnecessary image unloading

2025-09-17 Thread Alejandro Vallejo
On Thu Sep 11, 2025 at 10:24 AM CEST, Gerald Elder-Vass wrote: > Commit 59a1d6d3ea1e introduced Shim's LoadImage protocol and unloads the > image after loading it (for verification purposes) regardless of the > returned status. The protocol API implies this is the correct behaviour > but we should

Re: [ImageBuilder] Use LOAD_CMD by default if not specified in load_file()

2025-09-17 Thread Mykola Kvach
Hi Michal, Thank you for the patch and the detailed explanation. On Tue, Sep 9, 2025 at 10:42 AM Michal Orzel wrote: > > Commit 061d6782756f modified load_file() to take load command as > argument but did not change all the invocations (e.g. loading standalone > Linux, bitstream, etc.) which bro

Re: [PATCH v3] releases: use newer compression methods for tarballs

2025-09-17 Thread Julien Grall
Hi Jan, On 11/09/2025 09:14, Jan Beulich wrote: Other projects have long switched to xz and/or lzip. Tidy things some as well: With the removal of qemu from the tarball, intermediately extracting the tarball again has become wasteful. Drop that. Invoke compressors using asynchronous lists, to r

Re: [PATCH v2] misra: add deviation of Rule 2.1 for BUG() macro

2025-09-17 Thread Dmytro Prokopchuk1
On 9/17/25 17:16, Jan Beulich wrote: > On 17.09.2025 15:59, Dmytro Prokopchuk1 wrote: >> >> >> On 9/16/25 23:03, Jan Beulich wrote: >>> On 16.09.2025 21:35, Dmytro Prokopchuk1 wrote: On 9/16/25 17:27, Jan Beulich wrote: > On 16.09.2025 14:45, Dmytro Prokopchuk1 wrote: >> --

Re: [PATCH v2 1/2] libacpi: Prevent CPU hotplug AML from corrupting memory

2025-09-17 Thread Alejandro Vallejo
On Thu Sep 11, 2025 at 4:52 PM CEST, Jan Beulich wrote: > On 11.09.2025 13:53, Alejandro Vallejo wrote: >> CPU hotplug relies on the online CPU bitmap being provided on PIO 0xaf00 >> by the device model. The GPE handler checks this and compares it against >> the "online" flag on each MADT LAPIC ent

Re: [PATCH] libacpi: Remove CPU hotplug and GPE handling from PVH DSDTs

2025-09-17 Thread Alejandro Vallejo
On Wed Sep 10, 2025 at 5:31 PM CEST, Jan Beulich wrote: > On 10.09.2025 17:16, Alejandro Vallejo wrote: >> On Wed Sep 10, 2025 at 5:02 PM CEST, Jan Beulich wrote: >>> On 10.09.2025 16:49, Alejandro Vallejo wrote: CPU hotplug relies on the guest having access to the legacy online CPU bitma

Re: New Defects reported by Coverity Scan for XenProject

2025-09-17 Thread Jan Beulich
On 08.09.2025 13:04, Alejandro Vallejo wrote: > On Mon Sep 8, 2025 at 12:19 PM CEST, Jan Beulich wrote: >> On 07.09.2025 16:37, scan-ad...@coverity.com wrote: >>> ** CID 1665362: Integer handling issues (INTEGER_OVERFLOW) >>> /xen/lib/find-next-bit.c: 104 in find_next_zero_bit() >>

Re: [PATCH v7 02/16] xen/8250-uart: update definitions

2025-09-17 Thread Jan Beulich
On 08.09.2025 23:11, dmuk...@xen.org wrote: > --- a/xen/include/xen/8250-uart.h > +++ b/xen/include/xen/8250-uart.h > @@ -32,6 +32,7 @@ > #define UART_MCR 0x04/* Modem control*/ > #define UART_LSR 0x05/* line status */ > #define UART_MSR 0x06

Re: [PATCH v2 0/7] Nesting support for lazy MMU mode

2025-09-17 Thread David Hildenbrand
On 09.09.25 04:16, Andrew Morton wrote: On Mon, 8 Sep 2025 08:39:24 +0100 Kevin Brodsky wrote: The main change enabling nesting is patch 2, following the approach suggested by Catalin Marinas [4]: have enter() return some state and the matching leave() take that state. This is so totally th

Re: [PATCH v7 02/16] xen/8250-uart: update definitions

2025-09-17 Thread dmukhin
On Tue, Sep 09, 2025 at 12:05:41PM +0200, Jan Beulich wrote: > On 08.09.2025 23:11, dmuk...@xen.org wrote: > > --- a/xen/include/xen/8250-uart.h > > +++ b/xen/include/xen/8250-uart.h > > @@ -32,6 +32,7 @@ > > #define UART_MCR 0x04/* Modem control*/ > > #define UART_LSR

Re: WARN in xennet_disconnect_backend when frontend is paused during backend shutdown

2025-09-17 Thread Jürgen Groß
On 11.09.25 17:11, Marek Marczykowski-Górecki wrote: Hi, The steps: 1. Have domU netfront ("untrusted" here) and domU netback ("sys-firewall-alt" here). 2. Pause frontend 3. Shutdown backend 4. Unpause frontend 5. Detach network (in my case attaching another one follows just after, but I believe

Re: Xen Summit 2025 - Design Discussion Notes - Xen ABI

2025-09-17 Thread Jan Beulich
On 17.09.2025 06:49, Alexander M. Merritt wrote: > Hi all, it was requested I send the notes I took during the design discussion > on the ABI / APIs to the list. Thanks much. We will want to try to have notes taken more systematically today. Jan

Re: Xen Summit 2025 - Design Discussion Notes - Xen ABI

2025-09-17 Thread Alex Brett
I also took notes during this session - as usual apologies for any misquotes etc: Christopher Clark (CC): Preparing a collection of docs to understand the problem space and what we want to achieve ahead of doing the work - List of API/ABIs - List of known limitations / issues / concerns with the

Re: [PATCH v3 7/7] hw/xen: Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:32PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the instance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callbac

Re: [PATCH v3 6/7] vfio: Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:31PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the instance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callbac

Re: [PATCH v3 5/7] hw/sd/sdhci: Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:30PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the instance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callbac

Re: [PATCH v3 4/7] hv-balloon: hw/core/register: Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:29PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the instance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callbac

Re: [PATCH v3 3/7] hw/core/register: Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:28PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the instance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callbac

Re: [PATCH v3 2/7] vfio/pci: Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:27PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the insntance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callba

Re: [PATCH v3 1/7] docs/devel: Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:26PM +0900, Akihiko Odaki wrote: > Children are automatically unparented so manually unparenting is > unnecessary. > > Worse, automatic unparenting happens before the instance_finalize() > callback of the parent gets called, so object_unparent() calls in > the callbac

Re: [PATCH v2] misra: add deviation of Rule 2.1 for BUG() macro

2025-09-17 Thread Dmytro Prokopchuk1
On 9/16/25 23:03, Jan Beulich wrote: > On 16.09.2025 21:35, Dmytro Prokopchuk1 wrote: >> >> >> On 9/16/25 17:27, Jan Beulich wrote: >>> On 16.09.2025 14:45, Dmytro Prokopchuk1 wrote: --- a/docs/misra/deviations.rst +++ b/docs/misra/deviations.rst @@ -98,6 +98,23 @@ Deviations relat

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-17 Thread Akihiko Odaki
On 2025/09/17 20:57, Daniel P. Berrangé wrote: On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: Based-on: ("[PATCH v2 00/14] hw/pci-host/raven clean ups") Supersedes: <20240829-memory-v1-1-ac07af2f4...@daynix.com> ("[PATCH] docs/devel: Prohibit calling object_unparent() for memor

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 02:17:35PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 17, 2025 at 09:24:04PM +0900, Akihiko Odaki wrote: > > On 2025/09/17 20:57, Daniel P. Berrangé wrote: > > > On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: > > > > Based-on: > > > > ("[PATCH v2 00/14]

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 09:24:04PM +0900, Akihiko Odaki wrote: > On 2025/09/17 20:57, Daniel P. Berrangé wrote: > > On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: > > > Based-on: > > > ("[PATCH v2 00/14] hw/pci-host/raven clean ups") > > > > > > Supersedes: <20240829-memory-v1-1-a

Re: [PATCH v2] misra: add deviation of Rule 2.1 for BUG() macro

2025-09-17 Thread Jan Beulich
On 17.09.2025 15:59, Dmytro Prokopchuk1 wrote: > > > On 9/16/25 23:03, Jan Beulich wrote: >> On 16.09.2025 21:35, Dmytro Prokopchuk1 wrote: >>> >>> >>> On 9/16/25 17:27, Jan Beulich wrote: On 16.09.2025 14:45, Dmytro Prokopchuk1 wrote: > --- a/docs/misra/deviations.rst > +++ b/docs/m

Re: [PATCH] xen/domain: introduce DOMID_ANY

2025-09-17 Thread Jan Beulich
On 16.09.2025 22:51, Andrew Cooper wrote: > On 16/09/2025 1:05 pm, Jan Beulich wrote: >> On 16.09.2025 19:37, dmuk...@xen.org wrote: >>> --- a/xen/include/public/xen.h >>> +++ b/xen/include/public/xen.h >>> @@ -608,6 +608,9 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); >>> /* DOMID_INVALID is used to i

Re: [PATCH v3 0/7] Do not unparent in instance_finalize()

2025-09-17 Thread Daniel P . Berrangé
On Wed, Sep 17, 2025 at 07:13:25PM +0900, Akihiko Odaki wrote: > Based-on: > ("[PATCH v2 00/14] hw/pci-host/raven clean ups") > > Supersedes: <20240829-memory-v1-1-ac07af2f4...@daynix.com> > ("[PATCH] docs/devel: Prohibit calling object_unparent() for memory region") > > Children are automatical

Re: [PATCH v6 02/13] xen/arm: gic-v2: Implement GIC suspend/resume functions

2025-09-16 Thread Mykola Kvach
Hi Julien, Thank you for the review. On Sat, Sep 13, 2025 at 2:30 AM Julien Grall wrote: > > Hi Mykola, > > On 01/09/2025 23:10, Mykola Kvach wrote: > > From: Mirela Simonovic > > > > System suspend may lead to a state where GIC would be powered down. > > Therefore, Xen should save/restore the

Re: [PATCH v6 04/13] xen/arm: Don't release IRQs on suspend

2025-09-16 Thread Mykola Kvach
Hi Julien, Thank you for the review. On Sat, Sep 13, 2025 at 2:45 AM Julien Grall wrote: > > Hi Mykola, > > On 01/09/2025 23:10, Mykola Kvach wrote: > > From: Mykola Kvach > > > > If we call disable_nonboot_cpus on ARM64 with system_state set > > to SYS_STATE_suspend, the following assertion wi

Re: [PATCH v2] misra: add deviation of Rule 2.1 for BUG() macro

2025-09-16 Thread Jan Beulich
On 16.09.2025 21:35, Dmytro Prokopchuk1 wrote: > > > On 9/16/25 17:27, Jan Beulich wrote: >> On 16.09.2025 14:45, Dmytro Prokopchuk1 wrote: >>> --- a/docs/misra/deviations.rst >>> +++ b/docs/misra/deviations.rst >>> @@ -98,6 +98,23 @@ Deviations related to MISRA C:2012 Rules: >>> even wh

Re: [PATCH] xen/domain: introduce DOMID_ANY

2025-09-16 Thread Andrew Cooper
On 16/09/2025 1:05 pm, Jan Beulich wrote: > On 16.09.2025 19:37, dmuk...@xen.org wrote: >> --- a/xen/include/public/xen.h >> +++ b/xen/include/public/xen.h >> @@ -608,6 +608,9 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); >> /* DOMID_INVALID is used to identify pages with unknown owner. */ >> #define

Re: [RFC PATCH] xen/arm: Introduce GICV3 Self Tests

2025-09-16 Thread Grygorii Strashko
Hi Ayan, On 12.09.25 20:00, Ayan Kumar Halder wrote: Introduce CONFIG_GICV3_SELFTEST to enclose tests for GICv3 driver. Test that Xen is able to generate SGIs. Signed-off-by: Ayan Kumar Halder --- One of the aim of functional safety is to test hw/sw interface. This means that Xen is able to co

Re: [XEN][PATCH 2/2] x86: hvm: svm: fix runtime svm presence check for !CONFIG_AMD_SVM case

2025-09-16 Thread Oleksii Kurochko
On 9/16/25 12:32 PM, Grygorii Strashko wrote: From: Grygorii Strashko Since commit b99227347230 ("x86: Fix AMD_SVM and INTEL_VMX dependency") the AMD-V support can be gracefully disabled, but it still keeps SVM code partially built-in, because HVM code uses mix of: - "cpu_has_svm" macro, which

Re: [PATCH] xen/domain: introduce DOMID_ANY

2025-09-16 Thread Andrew Cooper
On 16/09/2025 10:37 am, dmuk...@xen.org wrote: > From: Denis Mukhin > > Add a new symbol DOMID_ANY aliasing DOMID_INVALID to improve the readability > of the code. > > Update all relevant domid_alloc() call sites. > > Amends: 2d5065060710 ("xen/domain: unify domain ID allocation") > Signed-off-by

Re: [XEN][PATCH 1/2] x86: hvm: vmx: fix runtime vmx presence check for !CONFIG_INTEL_VMX case

2025-09-16 Thread Andrew Cooper
On 16/09/2025 9:57 am, Grygorii Strashko wrote: > Hi Jan, > > On 16.09.25 17:34, Jan Beulich wrote: >> On 16.09.2025 12:32, Grygorii Strashko wrote: >>> From: Grygorii Strashko >>> >>> Since commit b99227347230 ("x86: Fix AMD_SVM and INTEL_VMX >>> dependency") the >>> HVM Intel VT-x support can be

Re: [XEN][PATCH 1/2] x86: hvm: vmx: fix runtime vmx presence check for !CONFIG_INTEL_VMX case

2025-09-16 Thread Grygorii Strashko
Hi Jan, On 16.09.25 17:34, Jan Beulich wrote: On 16.09.2025 12:32, Grygorii Strashko wrote: From: Grygorii Strashko Since commit b99227347230 ("x86: Fix AMD_SVM and INTEL_VMX dependency") the HVM Intel VT-x support can be gracefully disabled, but it still keeps VMX code partially built-in, be

Re: [XEN][PATCH] x86: hvm: hypercall: use define instead of const in hvm_hypercall()

2025-09-16 Thread Andrew Cooper
On 12/09/2025 10:47 am, Grygorii Strashko wrote: > From: Grygorii Strashko > > Use define X86_MODE_64BIT instead of constant in hvm_hypercall() for "mode" > conditional check to improve code readability. > > Signed-off-by: Grygorii Strashko Acked-by: Andrew Cooper but this really needs to wait

  1   2   3   4   5   6   7   8   9   10   >