Re: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-11 Thread Jan Beulich
On 09.09.2022 17:41, Daniel P. Smith wrote: > > On 9/9/22 08:10, Jan Beulich wrote: >> On 09.09.2022 13:34, Daniel P. Smith wrote: >>> On 9/9/22 06:04, Jan Beulich wrote: On 09.09.2022 11:50, Daniel P. Smith wrote: > --- a/xen/xsm/flask/avc.c > +++ b/xen/xsm/flask/avc.c > @@ -566,

Re: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-09 Thread Daniel P. Smith
On 9/9/22 08:10, Jan Beulich wrote: > On 09.09.2022 13:34, Daniel P. Smith wrote: >> On 9/9/22 06:04, Jan Beulich wrote: >>> On 09.09.2022 11:50, Daniel P. Smith wrote: --- a/xen/xsm/flask/avc.c +++ b/xen/xsm/flask/avc.c @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16

RE: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-09 Thread Henry Wang
Hi Daniel, > -Original Message- > From: Daniel P. Smith > > This should also be fine to merge in 4.17, but following the discussion with > > Julien and Jan I think providing a Release ack would lead to confusion... > > I was hoping it would go in, but understand if it is kept out. I have

Re: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-09 Thread Jan Beulich
On 09.09.2022 13:34, Daniel P. Smith wrote: > On 9/9/22 06:04, Jan Beulich wrote: >> On 09.09.2022 11:50, Daniel P. Smith wrote: >>> --- a/xen/xsm/flask/avc.c >>> +++ b/xen/xsm/flask/avc.c >>> @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 >>> requested, >>> if ( a

Re: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-09 Thread Daniel P. Smith
On 9/9/22 05:56, Henry Wang wrote: Hi Daniel, -Original Message- Subject: [PATCH] xsm/flask: adjust print messages to use %pd Print messages from flask use an inconsistent format when printing the domain id. The %pd conversion specifier provides a consistent way to format for the domai

Re: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-09 Thread Daniel P. Smith
On 9/9/22 06:04, Jan Beulich wrote: On 09.09.2022 11:50, Daniel P. Smith wrote: --- a/xen/xsm/flask/avc.c +++ b/xen/xsm/flask/avc.c @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 requested, if ( a && (a->sdom || a->tdom) ) { if ( a->sdom && a->tdo

Re: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-09 Thread Jan Beulich
On 09.09.2022 11:50, Daniel P. Smith wrote: > --- a/xen/xsm/flask/avc.c > +++ b/xen/xsm/flask/avc.c > @@ -566,14 +566,14 @@ void avc_audit(u32 ssid, u32 tsid, u16 tclass, u32 > requested, > if ( a && (a->sdom || a->tdom) ) > { > if ( a->sdom && a->tdom && a->sdom != a->tdom ) >

RE: [PATCH] xsm/flask: adjust print messages to use %pd

2022-09-09 Thread Henry Wang
Hi Daniel, > -Original Message- > Subject: [PATCH] xsm/flask: adjust print messages to use %pd > > Print messages from flask use an inconsistent format when printing the > domain > id. The %pd conversion specifier provides a consistent way to format for the > domain id and aligns with the