Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-15 Thread Jan Beulich
On 14.02.2023 06:07, Tamas K Lengyel wrote: > An assert failure has been observed at p2m-basic.c:173 when performing vm Please can you at least also name the function here? The line number is going to change, and when coming back to this change later, it'll be more troublesome to figure out which

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-15 Thread Tamas K Lengyel
On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > > On 14.02.2023 06:07, Tamas K Lengyel wrote: > > An assert failure has been observed at p2m-basic.c:173 when performing vm > > Please can you at least also name the function here? The line number is > going to change, and when coming back to th

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Jan Beulich
On 15.02.2023 17:29, Tamas K Lengyel wrote: > On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: >> Did you consider the alternative of adjusting the ASSERT() in question >> instead? It could reasonably become >> >> #ifdef CONFIG_MEM_SHARING >> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || >

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Tamas K Lengyel
On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > > On 15.02.2023 17:29, Tamas K Lengyel wrote: > > On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > >> Did you consider the alternative of adjusting the ASSERT() in question > >> instead? It could reasonably become > >> > >> #ifdef CONFIG_ME

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Jan Beulich
On 16.02.2023 13:22, Tamas K Lengyel wrote: > On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: >> >> On 15.02.2023 17:29, Tamas K Lengyel wrote: >>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: Did you consider the alternative of adjusting the ASSERT() in question instead? It co

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Tamas K Lengyel
On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: > > On 16.02.2023 13:22, Tamas K Lengyel wrote: > > On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > >> > >> On 15.02.2023 17:29, Tamas K Lengyel wrote: > >>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > Did you consider the alt

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Jan Beulich
On 16.02.2023 16:10, Tamas K Lengyel wrote: > On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: >> >> On 16.02.2023 13:22, Tamas K Lengyel wrote: >>> On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: On 15.02.2023 17:29, Tamas K Lengyel wrote: > On Wed, Feb 15, 2023 at 5:27 AM Jan

Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown

2023-02-16 Thread Tamas K Lengyel
On Thu, Feb 16, 2023 at 10:24 AM Jan Beulich wrote: > > On 16.02.2023 16:10, Tamas K Lengyel wrote: > > On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: > >> > >> On 16.02.2023 13:22, Tamas K Lengyel wrote: > >>> On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > > On 15.02.2023 17