Re: [PATCH v3 4/6] x86/gdbsx: expand dbg_rw_mem() inline

2021-08-24 Thread Jan Beulich
On 18.08.2021 22:29, Bobby Eshleman wrote: > --- a/xen/arch/x86/gdbsx.c > +++ b/xen/arch/x86/gdbsx.c > @@ -151,33 +151,23 @@ static unsigned int dbg_rw_guest_mem(struct domain *dp, > unsigned long addr, > return len; > } > > -/* > - * addr is guest addr > - * buf is debugger buffer. > - *

Re: [PATCH v3 4/6] x86/gdbsx: expand dbg_rw_mem() inline

2021-08-24 Thread Andrew Cooper
On 18/08/2021 21:29, Bobby Eshleman wrote: > Because dbg_rw_mem() has only a single call site, this commit > expands it inline. Missing a SoB. Otherwise, looks ok.