Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Julien Grall
Hi, On 4/8/19 3:33 PM, Andrew Cooper wrote: On 08/04/2019 14:53, Julien Grall wrote: Hi Andrew, On 4/8/19 1:09 PM, Andrew Cooper wrote: On 08/04/2019 12:38, Julien Grall wrote: Hi, On 4/8/19 11:47 AM, Andrew Cooper wrote: On 08/04/2019 11:39, Julien Grall wrote: Hi, On 4/8/19 10:39 AM, A

Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Andrew Cooper
On 08/04/2019 14:53, Julien Grall wrote: > Hi Andrew, > > On 4/8/19 1:09 PM, Andrew Cooper wrote: >> On 08/04/2019 12:38, Julien Grall wrote: >>> Hi, >>> >>> On 4/8/19 11:47 AM, Andrew Cooper wrote: On 08/04/2019 11:39, Julien Grall wrote: > Hi, > > On 4/8/19 10:39 AM, Andrew Coope

Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Julien Grall
Hi Andrew, On 4/8/19 1:09 PM, Andrew Cooper wrote: On 08/04/2019 12:38, Julien Grall wrote: Hi, On 4/8/19 11:47 AM, Andrew Cooper wrote: On 08/04/2019 11:39, Julien Grall wrote: Hi, On 4/8/19 10:39 AM, Andrew Cooper wrote: +    case CPU_RESUME_FAILED: +    if ( !park_offline_cpus && sy

Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Andrew Cooper
On 08/04/2019 12:38, Julien Grall wrote: > Hi, > > On 4/8/19 11:47 AM, Andrew Cooper wrote: >> On 08/04/2019 11:39, Julien Grall wrote: >>> Hi, >>> >>> On 4/8/19 10:39 AM, Andrew Cooper wrote: +    case CPU_RESUME_FAILED: +    if ( !park_offline_cpus && system_state != SYS_STATE_

Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Julien Grall
Hi, On 4/8/19 11:47 AM, Andrew Cooper wrote: On 08/04/2019 11:39, Julien Grall wrote: Hi, On 4/8/19 10:39 AM, Andrew Cooper wrote: +    case CPU_RESUME_FAILED: +    if ( !park_offline_cpus && system_state != SYS_STATE_suspend ) This patch breaks compilation on arm32/arm64 because park_o

Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Andrew Cooper
On 08/04/2019 11:39, Julien Grall wrote: > Hi, > > On 4/8/19 10:39 AM, Andrew Cooper wrote: >> +    case CPU_RESUME_FAILED: >> +    if ( !park_offline_cpus && system_state != SYS_STATE_suspend ) > > This patch breaks compilation on arm32/arm64 because park_offline_cpus > is not defined: > > tim

Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Julien Grall
Hi, On 4/8/19 10:39 AM, Andrew Cooper wrote: +case CPU_RESUME_FAILED: +if ( !park_offline_cpus && system_state != SYS_STATE_suspend ) This patch breaks compilation on arm32/arm64 because park_offline_cpus is not defined: timer.c: In function 'cpu_callback': timer.c:651:15: error

Re: [Xen-devel] [PATCH v2] xen/timers: Fix memory leak with cpu unplug/plug

2019-04-08 Thread Jan Beulich
>>> On 08.04.19 at 11:39, wrote: > timer_softirq_action() realloc's itself a larger timer heap whenever > necessary, which includes bootstrapping from the empty dummy_heap. Nothing > ever freed this allocation. > > CPU plug and unplug has the side effect of zeroing the percpu data area, which >