>>> On 27.07.18 at 16:20, wrote:
> In order to mostly eliminate abuse of what Xen leaves in the RSB by
> guest level attackers, fill the RSB with almost-NULL pointers right
> before entering guest context.
>
> The placement of the initialization code is intentional: If it was put
> in e.g.
I'm not really convinced of the change done in v3, even less so with
x86'es pv/domain.h not really having been suitable for inclusion in
spec-ctrl.c (needed an extra, seemingly unrelated adjustment), but
in the interest of getting this done, here you go.
1: x86: report use of PCID together with
>>> On 16.08.18 at 22:02, wrote:
> On Wed, Aug 15, 2018 at 10:00:48AM -0600, Jan Beulich wrote:
>> >>> On 09.08.18 at 21:42, wrote:
>> > --- a/xen/arch/x86/spec_ctrl.c
>> > +++ b/xen/arch/x86/spec_ctrl.c
>>
>> First of all - I'm not convinced some of the AMD specific code here
>> wouldn't
Restore symmetry between get_page_from_le(): pv_l1tf_check_le is
uniformly invoked from outside of them. They're no longer getting called
for non-present PTEs. This way the slightly odd three-way return value
meaning of the higher level ones can also be got rid of.
Introduce local variables
Given what pt_pci_init() actually does, rename it properly and move its
declaration to pci.h, move the only call in acpi_mmcfg_init().
No functional change.
Signed-off-by: Zhenzhong Duan
Tested-by: Gopalasetty, Manoj
---
xen/arch/x86/setup.c |2 --
pci_conf_read8() needs pci mmcfg mapping to work on multiple pci segments
system such as HPE Superdome-Flex.
Move acpi_mmcfg_init() call in acpi_boot_init() before calling
acpi_parse_dmar() so that when pci_conf_read8() is called in
acpi_parse_dev_scope(), we already have the mapping set up.
Signed-off-by: Jan Beulich
Reviewed-by: Roger Pau Monné
---
v3: Move declaration to pv/domain.h. Re-base.
v2: Add CONFIG_PV conditional.
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -289,6 +289,12 @@ int pv_domain_initialise(struct domain *
return rc;
}
+bool __init
1: remove page.h and processor.h inclusion from asm_defns.h
2: use PDEP/PEXT for maddr/direct-map-offset conversion when available
3: use PDEP/PEXT for PFN/PDX conversion when available
4: use MOV for PFN/PDX conversion when possible
5: use PDEP for PTE flags insertion when available
On Thu, Aug 16, 2018 at 01:22:41PM -0700, Christopher Clark wrote:
> Add zero-padding to #defined ACPI table strings that are copied.
> Provides sufficient characters to satisfy the length required to
> fully populate the destination and prevent array-bounds warnings.
> Add BUILD_BUG_ON sizeof
This run is configured for baseline tests only.
flight 75076 ovmf real [real]
http://osstest.xensource.com/osstest/logs/75076/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-i386-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail like 75068
flight 126021 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/126021/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 12 guest-start fail REGR. vs. 125923
Tests which
>>> On 17.08.18 at 06:52, wrote:
> flight 126019 xen-unstable-smoke real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/126019/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> test-armhf-armhf-xl 12
On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote:
> From: Vitaly Kuznetsov
>
> Well require to call add_memory()/add_memory_resource() with
> device_hotplug_lock held, to avoid a lock inversion. Allow external modules
> (e.g. hv_balloon) that make use of
On 17/08/2018 08:23, Jan Beulich wrote:
> ... and (of course) also maddr / direct-map-offset ones.
>
> Most x86 systems don't actually require the use of PDX compression. Now
> that we have patching for the conversion code in place anyway, extend it
> to use simple MOV when possible. Introduce a
On 17.08.2018 10:41, Greg Kroah-Hartman wrote:
> On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote:
>> From: Vitaly Kuznetsov
>>
>> Well require to call add_memory()/add_memory_resource() with
>> device_hotplug_lock held, to avoid a lock inversion. Allow external modules
>> (e.g.
This allows to fold 6 instructions into a single one, reducing code size
quite a bit, especially when not considering the fallback functions
(which won't ever need to be brought into iCache or their mappings into
iTLB on systems supporting BMI2).
Make use of gcc's new V operand modifier, even if
Subsequent changes require this (too wide anyway imo) dependency to be
dropped.
Signed-off-by: Jan Beulich
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -5,6 +5,7 @@
#include
#include
#include
+#include
#include
#include
#include
---
>>> On 17.08.18 at 00:04, wrote:
> On Tue, Jul 10, 2018 at 04:14:11AM -0600, Jan Beulich wrote:
>> Having noticed that VMLOAD alone is about as fast as a single of the
>> involved WRMSRs, I thought it might be a reasonable idea to also use it
>> for PV. Measurements, however, have shown that an
flight 125914 linux-3.18 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/125914/
Failures and problems with tests :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-libvirt-raw broken
Tests which are
>>> On 16.08.18 at 18:43, wrote:
> Booting just linux with both options works just fine, I grepped the
> dmesg log for the device that causes the issues with Xen but there are
> no errors in the log:
Well, this as well as ...
> I double checked and the option is set properly but I'm still
On Fri, Aug 17, 2018 at 9:59 AM David Hildenbrand wrote:
>
> There seem to be some problems as result of 30467e0b3be ("mm, hotplug:
> fix concurrent memory hot-add deadlock"), which tried to fix a possible
> lock inversion reported and discussed in [1] due to the two locks
> a)
On 17/08/2018 08:20, Jan Beulich wrote:
> Subsequent changes require this (too wide anyway imo) dependency to be
> dropped.
>
> Signed-off-by: Jan Beulich
Acked-by: Andrew Cooper
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
On Thu, Aug 16, 2018 at 10:43:54AM -0600, Tamas K Lengyel wrote:
> I double checked and the option is set properly but I'm still getting
> the same non-present entry faults as before. At the moment I don't
> have serial access so not sure how to verify that the option took
> effect. This is my
On 17/08/2018 08:21, Jan Beulich wrote:
> --- a/xen/include/asm-x86/asm_defns.h
> +++ b/xen/include/asm-x86/asm_defns.h
> @@ -186,6 +186,20 @@ void ret_from_intr(void);
> UNLIKELY_END_SECTION "\n" \
> ".Llikely." #tag ".%=:"
>
> +#define LINKONCE_PROLOGUE(sym)
On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote:
>
> On 17.08.2018 10:41, Greg Kroah-Hartman wrote:
> > On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote:
> >> From: Vitaly Kuznetsov
> >>
> >> Well require to call add_memory()/add_memory_resource() with
> >>
Putting them on separate lines was suggested before, and is going to
become necessary eventually anyway as things get added here. Split them
now, and put the respective pieces in CONFIG_* conditionals at the same
time.
Signed-off-by: Jan Beulich
Acked-by: Andrew Cooper
Reviewed-by: Roger Pau
This run is configured for baseline tests only.
flight 75075 xen-4.11-testing real [real]
http://osstest.xensource.com/osstest/logs/75075/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-qemut-win10-i386 10 windows-installfail
Both replace 6 instructions by a single one, further reducing code size,
cache, and TLB footprint (in particular on systems supporting BMI2).
Signed-off-by: Jan Beulich
---
v2: Avoid quoted symbols; use gcc's new V operand modifier instead.
Re-base.
--- a/xen/arch/x86/mm.c
+++
... and (of course) also maddr / direct-map-offset ones.
Most x86 systems don't actually require the use of PDX compression. Now
that we have patching for the conversion code in place anyway, extend it
to use simple MOV when possible. Introduce a new pseudo-CPU-feature to
key the patching off of.
This replaces 5 instructions by a single one, further reducing code size,
cache, and TLB footprint (in particular on systems supporting BMI2).
Signed-off-by: Jan Beulich
---
Irrespective of the note regarding a possible alternative route, I think
the change here is an improvement until someone
There seem to be some problems as result of 30467e0b3be ("mm, hotplug:
fix concurrent memory hot-add deadlock"), which tried to fix a possible
lock inversion reported and discussed in [1] due to the two locks
a) device_lock()
b) mem_hotplug_lock
While add_memory() first takes b),
Reading through the code and studying how mem_hotplug_lock is to be used,
I noticed that there are two places where we can end up calling
device_online()/device_offline() - online_pages()/offline_pages() without
the mem_hotplug_lock. And there are other places where we call
From: Vitaly Kuznetsov
Well require to call add_memory()/add_memory_resource() with
device_hotplug_lock held, to avoid a lock inversion. Allow external modules
(e.g. hv_balloon) that make use of add_memory()/add_memory_resource() to
lock device hotplug.
Signed-off-by: Vitaly Kuznetsov
[modify
On 17.08.2018 10:20, Rafael J. Wysocki wrote:
> On Fri, Aug 17, 2018 at 9:59 AM David Hildenbrand wrote:
>>
>> There seem to be some problems as result of 30467e0b3be ("mm, hotplug:
>> fix concurrent memory hot-add deadlock"), which tried to fix a possible
>> lock inversion reported and discussed
On Fri, Aug 17, 2018 at 10:41 AM Greg Kroah-Hartman
wrote:
>
> On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote:
> > From: Vitaly Kuznetsov
> >
> > Well require to call add_memory()/add_memory_resource() with
> > device_hotplug_lock held, to avoid a lock inversion. Allow
flight 125919 qemu-upstream-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/125919/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 122862
>>> On 17.08.18 at 12:17, wrote:
On 14.08.18 at 15:43, wrote:
>> +switch ( e820.map[i].type )
>> +{
>> +case E820_RAM:
>> +return RAM_TYPE_CONVENTIONAL;
>> +
>> +case E820_RESERVED:
>> +return RAM_TYPE_RESERVED;
On Fri, Aug 17, 2018 at 04:04:34AM -0600, Jan Beulich wrote:
> >>> On 14.08.18 at 15:43, wrote:
> > --- a/xen/drivers/passthrough/vtd/iommu.c
> > +++ b/xen/drivers/passthrough/vtd/iommu.c
> > @@ -1304,11 +1304,9 @@ static void __hwdom_init
> > intel_iommu_hwdom_init(struct domain *d)
> > {
> >
flight 126043 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/126043/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 12 guest-start fail REGR. vs. 125923
Tests which
>>> On 14.08.18 at 15:43, wrote:
> +static bool __hwdom_init hwdom_iommu_map(const struct domain *d,
Unused function parameter?
> + unsigned long pfn,
> + unsigned long max_pfn)
> +{
> +/*
> + * Set up 1:1
>>> On 17.08.18 at 12:32, wrote:
> On Fri, Aug 17, 2018 at 04:04:34AM -0600, Jan Beulich wrote:
>> >>> On 14.08.18 at 15:43, wrote:
>> > --- a/xen/drivers/passthrough/vtd/iommu.c
>> > +++ b/xen/drivers/passthrough/vtd/iommu.c
>> > @@ -1304,11 +1304,9 @@ static void __hwdom_init
>> >
>>> On 14.08.18 at 15:43, wrote:
> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -134,6 +134,37 @@ void arch_iommu_domain_destroy(struct domain *d)
> {
> }
>
> +static bool __hwdom_init hwdom_iommu_map(const struct domain *d,
> +
>>> On 14.08.18 at 15:43, wrote:
> So it's done before the iommu is initialized. This is required in
> order to be able to fetch the MMCFG regions from the domain struct.
>
> No functional change.
>
> Signed-off-by: Roger Pau Monné
Acked-by: Jan Beulich
>>> On 14.08.18 at 15:43, wrote:
> The helpers returns whether a given memory address belongs to a domain
> MMCFG range.
>
> Signed-off-by: Roger Pau Monné
I'd prefer if this was part of the patch actually using the new function.
Jan
___
Xen-devel
On 17.08.2018 12:06, Greg Kroah-Hartman wrote:
> On Fri, Aug 17, 2018 at 11:41:24AM +0200, David Hildenbrand wrote:
>> On 17.08.2018 11:03, Rafael J. Wysocki wrote:
>>> On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote:
On 17.08.2018 10:41, Greg Kroah-Hartman wrote:
> On Fri,
>>> On 14.08.18 at 15:43, wrote:
> @@ -138,13 +139,20 @@ static bool __hwdom_init hwdom_iommu_map(const struct
> domain *d,
> unsigned long pfn,
> unsigned long max_pfn)
> {
> +unsigned int i;
> +
> /*
On Fri, Aug 17, 2018 at 05:08:08AM -0600, Jan Beulich wrote:
> >>> On 14.08.18 at 15:43, wrote:
> > @@ -185,7 +219,13 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain
> > *d)
> > if ( !hwdom_iommu_map(d, pfn, max_pfn) )
> > continue;
> >
> > -rc =
On Fri, Aug 17, 2018 at 03:20:11AM -0600, Jan Beulich wrote:
> Rather than special casing the ->iomem_caps check in x86's
> get_page_from_l1e() for the dom_xen case, let's be more tolerant in
> general, along the lines of rangeset_is_empty(): A never allocated
> rangeset can't possibly contain or
>>> On 17.08.18 at 10:59, wrote:
> On 17/08/2018 08:21, Jan Beulich wrote:
>> --- a/xen/include/asm-x86/asm_defns.h
>> +++ b/xen/include/asm-x86/asm_defns.h
>> @@ -186,6 +186,20 @@ void ret_from_intr(void);
>> UNLIKELY_END_SECTION "\n" \
>> ".Llikely." #tag ".%=:"
>>
>>> On 14.08.18 at 15:43, wrote:
> To iommu_hwdom_strict and iommu_hwdom_passthrough which is more
> descriptive of their usage. Also change their type from bool_t to
> bool.
>
> No functional change.
>
> Signed-off-by: Roger Pau Monné
Reviewed-by: Jan Beulich
with one remark:
> @@ -175,7
On Fri, Aug 17, 2018 at 03:41:31AM -0600, Jan Beulich wrote:
> >>> On 17.08.18 at 11:29, wrote:
> > As said in the commit message, this is done to avoid an extra check in
> > get_page_from_l1e I assume, so should the extra check also be dropped
> > here?
>
> I'm afraid I don't understand: I
On 17/08/2018 10:52, Roger Pau Monné wrote:
> On Fri, Aug 17, 2018 at 11:50:53AM +0200, Roger Pau Monne wrote:
>> Fixes the ARM build breakage introduced by 54ed251dc7.
> It's not a build fix but a runtime fix, so the 'build' in the above
> sentence should be removed if this ends up in the repo.
>>> On 14.08.18 at 15:43, wrote:
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -1304,11 +1304,9 @@ static void __hwdom_init intel_iommu_hwdom_init(struct
> domain *d)
> {
> struct acpi_drhd_unit *drhd;
>
> -if ( !iommu_hwdom_passthrough
>>> On 14.08.18 at 15:43, wrote:
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1181,6 +1181,12 @@ int page_is_ram_type(unsigned long mfn, unsigned long
> mem_type)
> return 0;
> }
>
> +int page_get_type(unsigned long mfn)
> +{
> +ASSERT_UNREACHABLE();
> +return -1;
>
Rather than special casing the ->iomem_caps check in x86's
get_page_from_l1e() for the dom_xen case, let's be more tolerant in
general, along the lines of rangeset_is_empty(): A never allocated
rangeset can't possibly contain or overlap any range.
Reported-by: Andrew Cooper
Signed-off-by: Jan
On 17.08.2018 11:03, Rafael J. Wysocki wrote:
> On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote:
>>
>> On 17.08.2018 10:41, Greg Kroah-Hartman wrote:
>>> On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote:
From: Vitaly Kuznetsov
Well require to call
>>> On 17.08.18 at 11:29, wrote:
> On Fri, Aug 17, 2018 at 03:20:11AM -0600, Jan Beulich wrote:
>> Rather than special casing the ->iomem_caps check in x86's
>> get_page_from_l1e() for the dom_xen case, let's be more tolerant in
>> general, along the lines of rangeset_is_empty(): A never
On Fri, Aug 17, 2018 at 11:50:53AM +0200, Roger Pau Monne wrote:
> Fixes the ARM build breakage introduced by 54ed251dc7.
It's not a build fix but a runtime fix, so the 'build' in the above
sentence should be removed if this ends up in the repo.
___
>>> On 14.08.18 at 15:43, wrote:
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -681,6 +681,19 @@ Flag that makes a dom0 boot in PVHv2 mode.
> Flag that makes a dom0 use shadow paging. Only works when "pvh" is
> enabled.
>
> +### dom0-iommu
> +>
Fixes the ARM build breakage introduced by 54ed251dc7.
Signed-off-by: Roger Pau Monné
---
I've only build-tested this on x86.
---
Cc: Ian Jackson
Cc: Wei Liu
---
tools/libxc/xc_domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index
On Fri, Aug 17, 2018 at 03:20:11AM -0600, Jan Beulich wrote:
> Rather than special casing the ->iomem_caps check in x86's
> get_page_from_l1e() for the dom_xen case, let's be more tolerant in
> general, along the lines of rangeset_is_empty(): A never allocated
> rangeset can't possibly contain or
On Fri, Aug 17, 2018 at 11:41:24AM +0200, David Hildenbrand wrote:
> On 17.08.2018 11:03, Rafael J. Wysocki wrote:
> > On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote:
> >>
> >> On 17.08.2018 10:41, Greg Kroah-Hartman wrote:
> >>> On Fri, Aug 17, 2018 at 09:59:00AM +0200, David
On Fri, Aug 17, 2018 at 11:50:53AM +0200, Roger Pau Monne wrote:
> Fixes the ARM build breakage introduced by 54ed251dc7.
>
> Signed-off-by: Roger Pau Monné
Acked-by: Wei Liu
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
Hello.
Can anyone show me a book about learning Virtualization fundamental?
Thank you.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On Fri, Aug 17, 2018 at 01:04:58PM +0200, David Hildenbrand wrote:
> >> If there are no objections, I'll go into that direction. But I'll wait
> >> for more comments regarding the general concept first.
> >
> > It is the middle of the merge window, and maintainers are really busy
> > right now.
>>> On 17.08.18 at 13:17, wrote:
> On Fri, Aug 17, 2018 at 05:08:08AM -0600, Jan Beulich wrote:
>> >>> On 14.08.18 at 15:43, wrote:
>> > @@ -185,7 +219,13 @@ void __hwdom_init arch_iommu_hwdom_init(struct domain
>> > *d)
>> > if ( !hwdom_iommu_map(d, pfn, max_pfn) )
>> >
On 17.08.2018 13:28, Heiko Carstens wrote:
> On Fri, Aug 17, 2018 at 01:04:58PM +0200, David Hildenbrand wrote:
If there are no objections, I'll go into that direction. But I'll wait
for more comments regarding the general concept first.
>>>
>>> It is the middle of the merge window, and
flight 125915 linux-next real [real]
http://logs.test-lab.xenproject.org/osstest/logs/125915/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qcow210 debian-di-installfail REGR. vs. 125872
>>> On 17.08.18 at 09:01, wrote:
> Given what pt_pci_init() actually does, rename it properly and move its
> declaration to pci.h, move the only call in acpi_mmcfg_init().
>
> No functional change.
>
> Signed-off-by: Zhenzhong Duan
> Tested-by: Gopalasetty, Manoj
Acked-by: Jan Beulich
>>> On 15.08.18 at 19:57, wrote:
> --- a/xen/arch/x86/Rules.mk
> +++ b/xen/arch/x86/Rules.mk
> @@ -29,6 +29,10 @@ $(call as-option-add,CFLAGS,CC,"invpcid
> (%rax)$$(comma)%rax",-DHAVE_AS_INVPCID)
> $(call as-option-add,CFLAGS,CC,\
> ".if ((1 > 0) < 0); .error
Signed-off-by: Wei Liu
---
tools/firmware/xen-dir/shim.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/firmware/xen-dir/shim.config
b/tools/firmware/xen-dir/shim.config
index 21d7075..de53dfe 100644
--- a/tools/firmware/xen-dir/shim.config
+++
Make two functions static inline so that they can be referenced in p2m
code. Check nestedhvm is enabled before calling
nestedhvm_vmcx_flushtlb (which also has a side effect of not issuing
unnecessary IPIs for non-nested case).
While moving, reformat code and use proper boolean.
Signed-off-by:
On Fri, Aug 17, 2018 at 01:33:43AM -0600, Jan Beulich wrote:
> >>> On 17.08.18 at 00:04, wrote:
> > On Tue, Jul 10, 2018 at 04:14:11AM -0600, Jan Beulich wrote:
> >> Having noticed that VMLOAD alone is about as fast as a single of the
> >> involved WRMSRs, I thought it might be a reasonable idea
xen.lds.S uses on some of the config options set by Kconfig.
Signed-off-by: Wei Liu
---
xen/arch/arm/Makefile | 2 +-
xen/arch/x86/Makefile | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index b9b141dc84..4d732df1eb 100644
This series goes through x86 code to make CONFIG_HVM work.
With this series, it is possible to build Xen with PV support only.
Running `xl info` on a host with PV only Xen:
root@lcy2-dt108:~# xl info
host : lcy2-dt108
release: 4.17.0-0.bpo.1-amd64
version
VPCI is only useful for PVH / HVM guests. Ideally CONFIG_HVM should
imply !PV_SHIM_EXCLUSIVE, but we still want to build PV_SHIM_EXCLUSIVE
with CONFIG_HVM at this stage because a lot of things are still
entangled.
Signed-off-by: Wei Liu
---
xen/arch/x86/Kconfig | 2 +-
1 file changed, 1
The init function shouldn't be built or called at all when
!CONFIG_LOCK_PROFILE.
Signed-off-by: Wei Liu
---
xen/common/spinlock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
index 8f2ba08..36e31c9 100644
--- a/xen/common/spinlock.c
+++
Jan indicated that for PV guests the memory type is not changed, for
HVM guests memory_type_changed is needed for EPT's effective memory
type calculation. Call memory_type_changed for HVM guests only.
Signed-off-by: Wei Liu
---
xen/arch/x86/domctl.c | 4 ++--
xen/common/domctl.c
Signed-off-by: Wei Liu
---
xen/arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 63b286a..ba5cb62 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -94,6 +94,7 @@ config BIGMEM
config HVM_FEP
bool "HVM
Since it is defined in common header file, introduce CONFIG_HVM to
Arm to avoid breakage.
Signed-off-by: Wei Liu
---
xen/arch/arm/Kconfig| 3 +++
xen/include/xen/sched.h | 6 ++
2 files changed, 9 insertions(+)
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index
It is generally not a good idea to reference the internal data
structure of the another subsystem directly. Introduce a wrapper
function for the invlpg hook.
No functional change.
Signed-off-by: Wei Liu
---
xen/arch/x86/mm.c | 2 +-
xen/include/asm-x86/hvm/hvm.h | 5 +
2 files
PV guest (Dom0) needs to able to use these two hypercalls in order to
serve HVM guests. But if xen doesn't support HVM at all there is no
point in exposing them to PV guests.
Signed-off-by: Wei Liu
---
xen/arch/x86/pv/hypercall.c | 4
1 file changed, 4 insertions(+)
diff --git
Its callers live within the same file.
Signed-off-by: Wei Liu
---
xen/arch/x86/hvm/vmx/vvmx.c| 2 +-
xen/include/asm-x86/hvm/vmx/vvmx.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
index 918d47d..b7d9a1a
>>> On 17.08.18 at 09:01, wrote:
> pci_conf_read8() needs pci mmcfg mapping to work on multiple pci segments
> system such as HPE Superdome-Flex.
>
> Move acpi_mmcfg_init() call in acpi_boot_init() before calling
> acpi_parse_dmar() so that when pci_conf_read8() is called in
>
On Fri, Aug 17, 2018 at 03:56:29PM +0100, Wei Liu wrote:
> xen.lds.S uses on some of the config options set by Kconfig.
>
> Signed-off-by: Wei Liu
Ignore this patch, the path is wrong.
Wei.
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
xen.lds.S uses on some of the config options set by Kconfig.
Signed-off-by: Wei Liu
---
v2: correct the path used in the patch.
---
xen/arch/arm/Makefile | 2 +-
xen/arch/x86/Makefile | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/Makefile
Its counterpart is HVM only. Add the check to help dead code
elimination to figure out the call to pt_irq_destroy_bind is not
needed when HVM is not enabled.
Signed-off-by: Wei Liu
---
xen/arch/x86/domctl.c | 4
1 file changed, 4 insertions(+)
diff --git a/xen/arch/x86/domctl.c
They reference hvm_inject_event which is HVM code (not compiled). They
aren't used by code outside HVM code anyway.
Signed-off-by: Wei Liu
---
xen/include/asm-x86/hvm/hvm.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/xen/include/asm-x86/hvm/hvm.h b/xen/include/asm-x86/hvm/hvm.h
Move the code previously enclosed in CONFIG_HVM into its own file.
Note that although some code explicitly check is_hvm_*, which hints it
can be used for PV too, I can't find a code path that would be the
case.
Signed-off-by: Wei Liu
---
Can be squashed into previous patch if that's preferable.
Functions are moved to hvm.c. Reorder makefile items while at it.
Signed-off-by: Wei Liu
---
xen/drivers/passthrough/vtd/x86/Makefile | 3 +-
xen/drivers/passthrough/vtd/x86/hvm.c| 77 +-
xen/drivers/passthrough/vtd/x86/vtd.c| 45 +---
3 files
Move it to x86 generic code. While at it, use proper boolean type.
Signed-off-by: Wei Liu
---
xen/arch/x86/cpu/mtrr/generic.c | 31 +++
xen/arch/x86/hvm/mtrr.c | 31 ---
xen/include/asm-x86/mtrr.h | 2 +-
3 files changed, 32
p2m_flush is only called by HAP code, nvcpu_flush is only useful for
nestedhvm, both of which depend on HVM support.
Enclose their code in CONFIG_HVM. Add assertions.
Signed-off-by: Wei Liu
---
xen/arch/x86/mm/p2m.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
Signed-off-by: Wei Liu
---
xen/common/domain.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 171d25e..a22df12 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -318,8 +318,14 @@ struct domain
Signed-off-by: Wei Liu
---
xen/arch/x86/mm/mem_access.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c
index 03a8641..e1525fd 100644
--- a/xen/arch/x86/mm/mem_access.c
+++ b/xen/arch/x86/mm/mem_access.c
@@ -138,6 +138,7 @@ bool
Most are all HVM only. Provide stubs for !CONFIG_HVM.
One exception is PIT emulation, which is available to both PV and HVM.
Signed-off-by: Wei Liu
---
xen/include/asm-x86/domain.h | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git
We still need to test CONFIG_X86 because Arm also defines CONFIG_HVM.
Signed-off-by: Wei Liu
---
xen/drivers/passthrough/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/Makefile b/xen/drivers/passthrough/Makefile
index 6087333..6b2d2e0
This helps to take advantage of dead code elimination. Turn
hvm_enabled into proper bool while at it.
Providing an empty hvm_funcs resolves a lot of undefined references to
it in the header. It is safe to do so because those functions / macros
are not expected to be used.
Signed-off-by: Wei Liu
Going through the code, nested EPT, EPT, and ALTP2M depend on HVM code. Put
these components under CONFIG_HVM. This further requires putting one
of the vm event under CONFIG_HVM.
Also make hap_enabled evaluate to false when !CONFIG_HVM. This in turn
requires marking a variable in p2m_set_entry as
Enclose HVM only emulation code under CONFIG_HVM. Add some BUG()s to
to catch any issue.
Note that although some code checks is_hvm_*, which hints it can be
called for PV as well, I can't find such paths.
Signed-off-by: Wei Liu
---
xen/arch/x86/mm/shadow/common.c | 18 --
Ideally the HVM specific part of VM event should be moved into hvm/ at
some point, but this will do for now.
Signed-off-by: Wei Liu
---
xen/arch/x86/vm_event.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c
index f91aade..b4f6afb 100644
1 - 100 of 149 matches
Mail list logo
