[Xen-devel] [PATCH v6] arch/x86: Add registers to vm_event

2018-10-30 Thread Alexandru Stefan ISAILA
This patch adds a couple of regs to the vm_event that are used by the introspection. The base, limit and ar bits are compressed into a uint64_t union so as not to enlarge the vm_event. Signed-off-by: Alexandru Isaila Reviewed-by: Jan Beulich --- Changes since V5: - Rename x86_selector_r

Re: [Xen-devel] [PATCH v2 5/5] xen/keyhandler: Drop keyhandler_scratch

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 16:46, wrote: > On Tue, Oct 30, 2018 at 09:40:17AM -0600, Jan Beulich wrote: >> >>> On 30.10.18 at 16:32, wrote: >> > On Fri, Oct 26, 2018 at 09:21:03AM -0600, Jan Beulich wrote: >> >> >>> On 22.10.18 at 14:58, wrote: >> >> > --- a/xen/common/efi/boot.c >> >> > +++ b/xen/commo

Re: [Xen-devel] [PATCH v8 4/8] libxl: support unmapping static shared memory areas during domain destruction

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 4/8] libxl: support unmapping static shared memory areas during domain destruction"): > Add libxl__sshm_del to unmap static shared memory areas mapped by > libxl__sshm_add during domain creation. The unmapping process is: This whole part should be in a commen

Re: [Xen-devel] [PATCH v8 7/8] xen/arm: export shared memory regions as reserved-memory on device tree

2018-10-30 Thread Ian Jackson
Stefano Stabellini writes ("[PATCH v8 7/8] xen/arm: export shared memory regions as reserved-memory on device tree"): > Shared memory regions need to be advertised to the guest. Fortunately, a > device tree binding for special memory regions already exist: > reserved-memory. Oh! Here is the gues

[Xen-devel] [xen-unstable-smoke test] 129189: regressions - FAIL

2018-10-30 Thread osstest service owner
flight 129189 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129189/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 5 host-ping-check-native fail REGR. vs. 129151 Tests which

[Xen-devel] [OSSTEST PATCH] cr-for-branches: Add linux-4.19

2018-10-30 Thread Ian Jackson
Signed-off-by: Ian Jackson --- cr-for-branches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cr-for-branches b/cr-for-branches index f7e4caea..2e9717e0 100755 --- a/cr-for-branches +++ b/cr-for-branches @@ -31,7 +31,7 @@ scriptoptions="$1"; shift LOGFILE=tmp/cr-for-branches

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 14:29, wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -1142,12 +1142,14 @@ map_grant_ref( > { > if ( !(kind & MAPKIND_WRITE) ) > err = iommu_map_page(ld, _dfn(mfn_x(mfn)), mfn, > +

[Xen-devel] [OSSTEST PATCH] README.hardware-acquisition

2018-10-30 Thread Ian Jackson
New document-cum-checklist, for helping with hardware procurement. Signed-off-by: Ian Jackson CC: in...@xenproject.org --- README.hardware-acquisition | 310 1 file changed, 310 insertions(+) create mode 100644 README.hardware-acquisition diff --git

Re: [Xen-devel] [PATCH V3 1/3] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 13:40, wrote: > This patch is a pre-requisite for fixing the logdirty VGA issue > (display freezes when switching to a new altp2m view early in a > domain's lifetime), but sent separately for easier review. > The new ept_set_ad_sync() function has been added to update all > acti

Re: [Xen-devel] [PATCH V3 1/3] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 6:14 PM, Jan Beulich wrote: On 29.10.18 at 13:40, wrote: >> This patch is a pre-requisite for fixing the logdirty VGA issue >> (display freezes when switching to a new altp2m view early in a >> domain's lifetime), but sent separately for easier review. >> The new ept_set_ad_sync()

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 13:40, wrote: > This patch is a pre-requisite for the one fixing VGA logdirty > freezes when using altp2m. It only concerns itself with the > ranges allocation / deallocation / initialization part. But while looking (briefly only for now) over patch 3 I couldn't see any sync-in

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 08:44:20AM -0600, Jan Beulich wrote: > There's no guarantee that e.g. a switch() control expression's memory > operand(s) get(s) read just once. Guard against the compiler producing > "unexpected" code by sprinkling around some ACCESS_ONCE(). > > I'm leaving alone opt_consw

[Xen-devel] [qemu-mainline baseline-only test] 75545: trouble: blocked/broken/fail/pass

2018-10-30 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75545 qemu-mainline real [real] http://osstest.xensource.com/osstest/logs/75545/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386

Re: [Xen-devel] [PATCH V3 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-10-30 Thread Jan Beulich
>>> On 29.10.18 at 13:40, wrote: > @@ -316,6 +339,22 @@ void p2m_memory_type_changed(struct domain *d) > } > } > > +void p2m_memory_type_changed(struct domain *d) > +{ > +_memory_type_changed(p2m_get_hostp2m(d)); > + > +#ifdef CONFIG_HVM > +if ( unlikely(altp2m_active(d)) ) > +

Re: [Xen-devel] [PATCH 2/8] viridian: remove MSR perf counters

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:05PM +, Paul Durrant wrote: > They're not really useful so maintaining them is pointless. > > Signed-off-by: Paul Durrant If you think they are not helpful: Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 17:13, wrote: > New document-cum-checklist, for helping with hardware procurement. > > Signed-off-by: Ian Jackson I don't think any acks should be needed here, but if so: Acked-by: Jan Beulich Jan ___ Xen-devel mailing list Xen

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
Thank you Juergen for your comments. I will soon send v2 patch. -Thanks, Manjunath On 10/30/2018 12:04 AM, Juergen Gross wrote: On 29/10/2018 19:31, Manjunath Patil wrote: info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path. Typi

Re: [Xen-devel] [PATCH v3 3/7] x86/pvh: allow PVH Dom0 to use the debug IO port console

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 04:41:19PM +0100, Roger Pau Monne wrote: > Force trapping accesses to IO port 0xe9 for a PVH Dom0, so it can > print to the HVM debug console. > > Signed-off-by: Roger Pau Monné Reviewed-by: Wei Liu ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Andrew Cooper
On 30/10/18 16:22, Jan Beulich wrote: On 29.10.18 at 13:40, wrote: >> This patch is a pre-requisite for the one fixing VGA logdirty >> freezes when using altp2m. It only concerns itself with the >> ranges allocation / deallocation / initialization part. > But while looking (briefly only for n

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 17:23, wrote: > On Tue, Oct 30, 2018 at 08:44:20AM -0600, Jan Beulich wrote: >> There's no guarantee that e.g. a switch() control expression's memory >> operand(s) get(s) read just once. Guard against the compiler producing >> "unexpected" code by sprinkling around some ACCESS_O

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
On 10/30/2018 3:39 AM, Roger Pau Monné wrote: On Mon, Oct 29, 2018 at 11:31:56AM -0700, Manjunath Patil wrote: info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path. Typical call stack involving panic - #8 page_fault at 81

Re: [Xen-devel] [PATCH v3 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 04:41:23PM +0100, Roger Pau Monne wrote: > PV Dom0 has a quirk for some AMD processors, where enabling ACPI can > also enable C1E mode. Apply the same workaround as done on PV for a > PVH Dom0, which consist on trapping accesses to the SMI command IO > port and disabling C1E

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 10:28:21AM -0600, Jan Beulich wrote: > >>> On 30.10.18 at 17:23, wrote: > > On Tue, Oct 30, 2018 at 08:44:20AM -0600, Jan Beulich wrote: > >> There's no guarantee that e.g. a switch() control expression's memory > >> operand(s) get(s) read just once. Guard against the compi

Re: [Xen-devel] [PATCH] use consistent values when consuming runtime-changeable parameters

2018-10-30 Thread George Dunlap
On 10/30/2018 02:44 PM, Jan Beulich wrote: > There's no guarantee that e.g. a switch() control expression's memory > operand(s) get(s) read just once. Guard against the compiler producing > "unexpected" code by sprinkling around some ACCESS_ONCE(). > > I'm leaving alone opt_conswitch[]: It gets ac

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl-qemut-debianhvm-amd64-xsm

2018-10-30 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-qemut-debianhvm-amd64-xsm testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xe

Re: [Xen-devel] [PATCH v5 12/25] xen/arm: refactor construct_dom0

2018-10-30 Thread Julien Grall
Hi Stefano, On 23/10/2018 03:02, Stefano Stabellini wrote: Move generic initializations out of construct_dom0 so that they can be reused. Rename prepare_dtb to prepare_dtb_hwdom to avoid confusion. No functional changes in this patch. Signed-off-by: Stefano Stabellini Acked-by: Julien Gral

Re: [Xen-devel] [GIT PULL] xen: fixes for 4.20-rc1

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 12:44 AM Juergen Gross wrote: > > It contains only several small fixes and cleanups this time. Pulled, Linus ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/li

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 6:22 PM, Jan Beulich wrote: On 29.10.18 at 13:40, wrote: >> This patch is a pre-requisite for the one fixing VGA logdirty >> freezes when using altp2m. It only concerns itself with the >> ranges allocation / deallocation / initialization part. > > But while looking (briefly only

Re: [Xen-devel] [PATCH v5 13/25] xen/arm: move unregister_init_virtual_region to init_done

2018-10-30 Thread Julien Grall
Hi Stefano, On 23/10/2018 03:02, Stefano Stabellini wrote: Move unregister_init_virtual_region to init_done. Follow the same path as x86. It is also useful to move it later so that create_domUs can be called before that in following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Jul

Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing section number in the spec.

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:06PM +, Paul Durrant wrote: > Microsoft has a habit of re-numbering sections in the spec. so avoid > referring to section numbers in comments. Also remove the URL for the > spec. from the boilerplate... Again, Microsoft has a habit of changing > these too. > > Thi

Re: [Xen-devel] [PATCH v5 14/25] xen/arm: introduce create_domUs

2018-10-30 Thread Julien Grall
Hi Stefano, On 23/10/2018 03:02, Stefano Stabellini wrote: Call a new function, "create_domUs", from setup_xen to start DomU VMs. Introduce support for the "xen,domain" compatible node on device tree. Create new DomU VMs based on the information found on device tree under "xen,domain". Call con

Re: [Xen-devel] [PATCH 4/8] viridian: remove duplicate union types

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:07PM +, Paul Durrant wrote: > The 'viridian_vp_assist', 'viridian_hypercall_gpa' and > 'viridian_reference_tsc' union types are identical in layout. The layout > is also common throughout the specification [1]. > > This patch declares a common 'viridian_page_msr'

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 17:32, wrote: > On 10/30/18 6:22 PM, Jan Beulich wrote: > On 29.10.18 at 13:40, wrote: >>> This patch is a pre-requisite for the one fixing VGA logdirty >>> freezes when using altp2m. It only concerns itself with the >>> ranges allocation / deallocation / initialization par

Re: [Xen-devel] [PATCH V3 3/3] x86/altp2m: fix display frozen when switching to a new view early

2018-10-30 Thread Wei Liu
On Tue, Oct 30, 2018 at 10:25:20AM -0600, Jan Beulich wrote: > >>> On 29.10.18 at 13:40, wrote: > > @@ -316,6 +339,22 @@ void p2m_memory_type_changed(struct domain *d) > > } > > } > > > > +void p2m_memory_type_changed(struct domain *d) > > +{ > > +_memory_type_changed(p2m_get_hostp2m(d

[Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path. Typical call stack involving panic - #8 page_fault at 8175936f [exception RIP: blkif_free_ring+33] RIP: a0149491 RSP: 8804f7673c08 RFLAGS: 00010292 .

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("[Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper"): > Commit 81946a73dc975a7dafe9017a8e61d1e64fdbedbf removed > Xenctrl.with_intf based on its undesirable behaviour of opening and > closing a Xenctrl connection with every invocation. This commit

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("[Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise"): > The type of Xsraw.sync is made more precise: > > from val sync : (Xenbus.Xb.t -> 'a) -> con -> string > to val sync : (Xenbus.Xb.t -> unit) -> con -> string > > The first argument is enforc

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 6:28 PM, Andrew Cooper wrote: > On 30/10/18 16:22, Jan Beulich wrote: > On 29.10.18 at 13:40, wrote: >>> This patch is a pre-requisite for the one fixing VGA logdirty >>> freezes when using altp2m. It only concerns itself with the >>> ranges allocation / deallocation / initializati

Re: [Xen-devel] [PATCH 5/8] viridian: separate interrupt related enlightenment implementations...

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:08PM +, Paul Durrant wrote: > ...into new 'synic' module. > > The SynIC (synthetic interrupt controller) is specified [1] to be a super- > set of a virtualized LAPIC, and its definition encompasses all > enlightenments related to virtual interrupt control. > > Th

Re: [Xen-devel] [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Juergen Gross
On 30/10/2018 17:49, Manjunath Patil wrote: > info->nr_rings isn't adjusted in case of ENOMEM error from > negotiate_mq(). This leads to kernel panic in error path. > > Typical call stack involving panic - > #8 page_fault at 8175936f > [exception RIP: blkif_free_ring+33] > RIP: ff

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Christian Lindig
> On 30 Oct 2018, at 16:50, Ian Jackson wrote: > > I'm not much of an ocaml programmer but this seems like it has no > overall functional change ? > > I take it that ignore is the trivial function with type ('a -> unit). That is correct. Except that types now reflect more accurately what is

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Andrew Cooper
On 30/10/18 16:51, Razvan Cojocaru wrote: > On 10/30/18 6:28 PM, Andrew Cooper wrote: >> On 30/10/18 16:22, Jan Beulich wrote: >> On 29.10.18 at 13:40, wrote: This patch is a pre-requisite for the one fixing VGA logdirty freezes when using altp2m. It only concerns itself with the >>>

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Christian Lindig
> On 30 Oct 2018, at 16:48, Ian Jackson wrote: > > I think it would be better to have close_handle set handle to None, > and write in the docs that it is forbidden to call close_handle within > with_intf. You are right - close_handle should set the handle to None in addition. > For that matt

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 October 2018 16:08 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap ; Wei > Liu ; Ian Jackson ; Jun > Nakajima ; Kevin Tian ; > Stefano Stabellini ; xen-devel de...@lists.xenproject.org>;

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: make type of Xsraw.sync more precise"): > > On 30 Oct 2018, at 16:50, Ian Jackson wrote: > > I'm not much of an ocaml programmer but this seems like it has no > > overall functional change ? > > > > I take it that ignore is the t

Re: [Xen-devel] [PATCH] libxl: libxl__ev_fd_callback: Document perhaps-no-retry semantics

2018-10-30 Thread Wei Liu
On Mon, Oct 15, 2018 at 03:01:07PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson > CC: Anthony PERARD I think you understand the event machinery more than I do, so feel free to apply this patch. Wei. ___ Xen-devel mailing list Xen-devel@list

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper"): > You are right - close_handle should set the handle to None in addition. > > > For that matter, why is close_handle needed at all ? > > I mostly added it for symmetry and it is needed to

Re: [Xen-devel] [PATCH] libxencall: Make bufdev/nobufdev mmap error messages distinct

2018-10-30 Thread Wei Liu
On Mon, Oct 15, 2018 at 03:24:11PM +0100, Ian Jackson wrote: > This assists diagnosis. Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2] libxencall: Improve linux syscall error messages

2018-10-30 Thread Wei Liu
On Mon, Oct 15, 2018 at 03:32:05PM +0100, Ian Jackson wrote: > Make the bufdev and non-bufdev messages distinct, and always print the > non-constant argument (ie, the size). > > This assists diagnosis. > > CC: Andrew Cooper > CC: Hans van Kranenburg Acked-by: Wei Liu

Re: [Xen-devel] [PATCH] libxl: libxl__ev_fd_callback: Document perhaps-no-retry semantics

2018-10-30 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: libxl__ev_fd_callback: Document perhaps-no-retry semantics"): > On Mon, Oct 15, 2018 at 03:01:07PM +0100, Ian Jackson wrote: > > Signed-off-by: Ian Jackson > > CC: Anthony PERARD > > I think you understand the event machinery more than I do, so feel free > to

Re: [Xen-devel] [PATCH 6/8] viridian: separate time related enlightenment implementations...

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:09PM +, Paul Durrant wrote: > @@ -154,6 +145,14 @@ viridian_hypercall(struct cpu_user_regs *regs); > void viridian_time_ref_count_freeze(struct domain *d); > void viridian_time_ref_count_thaw(struct domain *d); > > +int viridian_time_wrmsr(struct vcpu *v, uint3

Re: [Xen-devel] [PATCH 4/8] viridian: remove duplicate union types

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 16:40 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Jan Beulich > > Subject: Re: [Xen-devel] [PATCH 4/8] viridian: remove duplicate union > types > > On Mon, Oct 29, 2018 at 06:02:

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Jan Beulich
>>> On 30.10.18 at 17:56, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 30 October 2018 16:08 >> >> >>> On 29.10.18 at 14:29, wrote: >> > --- a/xen/common/grant_table.c >> > +++ b/xen/common/grant_table.c >> > @@ -1142,12 +1142,14 @@ map_grant_ref( >> > { >> >

Re: [Xen-devel] [PATCH 5/8] viridian: separate interrupt related enlightenment implementations...

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 16:52 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Jan Beulich > > Subject: Re: [Xen-devel] [PATCH 5/8] viridian: separate interrupt related > enlightenment implementations... > >

Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing section number in the spec.

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 16:34 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Jan Beulich > > Subject: Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing > section number in the spec. > > On

Re: [Xen-devel] [PATCH 7/8] viridian: define type for the 'virtual VP assist page'

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:10PM +, Paul Durrant wrote: > The specification [1] defines a type so we should use it, rather than just > OR-ing and AND-ing magic bits. > > No functional change. > > NOTE: The type defined in the specification does include an anonymous > sub-struct in the

Re: [Xen-devel] [PATCH 6/8] viridian: separate time related enlightenment implementations...

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 17:03 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Jan Beulich > > Subject: Re: [Xen-devel] [PATCH 6/8] viridian: separate time related > enlightenment implementations... > > On M

Re: [Xen-devel] [PATCH] docs: remove ChangeLog file

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 12:38:06PM +0200, Juergen Gross wrote: > docs/ChangeLog has been updated for Xen 3.3 last time. It seems to be > interesting for archaeologists only today. > > Remove it. > > Signed-off-by: Juergen Gross I wouldn't mind removing it. Nowadays I mostly use git to do archae

Re: [Xen-devel] [PATCH v2] iommu / p2m: add a page_order parameter to iommu_map/unmap_page()

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 October 2018 17:05 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; George Dunlap ; Ian > Jackson ; Wei Liu ; Jun > Nakajima ; Kevin Tian ; > Stefano Stabellini ; xen-devel de...@lists.xenproject.org>;

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Christian Lindig
> On 30 Oct 2018, at 17:01, Ian Jackson wrote: > > Well, yes, but who would ever call it ? It's not safe to use except > at the toplevel (whatever that means, but probably outside any > with_intf) because elsewhere you don't know whose work you're > sabotaging. > > Which reminds me: why do yo

Re: [Xen-devel] [PATCH 7/8] viridian: define type for the 'virtual VP assist page'

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 17:09 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Wei Liu ; Jan Beulich > > Subject: Re: [Xen-devel] [PATCH 7/8] viridian: define type for the > 'virtual VP assist page' > > On Mon, Oct 29

Re: [Xen-devel] [PATCH V2] Release: add release note link to SUPPORT.md

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 03:13:44PM +0200, Juergen Gross wrote: > In order to have a link to the release notes in the feature list > generated from SUPPORT.md add that link in the "Release Support" > section of that file. > > The real link needs to be adapted when the version is being released. >

Re: [Xen-devel] [PATCH 8/8] viridian: introduce struct viridian_page

2018-10-30 Thread Roger Pau Monné
On Mon, Oct 29, 2018 at 06:02:11PM +, Paul Durrant wrote: > The 'vp_assist' page is currently an example of a guest page which needs to > be kept mapped throughout the life-time of a guest, but there are other > such examples in the specifiction [1]. This patch therefore introduces a > generic

Re: [Xen-devel] [PATCH 8/8] viridian: introduce struct viridian_page

2018-10-30 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 30 October 2018 17:18 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Wei Liu ; Ian > Jackson ; Jan Beulich ; Andrew > Cooper > Subject: Re: [Xen-devel] [PATCH 8/8] viridian: introduce struct > viridian_page > > On Mon, Oct 29

Re: [Xen-devel] [PULL v2 00/20] Qemu trivial for 3.1 patches

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:23, Laurent Vivier wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository at:

[Xen-devel] [ovmf test] 129191: all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129191 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129191/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a0f01e8a22e15000e564f09e82eae13d7127be3c baseline version: ovmf 4222e8e7e421e9c8d2c2f

Re: [Xen-devel] [PATCH RESEND qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time

2018-10-30 Thread Pasi Kärkkäinen
On Mon, Oct 29, 2018 at 08:55:09PM +, Paraschiv, Andra-Irina wrote: > > > On Mon, Oct 29, 2018 at 04:58:22PM +0200, Pasi Kärkkäinen wrote: > > Hi, > > > > On Wed, Oct 24, 2018 at 04:20:35PM +0100, Ian Jackson wrote: > > > Andra Paraschiv writes ("[PATCH RESEND qemu-xen-traditional] xen/pt: >

Re: [Xen-devel] [PATCH v2] arm, smmu: backport "Disable stalling faults for all endpoints"

2018-10-30 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Jan Beulich wrote: > >>> On 29.10.18 at 22:14, wrote: > > From: Stefano Stabellini > > > > Backport commit 3714ce1d6655098ee69ede632883e5874d67e4ab > > "iommu/arm-smmu: Disable stalling faults for all endpoints" from the > > Linux kernel. This works-around Erratum #842869. >

Re: [Xen-devel] [PATCH v2 03/16] x86: make traps.c build with !CONFIG_PV

2018-10-30 Thread Wei Liu
On Fri, Oct 26, 2018 at 10:02:19AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 16:28, wrote: > > @@ -1337,8 +1339,15 @@ static int fixup_page_fault(unsigned long addr, > > struct cpu_user_regs *regs) > > { > > if ( !(regs->error_code & (PFEC_user_mode | PFEC_reserved_bit)) && > >

Re: [Xen-devel] [PATCH v5 03/15] libxl_qmp: Implement fd callback and read data [and 1 more messages]

2018-10-30 Thread Anthony PERARD
On Mon, Oct 29, 2018 at 05:31:59PM +, Ian Jackson wrote: > Anthony PERARD writes ("Re: [PATCH v5 03/15] libxl_qmp: Implement fd callback > and read data [and 1 more messages]"): > > On Mon, Oct 15, 2018 at 05:35:36PM +0100, Ian Jackson wrote: > > > > +ev->buf_consumed += len; > > > > +

Re: [Xen-devel] [PATCH v2 09/16] x86: don't setup PV hypercall stubs and entries when !CONFIG_PV

2018-10-30 Thread Andrew Cooper
On 29/10/18 14:37, Jan Beulich wrote: On 19.10.18 at 17:59, wrote: >> On 19/10/18 15:28, Wei Liu wrote: >>> @@ -347,6 +352,7 @@ void subarch_percpu_traps_init(void) >>> /* Common SYSCALL parameters. */ >>> wrmsrl(MSR_STAR, XEN_MSR_STAR); >>> wrmsrl(MSR_SYSCALL_MASK, XEN_SYSCALL

Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper

2018-10-30 Thread Ian Jackson
Christian Lindig writes ("Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper"): > I agree that it would not harm but conceptually I believe you > should manage this explicitly using interface_{open/close} or implicitly > using with_intf. I would use an exit handler t

Re: [Xen-devel] [PATCH v5 03/15] libxl_qmp: Implement fd callback and read data [and 1 more messages]

2018-10-30 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH v5 03/15] libxl_qmp: Implement fd callback and read data [and 1 more messages]"): > On Mon, Oct 29, 2018 at 05:31:59PM +, Ian Jackson wrote: > > To be honest this condition is a bit fiddly. Why not do this after > > subtracting buf_consumed from buf_used and

Re: [Xen-devel] [PATCH V3 2/3] x86/mm: allocate logdirty_ranges for altp2ms

2018-10-30 Thread Razvan Cojocaru
On 10/30/18 6:54 PM, Andrew Cooper wrote: > On 30/10/18 16:51, Razvan Cojocaru wrote: >> On 10/30/18 6:28 PM, Andrew Cooper wrote: >>> On 30/10/18 16:22, Jan Beulich wrote: >>> On 29.10.18 at 13:40, wrote: > This patch is a pre-requisite for the one fixing VGA logdirty > freezes when u

Re: [Xen-devel] [PATCH v8 6/8] docs: documentation about static shared memory regions

2018-10-30 Thread Stefano Stabellini
Hi Ian, I am replying here, but I am addressing also your other emails. This is v8 of the series, the first version was sent in Aug 2017, and the design document, including the master/slave terminology, was accepted even before that. At this stage I am only looking for minor suggestions for impro

[Xen-devel] [xen-unstable-smoke test] 129196: tolerable all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129196 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129196/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v8 6/8] docs: documentation about static shared memory regions

2018-10-30 Thread Julien Grall
On 10/30/18 6:58 PM, Stefano Stabellini wrote: Hi Ian, I am replying here, but I am addressing also your other emails. This is v8 of the series, the first version was sent in Aug 2017, and the design document, including the master/slave terminology, was accepted even before that. At this stag

Re: [Xen-devel] [PATCH v8 2/8] libxl: introduce a new structure to represent static shared memory regions

2018-10-30 Thread Julien Grall
Hi Ian, On 10/30/18 3:20 PM, Ian Jackson wrote: Stefano Stabellini writes ("[PATCH v8 2/8] libxl: introduce a new structure to represent static shared memory regions"): From: Zhongze Liu Author: Zhongze Liu Add a new structure to the IDL family to represent static shared memory regions as

Re: [Xen-devel] [PATCH v8 3/8] libxl: support mapping static shared memory areas during domain creation

2018-10-30 Thread Julien Grall
On 10/30/18 3:36 PM, Ian Jackson wrote: Stefano Stabellini writes ("[PATCH v8 3/8] libxl: support mapping static shared memory areas during domain creation"): +_hidden +bool libxl__arch_domain_support_sshm(const libxl_domain_build_info *b_info); + +_hidden +int libxl__arch_domain_sshm_cachepo

Re: [Xen-devel] [PATCH v8 7/8] xen/arm: export shared memory regions as reserved-memory on device tree

2018-10-30 Thread Julien Grall
Hi, On 10/30/18 3:58 PM, Ian Jackson wrote: Stefano Stabellini writes ("[PATCH v8 7/8] xen/arm: export shared memory regions as reserved-memory on device tree"): Shared memory regions need to be advertised to the guest. Fortunately, a device tree binding for special memory regions already exis

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition

2018-10-30 Thread Julien Grall
Hi Ian, On 10/30/18 4:13 PM, Ian Jackson wrote: +Compatibility with Xen and Linux - requirements +--- + +(Normally these issues are not a problem for x86, except perhaps for +the network and storage controllers - see MASS STORAGE and NETWORKING, +above

Re: [Xen-devel] [PATCH v2 07/16] x86: put XEN_DOMCTL_{set, get}_address_size under CONFIG_PV

2018-10-30 Thread Wei Liu
On Mon, Oct 29, 2018 at 08:28:07AM -0600, Jan Beulich wrote: > >>> On 19.10.18 at 16:28, wrote: > > They are useful to PV only. > > Considering there was no is_{hvm,pv}_...() check so far, I think > you need to extend this a little plus ... I thought the code was self-explanatory enough. Anyway

Re: [Xen-devel] [PATCH v5 11/25] xen/arm: introduce allocate_memory

2018-10-30 Thread Julien Grall
Hi Stefano, More comments on it :). On 10/23/18 3:02 AM, Stefano Stabellini wrote: Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest memory map: GUEST_RAM0_BASE and GUEST_RAM1_BASE. This is under #if 0 as not

Re: [Xen-devel] [PATCH v5 15/25] xen/arm: implement construct_domU

2018-10-30 Thread Julien Grall
On 10/23/18 3:02 AM, Stefano Stabellini wrote: Similar to construct_dom0, construct_domU creates a barebone DomU guest. The device tree node passed as argument is compatible "xen,domain", see docs/misc/arm/device-tree/booting.txt. Remove #if 0 from allocate_memory as this patch will start usi

Re: [Xen-devel] [PATCH v5 18/25] xen/arm: generate vpl011 node on device tree for domU

2018-10-30 Thread Julien Grall
Hi Stefano, On 10/23/18 3:02 AM, Stefano Stabellini wrote: Introduce vpl011 support to guests started from Xen: it provides a simple way to print output from a guest, as most guests come with a pl011 driver. It is also able to provide a working console with interrupt support. The UART exposed t

Re: [Xen-devel] [PATCH v2 07/16] x86: put XEN_DOMCTL_{set, get}_address_size under CONFIG_PV

2018-10-30 Thread Wei Liu
On Fri, Oct 19, 2018 at 04:18:21PM +0100, Andrew Cooper wrote: > On 19/10/18 15:28, Wei Liu wrote: > > They are useful to PV only. > > > > Signed-off-by: Wei Liu > > How easy is this to turn into a domaincreate flag?  It is yet another > singleton operation which complicated Xen's init/cleanup pa

[Xen-devel] [PATCH] tools/misc/xenpm: fix getting info when some CPUs are offline

2018-10-30 Thread Marek Marczykowski-Górecki
Use physinfo.max_cpu_id instead of physinfo.nr_cpus to get max CPU id. This fixes for example 'xenpm get-cpufreq-para' with smt=off, which otherwise would miss half of the cores. Signed-off-by: Marek Marczykowski-Górecki --- Reported by @tfm1: https://github.com/QubesOS/qubes-issues/isues/4456 --

[Xen-devel] [xen-unstable-smoke test] 129202: tolerable all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129202 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129202/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH] tools/misc/xenpm: fix getting info when some CPUs are offline

2018-10-30 Thread Andrew Cooper
On 30/10/2018 22:16, Marek Marczykowski-Górecki wrote: > Use physinfo.max_cpu_id instead of physinfo.nr_cpus to get max CPU id. > This fixes for example 'xenpm get-cpufreq-para' with smt=off, which > otherwise would miss half of the cores. > > Signed-off-by: Marek Marczykowski-Górecki > --- > Repo

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition

2018-10-30 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > Hi Ian, > > On 10/30/18 4:13 PM, Ian Jackson wrote: > > +Compatibility with Xen and Linux - requirements > > +--- > > + > > +(Normally these issues are not a problem for x86, except perhaps for > > +the network

Re: [Xen-devel] [PATCH v8 7/8] xen/arm: export shared memory regions as reserved-memory on device tree

2018-10-30 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > Hi, > > On 10/30/18 3:58 PM, Ian Jackson wrote: > > Stefano Stabellini writes ("[PATCH v8 7/8] xen/arm: export shared memory > > regions as reserved-memory on device tree"): > > > Shared memory regions need to be advertised to the guest. Fortunately, a >

Re: [Xen-devel] [PATCH v8 6/8] docs: documentation about static shared memory regions

2018-10-30 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > On 10/30/18 6:58 PM, Stefano Stabellini wrote: > > Hi Ian, > > > > I am replying here, but I am addressing also your other emails. This is > > v8 of the series, the first version was sent in Aug 2017, and the design > > document, including the master/slav

[Xen-devel] [PATCH] libvchan: create xenstore entries in one transaction

2018-10-30 Thread Marek Marczykowski-Górecki
This will prevent race when client waits for server with xs_watch - all entries should appear at once. Signed-off-by: Marek Marczykowski-Górecki --- tools/libvchan/init.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/tools/libvchan/init.c b/tools/libv

[Xen-devel] [PATCH] tools/hotplug: remove xen-hotplug-cleanup

2018-10-30 Thread Marek Marczykowski-Górecki
Since udev is no longer used to call hotplug scripts (neither in dom0 nor driver domain), this scripts is no longer referenced anywhere. libxl (xl devd or else) has own cleanup code. Signed-off-by: Marek Marczykowski-Górecki --- tools/hotplug/Linux/Makefile| 1 - tools/hotplug/Linux

[Xen-devel] [xen-unstable test] 129138: regressions - FAIL

2018-10-30 Thread osstest service owner
flight 129138 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/129138/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 12 guest-start fail REGR. vs. 128775 test-armhf-armhf-l

[Xen-devel] [ovmf baseline-only test] 75548: tolerable FAIL

2018-10-30 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75548 ovmf real [real] http://osstest.xensource.com/osstest/logs/75548/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-amd64-libvirt 6 libvirt-buildfail like 75546 buil

[Xen-devel] [ovmf test] 129212: all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129212 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129212/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 27b9cb33e7437f6aef184c6b2982d004d279cc04 baseline version: ovmf a0f01e8a22e15000e564f

[Xen-devel] [ovmf test] 129218: all pass - PUSHED

2018-10-30 Thread osstest service owner
flight 129218 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129218/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 269f3b51803685eb3f4f4cd4415dc833d375efba baseline version: ovmf 27b9cb33e7437f6aef184

<    1   2