Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model

2023-08-07 Thread Jan Beulich
On 07.08.2023 18:22, Shawn Anastasio wrote: > On 8/2/23 2:16 AM, Jan Beulich wrote: >> On 02.08.2023 02:11, Shawn Anastasio wrote: >>> --- a/xen/arch/ppc/include/asm/asm-defns.h >>> +++ b/xen/arch/ppc/include/asm/asm-defns.h >>> @@ -16,6 +16,13 @@ >>> lis reg, (val) @h;

Re: [PATCH v4 46/48] mm: shrinker: make memcg slab shrink lockless

2023-08-07 Thread Dave Chinner
On Mon, Aug 07, 2023 at 07:09:34PM +0800, Qi Zheng wrote: > Like global slab shrink, this commit also uses refcount+RCU method to make > memcg slab shrink lockless. This patch does random code cleanups amongst the actual RCU changes. Can you please move the cleanups to a spearate patch to reduce

Re: [PATCH v4 06/48] binder: dynamically allocate the android-binder shrinker

2023-08-07 Thread Muchun Song
> On Aug 7, 2023, at 19:08, Qi Zheng wrote: > > Use new APIs to dynamically allocate the android-binder shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v4 19/48] rcu: dynamically allocate the rcu-kfree shrinker

2023-08-07 Thread Muchun Song
> On Aug 7, 2023, at 19:09, Qi Zheng wrote: > > Use new APIs to dynamically allocate the rcu-kfree shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

[xen-unstable-smoke test] 182223: tolerable all pass - PUSHED

2023-08-07 Thread osstest service owner
flight 182223 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182223/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

Re: [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless

2023-08-07 Thread Dave Chinner
On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote: > diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h > index eb342994675a..f06225f18531 100644 > --- a/include/linux/shrinker.h > +++ b/include/linux/shrinker.h > @@ -4,6 +4,8 @@ > > #include > #include > +#include >

Re: [PATCH v4 44/48] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred}

2023-08-07 Thread Dave Chinner
On Mon, Aug 07, 2023 at 07:09:32PM +0800, Qi Zheng wrote: > Currently, we maintain two linear arrays per node per memcg, which are > shrinker_info::map and shrinker_info::nr_deferred. And we need to resize > them when the shrinker_nr_max is exceeded, that is, allocate a new array, > and then copy

Re: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture

2023-08-07 Thread Henry Wang
Hi Ayan, > On Aug 7, 2023, at 21:17, Ayan Kumar Halder wrote: > > Hi Henry, > > On 01/08/2023 04:44, Henry Wang wrote: >> CAUTION: This message has originated from an External Source. Please use >> proper judgment and caution when opening attachments, clicking links, or >> responding to this

[ovmf test] 182224: all pass - PUSHED

2023-08-07 Thread osstest service owner
flight 182224 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182224/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3c274c0d83d5464b336e40058bc5969bfef25f7b baseline version: ovmf

Re: Xen 4.18 release: Reminder about last posting date

2023-08-07 Thread Henry Wang
Hi Stefano, > On Aug 8, 2023, at 03:24, Stefano Stabellini wrote: > > On Mon, 7 Aug 2023, Henry Wang wrote: >> Hi everyone, >> >> Following the release schedule discussion in in April, I am sending this >> email >> to remind that according to the release schedule [1], August 11 (this Friday)

[linux-linus test] 182219: regressions - FAIL

2023-08-07 Thread osstest service owner
flight 182219 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182219/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278

Re: [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless

2023-08-07 Thread Dave Chinner
On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote: > The shrinker_rwsem is a global read-write lock in shrinkers subsystem, > which protects most operations such as slab shrink, registration and > unregistration of shrinkers, etc. This can easily cause problems in the > following cases.

[PATCH mm-unstable v9 24/31] nios2: Convert __pte_free_tlb() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Acked-by: Dinh Nguyen Signed-off-by: Vishal Moola (Oracle) --- arch/nios2/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH mm-unstable v9 18/31] arm64: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Acked-by: Mike Rapoport (IBM) Acked-by: Catalin Marinas Signed-off-by: Vishal Moola (Oracle) --- arch/arm64/include/asm/tlb.h | 14 --

[PATCH mm-unstable v9 19/31] csky: Convert __pte_free_tlb() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Guo Ren Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/csky/include/asm/pgalloc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH mm-unstable v9 29/31] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents

2023-08-07 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable pte constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/srmmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sparc/mm/srmmu.c

[PATCH mm-unstable v9 27/31] sh: Convert pte_free_tlb() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Reviewed-by: Geert Uytterhoeven Acked-by: John Paul Adrian Glaubitz Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) ---

[PATCH mm-unstable v9 25/31] openrisc: Convert __pte_free_tlb() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/openrisc/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH mm-unstable v9 17/31] arm: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. late_alloc() also uses the __get_free_pages() helper function. Convert this to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v9 30/31] um: Convert {pmd, pte}_free_tlb() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/um/include/asm/pgalloc.h | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH mm-unstable v9 21/31] loongarch: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v9 23/31] mips: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v9 22/31] m68k: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v9 14/31] s390: Convert various pgalloc functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v9 31/31] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers

2023-08-07 Thread Vishal Moola (Oracle)
These functions are no longer necessary. Remove them and cleanup Documentation referencing them. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- Documentation/mm/split_page_table_lock.rst| 12 +-- .../zh_CN/mm/split_page_table_lock.rst| 14

[PATCH mm-unstable v9 20/31] hexagon: Convert __pte_free_tlb() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/hexagon/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH mm-unstable v9 16/31] pgalloc: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v9 28/31] sparc64: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/init_64.c | 17 + 1 file changed, 9

[PATCH mm-unstable v9 26/31] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH mm-unstable v9 15/31] mm: remove page table members from struct page

2023-08-07 Thread Vishal Moola (Oracle)
The page table members are now split out into their own ptdesc struct. Remove them from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm_types.h | 21 - 1 file changed, 21 deletions(-) diff --git

[PATCH mm-unstable v9 13/31] x86: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola

[PATCH mm-unstable v9 11/31] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor}

2023-08-07 Thread Vishal Moola (Oracle)
Create pagetable_pte_ctor(), pagetable_pmd_ctor(), pagetable_pte_dtor(), and pagetable_pmd_dtor() and make the original pgtable constructor/destructors wrappers. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 56

[PATCH mm-unstable v9 10/31] mm: Convert ptlock_free() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +- mm/memory.c| 4 ++-- 2 files changed, 7 insertions(+), 7

[PATCH mm-unstable v9 12/31] powerpc: Convert various functions to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/powerpc/mm/book3s64/mmu_context.c | 10 ++--- arch/powerpc/mm/book3s64/pgtable.c | 32 +++---

[PATCH mm-unstable v9 09/31] mm: Convert pmd_ptlock_free() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH mm-unstable v9 08/31] mm: Convert ptlock_init() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH mm-unstable v9 07/31] mm: Convert pmd_ptlock_init() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH mm-unstable v9 06/31] mm: Convert ptlock_ptr() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/x86/xen/mmu_pv.c | 2 +- include/linux/mm.h| 14 +++--- 2 files changed, 8 insertions(+), 8

[PATCH mm-unstable v9 04/31] mm: Convert pmd_pgtable_page() callers to use pmd_ptdesc()

2023-08-07 Thread Vishal Moola (Oracle)
Converts internal pmd_pgtable_page() callers to use pmd_ptdesc(). This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 4 ++-- 1 file changed,

[PATCH mm-unstable v9 05/31] mm: Convert ptlock_alloc() to use ptdescs

2023-08-07 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 6 +++--- mm/memory.c| 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)

[PATCH mm-unstable v9 02/31] pgtable: create struct ptdesc

2023-08-07 Thread Vishal Moola (Oracle)
Currently, page table information is stored within struct page. As part of simplifying struct page, create struct ptdesc for page table information. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm_types.h | 70 1

[PATCH mm-unstable v9 00/31] Split ptdesc from struct page

2023-08-07 Thread Vishal Moola (Oracle)
The MM subsystem is trying to shrink struct page. This patchset introduces a memory descriptor for page table tracking - struct ptdesc. This patchset introduces ptdesc, splits ptdesc from struct page, and converts many callers of page table constructor/destructors to use ptdescs. Ptdesc is a

[PATCH mm-unstable v9 03/31] mm: add utility functions for ptdesc

2023-08-07 Thread Vishal Moola (Oracle)
Introduce utility functions setting the foundation for ptdescs. These will also assist in the splitting out of ptdesc from struct page. Functions that focus on the descriptor are prefixed with ptdesc_* while functions that focus on the pagetable are prefixed with pagetable_*. pagetable_alloc()

[PATCH mm-unstable v9 01/31] mm: Add PAGE_TYPE_OP folio functions

2023-08-07 Thread Vishal Moola (Oracle)
No folio equivalents for page type operations have been defined, so define them for later folio conversions. Also changes the Page##uname macros to take in const struct page* since we only read the memory here. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) ---

[PATCH RESEND] libxl: Make domain build xc_domain_setmaxmem() call use max_memkb

2023-08-07 Thread Kevin Alarcon Negy
When building a domain, xc_domain_setmaxmem() is called with target_memkb (memory in domain config file). If a config specifies maxmem > memory, any attempts to increase the domain memory size to its max, outside of xl mem-set or xl mem-max, which already call xc_domain_setmaxmem() properly,

Re: Xen 4.18 release: Reminder about last posting date

2023-08-07 Thread Andrew Cooper
On 07/08/2023 8:24 pm, Stefano Stabellini wrote: > On Mon, 7 Aug 2023, Henry Wang wrote: >> Hi everyone, >> >> Following the release schedule discussion in in April, I am sending this >> email >> to remind that according to the release schedule [1], August 11 (this Friday) >> will be the last

Re: Xen 4.18 release: Reminder about last posting date

2023-08-07 Thread Stefano Stabellini
On Mon, 7 Aug 2023, Henry Wang wrote: > Hi everyone, > > Following the release schedule discussion in in April, I am sending this email > to remind that according to the release schedule [1], August 11 (this Friday) > will be the last posting date, when patches adding new features are expected >

Re: [PATCH v3 5/5] x86: short-circuit certain cpu_has_* when x86-64-v{2,3} are in effect

2023-08-07 Thread Jason Andryuk
On Wed, Jul 26, 2023 at 6:35 AM Jan Beulich wrote: > > Certain fallback code can be made subject to DCE this way. Note that > CX16 has no compiler provided manifest constant, so CONFIG_* are used > there instead. Note also that we don't have cpu_has_movbe nor > cpu_has_lzcnt (aka cpu_has_abm). >

Re: [XEN PATCH] libxl: Use XEN_LIB_DIR to store bootloader from pygrub

2023-08-07 Thread Jason Andryuk
On Mon, Aug 7, 2023 at 10:07 AM Anthony PERARD wrote: > > In osstest, the jobs using pygrub on arm64 on the branch linux-linus > started to fails with: > [Errno 28] No space left on device > Error writing temporary copy of ramdisk > > This is because /var/run is small when dom0 has only

Re: [PATCH v3 3/5] x86: allow Kconfig control over psABI level

2023-08-07 Thread Jason Andryuk
On Wed, Jul 26, 2023 at 6:34 AM Jan Beulich wrote: > > Newer hardware offers more efficient and/or flexible and/or capable > instructions, some of which we can make good use of in the hypervisor > as well. Allow a basic way (no alternatives patching) of enabling their > use. Of course this means

Re: [PATCH] automation: Advertise that ECLAIR jobs do not need prerequisites

2023-08-07 Thread Stefano Stabellini
On Mon, 7 Aug 2023, Michal Orzel wrote: > While not required today (ECLAIR jobs come first), add "needs: []" for > future-proofing and consistency with other jobs in the pipeline. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > automation/gitlab-ci/analyze.yaml | 1 +

[PATCH v8 15/15] CHANGELOG: Add Intel HWP entry

2023-08-07 Thread Jason Andryuk
Signed-off-by: Jason Andryuk Acked-by: Henry Wang --- v3: Position under existing Added section Add Henry's Ack v2: Add blank line --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e5efcabda..56921db79f 100644 --- a/CHANGELOG.md +++

[PATCH v8 13/15] libxc: Add xc_set_cpufreq_cppc

2023-08-07 Thread Jason Andryuk
Add xc_set_cpufreq_cppc to allow calling xen_systctl_pm_op SET_CPUFREQ_CPPC. Signed-off-by: Jason Andryuk Acked-by: Anthony PERARD --- v2: Mark xc_set_hwp_para_t const v4: s/hwp/cppc/ Add Anthony's Ack v5: Remove const and copy back result --- tools/include/xenctrl.h | 4

[PATCH v8 12/15] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op

2023-08-07 Thread Jason Andryuk
Add SET_CPUFREQ_HWP xen_sysctl_pm_op to set HWP parameters. The sysctl supports setting multiple values simultaneously as indicated by the set_params bits. This allows atomically applying new HWP configuration via a single wrmsr. XEN_SYSCTL_HWP_SET_PRESET_BALANCE/PERFORMANCE/POWERSAVE provide

Re: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator

2023-08-07 Thread Jason Andryuk
On Fri, Aug 4, 2023 at 7:36 AM Jan Beulich wrote: > > On 04.08.2023 11:29, Andrew Cooper wrote: > > On 04/08/2023 8:23 am, Jan Beulich wrote: > >> On 03.08.2023 22:36, Andrew Cooper wrote: > >>> The opensuse-tumbleweed build jobs currently fail with: > >>> > >>>

[PATCH v8 14/15] xenpm: Add set-cpufreq-cppc subcommand

2023-08-07 Thread Jason Andryuk
set-cpufreq-cppc allows setting the Hardware P-State (HWP) parameters. It can be run on all or just a single cpu. There are presets of balance, powersave & performance. Those can be further tweaked by param:val arguments as explained in the usage description. Parameter names are just checked

[PATCH v8 11/15] xenpm: Print HWP/CPPC parameters

2023-08-07 Thread Jason Andryuk
Print HWP-specific parameters. Some are always present, but others depend on hardware support. Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- v2: Style fixes Declare i outside loop Replace repearted hardware/configured limits with spaces Fixup for hw_ removal Use XEN_HWP_GOVERNOR

[PATCH v8 10/15] libxc: Include cppc_para in definitions

2023-08-07 Thread Jason Andryuk
Expose the cppc_para fields through libxc. Signed-off-by: Jason Andryuk Acked-by: Anthony PERARD --- v4: Rename hwp to cppc Add Anthony's Ack --- tools/include/xenctrl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index

[PATCH v8 09/15] cpufreq: Export HWP parameters to userspace as CPPC

2023-08-07 Thread Jason Andryuk
Extend xen_get_cpufreq_para to return hwp parameters. HWP is an implementation of ACPI CPPC (Collaborative Processor Performance Control). Use the CPPC name since that might be useful in the future for AMD P-state. We need the features bitmask to indicate fields supported by the actual hardware

[PATCH v8 06/15] cpufreq: Add Hardware P-State (HWP) driver

2023-08-07 Thread Jason Andryuk
>From the Intel SDM: "Hardware-Controlled Performance States (HWP), which autonomously selects performance states while utilizing OS supplied performance guidance hints." Enable HWP to run in autonomous mode by poking the correct MSRs. HWP is disabled by default, and cpufreq=hwp enables it.

[PATCH v8 08/15] xenpm: Change get-cpufreq-para output for hwp

2023-08-07 Thread Jason Andryuk
When using HWP, some of the returned data is not applicable. In that case, we should just omit it to avoid confusing the user. So switch to printing the base and max frequencies since those are relevant to HWP. Similarly, stop printing the CPU frequencies since those do not apply. The scaling

[PATCH v8 07/15] xen/x86: Tweak PDC bits when using HWP

2023-08-07 Thread Jason Andryuk
Qubes testing of HWP support had a report of a laptop, Thinkpad X1 Carbon Gen 4 with a Skylake processor, locking up during boot when HWP is enabled. A user found a kernel bug that seems to be the same issue: https://bugzilla.kernel.org/show_bug.cgi?id=110941. That bug was fixed by Linux commit

[PATCH v8 05/15] pmstat: Re-arrage for cpufreq union

2023-08-07 Thread Jason Andryuk
Rearrange code now that xen_sysctl_pm_op's get_para fields has the nested union and struct. In particular, the scaling governor information like scaling_available_governors is inside the union, so it is not always available. Move those fields (op->u.get_para.u.s.u.*) together as well as the

[PATCH v8 04/15] xen/sysctl: Nest cpufreq scaling options

2023-08-07 Thread Jason Andryuk
Add a union and struct so that most of the scaling variables of struct xen_get_cpufreq_para are within in a binary-compatible layout. This allows cppc_para to live in the larger union and use uint32_ts - struct xen_cppc_para will be 10 uint32_t's. The new scaling struct is 3 * uint32_t + 16

[PATCH v8 03/15] cpufreq: Export intel_feature_detect

2023-08-07 Thread Jason Andryuk
Export feature_detect as intel_feature_detect so it can be re-used by HWP. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v4: Add Jan's Ack v3: Remove void * cast when calling intel_feature_detect v2: export intel_feature_detect with typed pointer Move intel_feature_detect to

[PATCH v8 02/15] cpufreq: Add perf_freq to cpuinfo

2023-08-07 Thread Jason Andryuk
acpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP needs to scale by base frequency. Settings max_freq to base_freq "works" but the code is not obvious, and returning values to userspace is tricky. Add an additonal perf_freq member which is used for scaling aperf/mperf

[PATCH v8 00/15] Intel Hardware P-States (HWP) support

2023-08-07 Thread Jason Andryuk
Hi, This patch series adds Hardware-Controlled Performance States (HWP) for Intel processors to Xen. v2 was only partially reviewed, so v3 is mostly a reposting of v2. In v2 & v3, I think I addressed all comments for v1. I kept patch 11 "xenpm: Factor out a non-fatal cpuid_parse variant", with

[PATCH v8 01/15] cpufreq: Allow restricting to internal governors only

2023-08-07 Thread Jason Andryuk
For hwp, the standard governors are not usable, and only the internal one is applicable. Add the cpufreq_governor_internal boolean to indicate when an internal governor, like hwp, will be used. This is set during presmp_initcall, and governor registration can be skipped when called during

Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3

2023-08-07 Thread Stefano Stabellini
On Mon, 7 Aug 2023, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: > > The variable declared in the header file 'xen/arch/x86/include/asm/e820.h' > > is shadowed by many function parameters, so it is renamed to avoid these > > violations. > > > > No functional changes. > > > >

[xen-unstable test] 182210: regressions - FAIL

2023-08-07 Thread osstest service owner
flight 182210 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182210/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-build fail in 182203 REGR. vs. 182210 Tests which are

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-08-07 Thread Julien Grall
Hi Alex, One more remark in the title. s/HAS// as you renamed the Kconfig. On 28/07/2023 08:59, Alejandro Vallejo wrote: Adds a new compile-time flag to allow disabling pdx compression and compiles out compression-related code/data. It also shorts the pdx<->pfn conversion macros and creates

[xen-unstable-smoke test] 182218: tolerable all pass - PUSHED

2023-08-07 Thread osstest service owner
flight 182218 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182218/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3

2023-08-07 Thread Federico Serafini
A missing change to the type in 'opt_arat' declaration introduced a new violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). Change the type to restore the consistency between all declarations of the object and drop a

[PATCH] xen/IOMMU: Switch bool_t to bool

2023-08-07 Thread Andrew Cooper
... as part of cleaning up the types used. Minor style cleanup on some altered lines. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/drivers/passthrough/amd/iommu.h | 4 ++-- xen/drivers/passthrough/amd/iommu_acpi.c

Re: [PATCH v2 3/5] mm/pdx: Standardize region validation wrt pdx compression

2023-08-07 Thread Alejandro Vallejo
On Mon, Jul 31, 2023 at 05:27:22PM +0200, Jan Beulich wrote: > On 28.07.2023 09:59, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/x86_64/mm.c > > +++ b/xen/arch/x86/x86_64/mm.c > > @@ -1159,6 +1159,9 @@ static int mem_hotadd_check(unsigned long spfn, > > unsigned long epfn) > > { > >

Re: [XEN PATCH v2 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3

2023-08-07 Thread Nicola Vetrini
On 07/08/2023 14:48, Jan Beulich wrote: On 04.08.2023 22:45, Stefano Stabellini wrote: On Fri, 4 Aug 2023, Nicola Vetrini wrote: Rename variables to avoid shadowing and thus address MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an

Re: [PATCH v2 2/5] mm: Factor out the pdx compression logic in ma/va converters

2023-08-07 Thread Alejandro Vallejo
On Mon, Jul 31, 2023 at 05:15:19PM +0200, Jan Beulich wrote: > On 28.07.2023 09:59, Alejandro Vallejo wrote: > > --- a/xen/include/xen/pdx.h > > +++ b/xen/include/xen/pdx.h > > @@ -160,6 +160,31 @@ static inline unsigned long pdx_to_pfn(unsigned long > > pdx) > > #define mfn_to_pdx(mfn)

Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model

2023-08-07 Thread Shawn Anastasio
On 8/2/23 2:16 AM, Jan Beulich wrote: > On 02.08.2023 02:11, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/include/asm/asm-defns.h >> +++ b/xen/arch/ppc/include/asm/asm-defns.h >> @@ -16,6 +16,13 @@ >> lis reg, (val) @h; >> \ >> ori

Re: [PATCH 3/9] xen/ppc: Implement atomic.h

2023-08-07 Thread Jan Beulich
On 03.08.2023 01:02, Shawn Anastasio wrote: > Implement atomic.h for PPC, based off of the original Xen 3.2 > implementation. Since likely that originally came from Linux, did you cross check that Linux hasn't gained any bug fixes in the meantime? Other than this just a couple of nits; I'm not

Re: [PATCH 4/4] xen/ppc: Implement early serial console on PowerNV

2023-08-07 Thread Shawn Anastasio
On 8/7/23 10:05 AM, Jan Beulich wrote: > On 02.08.2023 02:11, Shawn Anastasio wrote: >> Implement the OPAL firmware calls required to write to the serial >> console on PowerNV systems. Unlike pseries/Open Firmware, the OPAL >> firmware interface can be used past early boot and as such the relevant

Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option

2023-08-07 Thread Alejandro Vallejo
Hi, A few days have passed. May I suggest taking a step back? On Tue, Aug 01, 2023 at 09:57:57AM +0200, Jan Beulich wrote: > On 31.07.2023 19:38, Andrew Cooper wrote: > > There's one system which never made its way into production, > > support-for-which in the no-op case is causing a 10% perf

Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t

2023-08-07 Thread Andy Shevchenko
On Mon, Aug 07, 2023 at 05:22:18PM +0200, Takashi Iwai wrote: > On Tue, 01 Aug 2023 19:51:39 +0200, Andy Shevchenko wrote: > > On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: ... > I rather wonder why it can't be simple strncpy(). This is obvious. To avoid compiler warning about 0

Re: [PATCH 2/9] xen/ppc: Add public/arch-ppc.h

2023-08-07 Thread Jan Beulich
On 03.08.2023 01:02, Shawn Anastasio wrote: > Signed-off-by: Shawn Anastasio > --- > xen/include/public/arch-ppc.h | 140 ++ > 1 file changed, 140 insertions(+) > create mode 100644 xen/include/public/arch-ppc.h > > diff --git a/xen/include/public/arch-ppc.h

[linux-linus test] 182209: regressions - FAIL

2023-08-07 Thread osstest service owner
flight 182209 linux-linus real [real] flight 182217 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182209/ http://logs.test-lab.xenproject.org/osstest/logs/182217/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 1/9] xen/common: Add missing #includes treewide

2023-08-07 Thread Jan Beulich
On 03.08.2023 01:02, Shawn Anastasio wrote: > A few files treewide depend on defininitions in headers that they > don't include. This works when arch headers end up including the > required headers by chance, but broke on ppc64 with only minimal/stub > arch headers. > > Signed-off-by: Shawn

Re: [XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3

2023-08-07 Thread Jan Beulich
On 07.08.2023 17:24, Federico Serafini wrote: > Keep consistency between object declarations to address a violation > of MISRA C:2012 Rule 8.3 ("All declarations of an object or function > shall use the same names and type qualifiers"). > > No functional change. > > Signed-off-by: Federico

[XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3

2023-08-07 Thread Federico Serafini
Keep consistency between object declarations to address a violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/cpu.h | 2 +- 1 file changed, 1

Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t

2023-08-07 Thread Takashi Iwai
On Tue, 01 Aug 2023 19:51:39 +0200, Andy Shevchenko wrote: > > On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: > > On Mon, 31 Jul 2023 21:40:20 +0200, > > Mark Brown wrote: > > > On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > > > > Mark Brown wrote: > > > > > > > >

[PATCH 4/4] x86emul: support SM4

2023-08-07 Thread Jan Beulich
Since the insns here and in particular their memory access patterns follow the usual scheme, I didn't think it was necessary to add a contrived test specifically for them. Signed-off-by: Jan Beulich --- SDE: -arl, -lnl, or -future --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@

[PATCH 3/4] x86emul: support SM3

2023-08-07 Thread Jan Beulich
Since the insns here and in particular their memory access patterns follow the usual scheme, I didn't think it was necessary to add a contrived test specifically for them. Signed-off-by: Jan Beulich --- SDE: -arl, -lnl, or -future --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@

[PATCH 2/4] x86emul: support SHA512

2023-08-07 Thread Jan Beulich
Since the insns here don't access memory, I didn't think it was necessary to extend our SHA test for them. Signed-off-by: Jan Beulich --- The need to set op_bytes here is a little odd; I'm inclined to move the generate_exception_if(!op_bytes, X86_EXC_UD) at the top of SIMD handling (near the

[PATCH 1/4] x86emul: support AVX-VNNI-INT16

2023-08-07 Thread Jan Beulich
These are close relatives of the AVX-VNNI and AVX-VNNI-INT8 ISA extensions. Since the insns here and in particular their memory access patterns follow the usual scheme (and especially the word variants of AVX-VNNI), I didn't think it was necessary to add a contrived test specifically for them.

[PATCH 0/4] x86emul: support further AVX extensions

2023-08-07 Thread Jan Beulich
Covers the smaller recently announced extensions, but not AVX10 (and even less so APX). Obviously CPUID aspects are taken care of alongside the actual emulator additions. 1: support AVX-VNNI-INT16 2: support SHA512 3: support SM3 4: support SM4 Jan

Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3

2023-08-07 Thread Jan Beulich
On 07.08.2023 17:03, Nicola Vetrini wrote: > On 07/08/2023 10:09, Jan Beulich wrote: >> On 04.08.2023 17:27, Nicola Vetrini wrote: >>> The variable declared in the header file >>> 'xen/arch/x86/include/asm/e820.h' >>> is shadowed by many function parameters, so it is renamed to avoid >>> these

Re: [PATCH 4/4] xen/ppc: Implement early serial console on PowerNV

2023-08-07 Thread Jan Beulich
On 02.08.2023 02:11, Shawn Anastasio wrote: > Implement the OPAL firmware calls required to write to the serial > console on PowerNV systems. Unlike pseries/Open Firmware, the OPAL > firmware interface can be used past early boot and as such the relevant > functions are not marked as __init. > >

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

2023-08-07 Thread Simon Gaiser
Jan Beulich: > On 07.08.2023 14:55, Simon Gaiser wrote: >> Jan Beulich: >>> On 07.08.2023 11:38, Simon Gaiser wrote: It seems some firmwares put dummy entries in the ACPI MADT table for non existing processors. On my NUC11TNHi5 those have the invalid APIC ID 0xff. Linux already has

Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3

2023-08-07 Thread Nicola Vetrini
On 07/08/2023 10:09, Jan Beulich wrote: On 04.08.2023 17:27, Nicola Vetrini wrote: The variable declared in the header file 'xen/arch/x86/include/asm/e820.h' is shadowed by many function parameters, so it is renamed to avoid these violations. No functional changes. Signed-off-by: Nicola

Re: [PATCH 3/4] xen/ppc: Parse device tree for OPAL node on PowerNV

2023-08-07 Thread Jan Beulich
On 02.08.2023 02:11, Shawn Anastasio wrote: > Communication with firmware boot services on PowerNV requires parsing > the fdt blob passed by the bootloader in order to obtain the firmware > entrypoint. Use Xen's libfdt to do this and store the information > required for firmware calls, to be

Re: [PATCH 2/4] xen/ppc: Add OPAL API definition header file

2023-08-07 Thread Jan Beulich
On 02.08.2023 02:11, Shawn Anastasio wrote: > OPAL (OpenPower Abstraction Layer) is the interface exposed by firmware > on PowerNV (bare metal) systems. Import Linux's header definining the > API and related information. > > From Linux commit 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc > >

Re: [XEN PATCH 11/13] xen/x86: address violations of MISRA C:2012 Rule 7.3

2023-08-07 Thread Jan Beulich
On 04.08.2023 02:59, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the

  1   2   3   >