[xen-unstable test] 185741: tolerable FAIL - PUSHED

2024-04-19 Thread osstest service owner
flight 185741 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185741/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185737

[qemu-mainline test] 185739: regressions - trouble: broken/fail/pass

2024-04-19 Thread osstest service owner
flight 185739 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/185739/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-libvirt 5

[xen-unstable-smoke test] 185740: tolerable all pass - PUSHED

2024-04-19 Thread osstest service owner
flight 185740 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185740/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[xen-unstable test] 185737: tolerable FAIL

2024-04-19 Thread osstest service owner
flight 185737 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185737/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185731

Re: [PATCH v2 1/3] tools/golang: When returning pointers, actually allocate structrues

2024-04-19 Thread George Dunlap
On Fri, Apr 19, 2024 at 4:27 PM Nick Rosbrook wrote: > > On Fri, Apr 19, 2024 at 10:00 AM George Dunlap > wrote: > > > > In a handful of cases, it was decided to return a pointer to a > > structure rather than the plain structure itself, due to the size. > > However, in these cases the

Re: Detecting whether dom0 is in a VM

2024-04-19 Thread George Dunlap
On Fri, Apr 19, 2024 at 4:29 PM George Dunlap wrote: > > On Fri, Jul 7, 2023 at 3:56 PM George Dunlap wrote: > >> >>> Xen's public interface offers access to the featuresets known / found / > >> >>> used by the hypervisor. See XEN_SYSCTL_get_cpu_featureset, accessible > >> >>> via

Re: [PATCH v2 3/3] tools/golang: Run `go vet` as part of the build process

2024-04-19 Thread Nick Rosbrook
On Fri, Apr 19, 2024 at 10:00 AM George Dunlap wrote: > > Signed-off-by: George Dunlap > --- > CC: Nick Rosbrook > CC: Anthony PERARD > --- > tools/golang/xenlight/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile

Re: [PATCH v2 2/3] golang/xenlight: Ensure comments aren't interpreted as docstrings

2024-04-19 Thread Nick Rosbrook
On Fri, Apr 19, 2024 at 10:00 AM George Dunlap wrote: > > Go has always interpreted a comment directly before a function as a > docstring, so having the C function prototypes which the golang method > is meant to wrap in the comment before was always a bit non-standard. > However, recent versions

Re: Detecting whether dom0 is in a VM

2024-04-19 Thread George Dunlap
On Fri, Jul 7, 2023 at 3:56 PM George Dunlap wrote: >> >>> Xen's public interface offers access to the featuresets known / found / >> >>> used by the hypervisor. See XEN_SYSCTL_get_cpu_featureset, accessible >> >>> via xc_get_cpu_featureset(). >> >>> >> >> >> >> Are any of these exposed in dom0

Re: [PATCH v2 1/3] tools/golang: When returning pointers, actually allocate structrues

2024-04-19 Thread Nick Rosbrook
On Fri, Apr 19, 2024 at 10:00 AM George Dunlap wrote: > > In a handful of cases, it was decided to return a pointer to a > structure rather than the plain structure itself, due to the size. > However, in these cases the structure was never allocated, leading to > a nil pointer exception when

Last posting date for Xen 4.19 is Apr 26, 2024

2024-04-19 Thread Oleksii
Hi all, The last posting date for Xen 4.19 is Apr 26, 2024. If you want your features to be included for the release, please make sure they are posted for the first time before Fri Apr 26, 2024. Have a good weekned! Best regards, Oleksii

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Jan Beulich
On 19.04.2024 12:50, Roger Pau Monné wrote: > On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: >> On 19.04.2024 12:02, Roger Pau Monne wrote: >>> Livepatch payloads containing symbols that belong to init sections can only >>> lead to page faults later on, as by the time the livepatch

Re: [PATCH v2 1/2] xen: introduce header file with section related symbols

2024-04-19 Thread Jan Beulich
On 19.04.2024 12:16, Andrew Cooper wrote: > On 19/04/2024 11:12 am, Jan Beulich wrote: >> On 19.04.2024 12:08, Andrew Cooper wrote: >>> On 19/04/2024 11:02 am, Roger Pau Monne wrote: Start by declaring the beginning and end of the init section. No functional change intended.

Re: [XEN PATCH v2] automation/eclair_analysis: substitute deprecated service STD.emptrecd

2024-04-19 Thread Jan Beulich
On 19.04.2024 15:01, Nicola Vetrini wrote: > On 2024-04-19 11:21, Jan Beulich wrote: >> On 19.04.2024 09:49, Nicola Vetrini wrote: >>> On 2024-04-19 09:35, Jan Beulich wrote: On 19.04.2024 09:16, Nicola Vetrini wrote: > The ECLAIR service STD.emptrecd is being deprecated; hence, as a

[PATCH v3] xen/riscv: check whether the assembler has Zbb extension support

2024-04-19 Thread Oleksii Kurochko
Update the argument of the as-insn for the Zbb case to verify that Zbb is supported not only by a compiler, but also by an assembler. Also, check-extenstion(ext_name, "insn") helper macro is introduced to check whether extension is supported by a compiler and an assembler. Signed-off-by: Oleksii

[PATCH v2 3/3] tools/golang: Run `go vet` as part of the build process

2024-04-19 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Nick Rosbrook CC: Anthony PERARD --- tools/golang/xenlight/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile index c5bb6b94a8..645e7b3a82 100644 --- a/tools/golang/xenlight/Makefile

[PATCH v2 1/3] tools/golang: When returning pointers, actually allocate structrues

2024-04-19 Thread George Dunlap
In a handful of cases, it was decided to return a pointer to a structure rather than the plain structure itself, due to the size. However, in these cases the structure was never allocated, leading to a nil pointer exception when calling the relevant `fromC` method. Allocate structures before

[PATCH v2 2/3] golang/xenlight: Ensure comments aren't interpreted as docstrings

2024-04-19 Thread George Dunlap
Go has always interpreted a comment directly before a function as a docstring, so having the C function prototypes which the golang method is meant to wrap in the comment before was always a bit non-standard. However, recent versions of `go fmt` now attempt to normalize these docstrings as well,

Re: [XEN PATCH v2] automation/eclair_analysis: substitute deprecated service STD.emptrecd

2024-04-19 Thread Nicola Vetrini
On 2024-04-19 11:21, Jan Beulich wrote: On 19.04.2024 09:49, Nicola Vetrini wrote: On 2024-04-19 09:35, Jan Beulich wrote: On 19.04.2024 09:16, Nicola Vetrini wrote: The ECLAIR service STD.emptrecd is being deprecated; hence, as a preventive measure, STD.anonstct is used here, which for Xen's

Re: [PATCH 1/3] tools/golang: When returning pointers, actually allocate structrues

2024-04-19 Thread Tobias Fitschen
Thank you for the fast response, George. I can confirm that I can call all three functions without errors now and this patch fixes the errors I encountered. Am 19. April 2024 12:50:35 MESZ schrieb George Dunlap : >In a handful of cases, it was decided to return a pointer to a >structure rather

Re: [PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking

2024-04-19 Thread Pavel Begunkov
On 4/19/24 12:08, Pavel Begunkov wrote: Please, don't take directly, conflicts with io_uring. When everyone is happy with the patches, Jens and Jakub will hopefully help to merge them. E.g. first staging net/ specific changes [1] and then handling all conflicts on the io_uring side. [1]

[PATCH io_uring-next/net-next v2 2/4] net: add callback for setting a ubuf_info to skb

2024-04-19 Thread Pavel Begunkov
At the moment an skb can only have one ubuf_info associated with it, which might be a performance problem for zerocopy sends in cases like TCP via io_uring. Add a callback for assigning ubuf_info to skb, this way we will implement smarter assignment later like linking ubuf_info together. Note,

[PATCH io_uring-next/net-next v2 4/4] io_uring/notif: implement notification stacking

2024-04-19 Thread Pavel Begunkov
The network stack allows only one ubuf_info per skb, and unlike MSG_ZEROCOPY, each io_uring zerocopy send will carry a separate ubuf_info. That means that send requests can't reuse a previosly allocated skb and need to get one more or more of new ones. That's fine for large sends, but otherwise it

[PATCH io_uring-next/net-next v2 0/4] implement io_uring notification (ubuf_info) stacking

2024-04-19 Thread Pavel Begunkov
Please, don't take directly, conflicts with io_uring. To have per request buffer notifications each zerocopy io_uring send request allocates a new ubuf_info. However, as an skb can carry only one uarg, it may force the stack to create many small skbs hurting performance in many ways. The

[PATCH io_uring-next/net-next v2 1/4] net: extend ubuf_info callback to ops structure

2024-04-19 Thread Pavel Begunkov
We'll need to associate additional callbacks with ubuf_info, introduce a structure holding ubuf_info callbacks. Apart from a more smarter io_uring notification management introduced in next patches, it can be used to generalise msg_zerocopy_put_abort() and also store ->sg_from_iter, which is

[PATCH io_uring-next/net-next v2 3/4] io_uring/notif: simplify io_notif_flush()

2024-04-19 Thread Pavel Begunkov
io_notif_flush() is partially duplicating io_tx_ubuf_complete(), so instead of duplicating it, make the flush call io_tx_ubuf_complete. Reviewed-by: Jens Axboe Signed-off-by: Pavel Begunkov --- io_uring/notif.c | 6 +++--- io_uring/notif.h | 9 +++-- 2 files changed, 6 insertions(+), 9

Re: [PATCH 2/3] golang/xenlight: Run `go fmt` on non-generated golang files

2024-04-19 Thread George Dunlap
On Fri, Apr 19, 2024 at 11:59 AM George Dunlap wrote: > > No functional change. > > Signed-off-by: George Dunlap > --- > CC: Nick Rosbrook > CC: Anthony PERARD > --- > tools/golang/xenlight/xenlight.go | 55 +-- > 1 file changed, 30 insertions(+), 25 deletions(-) >

[PATCH 2/3] golang/xenlight: Run `go fmt` on non-generated golang files

2024-04-19 Thread George Dunlap
No functional change. Signed-off-by: George Dunlap --- CC: Nick Rosbrook CC: Anthony PERARD --- tools/golang/xenlight/xenlight.go | 55 +-- 1 file changed, 30 insertions(+), 25 deletions(-) diff --git a/tools/golang/xenlight/xenlight.go

[PATCH 1/3] tools/golang: When returning pointers, actually allocate structrues

2024-04-19 Thread George Dunlap
In a handful of cases, it was decided to return a pointer to a structure rather than the plain structure itself, due to the size. However, in these cases the structure was never allocated, leading to a nil pointer exception when calling the relevant `fromC` method. Allocate structures before

[PATCH 3/3] tools/golang: Run `go vet` as part of the build process

2024-04-19 Thread George Dunlap
Signed-off-by: George Dunlap --- CC: Nick Rosbrook CC: Anthony PERARD --- tools/golang/xenlight/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile index c5bb6b94a8..645e7b3a82 100644 --- a/tools/golang/xenlight/Makefile

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 12:15:19PM +0200, Jan Beulich wrote: > On 19.04.2024 12:02, Roger Pau Monne wrote: > > Livepatch payloads containing symbols that belong to init sections can only > > lead to page faults later on, as by the time the livepatch is loaded init > > sections have already been

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 11:10:33AM +0100, Andrew Cooper wrote: > On 19/04/2024 11:02 am, Roger Pau Monne wrote: > > Livepatch payloads containing symbols that belong to init sections can only > > lead to page faults later on, as by the time the livepatch is loaded init > > sections have already

Re: [PATCH v2] xen/riscv: check whether the assembler has Zbb extension support

2024-04-19 Thread Oleksii
On Fri, 2024-04-19 at 12:26 +0200, Oleksii Kurochko wrote: > Update the argument of the as-insn for the Zbb case to verify that > Zbb is supported not only by a compiler, but also by an assembler. > > Also, check_extenstion(ext_name, "insn") helper macro is introduced > to check whether extension

[PATCH v2] xen/riscv: check whether the assembler has Zbb extension support

2024-04-19 Thread Oleksii Kurochko
Update the argument of the as-insn for the Zbb case to verify that Zbb is supported not only by a compiler, but also by an assembler. Also, check_extenstion(ext_name, "insn") helper macro is introduced to check whether extension is supported by a compiler and an assembler. Signed-off-by: Oleksii

Re: [XEN PATCH v1 01/15] x86: introduce AMD-V and Intel VT-x Kconfig options

2024-04-19 Thread Sergiy Kibrik
18.04.24 14:16, Jan Beulich: On 16.04.2024 08:20, Sergiy Kibrik wrote: From: Xenia Ragiadakou Introduce two new Kconfig options, SVM and VMX, to allow code specific to each virtualization technology to be separated and, when not required, stripped. CONFIG_SVM will be used to enable virtual

Re: [PATCH v2 1/2] xen: introduce header file with section related symbols

2024-04-19 Thread Andrew Cooper
On 19/04/2024 11:12 am, Jan Beulich wrote: > On 19.04.2024 12:08, Andrew Cooper wrote: >> On 19/04/2024 11:02 am, Roger Pau Monne wrote: >>> Start by declaring the beginning and end of the init section. >>> >>> No functional change intended. >>> >>> Requested-by: Andrew Cooper >>> Signed-off-by:

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Jan Beulich
On 19.04.2024 12:02, Roger Pau Monne wrote: > Livepatch payloads containing symbols that belong to init sections can only > lead to page faults later on, as by the time the livepatch is loaded init > sections have already been freed. > > Refuse to resolve such symbols and return an error instead.

Re: [PATCH v2 1/2] xen: introduce header file with section related symbols

2024-04-19 Thread Jan Beulich
On 19.04.2024 12:08, Andrew Cooper wrote: > On 19/04/2024 11:02 am, Roger Pau Monne wrote: >> Start by declaring the beginning and end of the init section. >> >> No functional change intended. >> >> Requested-by: Andrew Cooper >> Signed-off-by: Roger Pau Monné > > TYVM for doing this.  There's

Re: [PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Andrew Cooper
On 19/04/2024 11:02 am, Roger Pau Monne wrote: > Livepatch payloads containing symbols that belong to init sections can only > lead to page faults later on, as by the time the livepatch is loaded init > sections have already been freed. > > Refuse to resolve such symbols and return an error

Re: [PATCH v2 1/2] xen: introduce header file with section related symbols

2024-04-19 Thread Andrew Cooper
On 19/04/2024 11:02 am, Roger Pau Monne wrote: > Start by declaring the beginning and end of the init section. > > No functional change intended. > > Requested-by: Andrew Cooper > Signed-off-by: Roger Pau Monné TYVM for doing this.  There's a lot of cleanup which can follow on for it.

[PATCH v2 1/2] xen: introduce header file with section related symbols

2024-04-19 Thread Roger Pau Monne
Start by declaring the beginning and end of the init section. No functional change intended. Requested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- xen/arch/arm/mmu/setup.c | 3 +-- xen/arch/x86/setup.c | 3 +-- xen/include/xen/sections.h | 17 + 3 files

[PATCH v2 2/2] livepatch: refuse to resolve symbols that belong to init sections

2024-04-19 Thread Roger Pau Monne
Livepatch payloads containing symbols that belong to init sections can only lead to page faults later on, as by the time the livepatch is loaded init sections have already been freed. Refuse to resolve such symbols and return an error instead. Note such resolutions are only relevant for symbols

[PATCH v2 0/2] livepatch: make symbol resolution more robust

2024-04-19 Thread Roger Pau Monne
Hello, Previously a single patch, now with a pre-patch to place the init section markers into a common file. Thanks, Roger. Roger Pau Monne (2): xen: introduce header file with section related symbols livepatch: refuse to resolve symbols that belong to init sections

[xen-unstable-smoke test] 185738: tolerable all pass - PUSHED

2024-04-19 Thread osstest service owner
flight 185738 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185738/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[libvirt test] 185736: tolerable all pass - PUSHED

2024-04-19 Thread osstest service owner
flight 185736 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/185736/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185641 test-amd64-amd64-libvirt-xsm 15

Re: [PATCH 2/2] x86/video: do not assume a video mode to be unconditionally present

2024-04-19 Thread Jan Beulich
On 19.04.2024 09:42, Roger Pau Monné wrote: > On Tue, Apr 02, 2024 at 11:49:20AM +0200, Jan Beulich wrote: >> On 28.03.2024 16:35, Roger Pau Monne wrote: >>> There's no reason to assume VGA text mode 3 to be unconditionally available. >>> With the addition of booting Xen itself in PVH mode there's

Re: [XEN PATCH v2] automation/eclair_analysis: substitute deprecated service STD.emptrecd

2024-04-19 Thread Jan Beulich
On 19.04.2024 09:49, Nicola Vetrini wrote: > On 2024-04-19 09:35, Jan Beulich wrote: >> On 19.04.2024 09:16, Nicola Vetrini wrote: >>> The ECLAIR service STD.emptrecd is being deprecated; hence, as a >>> preventive >>> measure, STD.anonstct is used here, which for Xen's purposes has >>>

Re: [XEN PATCH v1 03/15] x86/monitor: guard altp2m usage

2024-04-19 Thread Sergiy Kibrik
18.04.24 14:31, Jan Beulich: On 16.04.2024 08:25, Sergiy Kibrik wrote: Use altp2m index only when it is supported by the platform, i.e. VMX. The puspose of that is the possiblity to disable VMX support and exclude its code from the build completely. I'm afraid this description doesn't make

Re: [OSSTEST PATCH 00/36] Switch to Debian Bookworm

2024-04-19 Thread Roger Pau Monné
On Fri, Apr 19, 2024 at 09:34:21AM +0100, Anthony PERARD wrote: > On Mon, Apr 08, 2024 at 10:29:08AM +0100, Anthony PERARD wrote: > > On Fri, Apr 05, 2024 at 04:54:30PM +0100, Anthony PERARD wrote: > > > On Thu, Mar 28, 2024 at 05:54:04PM +, Anthony PERARD wrote: > > > > On Mon, Mar 18, 2024

Re: [OSSTEST PATCH 00/36] Switch to Debian Bookworm

2024-04-19 Thread Anthony PERARD
On Mon, Apr 08, 2024 at 10:29:08AM +0100, Anthony PERARD wrote: > On Fri, Apr 05, 2024 at 04:54:30PM +0100, Anthony PERARD wrote: > > On Thu, Mar 28, 2024 at 05:54:04PM +, Anthony PERARD wrote: > > > On Mon, Mar 18, 2024 at 04:55:09PM +, Anthony PERARD wrote: > > > > I've now pushed > >

Re: [XEN PATCH v1 02/15] x86/hvm: guard AMD-V and Intel VT-x hvm_function_table initializers

2024-04-19 Thread Sergiy Kibrik
18.04.24 14:18, Jan Beulich: On 16.04.2024 08:22, Sergiy Kibrik wrote: --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -156,9 +156,9 @@ static int __init cf_check hvm_enable(void) { const struct hvm_function_table *fns = NULL; -if ( cpu_has_vmx ) +if (

Re: [XEN PATCH v2] automation/eclair_analysis: substitute deprecated service STD.emptrecd

2024-04-19 Thread Nicola Vetrini
On 2024-04-19 09:35, Jan Beulich wrote: On 19.04.2024 09:16, Nicola Vetrini wrote: The ECLAIR service STD.emptrecd is being deprecated; hence, as a preventive measure, STD.anonstct is used here, which for Xen's purposes has equivalent functionality. I'm sorry, but no, this still does not

Re: [PATCH 2/2] x86/video: do not assume a video mode to be unconditionally present

2024-04-19 Thread Roger Pau Monné
On Tue, Apr 02, 2024 at 11:49:20AM +0200, Jan Beulich wrote: > On 28.03.2024 16:35, Roger Pau Monne wrote: > > There's no reason to assume VGA text mode 3 to be unconditionally available. > > With the addition of booting Xen itself in PVH mode there's a boot path that > > explicitly short-circuits

Re: [XEN PATCH v2] automation/eclair_analysis: substitute deprecated service STD.emptrecd

2024-04-19 Thread Jan Beulich
On 19.04.2024 09:16, Nicola Vetrini wrote: > The ECLAIR service STD.emptrecd is being deprecated; hence, as a preventive > measure, STD.anonstct is used here, which for Xen's purposes has equivalent > functionality. I'm sorry, but no, this still does not clarify things enough. It is still

Re: [XEN PATCH v4] xen/domain: deviate MISRA C Rule 16.2 violation

2024-04-19 Thread Jan Beulich
On 19.04.2024 09:05, Nicola Vetrini wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -457,6 +457,7 @@ static int domain_teardown(struct domain *d) > > for_each_vcpu ( d, v ) > { > +/* SAF-5-safe MISRA C Rule 16.2: switch label enclosed by for >

Re: [PATCH 1/2] x86/video: add boot_video_info offset generation to asm-offsets

2024-04-19 Thread Roger Pau Monné
On Tue, Apr 02, 2024 at 11:43:49AM +0200, Jan Beulich wrote: > On 02.04.2024 11:38, Jan Beulich wrote: > > On 28.03.2024 16:35, Roger Pau Monne wrote: > >> Currently the offsets into the boot_video_info struct are manually encoded > >> in > >> video.S, which is fragile. Generate them in

[XEN PATCH v2] automation/eclair_analysis: substitute deprecated service STD.emptrecd

2024-04-19 Thread Nicola Vetrini
The ECLAIR service STD.emptrecd is being deprecated; hence, as a preventive measure, STD.anonstct is used here, which for Xen's purposes has equivalent functionality. This new service is already supported by the current version of ECLAIR. No functional change. Signed-off-by: Nicola Vetrini

[XEN PATCH v4] xen/domain: deviate MISRA C Rule 16.2 violation

2024-04-19 Thread Nicola Vetrini
MISRA C Rule 16.2 states: "A switch label shall only be used when the most closely-enclosing compound statement is the body of a switch statement". The PROGRESS_VCPU local helper specifies a case that is directly inside the compound statement of a for loop, hence violating the rule. To avoid

[xen-unstable test] 185731: tolerable FAIL - PUSHED

2024-04-19 Thread osstest service owner
flight 185731 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185731/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185712

Re: [PATCH] x86/PVH: Use unsigned int for dom0 e820 index

2024-04-19 Thread Jan Beulich
On 18.04.2024 18:07, Jason Andryuk wrote: > Switch to unsigned int for the dom0 e820 index. This eliminates the > potential for array underflows, and the compiler might be able to > generate better code. > > Requested-by: Jan Beulich > Signed-off-by: Jason Andryuk Acked-by: Jan Beulich

Re: [XEN PATCH v1 05/15] x86/p2m: move altp2m-related code to separate file

2024-04-19 Thread Sergiy Kibrik
18.04.24 14:36, Jan Beulich: On 16.04.2024 08:29, Sergiy Kibrik wrote: Move altp2m code from generic p2m.c file to altp2m.c, so that VMX-specific code is kept separately and can possibly be disabled in the build. The code movement is desirable, but the reasoning isn't quite right (see replies

Re: [PATCH v4 4/5] xen/memory, tools: Avoid hardcoding GUEST_MAGIC_BASE in init-dom0less

2024-04-19 Thread Henry Wang
Hi Jan, On 4/19/2024 2:18 PM, Jan Beulich wrote: On 19.04.2024 04:31, Henry Wang wrote: On 4/18/2024 8:54 PM, Jan Beulich wrote: On 09.04.2024 06:53, Henry Wang wrote: --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -21,6 +21,7 @@ #define XENMEM_increase_reservation

Re: [XEN PATCH] docs/misra: mark the gzip folder as adopted code

2024-04-19 Thread Jan Beulich
On 18.04.2024 20:33, Andrew Cooper wrote: > On 18/04/2024 8:39 am, Jan Beulich wrote: >> On 15.04.2024 17:44, Andrew Cooper wrote: >>> On 15/04/2024 10:56 am, Federico Serafini wrote: Mark the whole gzip folder as adopted code and remove the redundant deviation of file inflate.

Re: [PATCH v2 2/2] x86/spec: adjust logic to logic that elides lfence

2024-04-19 Thread Jan Beulich
On 18.04.2024 17:52, Roger Pau Monne wrote: > It's currently too restrictive by just checking whether there's a BHB clearing > sequence selected. It should instead check whether BHB clearing is used on > entry from PV or HVM specifically. > > Switch to use opt_bhb_entry_{pv,hvm} instead, and

Re: [PATCH v4 4/5] xen/memory, tools: Avoid hardcoding GUEST_MAGIC_BASE in init-dom0less

2024-04-19 Thread Jan Beulich
On 19.04.2024 04:31, Henry Wang wrote: > On 4/18/2024 8:54 PM, Jan Beulich wrote: >> On 09.04.2024 06:53, Henry Wang wrote: >>> --- a/xen/include/public/memory.h >>> +++ b/xen/include/public/memory.h >>> @@ -21,6 +21,7 @@ >>> #define XENMEM_increase_reservation 0 >>> #define

Re: [PATCH v4 1/5] xen/domctl, tools: Introduce a new domctl to get guest memory map

2024-04-19 Thread Jan Beulich
On 19.04.2024 04:27, Henry Wang wrote: > On 4/18/2024 8:37 PM, Jan Beulich wrote: >> On 09.04.2024 06:53, Henry Wang wrote: >>> --- a/xen/include/public/arch-arm.h >>> +++ b/xen/include/public/arch-arm.h >>> @@ -223,6 +223,13 @@ typedef uint64_t xen_pfn_t; >>>*/ >>> #define