[xen-unstable-smoke test] 185895: tolerable all pass - PUSHED

2024-05-01 Thread osstest service owner
flight 185895 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/185895/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm

[linux-linus test] 185893: regressions - FAIL

2024-05-01 Thread osstest service owner
flight 185893 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/185893/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-examine 8 reboot fail REGR. vs. 185870 Tests which are

Re: [PATCH v4 15/17] xen: mapcache: Remove assumption of RAMBlock with 0 offset

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > The current mapcache assumes that all memory is mapped > in a single RAM MR (the first one with offset 0). Remove > this assumption and propagate the offset to the mapcache > so it can do reverse mappings (from hostptr

Re: [PATCH v4 14/17] xen: Add xen_mr_is_memory()

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add xen_mr_is_memory() to abstract away tests for the > xen_memory MR. > > Signed-off-by: Edgar E. Iglesias There is an important change in this patch below > --- > hw/xen/xen-hvm-common.c | 8 +++- >

Re: [PATCH v4 13/17] softmmu: Pass RAM MemoryRegion and is_write xen_map_cache()

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Propagate MR and is_write to xen_map_cache(). > This is in preparation for adding support for grant mappings. > > No functional change. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > ---

Re: [PATCH v4 12/17] xen: mapcache: Unmap first entries in buckets

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > When invalidating memory ranges, if we happen to hit the first > entry in a bucket we were never unmapping it. This was harmless > for foreign mappings but now that we're looking to reuse the > mapcache for transient

Re: [PATCH v4 11/17] xen: mapcache: Make MCACHE_BUCKET_SHIFT runtime configurable

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Make MCACHE_BUCKET_SHIFT runtime configurable per cache instance. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > hw/xen/xen-mapcache.c | 52

Re: [PATCH v4 10/17] xen: mapcache: Break out xen_map_cache_init_single()

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Break out xen_map_cache_init_single() in preparation for > adding multiple map caches. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > hw/xen/xen-mapcache.c | 53

Re: [PATCH v4 09/17] xen: mapcache: Break out xen_invalidate_map_cache_single()

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Break out xen_invalidate_map_cache_single(). > > No functional changes. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- > hw/xen/xen-mapcache.c | 25 +++-- > 1

Re: [PATCH v4 08/17] xen: mapcache: Refactor xen_invalidate_map_cache_entry_unlocked

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add MapCache argument to xen_invalidate_map_cache_entry_unlocked. > This is in preparation for supporting multiple map caches. > > No functional changes. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano

Re: [PATCH v4 07/17] xen: mapcache: Refactor xen_replace_cache_entry_unlocked

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add MapCache argument to xen_replace_cache_entry_unlocked in > preparation for supporting multiple map caches. > > No functional change. > > Signed-off-by: Edgar E. Iglesias > --- > hw/xen/xen-mapcache.c | 8

Re: [PATCH v4 06/17] xen: mapcache: Break out xen_ram_addr_from_mapcache_single

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Break out xen_ram_addr_from_mapcache_single(), a multi-cache > aware version of xen_ram_addr_from_mapcache. > > No functional changes. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- >

Re: [PATCH v4 05/17] xen: mapcache: Refactor xen_remap_bucket for multi-instance

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add MapCache argument to xen_remap_bucket in preparation > to support multiple map caches. > > No functional changes. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- >

Re: [PATCH v4 04/17] xen: mapcache: Refactor xen_map_cache for multi-instance

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Make xen_map_cache take a MapCache as argument. This is in > prepaparation to support multiple map caches. > > No functional changes. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > --- >

Re: [PATCH v4 03/17] xen: mapcache: Refactor lock functions for multi-instance

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Make the lock functions take MapCache * as argument. This is > in preparation for supporting multiple caches. > > No functional changes. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini > ---

Re: [XEN PATCH] automation/eclair_enalysis: amend configuration for some MISRA rules

2024-05-01 Thread Stefano Stabellini
On Mon, 29 Apr 2024, Alessandro Zucchelli wrote: > Adjust ECLAIR configuration for rules: R21.14, R21.15, R21.16 by taking > into account mem* macros defined in the Xen sources as if they were > equivalent to the ones in Standard Library. > > Signed-off-by: Alessandro Zucchelli Reviewed-by:

Re: [XEN PATCH v2 1/3] drivers: char: address violation of MISRA C Rule 20.7

2024-05-01 Thread Stefano Stabellini
On Tue, 30 Apr 2024, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be

Re: [XEN PATCH 03/10] automation/eclair_analysis: deviate macro count_args_ for MISRA Rule 20.7

2024-05-01 Thread Stefano Stabellini
On Mon, 29 Apr 2024, Nicola Vetrini wrote: > On 2024-04-25 02:28, Stefano Stabellini wrote: > > On Tue, 23 Apr 2024, Nicola Vetrini wrote: > > > The count_args_ macro violates Rule 20.7, but it can't be made > > > compliant with Rule 20.7 without breaking its functionality. Since > > > it's very

Re: [XEN PATCH 3/3] automation/eclair: make explicit there are no adopted files by default

2024-05-01 Thread Stefano Stabellini
On Mon, 29 Apr 2024, Federico Serafini wrote: > Update ECLAIR configuration to consider no adopted files by default. > > Signed-off-by: Federico Serafini Acked-by: Stefano Stabellini > --- > automation/eclair_analysis/ECLAIR/analysis.ecl | 4 > 1 file changed, 4 insertions(+) > > diff

Re: [XEN PATCH 2/3] automation: do not allow failure for triggered analyses

2024-05-01 Thread Stefano Stabellini
On Mon, 29 Apr 2024, Federico Serafini wrote: > Do not allow_failure for triggered analyses: > introducing regressions of clean guidelines will cause a CI failure. > > Signed-off-by: Federico Serafini Acked-by: Stefano Stabellini > --- > automation/gitlab-ci/analyze.yaml | 1 - > 1 file

Re: [XEN PATCH 1/3] automation/eclair: tag Rule 7.2 as clean and temporarily remove Rules 1.1 and 8.2

2024-05-01 Thread Stefano Stabellini
On Mon, 29 Apr 2024, Federico Serafini wrote: > Update ECLAIR configuration to consider Rule 7.2 as clean. > > Temporarily remove the clean tag from Rules 1.1 and 8.2: > when violations of such rules will be addressed, the clean tag will be > reintroduced. > > Signed-off-by: Federico Serafini

[libvirt test] 185891: tolerable all pass - PUSHED

2024-05-01 Thread osstest service owner
flight 185891 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/185891/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185829 test-amd64-amd64-libvirt 15

[xen-unstable test] 185890: tolerable FAIL - PUSHED

2024-05-01 Thread osstest service owner
flight 185890 xen-unstable real [real] flight 185894 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185890/ http://logs.test-lab.xenproject.org/osstest/logs/185894/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking):

Re: [PATCH 6/6] xen/x86: Add topology generator

2024-05-01 Thread Alejandro Vallejo
On 26/03/2024 17:02, Jan Beulich wrote: > On 09.01.2024 16:38, Alejandro Vallejo wrote: >> --- a/tools/include/xenguest.h >> +++ b/tools/include/xenguest.h >> @@ -843,5 +843,20 @@ enum xc_static_cpu_featuremask { >> XC_FEATUREMASK_HVM_HAP_DEF, >> }; >> const uint32_t

Re: [PATCH v4 13/17] softmmu: Pass RAM MemoryRegion and is_write xen_map_cache()

2024-05-01 Thread Peter Xu
On Tue, Apr 30, 2024 at 06:49:35PM +0200, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Propagate MR and is_write to xen_map_cache(). > This is in preparation for adding support for grant mappings. > > No functional change. > > Signed-off-by: Edgar E. Iglesias Acked-by: Peter Xu

Re: [PATCH 5/6] xen/x86: Derive topologically correct x2APIC IDs from the policy

2024-05-01 Thread Alejandro Vallejo
Hi, On 26/03/2024 16:41, Jan Beulich wrote: > On 09.01.2024 16:38, Alejandro Vallejo wrote: >> --- a/xen/lib/x86/policy.c >> +++ b/xen/lib/x86/policy.c >> @@ -2,15 +2,78 @@ >> >> #include >> >> -uint32_t x86_x2apic_id_from_vcpu_id(const struct cpu_policy *p, uint32_t >> vcpu_id) >> +static

Re: [PATCH 5/6] xen/x86: Derive topologically correct x2APIC IDs from the policy

2024-05-01 Thread Alejandro Vallejo
Hi, Ack and sure to everything on types, constness and variable names. On 20/03/2024 10:15, Roger Pau Monné wrote: >> +const char *name; >> +uint32_t vcpu_id; >> +uint32_t x2apic_id; >> +struct cpu_policy policy; >> +} tests[] = { >> +{ >> +

Re: [PATCH 09/15] tools/libs/light: Modify dtbo to domU linux dtbo format

2024-05-01 Thread Anthony PERARD
On Wed, Apr 24, 2024 at 11:34:43AM +0800, Henry Wang wrote: > diff --git a/tools/libs/light/libxl_dt_overlay.c > b/tools/libs/light/libxl_dt_overlay.c > index cdb62b28cf..eaf11a0f9c 100644 > --- a/tools/libs/light/libxl_dt_overlay.c > +++ b/tools/libs/light/libxl_dt_overlay.c > @@ -41,6 +42,69 @@

Re: [PATCH 08/15] tools: Add domain_id and expert mode for overlay operations

2024-05-01 Thread Anthony PERARD
On Wed, Apr 24, 2024 at 11:34:42AM +0800, Henry Wang wrote: > From: Vikram Garhwal > > Add domain_id and expert mode for overlay assignment. This enables dynamic > programming of nodes during runtime. > > Take the opportunity to fix the name mismatch in the xl command, the > command name should

Re: [PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd

2024-05-01 Thread Andrew Cooper
On 01/05/2024 2:29 pm, Anthony PERARD wrote: > On Fri, Apr 26, 2024 at 09:51:47AM +0100, Anthony PERARD wrote: >> Run `systemd-notify --ready` instead. Hopefully, that will be enough. >> ($NOTIFY_SOCKET is a socket, and a bit more complicated that I though, >> it can start with "@" for example) >

Re: [PATCH 05/15] tools/libs/light: Increase nr_spi to 160

2024-05-01 Thread Anthony PERARD
On Wed, Apr 24, 2024 at 11:34:39AM +0800, Henry Wang wrote: > Increase number of spi to 160 i.e. gic_number_lines() for Xilinx ZynqMP - 32. > This was done to allocate and assign IRQs to a running domain. > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini > Signed-off-by:

Re: [PATCH 04/15] tools/libs/light: Always enable IOMMU

2024-05-01 Thread Anthony PERARD
On Wed, Apr 24, 2024 at 11:34:38AM +0800, Henry Wang wrote: > For overlay with iommu functionality to work with running VMs, we need > to enable IOMMU when iomem presents for the domains. > > Signed-off-by: Vikram Garhwal > Signed-off-by: Henry Wang > --- > tools/libs/light/libxl_arm.c | 6

Re: [PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd

2024-05-01 Thread Anthony PERARD
On Fri, Apr 26, 2024 at 09:51:47AM +0100, Anthony PERARD wrote: > Run `systemd-notify --ready` instead. Hopefully, that will be enough. > ($NOTIFY_SOCKET is a socket, and a bit more complicated that I though, > it can start with "@" for example) FTR: If it turns out that calling systemd-notify

[linux-linus test] 185888: regressions - FAIL

2024-05-01 Thread osstest service owner
flight 185888 linux-linus real [real] flight 185892 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185888/ http://logs.test-lab.xenproject.org/osstest/logs/185892/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-05-01 Thread George Dunlap
On Wed, May 1, 2024 at 11:39 AM Andrew Cooper wrote: > > On 01/05/2024 11:00 am, George Dunlap wrote: > > On Mon, Apr 29, 2024 at 4:16 PM Andrew Cooper > > wrote: > >> These will replace svm_feature_flags and the SVM_FEATURE_* constants over > >> the > >> next few changes. Take the

Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-05-01 Thread Andrew Cooper
On 01/05/2024 11:00 am, George Dunlap wrote: > On Mon, Apr 29, 2024 at 4:16 PM Andrew Cooper > wrote: >> These will replace svm_feature_flags and the SVM_FEATURE_* constants over the >> next few changes. Take the opportunity to rationalise some names. >> >> Drop the opencoded "inherit from

Re: [PATCH 2/5] x86/cpu-policy: Add SVM features already used by Xen

2024-05-01 Thread George Dunlap
On Mon, Apr 29, 2024 at 4:16 PM Andrew Cooper wrote: > > These will replace svm_feature_flags and the SVM_FEATURE_* constants over the > next few changes. Take the opportunity to rationalise some names. > > Drop the opencoded "inherit from host" logic in calculate_hvm_max_policy() and > use

Re: [PATCH 1/5] x86/cpu-policy: Infrastructure for the AMD SVM and SEV leaves

2024-05-01 Thread George Dunlap
On Tue, Apr 30, 2024 at 2:25 PM Andrew Cooper wrote: > > On 30/04/2024 1:45 pm, Jan Beulich wrote: > > On 29.04.2024 17:16, Andrew Cooper wrote: > >> Allocate two new feature leaves, and extend cpu_policy with the non-feature > >> fields too. > >> > >> The CPUID dependency between the SVM bit on

[xen-4.15-testing test] 185877: tolerable FAIL - PUSHED

2024-05-01 Thread osstest service owner
flight 185877 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/185877/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 185709

Re: [PATCH 2/2] xen/arm: Fix MISRA regression on R1.1, flexible array member not at the end

2024-05-01 Thread Luca Fancellu
Hi Jan, > On 30 Apr 2024, at 12:37, Jan Beulich wrote: > > On 30.04.2024 13:09, Luca Fancellu wrote: >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -64,18 +64,20 @@ struct membank { >> }; >> >> struct membanks { >> -unsigned int nr_banks; >> -

Re: [PATCH 1/2] xen/kernel.h: Import __struct_group from Linux

2024-05-01 Thread Luca Fancellu
Hi Jan, > On 30 Apr 2024, at 12:43, Jan Beulich wrote: > > On 30.04.2024 13:09, Luca Fancellu wrote: >> --- a/xen/include/xen/kernel.h >> +++ b/xen/include/xen/kernel.h >> @@ -54,6 +54,27 @@ >> typeof_field(type, member) *__mptr = (ptr); \ >> (type *)( (char