Re: [Xen-devel] Re: [XenPPC] [PATCH] [POWERPC] fix vga.c compilation

2006-08-16 Thread Alex Williamson
On Wed, 2006-08-16 at 15:24 +0100, Keir Fraser wrote: > Actually I'm not sure this is particularly necessary for headless x86 > either. I could move the test to the end of setup_vga(), and only probe > 0xb8000? Hi Keir, Yeah, I think something like the below change to your previous patch woul

Re: [Xen-devel] Re: [XenPPC] [PATCH] [POWERPC] fix vga.c compilation

2006-08-16 Thread Keir Fraser
On 16/8/06 2:59 pm, "Alex Williamson" <[EMAIL PROTECTED]> wrote: >In general this looks a lot better, but I think ia64 is still going > to have trouble with the chunk below. It seems that a VGA card > operating in a standard text mode doesn't necessarily respond to all of > these addresses

Re: [Xen-devel] Re: [XenPPC] [PATCH] [POWERPC] fix vga.c compilation

2006-08-16 Thread Alex Williamson
On Wed, 2006-08-16 at 11:49 +0100, Keir Fraser wrote: > Here you go. Arch/powerpc/vga.c isn't great but I assume it's > temporary > until vga support is fixed properly. > > If you think it looks okay I'll apply it. Also Sign-off or Ack if you > like. Hi Keir, In general this looks a lot bette

Re: [Xen-devel] Re: [XenPPC] [PATCH] [POWERPC] fix vga.c compilation

2006-08-16 Thread Keir Fraser
On 16/8/06 10:15 am, "Keir Fraser" <[EMAIL PROTECTED]> wrote: >> Looks like I bungled this whitespace; could you fix when you commit >> please? >> >> It would probably be best to combine this patch with the ia64 patch and >> put both our signed-off lines on it. (I'll sign off on Alex's changes,

Re: [XenPPC] [PATCH] [POWERPC] fix vga.c compilation

2006-08-16 Thread Keir Fraser
On 16/8/06 1:30 am, "Hollis Blanchard" <[EMAIL PROTECTED]> wrote: > Looks like I bungled this whitespace; could you fix when you commit > please? > > It would probably be best to combine this patch with the ia64 patch and > put both our signed-off lines on it. (I'll sign off on Alex's changes,

Re: [XenPPC] [PATCH] [POWERPC] fix vga.c compilation

2006-08-15 Thread Hollis Blanchard
On Tue, 2006-08-15 at 18:08 -0500, Hollis Blanchard wrote: > diff -r 6dcd85ea232e -r 2250d38aed38 xen/arch/powerpc/vga.c > --- /dev/null Thu Jan 01 00:00:00 1970 + > +++ b/xen/arch/powerpc/vga.cTue Aug 15 18:08:26 2006 -0500 ... > + > +#include > + > +int detect_vga(void) > +{ > +

[XenPPC] [PATCH] [POWERPC] fix vga.c compilation

2006-08-15 Thread Hollis Blanchard
# HG changeset patch # User Hollis Blanchard <[EMAIL PROTECTED]> # Date 1155683306 18000 # Node ID 2250d38aed3854c626bdc642a91884754f9d12d8 # Parent 6dcd85ea232e0de5445f325abd0829a0ed6d56a1 [POWERPC] fix vga.c compilation - replace vga_readb/writeb with plain readb/writeb - add per-arch vga.c and