RE: rtnet rt_igb I210 not working with ARM

2022-01-05 Thread Yann Le Chevoir via Xenomai
> > Hello, > > > > I have an issue with rt_igb not working with an Intel I210 on ARM (see > > system configuration below). > > With Wireshark, looks like rtping is sending garbage on the network > > (see below). > > I notice there is no interrupt in /proc/xenomai/irq (see below). > > Looks like oth

Re: [PATCH 0/7] y2038: cond_wait_prologue64 and related fixes

2022-01-05 Thread Jan Kiszka via Xenomai
On 05.01.22 16:08, Bezdeka, Florian (T CED SES-DE) wrote: > On Wed, 2022-01-05 at 15:58 +0100, Jan Kiszka wrote: >> On 05.01.22 15:56, Bezdeka, Florian (T CED SES-DE) wrote: >>> On Wed, 2022-01-05 at 15:43 +0100, Jan Kiszka wrote: On 05.01.22 15:06, Florian Bezdeka wrote: > Hi all, > >

Re: [PATCH 0/7] y2038: cond_wait_prologue64 and related fixes

2022-01-05 Thread Bezdeka, Florian via Xenomai
On Wed, 2022-01-05 at 15:58 +0100, Jan Kiszka wrote: > On 05.01.22 15:56, Bezdeka, Florian (T CED SES-DE) wrote: > > On Wed, 2022-01-05 at 15:43 +0100, Jan Kiszka wrote: > > > On 05.01.22 15:06, Florian Bezdeka wrote: > > > > Hi all, > > > > > > > > this is the last missing POSIX related y2038 aff

Re: [PATCH 0/7] y2038: cond_wait_prologue64 and related fixes

2022-01-05 Thread Jan Kiszka via Xenomai
On 05.01.22 15:56, Bezdeka, Florian (T CED SES-DE) wrote: > On Wed, 2022-01-05 at 15:43 +0100, Jan Kiszka wrote: >> On 05.01.22 15:06, Florian Bezdeka wrote: >>> Hi all, >>> >>> this is the last missing POSIX related y2038 affected syscall in >>> Xenomai. With this applied we have two Xenomai speci

Re: [PATCH 0/7] y2038: cond_wait_prologue64 and related fixes

2022-01-05 Thread Bezdeka, Florian via Xenomai
On Wed, 2022-01-05 at 15:43 +0100, Jan Kiszka wrote: > On 05.01.22 15:06, Florian Bezdeka wrote: > > Hi all, > > > > this is the last missing POSIX related y2038 affected syscall in > > Xenomai. With this applied we have two Xenomai specific syscalls > > missing: > > > > - sc_cobalt_thread_sets

Re: [PATCH 0/7] y2038: cond_wait_prologue64 and related fixes

2022-01-05 Thread Jan Kiszka via Xenomai
On 05.01.22 15:06, Florian Bezdeka wrote: > Hi all, > > this is the last missing POSIX related y2038 affected syscall in > Xenomai. With this applied we have two Xenomai specific syscalls > missing: > > - sc_cobalt_thread_setschedparam_ex > - sc_cobalt_thread_getschedparam_ex > > While addin

[PATCH 6/7] y2038: testsuite/smokey/y2038: Add a missing error handling path

2022-01-05 Thread Florian Bezdeka via Xenomai
Initialization of the mutex used for mutex_timedlock64 tests could fail. We have to abort the test in this case. Signed-off-by: Florian Bezdeka --- testsuite/smokey/y2038/syscall-tests.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testsuite/smokey/y2038/syscall-tests.c

[PATCH 2/7] cobalt: posix/cond: Add missing __user annotation to user provided ptr

2022-01-05 Thread Florian Bezdeka via Xenomai
Like all other pointers in the cond_wait_prologue interface the error pointer is user-provided and should be annotated accordingly. Signed-off-by: Florian Bezdeka --- kernel/cobalt/posix/cond.c | 8 kernel/cobalt/posix/cond.h | 8 kernel/cobalt/posix/syscall32.c | 4 +

[PATCH 3/7] y2038: lib/cobalt: Dispatch cond_wait_prologue

2022-01-05 Thread Florian Bezdeka via Xenomai
It libc reports time64_t support, cond_wait_prologue is now dispatched to the time64_t based syscall. Signed-off-by: Florian Bezdeka --- lib/cobalt/cond.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/lib/cobalt/cond.c b/lib/cobalt/cond.c index 1bf5c7

[PATCH 7/7] cobalt: Protect __xn_get_user() by access_ok()

2022-01-05 Thread Florian Bezdeka via Xenomai
According to the doctype provided by __get_user (which is used by the __xn_get_user() macro) each call should be protected by access_ok(). We missed such a protection at some places. Signed-off-by: Florian Bezdeka --- kernel/cobalt/posix/internal.h | 4 kernel/cobalt/posix/nsem.c | 3

[PATCH 5/7] y2038: testsuite/smokey/y2038: Adding tests for cond_wait_prologue64

2022-01-05 Thread Florian Bezdeka via Xenomai
Extending the smokey testsuite to do some tests for the recently added cond_wait_prologue64 syscall. Signed-off-by: Florian Bezdeka --- testsuite/smokey/y2038/syscall-tests.c | 97 ++ 1 file changed, 97 insertions(+) diff --git a/testsuite/smokey/y2038/syscall-tests.c b

[PATCH 4/7] cobalt: posix/cond: Add missing input validations

2022-01-05 Thread Florian Bezdeka via Xenomai
The following validation issues have been addressed: - __cobalt_cond_wait_prologue() missed validating the supplied pointers after the registry lookup which could fail. That triggered the kernel OOPS dumped below - The check removed from cobalt_cond_timedwait_prologue() is now alr

[PATCH 1/7] y2038: cobalt/posix/cond: Adding cond_wait_prologue64

2022-01-05 Thread Florian Bezdeka via Xenomai
Add a syscall specific for cond_wait_prologue64 with 64bit time_t. Signed-off-by: Florian Bezdeka --- include/cobalt/uapi/syscall.h | 1 + kernel/cobalt/posix/cond.c | 26 ++ kernel/cobalt/posix/cond.h | 13 + kernel/cobalt/posix/syscall3

[PATCH 0/7] y2038: cond_wait_prologue64 and related fixes

2022-01-05 Thread Florian Bezdeka via Xenomai
Hi all, this is the last missing POSIX related y2038 affected syscall in Xenomai. With this applied we have two Xenomai specific syscalls missing: - sc_cobalt_thread_setschedparam_ex - sc_cobalt_thread_getschedparam_ex While adding tests for the introduced cond_wait_prologue64 I hit a kernel