Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Philippe Gerum via Xenomai
Jan Kiszka writes: > On 15.03.21 10:47, Philippe Gerum wrote: >> >> Jan Kiszka writes: >> >>> On 15.03.21 10:00, Philippe Gerum wrote: Jan Kiszka writes: > On 14.03.21 18:14, Philippe Gerum wrote: >> >> Jan Kiszka via Xenomai writes: >> >>> From: Jan Kisz

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Jan Kiszka via Xenomai
On 15.03.21 10:47, Philippe Gerum wrote: > > Jan Kiszka writes: > >> On 15.03.21 10:00, Philippe Gerum wrote: >>> >>> Jan Kiszka writes: >>> On 14.03.21 18:14, Philippe Gerum wrote: > > Jan Kiszka via Xenomai writes: > >> From: Jan Kiszka >> >> This is only called

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Philippe Gerum via Xenomai
Philippe Gerum writes: > Jan Kiszka writes: > >> On 15.03.21 10:00, Philippe Gerum wrote: >>> >>> Jan Kiszka writes: >>> On 14.03.21 18:14, Philippe Gerum wrote: > > Jan Kiszka via Xenomai writes: > >> From: Jan Kiszka >> >> This is only called during early in

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Philippe Gerum via Xenomai
Jan Kiszka writes: > On 15.03.21 10:00, Philippe Gerum wrote: >> >> Jan Kiszka writes: >> >>> On 14.03.21 18:14, Philippe Gerum wrote: Jan Kiszka via Xenomai writes: > From: Jan Kiszka > > This is only called during early init, e.g. for switching alternatives. >>

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Philippe Gerum via Xenomai
Jan Kiszka writes: > On 15.03.21 10:00, Philippe Gerum wrote: >> >> Jan Kiszka writes: >> >>> On 14.03.21 18:14, Philippe Gerum wrote: Jan Kiszka via Xenomai writes: > From: Jan Kiszka > > This is only called during early init, e.g. for switching alternatives. >>

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Jan Kiszka via Xenomai
On 15.03.21 10:00, Philippe Gerum wrote: > > Jan Kiszka writes: > >> On 14.03.21 18:14, Philippe Gerum wrote: >>> >>> Jan Kiszka via Xenomai writes: >>> From: Jan Kiszka This is only called during early init, e.g. for switching alternatives. Still, switch_mm_irqs_off would

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Philippe Gerum via Xenomai
Jan Kiszka writes: > On 15.03.21 07:19, Jan Kiszka via Xenomai wrote: >> On 14.03.21 18:14, Philippe Gerum wrote: >>> >>> Jan Kiszka via Xenomai writes: >>> From: Jan Kiszka This is only called during early init, e.g. for switching alternatives. Still, switch_mm_irqs_off w

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Philippe Gerum via Xenomai
Jan Kiszka writes: > On 14.03.21 18:14, Philippe Gerum wrote: >> >> Jan Kiszka via Xenomai writes: >> >>> From: Jan Kiszka >>> >>> This is only called during early init, e.g. for switching alternatives. >>> Still, switch_mm_irqs_off would complain without this, and we are better >>> safe th

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-15 Thread Jan Kiszka via Xenomai
On 15.03.21 07:19, Jan Kiszka via Xenomai wrote: > On 14.03.21 18:14, Philippe Gerum wrote: >> >> Jan Kiszka via Xenomai writes: >> >>> From: Jan Kiszka >>> >>> This is only called during early init, e.g. for switching alternatives. >>> Still, switch_mm_irqs_off would complain without this, and w

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-14 Thread Jan Kiszka via Xenomai
On 14.03.21 18:14, Philippe Gerum wrote: > > Jan Kiszka via Xenomai writes: > >> From: Jan Kiszka >> >> This is only called during early init, e.g. for switching alternatives. >> Still, switch_mm_irqs_off would complain without this, and we are better >> safe than sorry. >> > > The way this is

Re: [PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-14 Thread Philippe Gerum via Xenomai
Jan Kiszka via Xenomai writes: > From: Jan Kiszka > > This is only called during early init, e.g. for switching alternatives. > Still, switch_mm_irqs_off would complain without this, and we are better > safe than sorry. > The way this is done in Dovetail is fragile too, since the protection w

[PATCH 5.4] x86: ipipe: Harden path between use_temporary_mm and unuse_temporary_mm

2021-03-14 Thread Jan Kiszka via Xenomai
From: Jan Kiszka This is only called during early init, e.g. for switching alternatives. Still, switch_mm_irqs_off would complain without this, and we are better safe than sorry. Signed-off-by: Jan Kiszka --- 4.19 is not affected. Dovetail solves this differently, via local_irq_save_full whic