Re: Fix for memory leak in StringReader

2001-08-08 Thread neilg
d to [EMAIL PROTECTED] Sent by: [EMAIL PROTECTED] To: [EMAIL PROTECTED] cc: Subject: Re: Fix for memory leak in StringReader [EMAIL PROTECTED] wrote: > Hi Jeremy, > > Just FYI, the best way to submit patches is as follows: > > - Run a cvs diff on each file you've changed; &

Re: Fix for memory leak in StringReader

2001-08-08 Thread Jeremy Carroll
[EMAIL PROTECTED] wrote: > Hi Jeremy, > > Just FYI, the best way to submit patches is as follows: > > - Run a cvs diff on each file you've changed; > - then submit each file *as an attachment* in a message to the list, > clearly indicating just what's being corrected. I attach a patch file for G

Re: Fix for memory leak in StringReader

2001-08-07 Thread neilg
001 03:47:20 PM Please respond to [EMAIL PROTECTED] To: [EMAIL PROTECTED] cc: Subject: Re: Fix for memory leak in StringReader Unsurprisingly, my test code still is satisfactory with Glenn's variant of the fix. Jeremy Glenn Marcy wrote: > > Jeremy, > > This part looks co

Re: Fix for memory leak in StringReader

2001-08-06 Thread Jeremy Carroll
Unsurprisingly, my test code still is satisfactory with Glenn's variant of the fix. Jeremy Glenn Marcy wrote: > > Jeremy, > > This part looks correct. My only suggestion to improve the change is to > split the cleanup responsibilities between the classes that define the > data members (and

Re: Fix for memory leak in StringReader

2001-08-05 Thread Glenn Marcy
TED] hp.com> cc: Subject: Fix for memory leak in StringReader 08/0

Fix for memory leak in StringReader

2001-08-03 Thread Jeremy Carroll
Snapshot: xml-xerces_20010803161801.tar.gz package org.apache.xerces.readers; file: StringReader.java Old code: lines 216 ==> 223 public XMLEntityHandler.EntityReader changeReaders() throws Exception { XMLEntityHandler.EntityReader nextReader = super.changeReaders(); s