Author: jannis
Date: 2007-02-14 12:17:05 +0000 (Wed, 14 Feb 2007)
New Revision: 24977
Modified:
libfrap/trunk/libfrap/menu/ChangeLog
libfrap/trunk/libfrap/menu/STATUS
libfrap/trunk/libfrap/menu/tests/test-display-root-menu.c
Log:
* STATUS: Menu spec test suite results added.
* tests/test-display-root-menu.c: Fix warning caused by copying
a string into a const gchar*.
Modified: libfrap/trunk/libfrap/menu/ChangeLog
===================================================================
--- libfrap/trunk/libfrap/menu/ChangeLog 2007-02-14 11:04:52 UTC (rev
24976)
+++ libfrap/trunk/libfrap/menu/ChangeLog 2007-02-14 12:17:05 UTC (rev
24977)
@@ -1,3 +1,9 @@
+2007-02-14 Janins Pohlmann <[EMAIL PROTECTED]>
+
+ * STATUS: Menu spec test suite results added.
+ * tests/test-display-root-menu.c: Fix warning caused by copying
+ a string into a const gchar*.
+
2007-02-14 Jannis Pohlmann <[EMAIL PROTECTED]>
* frap-menu-item-cache.h: Fix typo - it's
Modified: libfrap/trunk/libfrap/menu/STATUS
===================================================================
--- libfrap/trunk/libfrap/menu/STATUS 2007-02-14 11:04:52 UTC (rev 24976)
+++ libfrap/trunk/libfrap/menu/STATUS 2007-02-14 12:17:05 UTC (rev 24977)
@@ -1,14 +1,15 @@
XDG menu specificatiom implementation status
=======================================================================
- I. Menu file elements
- II. Filesystem monitoring
- III. UI interaction
+ I. Supported menu file elements
+ II. Test suite results
+ III. Filesystem monitoring
+ IV. UI interaction
-I. Menu file elements
-=====================
+I. Supported menu file elements
+===============================
[x] <Menu>
@@ -95,9 +96,68 @@
-II. Filesystem monitoring
-=========================
+II. Test suite results
+======================
+ The script tests/test-menu-spec makes it possible to test our
+ implementation with the freedesktop.org menu specification test suite:
+
+ http://webcvs.freedesktop.org/menus/menu-spec/tests/
+
+ Passed tests:
+
+ * All
+ * And
+ * AppDir-relative
+ * boolean-logic
+ * Category
+ * Deleted
+ * desktop-name-collision
+ * DesktopFileID
+ * DirectoryDir-relative
+ * Directory
+ * Exclude
+ * Filename
+ * menu-multiple-matching
+ * Merge-combined
+ * NoDisplay
+ * NoDisplay2
+ * NotOnlyUnallocated-default
+ * official-categories
+ * OnlyUnallocated
+ * Or
+ * submenu-collision
+
+ Failed tests:
+
+ * AppDir (test suite bug, missing result file)
+ * DefaultMergeDirs
+ * DirectoryDir (test suite bug, missing result file)
+ * LegacyDir-Move
+ * LegacyDir-relative
+ * MergeDir-absolute
+ * MergeDir-relative
+ * MergeFile2
+ * MergeFile3
+ * MergeFile-absolute
+ * MergeFile-parent
+ * MergeFile-path
+ * MergeFile-recursive
+ * MergeFile-relative
+ * Move-collapsing
+ * Move-ordering
+ * Move-submenu
+ * Move (unverified test suite bug)
+
+ A list of test suite bugs I found during testing can be found here:
+
+ http://lunar-linux.org/~jannis/menu-spec-testsuite.txt
+
+
+
+III. Filesystem monitoring
+==========================
+
With a proper GObject structure for all classes (XfceMenu,
XfceMenuDirectory, XfceMenuItem etc.) reloading objects independently
of each other should be no problem.
@@ -111,8 +171,8 @@
-III. UI interaction
-===================
+IV. UI interaction
+==================
Using GObject signals it should be easy to connect to menus and
menu items in order to update the related widgets.
Modified: libfrap/trunk/libfrap/menu/tests/test-display-root-menu.c
===================================================================
--- libfrap/trunk/libfrap/menu/tests/test-display-root-menu.c 2007-02-14
11:04:52 UTC (rev 24976)
+++ libfrap/trunk/libfrap/menu/tests/test-display-root-menu.c 2007-02-14
12:17:05 UTC (rev 24977)
@@ -71,6 +71,7 @@
GtkIconTheme *icon_theme = gtk_icon_theme_get_default ();
const gchar *icon_name = frap_menu_item_get_icon_name (item);
const gchar *item_name = frap_menu_item_get_name (item);
+ gchar new_icon_name[1024];
if (icon_name == NULL)
return NULL;
@@ -96,13 +97,10 @@
if (extension != NULL)
{
/* Remove extension */
- gchar *new_icon_name = g_utf8_strncpy (icon_name, basename,
g_utf8_strlen (basename, -1) - g_utf8_strlen (extension, -1));
+ g_utf8_strncpy (new_icon_name, basename, g_utf8_strlen
(basename, -1) - g_utf8_strlen (extension, -1));
/* Try to load the pixbuf using the new icon name */
pixbuf = gtk_icon_theme_load_icon (icon_theme, new_icon_name,
ICON_SIZE, GTK_ICON_LOOKUP_USE_BUILTIN, NULL);
-
- /* Free new icon name */
- g_free (new_icon_name);
}
/* Free basename */
_______________________________________________
Xfce4-commits mailing list
Xfce4-commits@xfce.org
http://foo-projects.org/mailman/listinfo/xfce4-commits
