[xmail] Re: SMTP after POP3 in 1.25 pre-22 (a clue) --> still not 100% OK in pre25

2007-11-20 Thread Gerrit E.G. Hobbelt
Davide Libenzi wrote: > Ok, you made me waste *A LOT* of time, for a totally wrong analysis, > probably linked with your own compiler of XMail code additions. > The pszSMTPError string is printed only after a failure of one of > SMTPCheckReturnPath() and SMTPCheckForwardPath(), and both these func

[xmail] Re: bug fix for xmail crash (core dump) when build in Win32 debug mode

2007-11-20 Thread Gerrit E.G. Hobbelt
Davide Libenzi wrote: > I think this (and many of the patches you sent) it is just *your* problems > with a broken compiler. The Standard define non-local non-initialized > object to be pre-initialized with zero. > Please do not post those kind of patches anymore. > MSVC2005 is indeed not 100%

[xmail] Re: shouldn't this piece of authentication code read like...?

2007-11-20 Thread Gerrit E.G. Hobbelt
Davide Libenzi wrote: > On Tue, 20 Nov 2007, Gerrit E.G. Hobbelt wrote: > > > Hi, > > > > While hunting down another issue (to be posted shortly), I ran into this > > one. Shouldn't the '&&' be replaced with a '||' for security

[xmail] Re: fix for xmail command line handling of -SI ip[:port], etc. OPTIONAL [:port] spec handling

2007-11-20 Thread Gerrit E.G. Hobbelt
Davide Libenzi wrote: > This has been fixed in another way. hint: when you find yourself doing too > much cut&paste, that's the time to start a new function. > Note that MAX_ACCEPT_ADDRESSES is 32 though, and I doubt anyone will > manually need to add more than 32 binds per protocol. > Aye! A

[xmail] Re: SMTP after POP3 in 1.25 pre-22 (a clue) --> still not 100% OK in pre25

2007-11-19 Thread Gerrit E.G. Hobbelt
Hi, There's still a bug lurking in the code, but now for a fault situation only fortunately, far as I can tell. How to reproduce: - use Outlook Express - create account - FORGET to check the checkmark 'Outgoing (SMTP) server requires authentication' - start XMAIL server and have SMTP-after-POP

[xmail] bug fix for memory leak when reporting certain errors

2007-11-19 Thread Gerrit E.G. Hobbelt
Minor memory leaks were detected when certain errors had been reported. Best regards, Ger PS: also in this fix: zeroed static data because MSVC2005 does NOT zero static data unless specifically instructed to do so (in analysis debug builds at least), leading to random data in these structs an

[xmail] fix for xmail command line handling of -SI ip[:port], etc. OPTIONAL [:port] spec handling

2007-11-19 Thread Gerrit E.G. Hobbelt
If you use -SI (-PI / -XI / -FI / -CI / -WI ) with the optional [:port] section included to specify a non-standard port for the interface address(es), you're SOL as the code calls the appropriate routine but does not extract the decoded port for further use, nor does it mix well with any atte

[xmail] shouldn't this piece of authentication code read like...?

2007-11-19 Thread Gerrit E.G. Hobbelt
Hi, While hunting down another issue (to be posted shortly), I ran into this one. Shouldn't the '&&' be replaced with a '||' for security reasons in error situations? Otherwise error situations in [ONLY] ONE of the calls (due to wrong setup or other gimmicks) would INCORRECTLY and UNDESIRABLY

[xmail] bug fix for xmail crash (core dump) when build in Win32 debug mode

2007-11-19 Thread Gerrit E.G. Hobbelt
Situation: - Win32 [release or] debug build (yep, I use MSVC2005 project files, NOT the makefile, but that does not make any real difference here) - link to the DLL version of the OpenSSL library (0.9.9 tested, will VERY probably happen with other versions too, as long as you use OpenSSL DLLs!)

[xmail] bug fix for spurious error: treating failure as OK situation incorrectly

2007-11-19 Thread Gerrit E.G. Hobbelt
When you've got that situation where those empty directories don't all exist (just like the documentation is warning you about), XMAIL will sometimes treat such a situation not as the severe error it should be, but instead ignores the failure. This has to do with the fact that the OS error is n

[xmail] Re: fixes some typos in the docs

2007-11-19 Thread Gerrit E.G. Hobbelt
Davide Libenzi wrote: > Thanks, applied. > > You're welcome ;-) There's a few more minor tidbits, which I'll be posting diffs for in the next few weeks (got to separate them out for easier processing). Cheers, Ger - To unsubscribe from this list: send the line "unsubscribe xmail" in the bod

[xmail] fixes some typos in the docs

2007-11-19 Thread Gerrit E.G. Hobbelt
Haven't checked the complete docs yet, so there may remain some minor typos. Anyway, I hope this is useful. Best regards, Ger Also no more warnings when running cvpod.pl *.cvpod in the docs dir. diff of the .pod files follows: --

[xmail] Re: SMTP after POP3 in 1.25 pre-22 (a clue)

2007-11-16 Thread Gerrit E.G. Hobbelt
Gerrit E.G. Hobbelt wrote: > See below for a copy, COMPLETE diff/patch is attached to this reply: > Since 7z attachments get stripped, here it is in literal uncompressed format: --- ../../1original/xmail/CTRLClient.cpp2007-11-02 01:34:32.0 +0100 +++ ./CTRLClient.cpp

[xmail] Re: files missing from the 1.25-preXX distros

2007-11-16 Thread Gerrit E.G. Hobbelt
Davide Libenzi wrote: > On Fri, 16 Nov 2007, Gerrit E.G. Hobbelt wrote: > > > Hi, > > > > at least the latest couple of preXX tar.gz distros were lacking these files: > > > > SSLSupport.cpp > > SSLSupport.h > > Main.cpp > > SysDep.cpp &

[xmail] Re: SMTP after POP3 in 1.25 pre-22 (a clue)

2007-11-16 Thread Gerrit E.G. Hobbelt
Francesco Vertova wrote: > At 18.24 16/11/07, you wrote: > > >Can you try the patch below? > > > > > >diff --git a/POP3Utils.cpp b/POP3Utils.cpp > >index 85ee92d..5b3111b 100644 > >--- a/POP3Utils.cpp > >+++ b/POP3Utils.cpp > >@@ -1542,10 +1542,10 @@ int UPopUserIpCheck(UserInfo *pUI, SYS_INET_ADDR

[xmail] files missing from the 1.25-preXX distros

2007-11-16 Thread Gerrit E.G. Hobbelt
Hi, at least the latest couple of preXX tar.gz distros were lacking these files: SSLSupport.cpp SSLSupport.h Main.cpp SysDep.cpp is this intentional and have I got my MSVC2005 projects wrong, or vice versa? Best regards, Ger - To unsubscribe from this list: send the line "unsubscribe xmail"

[xmail] Re: SMTP after POP3 in 1.25 pre-22 --> source code changes/fixes

2007-11-16 Thread Gerrit E.G. Hobbelt
Hi, As I am currently testing xmail for a custom setup over here, I ran into several issues, one of which was/is the SMTP-POP3 auth mechanism. Using 1.25-pre22 (downloaded from link presented on this ML earlier). Turns out that the code as is should've never worked; at it it won't ever on my sy