Re: [xml] Patch to fix ICU flush and pivot buffer

2017-10-25 Thread Joel Hockey
I've updated the patch using git format-patch. * reverted public interface xmlCharEncInFunc. It now calls xmlEncInputChunk with flush=1 on all calls as suggested. Always setting flush=TRUE here makes sense since this is a one-shot conversion of the entire buffer. * Moved the pivot buf reset to o

Re: [xml] Patch to fix ICU flush and pivot buffer

2017-10-25 Thread Nick Wellnhofer
On 25/10/2017 17:40, Markus Scherer wrote: On Wed, Oct 25, 2017 at 4:02 AM, Nick Wellnhofer The patch changes public function xmlCharEncInFunc but this function isn't used internally anymore (since commit a78d8036 from 2012). It might still be used in client code that wants to use lib

Re: [xml] Patch to fix ICU flush and pivot buffer

2017-10-25 Thread Nick Wellnhofer
On 25/10/2017 10:32, Joel Hockey wrote: This patch fixes those issues. Looks good. The patch changes public function xmlCharEncInFunc but this function isn't used internally anymore (since commit a78d8036 from 2012). It might still be used in client code that wants to use libxml2's character

[xml] Patch to fix ICU flush and pivot buffer

2017-10-25 Thread Joel Hockey
Hi, The chromium team have recently detected a fuzz-testing bug in libxml / ICU where UTF8 chars can be decoded incorrectly. See http://crbug.com/722420. The root cause of this problem is that libxml is calling ICU ucnv_convertEx with incorrect params. It is always setting flush to TRUE. This