Re: [xmlsec] Valgrind reports an invalid read that can lead to crash

2010-01-14 Thread Aleksey Sanin
Cool! Thanks for testing and letting me know! Aleksey On 1/14/2010 2:10 AM, Frank Gross wrote: Hi Aleksey, Sorry for the delay, but I had a lot of work. I applied your patch and it fixes my issue, and all my tests passed successfully too. Thanks, Frank Aleksey Sanin a écrit : Actually, nev

Re: [xmlsec] Valgrind reports an invalid read that can lead to crash

2010-01-14 Thread Frank Gross
Hi Aleksey, Sorry for the delay, but I had a lot of work. I applied your patch and it fixes my issue, and all my tests passed successfully too. Thanks, Frank Aleksey Sanin a écrit : Actually, never mind. I think I created a test case myself: multiple chained XPath transforms after somethi

Re: [xmlsec] Valgrind reports an invalid read that can lead to crash

2010-01-13 Thread Aleksey Sanin
Actually, never mind. I think I created a test case myself: multiple chained XPath transforms after something like xslt transform. Could you please test the following patch: http://git.gnome.org/browse/xmlsec/diff/src/nodeset.c?id=8ee4fbabcd651f01c6ec1b6aef70853f27db65a8 to make sure it fixes y

Re: [xmlsec] Valgrind reports an invalid read that can lead to crash

2010-01-12 Thread Aleksey Sanin
Hi Frank! Thanks for report and investigation! Do you have a repro test case that I can look at? Unfortunately, the ownership of the DOM nodes is not trivial and I can't say for sure if this is the right change or not. Thank you in advance, Aleksey On 1/6/2010 5:21 AM, Frank Gross wrote: Hi,

[xmlsec] Valgrind reports an invalid read that can lead to crash

2010-01-06 Thread Frank Gross
Hi, I had some random crashes using the xmlsec library for signature, so I did a test with valgrind that reported an invalid read (see attached valgrind output). You can see that it happens in the 'xmlXPathFreeNodeSet' function that is called in 'xmlSecNodeSetDestroy'. After some investiga