Re: Some cppcheck patches for xmms2-devel tree (fixes various resource leaks) v2

2010-01-15 Thread Thomas Frauendorfer
On Thu, Jan 14, 2010 at 9:12 PM, Sergei Trofimovich wrote: > On Thu, 14 Jan 2010 17:07:37 +0100 > Erik Massop wrote: > >> > Thomas Frauendorfer wrote: >> > > I mirrored the branch containing the patch in my repository as >> > > rfm-trofi-cleanups so that they show up on http://git.xmms.se/merge/

Re: Some cppcheck patches for xmms2-devel tree (fixes various resource leaks) v2

2010-01-14 Thread Sergei Trofimovich
On Thu, 14 Jan 2010 17:07:37 +0100 Erik Massop wrote: > > Thomas Frauendorfer wrote: > > > I mirrored the branch containing the patch in my repository as > > > rfm-trofi-cleanups so that they show up on http://git.xmms.se/merge/ > > Excellent, makes my life easier. But if you look there you see

Re: Some cppcheck patches for xmms2-devel tree (fixes various resource leaks) v2

2010-01-14 Thread Erik Massop
On Thu, 14 Jan 2010 10:42:57 +0100 Anders Waldenborg wrote: > Thomas Frauendorfer wrote: > > I mirrored the branch containing the patch in my repository as > > rfm-trofi-cleanups so that they show up on http://git.xmms.se/merge/ > > Excellent, makes my life easier. But if you look there you see

Re: Some cppcheck patches for xmms2-devel tree (fixes various resource leaks) v2

2010-01-14 Thread Anders Waldenborg
Thomas Frauendorfer wrote: I mirrored the branch containing the patch in my repository as rfm-trofi-cleanups so that they show up on http://git.xmms.se/merge/ Excellent, makes my life easier. But if you look there you see "UNKNOWN AUTHOR" on all and "BAD PREFIX" on one. anders -- _

Re: Some cppcheck patches for xmms2-devel tree (fixes various resource leaks) v2

2010-01-13 Thread Thomas Frauendorfer
On Wed, Jan 13, 2010 at 11:34 PM, Sergei Trofimovich wrote: > So, once again: > Whole set of patches is available at git repo: >    git://repo.or.cz/xmms2-devel/slyfox.git cppcheck_resleaks Hi, I had a look at those patches and they look good to me and I think they could be merged (But remember

Some cppcheck patches for xmms2-devel tree (fixes various resource leaks) v2

2010-01-13 Thread Sergei Trofimovich
On Tue, 12 Jan 2010 18:24:04 +0100 Tilman Sauerbeck wrote: > I think > OTHER: Fixed ReSIDBuilder object leak in error paths. > > would make for a more useful summary line. > Same for the other patches. Cleaned up all changelogs. > > val = g_new0 (xmms_stream_type_val_t, 1); > >

Re: Some cppcheck patches for xmms2-devel tree (fixes various resource leaks)

2010-01-12 Thread Tilman Sauerbeck
Sergei Trofimovich [2010-01-12 00:44]: Hi, > OTHED: sid: cppcheck: [./src/plugins/sid/sidplay_wrapper.cpp:184]: > (possible error) Memory leak: rs > > Fixed ReSIDBuilder object leak in error paths. > Thanks to cppcheck. I think OTHER: Fixed ReSIDBuilder object leak in error pat

Some cppcheck patches for xmms2-devel tree (fixes various resource leaks)

2010-01-11 Thread Sergei Trofimovich
Hi, xmms2-devel! Some days ago I've wandered on cppcheck[1] utility, decided to give it a try on some projects I use to use and it eventually found some real resource leaks! Fixing them is usually not so hard so it can be a good start in a new project. I hope I've properly fixed obvious ones (av