patch for plugins/pls/pls.c

2008-02-07 Thread Jim Eberle
I'm not sure if this is the patch format you guys are looking for. It's a 4 line change, based on code found in plugins/m3u/m3u.c. Cheers, Jim --- work/xmms2-0.2DrJekyll/src/plugins/pls/pls.c2007-05-20 15:55:40.0 + +++ /usr/home/jeberle/pls.c 2008-02-07 20:25:27.

Re: patch for plugins/pls/pls.c

2008-02-08 Thread Anders Waldenborg
Jim Eberle wrote: > I'm not sure if this is the patch format you guys are looking for. It's > a 4 line change, based on code found in plugins/m3u/m3u.c. Yeah, unified diff is the preferred format. Thanks for the patch.. but, what bug does the patch fix? anders --

Re: patch for plugins/pls/pls.c

2008-02-08 Thread Jim Eberle
> Jim Eberle wrote: >> I'm not sure if this is the patch format you guys are looking for. >> It's a 4 line change, based on code found in plugins/m3u/m3u.c. > > Yeah, unified diff is the preferred format. Thanks for the patch.. but, > what bug does the patch fix? > > anders > I didn't file a

Re: patch for plugins/pls/pls.c

2008-02-08 Thread Anders Waldenborg
Jim Eberle wrote: > I didn't file a bug on it, but here's the description. > > $ xmms2 addpls user.m3u > Playlist with 9 entries added > > $ xmms2 addpls user.pls > ERROR: End of file reached > > So, m3u files would load OK, but pls files would always fail. The problem was > the code used the s

Re: patch for plugins/pls/pls.c

2008-02-09 Thread Anders Waldenborg
Jim Eberle wrote: > $ xmms2 addpls user.pls > ERROR: End of file reached I can't reproduce this here.. Could you please provide that pls file? > I reran the diff using git diff, instead of my local diff program. I'm > guessing that is what you mean by a "universal diff". "unified diff", the one