Re: [PATCH] Update synaptics to XInput 7 ABI

2009-06-22 Thread Peter Hutterer
On Mon, Jun 22, 2009 at 01:56:07AM -0400, Ben Gamari wrote: On Fri, Jun 19, 2009 at 04:34:33PM +1000, Peter Hutterer wrote: On Fri, Jun 19, 2009 at 02:01:30AM -0400, Ben Gamari wrote: How about this one (obviously on top of fd939)? Looks good (once someone figures out the button

Re: [PATCH] Update synaptics to XInput 7 ABI

2009-06-21 Thread Ben Gamari
On Fri, Jun 19, 2009 at 04:34:33PM +1000, Peter Hutterer wrote: On Fri, Jun 19, 2009 at 02:01:30AM -0400, Ben Gamari wrote: How about this one (obviously on top of fd939)? Looks good (once someone figures out the button label situation). So getting the labels right is mostly candy now

Re: [PATCH] Update synaptics to XInput 7 ABI

2009-06-21 Thread Peter Hutterer
On Sun, Jun 21, 2009 at 03:38:15PM -0400, Ben Gamari wrote: On Fri, Jun 19, 2009 at 04:34:33PM +1000, Peter Hutterer wrote: On Fri, Jun 19, 2009 at 02:01:30AM -0400, Ben Gamari wrote: How about this one (obviously on top of fd939)? Looks good (once someone figures out the button

Re: [PATCH] Update synaptics to XInput 7 ABI

2009-06-21 Thread Ben Gamari
On Fri, Jun 19, 2009 at 04:34:33PM +1000, Peter Hutterer wrote: On Fri, Jun 19, 2009 at 02:01:30AM -0400, Ben Gamari wrote: How about this one (obviously on top of fd939)? Looks good (once someone figures out the button label situation). So getting the labels right is mostly candy now

Re: [PATCH] Update synaptics to XInput 7 ABI

2009-06-19 Thread Ben Gamari
On Thu, Jun 18, 2009 at 7:49 PM, Peter Huttererpeter.hutte...@who-t.net wrote: Thanks for the patch. A few comments though: On Thu, Jun 18, 2009 at 01:56:49AM -0400, Ben Gamari wrote: diff --git a/src/synaptics.c b/src/synaptics.c index ff66517..f917d8b 100644 --- a/src/synaptics.c +++

Re: [PATCH] Update synaptics to XInput 7 ABI

2009-06-19 Thread Peter Hutterer
On Fri, Jun 19, 2009 at 02:01:30AM -0400, Ben Gamari wrote: How about this one (obviously on top of fd939)? Looks good (once someone figures out the button label situation). buttons 1,2,3 are always LMR, simply because we're in a transition phase where even if our device only had one

Re: [PATCH] Update synaptics to XInput 7 ABI

2009-06-18 Thread Peter Hutterer
Thanks for the patch. A few comments though: On Thu, Jun 18, 2009 at 01:56:49AM -0400, Ben Gamari wrote: diff --git a/src/synaptics.c b/src/synaptics.c index ff66517..f917d8b 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -69,6 +69,11 @@ #include xf86Xinput.h #include exevents.h

[PATCH] Update synaptics to XInput 7 ABI

2009-06-17 Thread Ben Gamari
--- src/synaptics.c | 51 ++- 1 files changed, 46 insertions(+), 5 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index ff66517..f917d8b 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -69,6 +69,11 @@ #include xf86Xinput.h