[PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-07 Thread Peter Hutterer
After copying the master event, flip the detail field to the mapped button of the SD, not the physical button. This way if the SD has a mapping 1:3 and the MD has a mapping of 3:4, a press on button 1 on the SD results in a core event on button 4. X.Org Bug 19282

Re: [PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-07 Thread Thomas Jaeger
Alexia: What is the point of remapping buttons willy-nilly before posting an event anyway? The comment suggests it just servers as a reminder of how remapping works. It's problematic in that proper DeviceMappingNotify events aren't send and I don't want to think about what could potentially happe

Re: [PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-08 Thread Peter Hutterer
On Thu, Jan 08, 2009 at 01:43:39AM -0500, Thomas Jaeger wrote: > Alexia: What is the point of remapping buttons willy-nilly before > posting an event anyway? The comment suggests it just servers as a > reminder of how remapping works. It's problematic in that proper > DeviceMappingNotify events a

Re: [PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-08 Thread Thomas Jaeger
Alexia Death wrote: > On Thu, Jan 8, 2009 at 8:43 AM, Thomas Jaeger wrote: > >> Alexia: What is the point of remapping buttons willy-nilly before >> posting an event anyway? The comment suggests it just servers as a >> reminder of how remapping works. It's problematic in that proper >> DeviceMa

Re: [PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-08 Thread Thomas Jaeger
Peter Hutterer wrote: > On Thu, Jan 08, 2009 at 01:43:39AM -0500, Thomas Jaeger wrote: >> Alexia: What is the point of remapping buttons willy-nilly before >> posting an event anyway? The comment suggests it just servers as a >> reminder of how remapping works. It's problematic in that proper >>

Re: [PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-08 Thread Peter Hutterer
On Thu, Jan 08, 2009 at 11:19:15AM -0500, Thomas Jaeger wrote: > Peter Hutterer wrote: > > On Thu, Jan 08, 2009 at 01:43:39AM -0500, Thomas Jaeger wrote: > >> Alexia: What is the point of remapping buttons willy-nilly before > >> posting an event anyway? The comment suggests it just servers as a >

Re: [PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-09 Thread Thomas Jaeger
> that's not good. I think there's historical reason to do so, but by now the > drivers should just let button mapping to the DIX (unless they need something > really special). xsetwacom would be better off using libXi's > XSetDeviceButtonMapping. I've got a problem now, though. Apparently some w

Re: [PATCH] mi: ensure chained button mappings from SD -> MD (#19282)

2009-01-11 Thread Peter Hutterer
On Fri, Jan 09, 2009 at 02:13:34PM -0500, Thomas Jaeger wrote: > > that's not good. I think there's historical reason to do so, but by now the > > drivers should just let button mapping to the DIX (unless they need > > something > > really special). xsetwacom would be better off using libXi's > >