Re: [PATCH] xprop: Add colored icon support

2009-11-12 Thread Thomas Dickey
On Thu, 12 Nov 2009, Andy Spencer wrote: * Supports both 16 and 265 color terminals * 8 color output supports ascii and utf8 brightness Signed-off-by: Andy Spencer andy753...@gmail.com --- I'm not sure how to test for 16 and 256 color so I left them set to 0. The proper way is to check

Re: [PATCH] xprop: Add colored icon support

2009-11-12 Thread Andy Spencer
* Supports both 16 and 265 color terminals * 16 color output supports ascii and utf8 brightness Signed-off-by: Andy Spencer andy753...@gmail.com --- Here's an updated patch that uses setupterm and tigetnum, it also adds a check for curses and term.h in configure.ac.. When I test it in xterm, it

Re: [PATCH] xprop: Add colored icon support

2009-11-12 Thread Thomas Dickey
On Thu, 12 Nov 2009, Andy Spencer wrote: * Supports both 16 and 265 color terminals * 16 color output supports ascii and utf8 brightness Signed-off-by: Andy Spencer andy753...@gmail.com --- Here's an updated patch that uses setupterm and tigetnum, it also adds a check for curses and

[PATCH] xprop: Add colored icon support

2009-11-11 Thread Andy Spencer
* Supports both 16 and 265 color terminals * 8 color output supports ascii and utf8 brightness Signed-off-by: Andy Spencer andy753...@gmail.com --- I'm not sure how to test for 16 and 256 color so I left them set to 0. If someone can point out the proper way to do this I'll update it. I also

Re: [PATCH] xprop: Add colored icon support

2009-11-11 Thread Alan Coopersmith
[Patches usually go to xorg-devel@, not xorg@, for review/submission.] The greybeard in me wants to suggest that hardcoding the escape codes is wrong and that termcap/terminfo should be used instead to find the right ones for $TERM, but the realist in me wonders if there are any $TERM values in