Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-17 Thread Dan Nicholson
On Tue, Dec 16, 2008 at 11:28 PM, Daniel Stone wrote: > On Tue, Dec 16, 2008 at 11:04:15PM -0800, Dan Nicholson wrote: >> The other reason I had in mind was to tie into the keymap cache patch >> I sent. Smarter default means better chance you can reuse the cached >> map. And I definitely agree tha

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Daniel Stone
On Tue, Dec 16, 2008 at 11:04:15PM -0800, Dan Nicholson wrote: > The other reason I had in mind was to tie into the keymap cache patch > I sent. Smarter default means better chance you can reuse the cached > map. And I definitely agree that the the XkbSetRulesDflts API is not > exactly the way you'

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Dan Nicholson
On Tue, Dec 16, 2008 at 10:25 PM, Peter Hutterer wrote: > On Wed, Dec 17, 2008 at 05:17:19PM +1100, Daniel Stone wrote: >> On Tue, Dec 16, 2008 at 09:17:13PM -0800, Keith Packard wrote: >> > On Wed, 2008-12-17 at 07:52 +1000, Peter Hutterer wrote: >> > > XkbSetRulesDflts only sets some internal de

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Peter Hutterer
On Wed, Dec 17, 2008 at 05:17:19PM +1100, Daniel Stone wrote: > On Tue, Dec 16, 2008 at 09:17:13PM -0800, Keith Packard wrote: > > On Wed, 2008-12-17 at 07:52 +1000, Peter Hutterer wrote: > > > XkbSetRulesDflts only sets some internal defaults but doesn't actually use > > > them much. XkbInitKeyboa

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Daniel Stone
On Tue, Dec 16, 2008 at 09:17:13PM -0800, Keith Packard wrote: > On Wed, 2008-12-17 at 07:52 +1000, Peter Hutterer wrote: > > XkbSetRulesDflts only sets some internal defaults but doesn't actually use > > them much. XkbInitKeyboardDeviceStruct then calls XkbGetRulesDftls which > > returns either th

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Keith Packard
On Wed, 2008-12-17 at 07:52 +1000, Peter Hutterer wrote: > XkbSetRulesDflts only sets some internal defaults but doesn't actually use > them much. XkbInitKeyboardDeviceStruct then calls XkbGetRulesDftls which > returns either the ones set by the DDX, or the defaults. A DDX that doesn't > have set

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Dan Nicholson
On Tue, Dec 16, 2008 at 1:52 PM, Peter Hutterer wrote: > On Tue, Dec 16, 2008 at 12:05:17PM -0800, Dan Nicholson wrote: > >> diff --git a/xkb/xkbInit.c b/xkb/xkbInit.c >> index 3935f40..6d45d74 100644 >> --- a/xkb/xkbInit.c >> +++ b/xkb/xkbInit.c >> @@ -87,19 +87,19 @@ typedef struct _SrvXkmI

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Peter Hutterer
On Tue, Dec 16, 2008 at 12:05:17PM -0800, Dan Nicholson wrote: > On Tue, Dec 16, 2008 at 11:50 AM, Keith Packard wrote: > > This patch removes the default rules setting from DIX and adds it to the > > xfree86 DDX. What happens with other X servers if I apply this patch? XkbSetRulesDflts only sets

Re: Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Dan Nicholson
On Tue, Dec 16, 2008 at 11:50 AM, Keith Packard wrote: > This patch removes the default rules setting from DIX and adds it to the > xfree86 DDX. What happens with other X servers if I apply this patch? I'm pretty sure they fall back to the builtin defaults in xkb/xkbInit.c. They are defined in th

Let the DDX decide on the XkbRulesDefaults.

2008-12-16 Thread Keith Packard
This patch removes the default rules setting from DIX and adds it to the xfree86 DDX. What happens with other X servers if I apply this patch? -- keith.pack...@intel.com signature.asc Description: This is a digitally signed message part ___ xorg mailin