[PATCH REVISED] xkb: Support NoLock and NoUnlock for LockControls

The XKB protocol specification demands support for these flags. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c index 382cf7e..21955b6 100644

[PATCH REVISED] xkb: Fix ISOLock

will affect the locked modifiers. - Support for NoLock and NoUnlock was missing. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 159 --- 1 file changed, 117 insertions(+), 42 deletions(-) diff --git a/xkb/xkbActions.c b

[PATCH] xkbcomp Fix missing support for affect and incorrect modifier handling for ISOLock

Add missing support for affect flag to selectively affect locking or unlocking for for modifier locking, control locking, and ISOLock. Fix some incorrect masking and modifier handling for ISOLock. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- action.c | 52

[PATCH] libxkbfile: Fix mistyped argument of sizeof

A pointer rather than the buffer was given to sizeof. As the data to be written is only one or two bytes, a pointer size is at least four bytes, and the buffer has 32 bytes, this error did not have negative effects. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- src/xkbtext.c | 6

[PATCH] libxkbfile: Add missing support for NoLock and NoUnlock flags

The LockMods, ISOLock and LockControls support an affect flag to selectively enable and disable locking and unlocking for these actions. This change adds output of these flags. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- src/xkbtext.c | 48

[PATCH] libxkbfile: Add support for genKeyEvent flag

ActionMessage has an optional flag genKeyEvent. This change makes sure this flag is printed when it is set. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- src/xkbtext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xkbtext.c b/src/xkbtext.c index 4905f8b..013cdef 100644

[PATCH] xkb: Add missing support for NoLock and NoUnlock flag output

The LockMods, ISOLock and LockControls support an affect flag to selectively enable and disable locking and unlocking for these actions. This change adds output of these flags. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbtext.c | 48

[PATCH] xkb: Add support for genKeyEvent flag output

ActionMessage has an optional flag genKeyEvent. This change makes sure this flag is printed when it is set. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbtext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xkb/xkbtext.c b/xkb/xkbtext.c index 5d5f842..41e82ce 100644

[PATCH] xkb: Suppress autorepeat for Set and Lock of Mods, Groups, and Controls

completely is not ideal for users that have a usual layout besides Neo, where LSGT carries symbols. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c index 1443498..da2e242

[PATCH] xkb: Support NoLock and NoUnlock for LockControls

The XKB protocol specification demands support for these flags. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c index 89360df..84190df 100644

[PATCH] xkb: Keyboard mouse button emulation should not suppress other keyboard events

With this change, when a key mapped to an action to emulate mouse button presses and releases is held down, other keys pressed during that time are still processed normally. This is a prerequisite for proper support of ISOLock. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb

[PATCH] xkb: Fix ISOLock

will affect the locked modifiers. - Support for NoLock and NoUnlock was missing. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 154 --- 1 file changed, 112 insertions(+), 42 deletions(-) diff --git a/xkb/xkbActions.c b

[PATCH 2/3] libxkbfile: Add a few missing flags the output of the xkb layout

. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- src/xkbtext.c | 56 +++- 1 file changed, 51 insertions(+), 5 deletions(-) diff --git a/src/xkbtext.c b/src/xkbtext.c index b5d4750..d80c7a3 100644 --- a/src/xkbtext.c +++ b/src

[PATCH 3/3] xkbcomp: Add missing flag support and correct modifier handling of ISOLock

Add missing support for affect flag to selectively affect locking or unlocking for for modifier locking, control locking, and ISOLock. Fix some incorrect masking and modifier handling for ISOLock. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- action.c | 102

[PATCH 1/3] xkb: Several fixes to ISOLock and a few related changes.

in connection with ISOLock. Also note that the code did not properly check whether a key is released, so autorepeat handling was incorrect anyway. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 177 --- xkb/xkbtext.c

[PATCH] xkb: Fixes to LatchMods/LatchGroup

. The practical relevance of latches on higher levels is once more given by the revised German standard layout. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 175 +-- 1 file changed, 91 insertions(+), 84 deletions

[PATCH] xkb: Fix repeat behaviour of redirect and message actions

, the effective key repeat rate was halved. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 145 ++- 1 file changed, 89 insertions(+), 56 deletions(-) diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c index 8cd5f5c..f19505d

Re: [REMINDER] LockMods can lock another group on key release #865

Hello Daniel, On 20 November 2012 06:06, Andreas Wettstein wettstein...@solnet.ch wrote: Saturday last week, I sent a four-part xkb-related patch to address issue #865. The patch has not been reviewed yet. Can someone have a look please? I've been hoping to review this but haven't

Re: [PATCH] xkb: Do not use base group as an array index.

is there some sort of test-case that triggers this issue reliable? I found it when I tried: key FK07 { type= ONE_LEVEL, symbols[Group1]= [ NoSymbol ], actions[Group1]= [ LatchGroup(group=-1, clearLocks) ] }; and then hit F7. Using SetGroup(group=-1) should work

[PATCH] xkb: Do not use base group as an array index.

The base group is not brought into range and, therefore, using it as an array index crashed the X server. Also, at this place, we should ignore locked groups, but not latched groups. Therefore, use sum of base and latched groups, brought into range. Signed-off-by: Andreas Wettstein wettstein

[REMINDER] LockMods can lock another group on key release #865

Dear developers, Saturday last week, I sent a four-part xkb-related patch to address issue #865. The patch has not been reviewed yet. Can someone have a look please? I also notice that no part of the patch went into patchwork, which I thought would happen automatically. Actually, nothing went

[PATCH 2/4] kbproto: LockMods can lock another group on key release #865

Add the information to perform group actions to 'XkbModAction'. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- XKBstr.h | 3 +++ 1 Datei geändert, 3 Zeilen hinzugefügt(+) diff --git a/XKBstr.h b/XKBstr.h index e519e65..2390ae0 100644 --- a/XKBstr.h +++ b/XKBstr.h @@ -117,6 +117,9

[PATCH 1/4] xkb: LockMods can lock another group on key release #865

, a group lock as specified by these two bytes is performed. Otherwise, 'LockMods' operates according to the XKB protocol specification. If the two bytes are zero, which is the case by default, also no group change happens, so 'LockMods' operates according to the specification. Signed-off-by: Andreas

[PATCH 3/4] xkbcomp: Support 'noLock'/'noUnlock' flags and group locks in LockMods #865, #27903

-by: Andreas Wettstein wettstein...@solnet.ch --- action.c | 88 ++-- 1 Datei geändert, 53 Zeilen hinzugefügt(+), 35 Zeilen entfernt(-) diff --git a/action.c b/action.c index 3b82e64..99ec32c 100644 --- a/action.c +++ b/action.c @@ -436,33

[PATCH xserver] XKB: Redirect actions defunct with Gtk3 (XInput?)

seriously, Gtk3 does not receive state changes redirect actions might specify. This is because event_set_state in dix/inpututils.c accesses the prev_state field, but the changes for the redirect action are only put into the state field. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch

[REMINDER libX11] XIM: Allow modifier releases in compose sequences (#26705)

About a month ago I submitted a patch for the compose mechanism. It has not been reviewed yet. The patch is here: http://patchwork.freedesktop.org/patch/7884/ Andreas ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH xserver] xkb: Message actions suppress other key presses #28575

When a key to which a message action is mapped is held down, presses of other keys were not registered. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c index

xcb/util-keysym: Recognise ISO_Level5-keysyms as modifiers in xcb_is_modifier_key #39177

In August, I submitted a patch for xcb-bug #39177. It has been reviewed, but has not been applied. http://patchwork.freedesktop.org/patch/6622/ Can someone have look? Thanks, Andreas ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH libX11] XIM: Allow modifier releases in compose sequences (#26705)

in convenient reach for touch typing. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- modules/im/ximcp/imLcFlt.c | 52 +++ 1 files changed, 42 insertions(+), 10 deletions(-) diff --git a/modules/im/ximcp/imLcFlt.c b/modules/im/ximcp/imLcFlt.c

[PATCH] Recognise ISO_Level5-keysyms as modifiers in xcb_is_modifier_key #39177

xcb_is_modifier_key did not regecognise ISO_Level5_Shift, ISO_Level5_Latch, and ISO_Level5_Lock as modifiers. See bug 39177, https://bugs.freedesktop.org/show_bug.cgi?id=39177 Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- keysyms/keysyms.c |2 +- 1 files changed, 1 insertions

[PATCH] Recognise ISO_Level5-keysyms as modifiers in IsModifierKey #21910.

IsModifierKey macro did not regecognise ISO_Level5_Shift, ISO_Level5_Latch, and ISO_Level5_Lock as modifiers. See bug 21910, https://bugs.freedesktop.org/show_bug.cgi?id=21910 Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- include/X11/Xutil.h |2 +- 1 files changed, 1

Request: (XIM) Compose sequences using modifier key releases

Dear all, I would like to use modifiers keys (such as Control_L or Shift_R) as dead keys in compose sequences. Currently, only non-modifiers can be part of a compose sequence, and they are matched against the defined compose sequences at the time the key is pressed. I want to extend this to