against it?
I thought someone else had reviewed it and Chris was going to push it,
since he has direct push access to the X.Org repos. I don't usually
track patches from other X.Org developers who can push things themselves.
[ Anyone know the new email-address of Chase Douglas? ]
I'm
On Fri, Nov 9, 2012 at 11:43 AM, Aaron Westendorf aa...@agoragames.comwrote:
---
src/eventcomm.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/src/eventcomm.c b/src/eventcomm.c
index b1d5460..09e8a50 100644
--- a/src/eventcomm.c
+++
for the delay in reviewing these. Ubuntu developer summit and time
off got in the way...
All the patches in this series look reasonable to me.
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http
of the internals of X :(. While I can't make
out exactly how this works immediately, it looks like a proper solution all
around.
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives
the
server's\n
+ error messages when starting.;
+throw std::runtime_error(ss.str());
+ }
}
void xorg::testing::Test::TearDown() {
This should be very helpful for newbies :).
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel
+ XIGrabButton, XIUngrabButton, XIGrabKeycode, XIUngrabKeycode,
XIGrabTouchBegin, XIUngrabTouchBegin - grab/ungrab buttons or keys
SYNOPSIS
Looks right.
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel@lists.x.org: X.Org
(args.begin(), --leak-check=full);
+}
While this looks totally cool, it probably belongs in a separate commit :).
Without this hunk:
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
You can also add my Reviewed-by tag to a separate commit for just this
hunk. You might want to consider
::ScopedFakeTestPartResultReporter::INTERCEPT_ALL_THREADS, \
+ gtest_failures);\
+ if (::testing::internal::AlwaysTrue()) { statement; }\
+}\
+ } while (::testing::internal::AlwaysFalse())
+
+#endif // GTEST_INCLUDE_GTEST_GTEST_SPI_H_
Works for me.
Reviewed-by: Chase Douglas
On Thu, Oct 25, 2012 at 4:11 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
If set, XServer will ignore Terminate() and Kill() requests, and will not
die if the parent process dies. This enables a user to hook up gdb to a
server, wait for the test case to trigger some code in the server and
second
is a real failure :). I'm ok with this change, it just seems like it
shouldn't take that long...
For the series:
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives
On Mon, Oct 22, 2012 at 7:02 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
-logfile and -config are auto-filled for the default setup. A test that
needs no config file or the default log file must be able to unset those
defaults.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
I particularly like this XIO error throwing patch :).
For the series:
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
Everything here looks good :). For the series:
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
(Sorry for the delay getting to these patch reviews :( ).
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
On Tue, Oct 9, 2012 at 10:14 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
test/process-test.cpp | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/test/process-test.cpp b/test/process-test.cpp
:
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
,
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Sun, Oct 7, 2012 at 6:55 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
loops and usleeps are nice and simple, but have a tendency to overrun the
actual timeouts given. Use the actual time instead.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/process.cpp | 19
false;
+}
d_-pid = -1;
}
d_-state = TERMINATED;
- return wait_success;
+ return true;
}
bool xorg::testing::Process::Terminate(unsigned int timeout) {
This fix looks good.
For this and the following two related patches:
Reviewed-by: Chase Douglas chase.doug
-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On Sat, Sep 29, 2012 at 4:00 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On 30/09/12 04:25 , Chase Douglas wrote:
On Thu, Sep 27, 2012 at 11:34 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Fri, Sep 07, 2012 at 06:30:23PM +0100, Daniel Stone wrote:
Given the following
On Thu, Sep 27, 2012 at 2:12 PM, Adam Jackson a...@redhat.com wrote:
All this does is make it so editing configure.ac or Makefile.am doesn't
rebuild the makefiles. Which is just stupid.
Signed-off-by: Adam Jackson a...@redhat.com
---
configure.ac | 1 -
1 file changed, 1 deletion(-)
(keybd, oldWin, grab-window, NotifyGrab);
+if (oldWin)
+DoFocusEvents(keybd, oldWin, grab-window, NotifyGrab);
if (syncEvents.playingEvents)
grabinfo-grabTime = syncEvents.time;
else
Looks reasonably correct to me.
Reviewed-by: Chase Douglas chase.doug
as it would be a duplicate selection).
Fix this by performing the appropriate lookup for virtual devices.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Cc: Peter Hutterer peter.hutte...@who-t.net
Cc: Chase Douglas chase.doug...@ubuntu.com
---
Xi/xiselectev.c |9 +++--
1 file
solution
to this yet.
Cheers,
Peter
These all look good to me. I was initially trying to not overburden
the system with polling, but this isn't code that will be run in
production. There is no point in wasting development time when
computers are happy to poll quite often :).
Reviewed-by: Chase
;
+dev-transform.m[2][2] = 1.0;
XIChangeDeviceProperty(dev, XIGetKnownProperty(XI_PROP_TRANSFORM),
XIGetKnownProperty(XATOM_FLOAT), 32,
Makes sense to me.
Reviewed-by: Chase Douglas chase.doug...@ubuntu.com
___
xorg
)
*/
VMMouseClient_RequestAbsolute();
mPriv-absoluteRequested = TRUE;
- xf86Msg(X_INFO, VMWARE(0): vmmouse enable absolute mode\n);
+ LogMessageVerbSigSafe(X_INFO, 1, VMWARE(0): vmmouse enable absolute
mode\n);
}
/*
Looks right :).
Reviewed-by: Chase
Hi all,
I just wanted to note that my email address that I use for X development
purposes is changing:
Old: chase.doug...@canonical.com
New: chase.doug...@ubuntu.com
I won't have access to my old account after today, so please don't send any
email there :).
Thanks!
-- Chase
the appropriate lookup for virtual devices.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Cc: Peter Hutterer peter.hutte...@who-t.net
Cc: Chase Douglas chase.doug...@ubuntu.com
---
Xi/xiselectev.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Xi/xiselectev.c b
! Our first sigsafe log fix submission by someone other than Peter
and I :). Let me reach into my bag of prizes
Oooh look! I pulled out a brand spanking new tag!
Reviewed-by: Chase Douglas chase.doug...@canonical.com
This tag has an MSRP of $760,000! Enjoy! Please do spend it all in one
:
std::strerror(errno) \n;
return false;
} else
Fair enough :).
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
] == SLOTSTATE_CLOSE) {
Bool found = FALSE;
Ugh, I thought we caught all of these...
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info
On 08/29/2012 09:13 PM, Peter Hutterer wrote:
On Wed, Aug 29, 2012 at 04:22:33PM -0700, Chase Douglas wrote:
On 08/29/2012 03:36 PM, Peter Hutterer wrote:
On Wed, Aug 29, 2012 at 01:14:35PM -0700, Chase Douglas wrote:
On 08/28/2012 03:57 AM, Peter Hutterer wrote:
One of the things I've spent
On 08/28/2012 11:14 PM, Peter Hutterer wrote:
No functional changes, we'll re-use this though.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/device.cpp | 38 +++---
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/src/device.cpp
On 08/28/2012 11:14 PM, Peter Hutterer wrote:
uinput can be too slow, leaving us with GuessDeviceNode() failing and an
empty device string. Use inotify to tell us when a /dev/input/event device
appeared and then continue. However, even when inotify tells us the device
is there, the EVIOCGNAME
On 08/28/2012 03:57 AM, Peter Hutterer wrote:
One of the things I've spent quite a bit of time on over the last weeks
is a test suite. Chase tried to get some integration tests into the X
server repo a while ago but I think a standalone repo is best (for now
anyway).
I've pushed the current set
GuessDeviceNode() still has it's place.
Interesting... I've never had such issues myself.
For patches 1, 2, 4, and 5, which I have no replied to specifically:
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
On 08/29/2012 03:36 PM, Peter Hutterer wrote:
On Wed, Aug 29, 2012 at 01:14:35PM -0700, Chase Douglas wrote:
On 08/28/2012 03:57 AM, Peter Hutterer wrote:
One of the things I've spent quite a bit of time on over the last weeks
is a test suite. Chase tried to get some integration tests
On 08/29/2012 03:29 PM, Peter Hutterer wrote:
On Wed, Aug 29, 2012 at 01:07:31PM -0700, Chase Douglas wrote:
On 08/28/2012 11:14 PM, Peter Hutterer wrote:
No functional changes, we'll re-use this though.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/device.cpp | 38
On 08/29/2012 03:25 PM, Peter Hutterer wrote:
On Wed, Aug 29, 2012 at 01:09:32PM -0700, Chase Douglas wrote:
On 08/28/2012 11:14 PM, Peter Hutterer wrote:
uinput can be too slow, leaving us with GuessDeviceNode() failing and an
empty device string. Use inotify to tell us when a /dev/input
unpacked somewhere.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On 08/16/2012 04:53 PM, Peter Hutterer wrote:
On Thu, Aug 16, 2012 at 08:47:15AM -0700, Chase Douglas wrote:
On 08/15/2012 11:36 PM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
test/Makefile.am | 6 -
test/xserver-test.cpp | 62
logging.
This also adds more linebreaks to the message.
CC: Chase Douglas chase.doug...@canonical.com
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
os/log.c | 39 +--
1 file changed, 25 insertions(+), 14 deletions(-)
diff --git a/os/log.c b/os
On 08/14/2012 04:20 PM, Peter Hutterer wrote:
On Tue, Aug 14, 2012 at 10:19:00AM -0700, Chase Douglas wrote:
On 08/13/2012 06:16 PM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
include/xorg/gtest/xorg-gtest-process.h | 6 --
1 file changed, 4
());
+ if (args) {
+char *arg;
+do {
+ arg = va_arg(args, char*);
+ if (arg)
+argv.push_back(std::string(arg));
+} while (arg);
+ }
Start(program, argv);
}
Thanks for fixing this up :).
Reviewed-by: Chase Douglas chase.doug...@canonical.com
)
+usleep(100);
+
+}
+ASSERT_EQ(kill(child_pid, 0), -1);
+ASSERT_EQ(errno, ESRCH);
+ }
+}
+
int main(int argc, char *argv[]) {
testing::InitGoogleTest(argc, argv);
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg
.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
* of this software and associated documentation files (the Software), to
deal
For this and all the other patches I haven't replied specifically:
Reviewed-by: Chase Douglas chase.doug...@canonical.com
Thanks!
___
xorg-devel@lists.x.org: X.Org development
and given
that we had signal unsafe logging for years without too much fallout, we'll
probably be fine for those drivers.
Everything looks reasonable and correct to me. For the series:
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel
On 08/13/2012 06:20 PM, Peter Hutterer wrote:
Add a set of basic states to Process to allow callers to keep track of which
state a process is in (as seen from the library). This simplifies code that
needs to happen on certain conditions only, e.g. log file cleanup is only
needed if the process
On 08/13/2012 04:12 PM, Peter Hutterer wrote:
On Mon, Aug 13, 2012 at 09:32:00AM -0700, Chase Douglas wrote:
On 08/09/2012 10:38 PM, Peter Hutterer wrote:
Simple unlink() call to the logfile in use. The log file is only removed if
the server was started and terminated successfully
released it.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
And pushed as commit 4b8f4dd2b2be2bb036f75403ef4cef31d280f70b.
Thanks!
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org
On 08/09/2012 10:38 PM, Peter Hutterer wrote:
Add a set of basic states to Process to allow callers to keep track of which
state a process is in (as seen from the library). This simplifies code that
needs to happen on certain conditions only, e.g. log file cleanup is only
needed if the process
On 08/09/2012 10:38 PM, Peter Hutterer wrote:
Simple unlink() call to the logfile in use. The log file is only removed if
the server was started and terminated successfully. If it was never started
or the startup failed for some reason, this function does nothing.
Signed-off-by: Peter Hutterer
::string xorg::testing::XServer::GetLogFilePath() {
+ return d_-options[-logfile];
+}
+
+const std::string xorg::testing::XServer::GetConfigPath() {
+ return d_-options[-config];
+}
Fine by me.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
And pushed
) {
SetDisplayNumber(d_-display_number);
}
+xorg::testing::XServer::~XServer() {
+ if (Pid() 0)
+if (!Terminate(3000))
+ Kill(300);
+}
+
void xorg::testing::XServer::SetDisplayNumber(unsigned int display_number) {
d_-display_number = display_number;
Makes sense.
Reviewed-by: Chase Douglas
to uTouch-Evemu recording file.
+ * @param [in] path Path to evemu recording file.
*
* @throws std::runtime_error if playback failed for any reason.
*/
Thanks for catching these!
Reviewed-by: Chase Douglas chase.doug...@canonical.com
And pushed
On 08/06/2012 05:33 PM, Peter Hutterer wrote:
On Mon, Aug 06, 2012 at 09:59:29AM -0700, Chase Douglas wrote:
On 07/29/2012 06:05 PM, Peter Hutterer wrote:
Expanding this macro fails on some machines (RHEL6). It expands to
if test condition; then
fi
Empty statements are invalid.
Signed-off
. That no
longer is the case. Good catch :).
Reviewed-by: Chase Douglas chase.doug...@canonical.com
Pushed as commit 9d2dd4e86e4903eb1c20f6e936c7ca2df1cdb90f.
Thanks!
-- Chase
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
this may be a bit fragile. However, it's merely intended
to be used for diagnostics, I presume, so I'm ok with it.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
Pushed as commit 89d366ba5b8ad1023ded09e79d1fe093f20860eb.
Thanks!
-- Chase
= @inputdir@
@DRIVER_NAME@_drv_la_SOURCES = @DRIVER_NAME@.c \
Looks right.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org
,
I assume this caused a bug somehow? Please detail for the curious :).
Either way, the reasoning is sound.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg
On 07/29/2012 06:05 PM, Peter Hutterer wrote:
Expanding this macro fails on some machines (RHEL6). It expands to
if test condition; then
fi
Empty statements are invalid.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
aclocal/xorg-gtest.m4 |2 +-
1 file changed, 1
= MotionNotify;
buttons = 0;
Sounds correct to me.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
)) {
+ XI_HierarchyChanged, timeout)) {
XEvent event;
if (XNextEvent(display, event) != Success)
throw std::runtime_error(Failed to get X event);
Heh, sly little bug.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
And pushed as commit
been deprecated in favor of CamelCase
* A few various API additions
Chase Douglas (10):
Ensure xorg-gtest implementation is included in xorg-gtest{-all,
_main}.cpp
Upgrade dox/Doxyfile
Bump xorg-gtest.m4 serial number
Fix doxygen run so it works with out-of-tree builds
to do it right this minute.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
;
if (XNextEvent(display, event) != Success)
throw std::runtime_error(Failed to get X event);
Ahh, nuts... Right after I released it...
Reviewed-by: Chase Douglas chase.doug...@canonical.com
I'll let it sit for a bit before releasing a point release in case we
find any other nuggets.
Thanks
On 07/25/2012 10:53 AM, Chase Douglas wrote:
On 07/24/2012 06:26 PM, Peter Hutterer wrote:
Allows for attaching gdb to a server without messing around too much in the
test code.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
README |5 +
src/xserver.cpp |6
It's not installed and likely no one uses it.
Signed-off-by: Chase Douglas chase.doug...@canonical.com
---
doc/Doxyfile.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/Doxyfile.in b/doc/Doxyfile.in
index 357d429..cea27ce 100644
--- a/doc/Doxyfile.in
+++ b/doc
thing to do is
to remove the man page generation and installation.
Signed-off-by: Chase Douglas chase.doug...@canonical.com
---
doc/Doxyfile.in |2 +-
doc/Makefile.am |4
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/doc/Doxyfile.in b/doc/Doxyfile.in
index cea27ce
Caught by 'make distcheck'.
Signed-off-by: Chase Douglas chase.doug...@canonical.com
---
doc/Makefile.am |3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/Makefile.am b/doc/Makefile.am
index 7f8..9c52e84 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -34,6 +34,9 @@ install
+= .old;
log_test.open(old_log_file.c_str(), std::ofstream::out);
log_test.close();
Pretty obvious :).
Reviewed-by: Chase Douglas chase.doug...@canonical.com
I'll merge this in tomorrow, and then make a release.
Thanks!
___
xorg-devel
.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On 07/12/2012 11:33 PM, Peter Hutterer wrote:
The new xserver class is the main change here, but this set also
includes the Evemu::PlayOne() patch. Which has already turned out to be
really useful.
They're all reviewed except the Terminate/Kill patch (which has seen some
updates for the
On 07/11/2012 11:26 PM, Peter Hutterer wrote:
On Mon, Jul 09, 2012 at 05:13:15PM -0700, Chase Douglas wrote:
When a touch begin is pointer emulated, the initial motion and button
press events should not have the first button set in the button mask.
The button mask represents the state
On 07/11/2012 11:34 PM, Peter Hutterer wrote:
On Mon, Jul 09, 2012 at 05:12:44PM -0700, Chase Douglas wrote:
When a touch begin is pointer emulated, do not include touch state when
calculating the button state for the initial motion and button press
events. This change ensures the logical state
good!
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
::testing::XServer::WaitForDevice(::Display
*display, const std::string
return false;
}
+
+void xorg::testing::XServer::SetOption(std::string key, std::string value) {
+ d_-options[key] = value;
+}
With the above fixes:
Reviewed-by: Chase Douglas chase.doug...@canonical.com
::runtime_error(Unable to open connection to dummy X server);
+}
+
void xorg::testing::XServer::SetOption(std::string key, std::string value) {
d_-options[key] = value;
}
Looks good to me!
Reviewed-by: Chase Douglas chase.doug...@canonical.com
);
+}
+
void xorg::testing::XServer::SetOption(std::string key, std::string value) {
d_-options[key] = value;
}
With the fixes:
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http
;
std::mapstd::string, std::string::iterator it;
Looks good to me!
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
On 07/10/2012 08:28 PM, Peter Hutterer wrote:
Rename to TerminateAndCheck/KillAndCheck to signal that we're waiting for
the process to shut down instead of just sending the respective signals
I realized that perhaps we really should compose the functionalities
rather than combine them into
On 07/10/2012 08:28 PM, Peter Hutterer wrote:
Keep those in the server only, not the environment. And only override the
build-in ones when they've been set by main.
I'm a little confused by this patch. When I read Keep those in the
server only, not the environment, I expect that the members
server ... killing now ...
std::endl;
+ * if (!server.Kill())
+ * std::cerr Problem killing server std::endl;
+ * }
+ * @endcode
*/
class XServer : public xorg::testing::Process {
public:
Looks good to me :).
Reviewed-by: Chase Douglas chase.doug...@canonical.com
());
+
+ Start(program, argv);
+}
+
void xorg::testing::Process::Start(const std::string program, ...) {
va_list list;
va_start(list, program);
Works for me :).
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org
);
}
+const char* xorg::testing::evemu::Device::GetDeviceNode(void) {
+ return d_-device_node.length() 0 ? d_-device_node.c_str() : NULL;
+}
+
xorg::testing::evemu::Device::~Device() {
close(d_-fd);
evemu_delete(d_-device);
With the fixes:
Reviewed-by: Chase Douglas chase.doug
to use this for :).
It's probably in one of your new tests that I've yet to review.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org
this on.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
);
}
+const char* xorg::testing::evemu::Device::GetDeviceNode(void) {
+ return d_-device_node.length() 0 ? d_-device_node.c_str() : NULL;
+}
+
xorg::testing::evemu::Device::~Device() {
close(d_-fd);
evemu_delete(d_-device);
With the fixes:
Reviewed-by: Chase Douglas chase.doug
On 07/11/2012 03:16 PM, Peter Hutterer wrote:
On Wed, Jul 11, 2012 at 11:35:47AM -0700, Chase Douglas wrote:
On 07/10/2012 08:28 PM, Peter Hutterer wrote:
This class is a Process, so it's a drop-in replacement for the current
Environment, but it provides a few methods to talk to the server
On 07/11/2012 04:07 PM, Peter Hutterer wrote:
On Wed, Jul 11, 2012 at 11:57:50AM -0700, Chase Douglas wrote:
On 07/10/2012 08:28 PM, Peter Hutterer wrote:
Changes from hardcoded vararg call to requiring the caller to set up options
for logfile, config, etc. beforehand. The display string
On 07/11/2012 04:26 PM, Peter Hutterer wrote:
On Wed, Jul 11, 2012 at 12:24:18PM -0700, Chase Douglas wrote:
On 07/10/2012 08:28 PM, Peter Hutterer wrote:
Keep those in the server only, not the environment. And only override the
build-in ones when they've been set by main.
I'm a little
On 07/11/2012 06:12 PM, Peter Hutterer wrote:
On Wed, Jul 11, 2012 at 05:47:23PM -0700, Chase Douglas wrote:
On 07/11/2012 04:26 PM, Peter Hutterer wrote:
On Wed, Jul 11, 2012 at 12:24:18PM -0700, Chase Douglas wrote:
On 07/10/2012 08:28 PM, Peter Hutterer wrote:
Keep those in the server
)
{
if (setenv(name.c_str(), value.c_str(), overwrite) != 0)
Looks good :).
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org
:).
I think in the future we might end up exposing WaitForExit(). It's a
handy method if you are actually expecting a process to exit. We can
cross that bridge when we get there, though.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
include/xorg/gtest/xorg-gtest-process.h | 27
::GetDeviceNode(void) {
return d_-device_node;
}
Looks good!
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
On 07/08/2012 06:50 PM, Peter Hutterer wrote:
On Fri, Jul 06, 2012 at 11:08:13AM -0700, Chase Douglas wrote:
On 07/05/2012 05:50 PM, Peter Hutterer wrote:
On Thu, Jul 05, 2012 at 02:09:13PM -0700, Chase Douglas wrote:
On 07/03/2012 10:42 PM, Peter Hutterer wrote:
On Tue, Jul 03, 2012 at 10
)
i = 0;
for (axis = ABS_X; i MAX_VALUATORS axis = ABS_MAX; axis++) {
+#ifdef MULTITOUCH
int j;
+#endif
int mapping;
pEvdev-axis_map[axis] = -1;
if (!EvdevBitIsSet(pEvdev-abs_bitmask, axis) ||
Looks fine to me.
Reviewed-by: Chase Douglas chase.doug
On 07/09/2012 04:26 PM, Peter Hutterer wrote:
On Mon, Jul 09, 2012 at 10:19:50AM -0700, Chase Douglas wrote:
On 07/08/2012 06:50 PM, Peter Hutterer wrote:
On Fri, Jul 06, 2012 at 11:08:13AM -0700, Chase Douglas wrote:
On 07/05/2012 05:50 PM, Peter Hutterer wrote:
On Thu, Jul 05, 2012 at 02
1 - 100 of 1074 matches
Mail list logo
