Re: SCM_RIGHTS: XTrans vs ssh forwarding with MIT-SHM clients

(or is it not)?. > On Jan 17, 2023, at 01:06, Jeremy Huddleston Sequoia > wrote: > > Yep, thanks for the pointer. Looks like DetermineClientCmd() needs to be > implemented for darwin. > >> On Jan 16, 2023, at 01:14, Michel Dänzer wrote: >> >> On 1/16/23 06

Re: SCM_RIGHTS: XTrans vs ssh forwarding with MIT-SHM clients

Yep, thanks for the pointer. Looks like DetermineClientCmd() needs to be implemented for darwin. > On Jan 16, 2023, at 01:14, Michel Dänzer wrote: > > On 1/16/23 06:31, Jeremy Huddleston Sequoia wrote: >> >> How should this work? Why hasn't this been reported

SCM_RIGHTS: XTrans vs ssh forwarding with MIT-SHM clients

A user reported (https://github.com/XQuartz/XQuartz/issues/314) that running `feh` on a remote system would hang the process without producing any windows when they updated from an older XQuartz server to a newer one. I traced this to a difference in autoconf vs meson builds. With meson, we're

Future of ROOTLESS

Hi folks, XQuartz is the only DDX using miext/rootless. This code doesn't play well with modern X servers. For example, it is incompatible with COMPOSITE (cf https://gitlab.freedesktop.org/xorg/xserver/-/issues/1409), other rootless DDXs (eg: xwin, xwayland) don't make use of it, and we

Re: GetScratchPixmapHeader / FreeScratchPixmapHeader

Alrighty, then here it is: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1032?commit_id=5781ffcf5f3c918a97fe590ddb605fe0fefdb6ca Thanks, Jeremy > On Dec 21, 2022, at 13:24, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> Is ther

GetScratchPixmapHeader / FreeScratchPixmapHeader

In triaging some issues related to pixmaps in XQuartz / rootlesss these past few weeks, I found it useful to just disable recycling the scratch pixmap header. Specifically, in my debug build, GetScratchPixmapHeader() just does CreatePixmap + ModifyPixmapHeader and FreeScratchPixmapHeader()

Re: Making new releases of X.Org modules

> On Dec 8, 2022, at 16:22, Peter Hutterer wrote: > > On Thu, Dec 08, 2022 at 12:34:33PM -0800, Alan Coopersmith wrote: >> On 12/7/22 19:07, Peter Hutterer wrote: >>> fwiw, I've done similar things in the past, pushing a release out just >>> to make some internal processes easier. It's

Xlib contract for XEvent up/down-casting

I've been running XQuartz with ASan+UBSan to try to catch some issues some users have reported, and I stumbled across something below GLUT (specifically, freeglut 2.8.1), which does: XConfigureEvent fakeEvent = {0}; ... XPutBackEvent(fgDisplay.Display, (XEvent*)); and XPutBackEvent

Re: Need some help please!!

> On May 12, 2017, at 04:53, Sophia Kasasa wrote: > > Hi, > > I’m in the middle of trying to link up my Synergy Trader (ST) software to my > Vantage trading platform. > > This requires me to simply copy and paste two files from the ST to the > corresponding files on the

Re: [PATCH v2 xserver 4/7] configure.ac: factor out xquartz bundle destdir

I'm not familiar with the problem. Is this the canonical way to actually do this? It seems a bit odd, but it looks fine to me if just a bit quirky: Reviewed-by: Jeremy Sequoia > On Apr 4, 2017, at 4:49 PM, Mihail Konev wrote: > > Fixes DESTDIR not being

Re: [PATCH v2 xserver 5/7] hw/xquartz: fix path to pseudoramiX headers

Thanks. Reviewed-by: Jeremy Sequoia > On Apr 4, 2017, at 4:49 PM, Mihail Konev wrote: > > Fixes out-of-source XQuartz build. > > Fixes: 39c548da ("XQuartz: Fix build with moved pseudoramiX") > Signed-off-by: Mihail Konev > --- > v2: Reword. Add

Re: [ANNOUNCE] xorg-server 1.19.2

> On Mar 3, 2017, at 08:50, Adam Jackson wrote: > > On Thu, 2017-03-02 at 18:13 -0500, Adam Jackson wrote: >> A collection of stability fixes here across glamor, Xwayland, input, >> and Prime support. Also a security fix for CVE-2017-2624, a timing >> attack which can brute-force

Re: Help - want to uninstall X11 - Quartz

> On Dec 18, 2016, at 00:54, Diane Chan wrote: > > Today downloaded XQuartz 2.7.11 and installed on OS X Sierra after prompting > from my old version of CrossOver. How can I uninstall? I suspect it has > interfered with the computer’s ability to establish network

Re: XQuartz fails to Launch or Reinstall

Hi Wendy, Run `/bin/ls -Old /private/tmp` I suspect you'll see that "restricted" is set on /private/tmp. If so, you're likely seeing the same issue as impacting users of Xcode, mysqld, and other tools that make use of /tmp. You can see my answer on

Re: [PATCH xserver] inputthread: leave the main thread's name as-is

Shouldn't glibc be fixed instead? Why punish the platforms that do it right? --Jeremy > On Oct 17, 2016, at 21:13, Peter Hutterer wrote: > > On Linux, setting the main thread's name changes the program name > (/proc/self/comm). Setting it to MainThread breaks scripts

Re: XQuartz fails to Launch or Reinstall

eology/ > University of Nevada, Reno 775-784-1785 wcal...@unr.edu > __ > > > From: <jerem...@apple.com> on behalf of Jeremy Huddleston Sequoia > <jerem...@apple.com> > Date: Monday, October 10, 2016 at 11:50 PM > To:

Re: XQuartz fails to Launch or Reinstall

> Wendy M Calvin > Professor and Chair, Geological Sciences > http://www.unr.edu/geology/ > University of Nevada, Reno 775-784-1785 wcal...@unr.edu > __ > > > From: <jerem...@apple.com> on behalf of Jeremy Huddle

Re: [PATCH 3/3] glx: Initialize glx even if there are currently no screens attached

> On Oct 10, 2016, at 10:16, Adam Jackson <a...@nwnk.net> wrote: > > On Sun, 2016-10-09 at 12:51 -0700, Jeremy Huddleston Sequoia wrote: >> Failure to do so causes an overvlow in glxClientCallback > > This patch makes no sense at all. glxClientCallback is only added

Re: [PATCH 2/3] randr: Initialize RandR even if there are currently no screens attached

> On Oct 10, 2016, at 03:33, Emil Velikov <emil.l.veli...@gmail.com> wrote: > > Hi Jeremy, > > On 9 October 2016 at 20:51, Jeremy Huddleston Sequoia > <jerem...@apple.com> wrote: >> Failure to do so causes an overvlow in RRClientCallback(). >> >

[PATCH 2/3] randr: Initialize RandR even if there are currently no screens attached

#11 0x7fffc5f16aaa in _pthread_body (libsystem_pthread.dylib+0x3aaa) #12 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #13 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- randr/randr

[PATCH 3/3] glx: Initialize glx even if there are currently no screens attached

(libsystem_pthread.dylib+0x3aaa) #14 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #15 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- glx/glxext.c | 21 - 1 file chang

[PATCH 1/3] os/connection: Improve abstraction for launchd secure sockets

This changes away from hard-coding the /tmp/launch-* path to now supporting a generic [.] format for $DISPLAY. cf-libxcb: d978a4f69b30b630f28d07f1003cf290284d24d8 Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Adam Jackson <a...@kemper.freedesktop.org> --- os/

[PULL] XQuartz cleanup related to inputthread changes

) Jeremy Huddleston Sequoia (6): dix: Silence TSan warnings when checking for pending input XQuartz: Don't respond to SIGALRM on the AppKit thread XQuartz: Remove X11ApplicationFatalError XQuartz: pbproxy shouldn't need to wait for server initialization. XQuartz: Adopt

[ANNOUNCE] xproto 7.0.30

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremy Huddleston Sequoia (5): Xfuncproto.h: Define __has_feature() if it isn't already Xfuncproto.h: Define __has_extension() if it isn't already Xfuncproto: Add support for _X_DEPRECATED_MSG() macro Xfuncproto: Add support

[ANNOUNCE] xproto 7.0.30

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremy Huddleston Sequoia (5): Xfuncproto.h: Define __has_feature() if it isn't already Xfuncproto.h: Define __has_extension() if it isn't already Xfuncproto: Add support for _X_DEPRECATED_MSG() macro Xfuncproto: Add support

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

> On Sep 22, 2016, at 11:26, Keith Packard <kei...@keithp.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> I would've but we're post API freeze at this point, yes? Would that be ok? > > Yeah, better than duplicating, and it does

[PATCH 1/1] dix: Silence TSan warnings when checking for pending input

+0x5254) SUMMARY: ThreadSanitizer: data race mieq.c:263 in mieqEnqueue == Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Keith Packard <kei...@keithp.com> --- configure.ac | 2 +- dix/dispatch.c | 7 +++ include/dix.h | 6 ++ os/WaitFor.c

Re: [PATCH xserver 0/2] os: Fix write block handling in poll(2) path

Series is: Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> Tested-by: Jeremy Huddleston Sequoia <jerem...@apple.com> I'd still like to get rid of the large NewOutputPending hammer, but this is good for now. Thanks, Jeremy > On Sep 21, 2016, at 16:53, Kei

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

> On Sep 22, 2016, at 00:22, Keith Packard <kei...@keithp.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> +static inline _X_NOTSAN Bool >> +InputCheckPending(void) >> +{ >> +return (*checkForInput[0] != *checkFo

[PATCH 1/1] dix: Silence TSan warnings when checking for pending input

race mieq.c:263 in mieqEnqueue == Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- configure.ac | 2 +- dix/dispatch.c | 13 + os/WaitFor.c | 8 +++- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/configure.ac b/config

[PATCH xproto 3/4] Xfuncproto: Add support for _X_DEPRECATED_MSG() macro

Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- Xfuncproto.h.in | 8 1 file changed, 8 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 7f06e99..8a9530a 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -137,6 +137,14 @@ in this Software w

[PATCH xproto 1/4] Xfuncproto.h: Define __has_feature() if it isn't already

Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- Xfuncproto.h.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 5daa83e..8556c27 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -79,6 +79,9 @@ in this Software without

[PATCH xproto 4/4] Xfuncproto: Add support for _X_NOTSAN macro

Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- Xfuncproto.h.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 8a9530a..8715c9d 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -210,4 +210,11 @@ in this Software w

[PATCH xproto 2/4] Xfuncproto.h: Define __has_extension() if it isn't already

Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- Xfuncproto.h.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 8556c27..7f06e99 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -82,6 +82,9 @@ in this Software without

Re: [PATCH 1/1] dix: Hold the input_lock() when accessing the miEventQueue through checkForInput

> On Sep 19, 2016, at 09:52, Keith Packard <kei...@keithp.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> Yeah, I made the change mainly to shutup the analyzer while I was >> looking for other races. I decided to propose it

Re: [PATCH 1/1] dix: Hold the input_lock() when accessing the miEventQueue through checkForInput

> On Sep 19, 2016, at 08:30, Keith Packard <kei...@keithp.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> == >> WARNING: ThreadSanitizer: data race (pid=4943) >> Read of size 4 at 0x00010c4e3854 by thread T

Re: os/log.c thread safety

> On Sep 18, 2016, at 21:58, Keith Packard <kei...@keithp.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> [ Unknown signature status ] >> I noticed a data race in XQuartz. We call ErrorF in a couple places off of >> the mai

[PATCH 1/1] dix: Hold the input_lock() when accessing the miEventQueue through checkForInput

== Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- dix/dispatch.c | 21 ++--- os/WaitFor.c | 7 ++- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index 26a461b..dbf7f97 100644 --- a/dix/dispatch.c +++

[PATCH 1/1] dix: Make InitCoreDevices() failures more verbose.

Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- dix/devices.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/dix/devices.c b/dix/devices.c index 56aae85..ea3c6c8 100644 --- a/dix/devices.c +++ b/dix/dev

os/log.c thread safety

I noticed a data race in XQuartz. We call ErrorF in a couple places off of the main server thread. I could fix it by simply moving this logging onto the server thread (or not doing it with os/log), but with the split of InputThread off of MainThread, I'm wondering if it would be better to

Re: [PATCH 1/2] os/connection: Call ClientReady() based on a level trigger rather than an edge trigger

> On Sep 18, 2016, at 09:58, Keith Packard wrote: > > Matthieu Herrb writes: > >> this doesn't fix an issue I'm seeing on OpenBSD with xterm not beeing >> able to start (it makes the X server spin at 100% CPU in >> WaitForSomething()), while Jeremy's

Re: [PATCH 2/2] os/connection: Remove NewOutputPending

> On Sep 18, 2016, at 08:51, Keith Packard <kei...@keithp.com> wrote: > > Jeremy Huddleston Sequoia <jerem...@apple.com> writes: > >> Use any_output_pending() instead. > > These aren't equivalent -- NewOutputPending is set when there is output > p

CARD32 vs uint32_t

libXfont2's _xfont2_client_funcs struct has a get_time_in_millis entry that is declared as 'uint32_t (*get_time_in_millis)(void);' xserver tries to use GetTimeInMillis for this, but it is declared as 'CARD32 GetTimeInMillis(void)'. The issue is that CARD32 is actually 'unsigned long' on i386,

Re: XLoadQueryFont() not returning with recent xserver master

any_output_pending()? The following two patches for consideration address these points. Thanks, Jeremy > On Sep 16, 2016, at 23:16, Jeremy Huddleston Sequoia <jerem...@apple.com> > wrote: > > I bisected the issue to: > > f993091e7db81b0420e23c485378cba112278839 is the f

[PATCH 1/2] os/connection: Call ClientReady() based on a level trigger rather than an edge trigger

-exits if NewOutputPending is not set. The only place that is setting NewOutputPending is ClientReady(). The problem there is that ClientReady() is called based on an edge trigger and not a level trigger. Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Keith Packar

[PATCH 2/2] os/connection: Remove NewOutputPending

Use any_output_pending() instead. Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Keith Packard <kei...@keithp.com> --- os/WaitFor.c| 2 +- os/connection.c | 2 -- os/io.c | 5 + os/osdep.h | 2 -- 4 files changed, 2 insertions(+), 9 deleti

Re: XLoadQueryFont() not returning with recent xserver master

ep 11, 2016, at 16:54, Jeremy Huddleston Sequoia <jerem...@apple.com> > wrote: > > Upon a bit more digging, it looks like the clients are listed in > output_pending_clients, but it's not getting delivered. > > This situation reveals another issue with a use-after-free

Re: [ANNOUNCE] xorg-server 1.18.99.2

> On Sep 16, 2016, at 13:57, Keith Packard wrote: > > > I think we're ready for RC1 at this point, but wanted to give people a > chance to scream about "just one more API change" until tomorrow. Let me > know if there's something I'm missing; if I don't hear anything, I'll

Re: [PATCH 1/1] randr: Initialize RandR even if there are currently no screens attached

Ping. > On Sep 11, 2016, at 02:23, Jeremy Huddleston Sequoia <jerem...@apple.com> > wrote: > > Failure to do so causes an overvlow in RRClientCallback(). > > = > ==41262==ERROR: AddressSanitizer: global

Re: [PATCH 1/1] glx: Initialize glx even if there are currently no screens attached

Ping. > On Sep 11, 2016, at 03:44, Jeremy Huddleston Sequoia <jerem...@apple.com> > wrote: > > Failure to do so causes an overvlow in glxClientCallback > > Application Specific Information: > X.Org X Server 1.1

[PATCH 1/1] os/connection: Improve abstraction for launchd secure sockets

This changes away from hard-coding the /tmp/launch-* path to now supporting a generic [.] format for $DISPLAY. cf-libxcb: d978a4f69b30b630f28d07f1003cf290284d24d8 Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Adam Jackson <a...@kemper.freedesktop.org> --- os/

Re: [PULL] XQuartz {Add,Remove}EnabledDevice build fixes and other cleanup

> On Sep 13, 2016, at 07:48, Adam Jackson <a...@redhat.com> wrote: > > On Sun, 2016-09-11 at 00:03 -0700, Jeremy Huddleston Sequoia wrote: > >> os/connection: Improve abstraction for launchd secure sockets > > Mmm, not a huge fan of this one. You'

Re: [PATCH 2/3] Xext/shm: Better support cases where O_CLOEXEC is not defined

> On Sep 12, 2016, at 04:33, Julien Cristau <jcris...@debian.org> wrote: > > On Sun, Sep 11, 2016 at 20:01:50 -0700, Jeremy Huddleston Sequoia wrote: > >> Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> >> --- >> Xext/shm.c | 6 +- >

[PATCH 1/3] Xext/shm: Fix usage of F_GETFD to match standard

flags = fcntl(fd, F_GETFD) is compliant. fcntl(fd, F_GETFD, ) is non-compliant (Linux extension?) cf: http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- Xext/shm.c | 3 ++- 1 file changed, 2 insertions

[PATCH 3/3] os/inputthread: Fix setting of cloexec on file descriptors

://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html Regressed-in: 30ac7567980a1eb79d084a63e0e74e1d9a3af673 Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- os/inputthread.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/os/inputthread.

[PATCH 2/3] Xext/shm: Better support cases where O_CLOEXEC is not defined

Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- Xext/shm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Xext/shm.c b/Xext/shm.c index 125000f..7a45dbd 100644 --- a/Xext/shm.c +++ b/Xext/shm.c @@ -1202,7 +1202,11 @@ shm_tmpfile(void)

Re: XLoadQueryFont() not returning with recent xserver master

() as part of CloseDownConnection(). See https://bugs.freedesktop.org/show_bug.cgi?id=97770 for more details on that. > On Sep 11, 2016, at 12:24, Jeremy Huddleston Sequoia <jerem...@apple.com> > wrote: > > Using current master plus the various patches I submitted to the list last

XLoadQueryFont() not returning with recent xserver master

Using current master plus the various patches I submitted to the list last night, I'm able to launch the server fairly reliably under ASan again, but some clients are getting wedged. Most notably, xterm gets stuck waiting for a reply from XLoadQueryFont(). Looking at the state of the server

[PATCH 1/1] glx: Initialize glx even if there are currently no screens attached

(libsystem_pthread.dylib+0x3aaa) #14 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #15 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- glx/glxext.c | 21 - 1 file chang

[PATCH 1/1] dix/dispatch: Fix SmartScheduleClient interval adjustment to use best rather than pClient

-in: 8f1edf4bd3a1f050ce9eeb5eac45dd1a8f7a6d5e Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- dix/dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index 3b9600e..f1a074d 100644 --- a/dix/dispatch.c +++ b/dix/dispatch.c @@ -360,7

[PATCH 1/1] randr: Initialize RandR even if there are currently no screens attached

#11 0x7fffc5f16aaa in _pthread_body (libsystem_pthread.dylib+0x3aaa) #12 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #13 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- randr/randr

Re: [PATCH:xserver] Use pthread_setname_np to set thread names if available

Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> Tested-by: Jeremy Huddleston Sequoia <jerem...@apple.com> (on current macOS) > On Sep 10, 2016, at 21:14, Alan Coopersmith <alan.coopersm...@oracle.com> > wrote: > > Autoconf logic borrowed from

[PULL] XQuartz {Add, Remove}EnabledDevice build fixes and other cleanup

to dd85834e3995671da908e825eaa7a228d11f0b3d: xquartz: Update for removal of AddEnabledDevice and RemoveEnabledDevice (2016-09-10 23:37:46 -0700) Jeremy Huddleston Sequoia (4): XQuartz: Fix the issue where the h key could be come

[PATCH libXfont 3/4] fserve: Silence a -Wformat warning

src/fc/fserve.c:653:32: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long') [-Wformat] " from font server\n", rep->length); ^~~ 1 warning generated. Signed-off-by: Jeremy Huddl

[PATCH libXfont 4/4] fstrans: Remove unused foo() function

("a"); } ^ 1 warning generated. Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Keith Packard <kei...@keithp.com> --- src/fc/fstrans.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/fc/fstrans.c b/src/fc/fstrans.c index 66bc978..902ef

[PATCH libXfont 2/4] bitmap: Bail out on invalid input to FontFileMakeDir instead of calling calloc for 0 bytes

Found by clang static analysis: Call to 'calloc' has an allocation size of 0 bytes Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- src/bitmap/bitscale.c | 4 1 file changed, 4 insertions(+) diff --git a/src/bitmap/bitscale.c b/src/bitmap/bitscale.c index 2

[PATCH libXfont 1/4] FreeType: Correct an allocation size

off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- src/FreeType/ftfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FreeType/ftfuncs.c b/src/FreeType/ftfuncs.c index bbd4db4..e7c8026 100644 --- a/src/FreeType/ftfuncs.c +++ b/src/FreeType/ftfuncs.c @@ -623

[PATCH libXfont 1/1] fserve: Fix a buffer read overrun in _fs_client_access

t to 34 as one would expect). The following block changed authlen to 36 to make it 4byte aligned and the final _fs_write() caused us to read 36 bytes from this 34 byte buffer. This changes the incorrect size increase to instead use _fs_write_pad which takes care of the padding for us. Signed-off-b

Re: Remote OpenGL

> On May 27, 2016, at 09:27, Cook, Rich <coo...@llnl.gov> wrote: > > >> On May 27, 2016, at 1:53 AM, Jeremy Huddleston Sequoia >> <jerem...@freedesktop.org> wrote: >> >>> Another awkward thing about this, I suppose, is that on OSX the X server

Re: Remote OpenGL

> On May 26, 2016, at 15:56, Adam Jackson wrote: > > On Thu, 2016-05-26 at 09:14 +0200, Laurent Lamalle wrote: >> Hello, >> >> I have just discovered, through the x11-us...@lists.apple.com mailing >> list, that Xorg deprecated some software component (IGLX?) necessary for >>

[PULL 1.18] XQuartz configure cherry-picks

: Fix default CFBundleVersion (2016-05-18 14:13:04 -0700) Jeremy Huddleston Sequoia (7): XQuartz: Remove --with-launchd-id-prefix XQuartz: Fix the help text for --with-bundle-id-prefix XQuartz: Update release feed URL

[PULL] XQuartz configure.ac fix for default CFBundleVersion

to e6ac87cd05b459598e69eebee92bfd2f28292dae: XQuartz: Fix default CFBundleVersion (2016-05-18 09:56:33 -0700) Jeremy Huddleston Sequoia (1): XQuartz: Fix default CFBundleVersion configure.ac | 5 ++--- 1 file changed, 2

Re: [PATCH xserver] Use separate name for --with-bundle-version help variable

-0700) ---- Jeremy Huddleston Sequoia (1): XQuartz: Fix default CFBundleVersion configure.ac | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) > On May 12, 2016, at 10:35, Keith Packard <kei...@keithp.com> wrote

[PULL] XQuartz configure options

to 059d5ef30490233f410ca87084c7697b87e5b05e: XQuartz: Update copyright years (2016-05-04 00:08:34 -0700) Jeremy Huddleston Sequoia (6): XQuartz: Remove --with-launchd-id-prefix XQuartz: Fix the help text for --with-bundle-id-prefix XQuartz

Clang Static Analysis

Hey folks, I just wanted to let you all know that I made some updates to my OS X tinderbox (yuffie). It's has been updated to use clang 3.8. You can find the static analysis results at https://people.freedesktop.org/~jeremyhu/analyzer/yuffie --Jeremy smime.p7s Description: S/MIME

Re: [PATCH rendercheck 3/5] Use ELF sections to make test setup easier.

The use of __attribute(section()), __start_test_section, and __stop_test_section is not portable. Could you please follow this up with a change that allows rendercheck to continue to function on non-ELF platforms as well? Preferably by just having alternate implementations of the

Re: [PATCH xserver 3/8] {xwin, xquartz}/glx: Always enable GLX_{ARB, SGIS}_multisample

The xquartz -s look good given the change to core. Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> > On Mar 21, 2016, at 13:29, Adam Jackson <a...@redhat.com> wrote: > > This is enabled unconditionally in the GLX core. For xwin, if the > backend doesn't sup

Re: [PATCH xserver 5/8] xquartz/glx: Error out for MakeContextCurrent(draw != read)

With the change to !=: Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> > On Mar 21, 2016, at 13:29, Adam Jackson <a...@redhat.com> wrote: > > CGL doesn't have a way to express this directly, unlike EGL WGL and GLX. > It might be implementable, but it's never a

Re: How to Uninstall X11

Check out the instructions on http://www.xquartz.org/FAQs.html --Jeremy > On Feb 25, 2016, at 16:17, Dr. Daniel Cantú wrote: > > Hi, I installed X11 a while ago on my Macbook so i could use a guitar > software. > I am now handing this same Macbook to my wife and I

Re: How do I become the OpenChrome project maintainer?

Hey Kevin, I suggest you start by creating a freedesktop.org account as described at http://www.freedesktop.org/wiki/AccountRequests > On Jan 29, 2016, at 20:39, Kevin Brace wrote: > > Hi, > > I will like to take over the task of maintaining and developing OpenChrome >

[PATCH libXaw3d 1/2] darwin: Remove incorrect export of vendorShellClassRec and vendorShellWidgetClass

Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- src/Vendor.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/Vendor.c b/src/Vendor.c index 8899cd1..6b34b31 100644 --- a/src/Vendor.c +++ b/src/Vendor.c @@ -110,12 +110,21 @@ stati

CC_CHECK_FLAGS_APPEND (was Re: libXfont: Changes to 'master')

./configure: line 19194: syntax error near unexpected token `with_cflags,' ./configure: line 19194: ` CC_CHECK_FLAGS_APPEND(with_cflags, CFLAGS, \' From what I can tell, CC_CHECK_FLAGS_APPEND comes from glib. Can we please not add a dependency on glib for this? --Jeremy > commit

Re: Disabling RECORD by default

The XQuartz option was meant mainly for RECORD. I'll followup later to add a preference option for RECORD in XQuartz. Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --Jeremy > On Nov 23, 2015, at 18:13, Keith Packard <kei...@keithp.com> wrote: > &g

Re: [PATCH:xorg-docs 3/4] X.man: document protocol/ syntax in display string

Should we also mention the extension that was added for launchd support where we DISPLAY=[.] > On Oct 27, 2015, at 19:45, Alan Coopersmith > wrote: > > See > http://www.x.org/releases/X11R7.7/doc/libX11/libX11/libX11.html#Opening_the_Display > > Signed-off-by:

Re: [PATCH:xserver 1/3] Xorg.man: move XLOCAL details to X(7) man page instead

Series: Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> > On Oct 27, 2015, at 19:44, Alan Coopersmith <alan.coopersm...@oracle.com> > wrote: > > These settings affect clients, not server, so belong there, next to > the information about how to set $DISPLA

Re: [PATCH:macros] XORG_MANPAGE_SECTIONS: limit SVR4 man page sections to Solaris 2.0-11

6 @@ > dnl @configure_input@ > dnl > -dnl Copyright (c) 2005, 2006, Oracle and/or its affiliates. All rights > reserved. > +dnl Copyright (c) 2005, 2015, Oracle and/or its affiliates. All rights > reserved. "-" rather than "," Other than that, Reviewed-

Re: [PATCH] xfree86: Use same inb/outb asm code for i386 amd64 and ia64

Reviewed-by: Jeremy Huddleston Sequoia <jerem...@apple.com> > On Oct 21, 2015, at 09:24, Adam Jackson <a...@redhat.com> wrote: > > This matches the GCCUSESGAS path from the old monolith build (where that > macro was actually set), and fixes the build on modern OSX.

[PATCH 1/1] xfree86: Use the correct __i386__ inline asm fallbacks in compiler.h

r.h:975:26: error: unknown use of instruction mnemonic without a size suffix [Inline Assembly Issue] :1:2: note: instantiated into assembly here out (%dx) ^ 2 errors generated. Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> CC: Adam Jackson <a...@nwnk.net> --- hw/

Re: [PATCH 1/1] xfree86: Use the correct __i386__ inline asm fallbacks in compiler.h

015, at 10:52, Jeremy Huddleston Sequoia <jerem...@apple.com> > wrote: > > ../../../../hw/xfree86/common/compiler.h:975:26: error: invalid operand in > inline asm: 'out${0:B} ($1)' [Inline Assembly Issue] >__asm__ __volatile__("out

[PATCH v2 3/4] dix: Silence -Wunused-variable warning by moving window.c off of legacy region defines

window.c:223:15: warning: unused variable 'pScreen' [-Wunused-variable,Unused Entity Issue] ScreenPtr pScreen = pWin->drawable.pScreen; ^ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- dix/window.c | 9 - 1 file changed, 4 insertions(+), 5

[PATCH v2 2/4] glx: Fix header length error checking in __glXDisp_RenderLarge

glxcmds.c:2206:46: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare,Semantic Issue] if ((cmdlen = safe_pad(hdr->length)) < 0) ^ ~ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.c

[PATCH v2 4/4] osinit: Silence -Wunused-variable warnings

e[PATH_MAX]; ^ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- os/osinit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/os/osinit.c b/os/osinit.c index ddd3fce..6ec2f11 100644 --- a/os/osinit.c +++ b/os/osinit.c @@ -158,8 +158,10 @@ void OsInit(void) { static Bool b

[PATCH v2 1/4] randr: Silence -Wshift-negative-value warnings

: expanded from macro 'IntToxFixed' ^~ /opt/X11/include/pixman-1/pixman.h:130:56: note: expanded from macro 'pixman_int_to_fixed' ~~~ ^ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.

Re: [PATCH v2 4/4] osinit: Silence -Wunused-variable warnings

Actually, only this last one is "v2". The others I just still need a Reviewed-by: for, but they're unchanged from earlier. Sorry for any confusion. > On Oct 18, 2015, at 23:12, Jeremy Huddleston Sequoia <jerem...@apple.com> > wrote: > > osinit.c:161:24: warni

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

> On Oct 19, 2015, at 08:31, Adam Jackson <a...@nwnk.net> wrote: > > On Wed, 2015-10-14 at 15:44 -0700, Jeremy Huddleston Sequoia wrote: >>> On Oct 14, 2015, at 15:33, Alan Coopersmith wrote: >>> >>> On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia

[PULL] XQuartz -- Fix launching with ASan

by automation a few years ago (2015-10-19 09:06:22 -0700) Jeremy Huddleston Sequoia (2): XQuartz: Make sure that darwin_all_modifier_mask_additions is 0-terminated XQuartz: Cleanup formatting of DarwinEQInit

Re: X server commit process

> On Oct 19, 2015, at 08:56, Julien Cristau wrote: > > On Mon, Oct 19, 2015 at 11:47:09 -0400, Adam Jackson wrote: > >> I don't think there's anyone currently working on 1.16 or older. >> > I'm still interested in 1.16 as that's what Debian 8 ships, but at this > point I

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

I would suggest maybe instead doing: int main(int argc, char *argv[], char *envp[]) { ... if (getuid() != geteuid()) envp = {NULL, }; (void)execve(argv[0], argv, envp); ... } Or at least name the variable something like empty_envp to distinguish it more clearly from the

Re: ABI mismatch

You need to recompile your radeon driver [14.213] (EE) module ABI major version (19) doesn't match the server's version (20) [14.213] (II) UnloadModule: "radeon" [14.213] (II) Unloading radeon [14.213] (EE) Failed to load module "radeon" (module requirement mismatch, 0) > On

Re: X server commit process

What is the current process for pulling into release branches? Are the breakdowns the same, or is someone specific going to manage release branches? > On Oct 16, 2015, at 09:21, Keith Packard wrote: > > > We had a discussion at XDC which resulted in some minor changes in

  1   2   3   >