Re: [PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

2015-10-15 Thread Jeremy Huddleston Sequoia
some nitpicking ... > man 3 difftime > > i pretty sure it will cause a fundamental change ... > > > just my 2 cents > re, > wh > > Am 15.10.2015 00:13, schrieb Jeremy Huddleston Sequoia: >> xdmauth.c:230:13: warning: absolute value function 'abs' given an argum

Re: [PULL] XQuartz update for ATS allowance of our Sparkle feed and updated menu bar height logic

2015-10-14 Thread Jeremy Huddleston Sequoia
> On Oct 14, 2015, at 06:32, Adam Jackson <a...@nwnk.net> wrote: > > On Wed, 2015-10-14 at 00:40 -0700, Jeremy Huddleston Sequoia wrote: > >> XQuartz: Relax App Transport Security for communicating with the update >> server > > I'm not sure I'm a fan

[PULL] XQuartz update for ATS allowance of our Sparkle feed and updated menu bar height logic

2015-10-14 Thread Jeremy Huddleston Sequoia
to 4513f924a7065edbd267cf96837af94ce5a58a6f: XQuartz: Fix how we calculate the height of the OSX menu bar (2015-10-13 14:19:05 -0700) Jeremy Huddleston Sequoia (2): XQuartz: Relax App Transport Security for communicating with the update server

annarchy disk space

2015-10-14 Thread Jeremy Huddleston Sequoia
I noticed some errors in my git post commit hooks just now. It looks like annarchy is out of space on / $ git push -f... remote: mail: /tmp/mail.Rs7Ah02H: No space left on device jeremyhu@annarchy:~$ df -h / Filesystem Size Used Avail Use%

[PATCH xquartz 05/10] xres: Silence -Wunused-function warnings when building !COMPOSITE or !RENDER

2015-10-14 Thread Jeremy Huddleston Sequoia
xres.c:422:1: warning: unused function 'ResFindCompositeClientWindowPixmaps' [-Wunused-function,Unused Entity Issue] ResFindCompositeClientWindowPixmaps (void *value, XID id, void *cdata) ^ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- Xext/xres.c | 8

[PATCH xquartz 09/10] xdmcp: Declare XdmcpFatal _X_NORETURN

2015-10-14 Thread Jeremy Huddleston Sequoia
xdmcp.c:1404:1: warning: function 'XdmcpFatal' could be declared with attribute 'noreturn' [-Wmissing-noreturn,Semantic Issue] Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- os/xdmcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/os/xdmcp.c b/os/xdmcp.c index 7

[PATCH xquartz 07/10] dix: Silence -Wunused-variable warning by moving window.c off of legacy region defines

2015-10-14 Thread Jeremy Huddleston Sequoia
window.c:223:15: warning: unused variable 'pScreen' [-Wunused-variable,Unused Entity Issue] ScreenPtr pScreen = pWin->drawable.pScreen; ^ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- dix/window.c | 9 - 1 file changed, 4 insertions(+), 5

[PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

2015-10-14 Thread Jeremy Huddleston Sequoia
e[PATH_MAX]; ^ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- os/osinit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/os/osinit.c b/os/osinit.c index ddd3fce..41a0aa7 100644 --- a/os/osinit.c +++ b/os/osinit.c @@ -158,8 +158,6 @@ void OsInit(void) {

[PATCH xquartz 01/10] mi: Correct a miscall of abs() to instead call fabs()

2015-10-14 Thread Jeremy Huddleston Sequoia
>= 360.0) ^~~ fabs Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.com> --- mi/miarc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mi/miarc.c b/mi/miarc.c index 5e854b3..2588ee4 100644 --- a/mi/miarc.c +++ b/mi/miarc.c @@ -1711,7 +171

[PATCH xquartz 06/10] security: Silence some benign -Wformat warnings

2015-10-14 Thread Jeremy Huddleston Sequoia
~ security.c:915:39: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long') [-Wformat,Format String Issue] rec->client->index, rec->pWin->drawable.id, ^~~~

[PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

2015-10-14 Thread Jeremy Huddleston Sequoia
ion of value [-Wabsolute-value,Semantic Issue] if (abs(client->time - now) > TwentyMinutes) { ^ xdmauth.c:302:9: note: use function 'labs' instead [Semantic Issue] if (abs(client->time - now) > TwentyMinutes) { ^~~ labs Signed-off-by: Jeremy Huddleston Seq

[PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

2015-10-14 Thread Jeremy Huddleston Sequoia
: expanded from macro 'IntToxFixed' ^~ /opt/X11/include/pixman-1/pixman.h:130:56: note: expanded from macro 'pixman_int_to_fixed' ~~~ ^ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

2015-10-14 Thread Jeremy Huddleston Sequoia
> On Oct 14, 2015, at 15:33, Alan Coopersmith <alan.coopersm...@oracle.com> > wrote: > > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: >> rrtransform.c:199:23: warning: shifting a negative signed value is undefined >> [-Wshift-negative-value,Semantic Iss

[PATCH xquartz 10/10] glx: Fix header length error checking in __glXDisp_RenderLarge

2015-10-14 Thread Jeremy Huddleston Sequoia
glxcmds.c:2206:46: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare,Semantic Issue] if ((cmdlen = safe_pad(hdr->length)) < 0) ^ ~ Signed-off-by: Jeremy Huddleston Sequoia <jerem...@apple.c

Re: [PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

2015-10-14 Thread Jeremy Huddleston Sequoia
nning of the block > but will that make some other platforms with ancient compilers sad? > (OpenBSD with old gcc? Visual Studio on Windows?) > > -alan- > > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: >> osinit.c:161:24: warning: unused variable 'devnull'

Re: [PULL] Misc XQuartz warning and minor cleanup

2015-06-17 Thread Jeremy Huddleston Sequoia
Ping On Jun 9, 2015, at 23:43, Jeremy Huddleston Sequoia jerem...@apple.com wrote: The following changes since commit fa12f2c150b2f50de9dac4a2b09265f13af353af: glamor: don't do render ops with matching source/dest (v3) (2015-06-02 14:16:26 +1000) are available in the git repository

[PULL] Misc XQuartz warning and minor cleanup

2015-06-10 Thread Jeremy Huddleston Sequoia
to 9003a3e5c55903ce4e371b2d5cb5030b5f97ae0e: XQuartz: Silence -Wformat-security for NSRunAlertPanel (2015-06-09 23:42:03 -0700) Jeremy Huddleston Sequoia (5): XQuartz: GLX: Use __glXEnableExtension to build extensions list

Re: xrandr: Changes to 'master'

2015-03-30 Thread Jeremy Huddleston Sequoia
xrandr.c:2470:8: error: void function 'print_output_property' should not return a value [-Wreturn-type,Semantic Issue] return NULL; ^ 1 error generated. --- Do you want to print an error message and then return? On Mar 29, 2015, at 21:58, Dave Airlie

Re: [PULL] Misc patches

2015-03-30 Thread Jeremy Huddleston Sequoia
Hey Jon, One additional change needed (see below). Please squash that in and then you can tag it: Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com Tested-by: Jeremy Huddleston Sequoia jerem...@apple.com Thanks, Jeremy --- a/hw/xquartz/xpr/xprScreen.c +++ b/hw/xquartz/xpr/xprScreen.c

Re: [PULL] Misc patches

2015-03-29 Thread Jeremy Huddleston Sequoia
Hey Jon, Sorry, I didn't get around to reviewing or testing these earlier. I suspect this might be the cause of the build failure fallout on tinderbox: http://tinderbox.x.org/builds/2015-03-29-0002/logs/xserver/#build ../../mi/miinitext.c:261:6: error: use of undeclared identifier

[PATCH 1/1] XQuartz: GLX: Use __glXEnableExtension to build extensions list

2015-02-15 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- hw/xquartz/GL/indirect.c | 37 +++-- 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/hw/xquartz/GL/indirect.c b/hw/xquartz/GL/indirect.c index 19b7d86..4e6ab3d 100644 --- a/hw/xquartz/GL

Re: Migrating away from using cpp for startx and xinitrc in xinit

2015-02-10 Thread Jeremy Huddleston Sequoia
On Feb 10, 2015, at 00:35, Hans de Goede hdego...@redhat.com wrote: Hi, On 10-02-15 08:39, Jeremy Huddleston Sequoia wrote: It seems that using cpp for startx and xinitrc in the xinit port is coming back to bite us now as different C preprocessors don't exactly process non-C files

Migrating away from using cpp for startx and xinitrc in xinit

2015-02-09 Thread Jeremy Huddleston Sequoia
It seems that using cpp for startx and xinitrc in the xinit port is coming back to bite us now as different C preprocessors don't exactly process non-C files in ways that we might want. https://trac.macports.org/ticket/46811#comment:4 Does anyone have any strong opinions about this state of

Re: [PATCH:xauth] include limits.h for PATH_MAX on OS'es without sys/syslimits.h

2015-01-02 Thread Jeremy Huddleston Sequoia
Sorry for my BSD-ism. =) Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Jan 2, 2015, at 09:50, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- gethost.c|4 parsedpy.c

Re: Reference: xorg/app/xauth Update DISPLAY parsing to work with new launchd paths in Yosemite

2015-01-02 Thread Jeremy Huddleston Sequoia
Sorry about that. Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Jan 2, 2015, at 09:45, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 01/ 2/15 09:42 AM, Jon TURNEY wrote: On 31/12/2014 17:47, Alan Coopersmith wrote: On 12/31/14 08:11 AM, Colin Harrison wrote: Hi

Re: [PATCH] Drop valuator mask argument from GetKeyboardEvents

2014-12-16 Thread Jeremy Huddleston Sequoia
I should be able to take a look over the winter break next week. --Jeremy On Dec 15, 2014, at 20:43, Peter Hutterer peter.hutte...@who-t.net wrote: Nothing was using it and if anyone had they would've gotten a warning and noticed that it doesn't actually work. Drop this, it has been unused

Re: xf86-video-intel: tools/virtual.c

2014-08-26 Thread Jeremy Huddleston Sequoia
I would strongly suggest you transition to using strlcpy() instead. --Jeremy On Aug 26, 2014, at 10:32, Chris Wilson ic...@kemper.freedesktop.org wrote: tools/virtual.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit

[PULL] XQuartz minor bug fixes

2014-08-11 Thread Jeremy Huddleston Sequoia
to ab32ee35890be51137b56525826ffe219b63eb88: XQuartz: Better support turning off Displays have separate Spaces on OS X Mavericks (2014-08-11 13:18:51 -0700) Jeremy Huddleston Sequoia (2): ListenOnOpenFD: Remove Resets since this is intended to be for hotplugging

Re: xserver: Branch 'server-1.16-branch' - 2 commits

2014-08-11 Thread Jeremy Huddleston Sequoia
|7 --- 2 files changed, 17 insertions(+), 13 deletions(-) New commits: commit af2e9e3bb173885106f041f89b9f39b57fe3550a Author: Jeremy Huddleston Sequoia jerem...@apple.com Date: Mon Aug 11 13:15:24 2014 -0700 XQuartz: Better support turning off Displays have separate Spaces on OS

Re: [PATCH:x11proto] Use clang's __has_attribute to check for attribute support

2014-07-31 Thread Jeremy Huddleston Sequoia
Looks good to me. Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Jul 31, 2014, at 15:26, Alan Coopersmith alan.coopersm...@oracle.com wrote: Hopefully other compilers will start adopting this so we don't have to maintain ever growing matrixes of compiler/version checks

[PATCH 1/1] ListenOnOpenFD: Remove Resets since this is intended to be for hotplugging connections

2014-07-28 Thread Jeremy Huddleston Sequoia
pharris says that the resets should not be done in the hotplugging case. This may fix a crash reported against XQuartz: http://xquartz.macosforge.org/trac/ticket/869 Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC: Peter Harris phar...@opentext.com CC: Kristian Høgsberg k

Re: [PATCH 21/22] xquartz: Remove unused DRI{,Post}ValidateTree

2014-07-28 Thread Jeremy Huddleston Sequoia
Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On Jul 22, 2014, at 08:46, Adam Jackson a...@redhat.com wrote: Cargo-culted from DRI1, not actually used for anything. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xquartz/xpr/dri.c | 51

Assertion failure in SecurityDeleteAuthorization (xorg-server 1.14.4)

2014-07-23 Thread Jeremy Huddleston Sequoia
Hey Peter, Do you think that the double decrement that you fixed in the commit at the bottom is related to the issue reported with the 1.14 server in this ticket? Maybe by SecurityDeleteAuthorization getting called a second time? If not, any idea why this might be happening?

Re: ANN: xterm-309

2014-07-22 Thread Jeremy Huddleston Sequoia
On Jul 13, 2014, at 15:11, Thomas Dickey dic...@his.com wrote: * modify configure script to work around debris left by XQuartz upgrades. What is this about? This is the first I've heard of anything... --Jeremy ___

Re: ANN: xterm-309

2014-07-22 Thread Jeremy Huddleston Sequoia
On Jul 22, 2014, at 12:35, Thomas Dickey dic...@his.com wrote: On Mon, Jul 21, 2014 at 11:12:18PM -0700, Jeremy Huddleston Sequoia wrote: On Jul 13, 2014, at 15:11, Thomas Dickey dic...@his.com wrote: * modify configure script to work around debris left by XQuartz upgrades

Re: [PATCH 1/1] mieq: Fix a crash regression in mieqProcessDeviceEvent

2014-07-22 Thread Jeremy Huddleston Sequoia
On Jul 21, 2014, at 19:09, Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Jul 19, 2014 at 05:36:34PM -0700, Jeremy Huddleston Sequoia wrote: Actually ... while this does address the crash, it now just causes a bunch of our events to be ignored instead of processed. So should

[PULL] XQuartz mieq crash fix

2014-07-22 Thread Jeremy Huddleston Sequoia
) Jeremy Huddleston Sequoia (1): mieq: Fix a crash regression in mieqProcessDeviceEvent mi/mieq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

[PATCH 1/1] mieq: Fix a crash regression in mieqProcessDeviceEvent

2014-07-19 Thread Jeremy Huddleston Sequoia
Huddleston Sequoia jerem...@apple.com CC: Peter Hutterer peter.hutte...@who-t.net --- mi/mieq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mi/mieq.c b/mi/mieq.c index 872ff93..aced60d 100644 --- a/mi/mieq.c +++ b/mi/mieq.c @@ -516,7 +516,7 @@ mieqProcessDeviceEvent

Re: [PATCH 1/1] mieq: Fix a crash regression in mieqProcessDeviceEvent

2014-07-19 Thread Jeremy Huddleston Sequoia
, ProcessInputEvents gives the implication that dev can be NULL whereas mieqProcessInputEvents does not handle that, so we should possibly assert that dev is non-null earlier and remove dead code for the NULL case. --Jeremy On Jul 19, 2014, at 17:12, Jeremy Huddleston Sequoia jerem...@apple.com

[PULL] mi build fix

2014-06-06 Thread Jeremy Huddleston Sequoia
to e27a839bf0488d5b1cc2e2a887f2ea0e3d790790: mi: Build fix: mieqProcessDeviceEvent returns void (2014-06-06 01:04:03 -0700) Jeremy Huddleston Sequoia (1): mi: Build fix: mieqProcessDeviceEvent returns void mi/mieq.c | 2 +- 1 file changed, 1 insertion

[PATCH mi 1/1] mi: Build fix: mieqProcessDeviceEvent returns void

2014-06-05 Thread Jeremy Huddleston Sequoia
mieq.c:520:9: error: void function 'mieqProcessDeviceEvent' should not return a value [-Wreturn-type,Semantic Issue] return 0; ^ ~ 1 error generated. Regression-from: 9fb08310b51b46736f3ca8dbc04efdf502420403 Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC

[PULL 1.15] Misc XQuartz fixes and fbGlyphs origin

2014-06-05 Thread Jeremy Huddleston Sequoia
) Jeremy Huddleston Sequoia (3): XQuartz: Bump to 2.7.7 XQuartz: Dead code removal (ENABLE_DEBUG_LOG) XQuartz: Update logic to account for title bar on every display in Mavericks Peter Harris (1): fb: Fix origin of source picture in fbGlyphs fb

Re: [PATCH v2] mi: don't process events from disabled devices (#77884)

2014-06-05 Thread Jeremy Huddleston Sequoia
Introduces a build failure: http://tinderbox.x.org/builds/2014-06-05-0001/logs/xserver/#build mieq.c:520:9: error: void function 'mieqProcessDeviceEvent' should not return a value [-Wreturn-type,Semantic Issue] return 0; ^ ~ 1 error generated. make[1]: *** [mieq.lo] Error 1

[PULL] XQuartz Mavericks multimonitor bugfix

2014-05-31 Thread Jeremy Huddleston Sequoia
to 1c10b37380d228b35db8a8616a6312ac54f5e59b: XQuartz: Update logic to account for title bar on every display in Mavericks (2014-05-31 17:48:29 -0700) Jeremy Huddleston Sequoia (3): XQuartz: Bump to 2.7.7 XQuartz: Dead code removal

Re: [PULL] XQuartz minor bugfix

2014-04-09 Thread Jeremy Huddleston Sequoia
ping. I'd also like to cherry-pick this into 1.14.6 and 1.15.1 once it's on master. --Jeremy On Apr 6, 2014, at 05:45, Jeremy Huddleston Sequoia jerem...@apple.com wrote: The following changes since commit 901fbfbbbd71c0d82080957f8ba09eebbc786f2b: Add a return value to load_cursor_argb

[PULL] XQuartz minor bugfix

2014-04-06 Thread Jeremy Huddleston Sequoia
changes up to ec6007e6f7772a90713c9c51c64359229961ce27: XQuartz: Ensure we wait for the server thread to terminate (2014-04-06 05:32:03 -0700) Jeremy Huddleston Sequoia (1): XQuartz: Ensure we wait for the server thread

[PULL] XQuartz build fix

2014-02-14 Thread Jeremy Huddleston Sequoia
-14 00:33:38 -0800) Jeremy Huddleston Sequoia (1): XQuartz: pointer - void * hw/xquartz/quartzCocoa.m | 8 1 file changed, 4 insertions(+), 4 deletions(-) ___ xorg-devel

[PULL 1.14 and 1.15] XQuartz Hardening

2014-01-22 Thread Jeremy Huddleston Sequoia
in AppleWMSetWindowMenu (2014-01-22 15:17:49 -0800) Jeremy Huddleston Sequoia (12): darwin: Don't leave stdin/stdout closed XQuartz: Use asl_log_descriptor to log stdout/stderr of child processes XQuartz: Silence some static

Re: [PULL] XQuartz hardening and static analysis cleanup

2014-01-21 Thread Jeremy Huddleston Sequoia
Ping. These are still waiting for a merge. On Jan 12, 2014, at 23:15, Jeremy Huddleston Sequoia jerem...@apple.com wrote: Ping. I've rebased these against current master. --Jeremy On Jan 1, 2014, at 11:14, Jeremy Huddleston Sequoia jerem...@apple.com wrote: The following changes

Re: [PULL] XQuartz hardening and static analysis cleanup

2014-01-12 Thread Jeremy Huddleston Sequoia
Ping. I've rebased these against current master. --Jeremy On Jan 1, 2014, at 11:14, Jeremy Huddleston Sequoia jerem...@apple.com wrote: The following changes since commit 2ea973e12f5d954211e1d10085a4c74581b43aca: Bump version to 1.15.0 (2013-12-27 09:50:55 -0800) are available

[PULL] XQuartz hardening and static analysis cleanup

2014-01-01 Thread Jeremy Huddleston Sequoia
to 7160409207553404ae33eb5d5964b4d54d2adfcf: XQuartz: Avoid passing uninitialized pointers to X11ApplicationSetWindowMenu in AppleWMSetWindowMenu (2014-01-01 11:10:41 -0800) Jeremy Huddleston Sequoia (11): XQuartz: Silence some static analyzer warnings

[PULL] XQuartz working again on master with these changes

2013-12-13 Thread Jeremy Huddleston Sequoia
-13 01:39:44 -0800) Jeremy Huddleston Sequoia (3): darwin: Don't leave stdin/stdout closed XQuartz: Use asl_log_descriptor to log stdout/stderr of child processes configure.ac: Add PRESENT_LIB to XQUARTZ_LIBS

[PULL] XQuartz stdio

2013-12-12 Thread Jeremy Huddleston Sequoia
to d7c9235ee261b0f780320985233e00dec5e2689c: XQuartz: Use asl_log_descriptor to log stdout/stderr of child processes (2013-12-12 01:30:04 -0800) Jeremy Huddleston Sequoia (2): darwin: Don't leave stdin/stdout closed XQuartz: Use

[PATCH 1/1] darwin: Don't leave stdin/stdout closed

2013-12-07 Thread Jeremy Huddleston Sequoia
rdar://problem/15609419 Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- os/osinit.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/os/osinit.c b/os/osinit.c index 60d1069..4d48ea9 100644 --- a/os/osinit.c +++ b/os/osinit.c @@ -213,10 +213,18

Re: [PATCH 1/1] darwin: Don't leave stdin/stdout closed

2013-12-07 Thread Jeremy Huddleston Sequoia
As I'm sure other platforms would get cranky if stdin or stdout are closed, is there interest in just using this approach for the !defined(__CYGWIN__) case instead of just on darwin? On Dec 7, 2013, at 01:26, Jeremy Huddleston Sequoia jerem...@apple.com wrote: rdar://problem/15609419

Re: [PATCH 0/8] Attempt to fix GLX for OSX

2013-12-03 Thread Jeremy Huddleston Sequoia
I haven't tested the series yet, but I will hopefully tomorrow. My main concern is with error handling when __glGetProcAddress() returns NULL. == 1,4,5 == Ok Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com == 2 == I didn't check line by line, but the pattern looks reasonable if one

Re: [PATCH 1/1] glxstubs: Don't mix availability types on non-ELF

2013-12-02 Thread Jeremy Huddleston Sequoia
On Dec 2, 2013, at 04:37, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 29/11/2013 19:36, Jeremy Huddleston Sequoia wrote: Signed-off-by: Jeremy Huddleston Sequoia jeremyhu-2kanfrk1nckavxtiumw...@public.gmane.org --- glx/glxstubs.c | 8 +++- 1 file changed, 7 insertions(+), 1

Re: [PATCH 3/3] configure.ac: Require libpciaccess for int10

2013-11-29 Thread Jeremy Huddleston Sequoia
For Jon's fixup: Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com Tested-by: Jeremy Huddleston Sequoia jerem...@apple.com On Nov 29, 2013, at 4:26, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 16/11/2013 01:00, Connor Behan wrote: A --disable-pciaccess build will fail

[PATCH 1/1] glxstubs: Don't mix availability types on non-ELF

2013-11-29 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- glx/glxstubs.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/glx/glxstubs.c b/glx/glxstubs.c index 69bc004..509f65c 100644 --- a/glx/glxstubs.c +++ b/glx/glxstubs.c @@ -33,8 +33,14 @@ #include inttypes.h

Re: [RFC] GLX dispatch rewrite

2013-11-29 Thread Jeremy Huddleston Sequoia
On Nov 29, 2013, at 12:13, Keith Packard kei...@keithp.com wrote: Jeremy Huddleston Sequoia jerem...@freedesktop.org writes: So what's the story on this? How should we solve this for xquartz and xwin? Should we pull the old code into hw/xquartz/GL and hw/xwin/GL? That seems redundant

Re: [RFC] GLX dispatch rewrite

2013-11-29 Thread Jeremy Huddleston Sequoia
On Nov 29, 2013, at 15:20, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: On Nov 29, 2013, at 12:13, Keith Packard kei...@keithp.com wrote: Jeremy Huddleston Sequoia jerem...@freedesktop.org writes: So what's the story on this? How should we solve this for xquartz and xwin

Re: [RFC] GLX dispatch rewrite

2013-11-26 Thread Jeremy Huddleston Sequoia
as well). --Jeremy On Nov 13, 2013, at 9:47, Jeremy Huddleston Sequoia jerem...@freedesktop.org wrote: Hey ajax, Here's another XQuartz build regression from the GLX rework. Your commit (referenced below) got rid of _glapi_create_table_from_handle along with the rest of glapi.h. I

Re: modular: Changes to 'master'

2013-11-14 Thread Jeremy Huddleston Sequoia
As libxshmfence is Linux-only (or is it Linux + Solaris now), including it in xorg.modules for everyone causes build failure for everyone else... http://tinderbox.x.org/builds/2013-11-14-0003/ --Jeremy On Nov 13, 2013, at 9:59, Rob Clark robcl...@kemper.freedesktop.org wrote: xorg.modules |

Re: [RFC] GLX dispatch rewrite

2013-11-13 Thread Jeremy Huddleston Sequoia
Hey ajax, Here's another XQuartz build regression from the GLX rework. Your commit (referenced below) got rid of _glapi_create_table_from_handle along with the rest of glapi.h. I specifically created _glapi_create_table_from_handle for XQuartz (mesa: 85937f4c0d4a78d3a11e3c1fa6148640f2a9ad7b,

[PULL] Trivial fix for non-libpciaccess Xorg

2013-11-12 Thread Jeremy Huddleston Sequoia
) Jeremy Huddleston Sequoia (1): xfree86: Fix build without libpciaccess hw/xfree86/common/xf86Bus.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) ___ xorg-devel@lists.x.org: X.Org development Archives: http

[PULL] Trivial fix for non-libpciaccess Xorg

2013-11-12 Thread Jeremy Huddleston Sequoia
) Jeremy Huddleston Sequoia (1): xfree86: Fix build without libpciaccess hw/xfree86/common/xf86Bus.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) smime.p7s Description: S/MIME cryptographic signature

[PATCH 1/1] configure.ac: Move GLX section after DRI

2013-11-08 Thread Jeremy Huddleston Sequoia
The GLX section of configura.ac checks the state of DRI2, so it needs to be after DRI2=auto is resolved. Also reset libgl requirement to 7.1.0 in non-dri2 case. Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC: Ian Romanick i...@freedesktop.org --- configure.ac | 57

[PULL] configure.ac fixes for no/auto-DRI2 GLX

2013-11-08 Thread Jeremy Huddleston Sequoia
to 7cac488fc926068a53ff4673a6654f58ed226dad: configure.ac: Move GLX section after DRI (2013-11-08 10:21:43 -0800) Jeremy Huddleston Sequoia (1): configure.ac: Move GLX section after DRI configure.ac | 57

Re: [PATCH 1/1] configure.ac: Move GLX section after DRI

2013-11-08 Thread Jeremy Huddleston Sequoia
On Nov 8, 2013, at 9:58, Adam Jackson a...@nwnk.net wrote: On Fri, 2013-11-08 at 02:12 -0800, Jeremy Huddleston Sequoia wrote: The GLX section of configura.ac checks the state of DRI2, so it needs to be after DRI2=auto is resolved. Also reset libgl requirement to 7.1.0 in non-dri2 case

Re: [PATCH RESEND] xfree86: Find primary entity when bus types are nominally different

2013-11-08 Thread Jeremy Huddleston Sequoia
This breaks Xorg builds on systems without libpci. This is also on server-1.14-branch post 1.14.4, so we need to get this fixed up on the stable branch too. xf86Bus.c:270:9: error: incomplete definition of type 'struct pci_device' [Semantic Issue] return

[PATCH 1/1] xfree86: Fix build without libpciaccess

2013-11-08 Thread Jeremy Huddleston Sequoia
Regression fix from commit 04ab07ca19236d6c9a947e065fb69b0dd0d16639 Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC: Connor Behan connor.be...@gmail.com CC: Keith Packard kei...@keithp.com CC: Matt Dew mar...@osource.org --- hw/xfree86/common/xf86Bus.c | 5 - 1 file changed, 4

[PATCH 1/1] configure.ac: Bump xtrans requirement to 1.3.2 for TransRecvFd et al.

2013-11-08 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 8a9832c..47df86b 100644 --- a/configure.ac +++ b/configure.ac @@ -806,7 +806,7 @@ FIXESPROTO=fixesproto = 5.0

Re: [PULL] GLX rewrite

2013-11-08 Thread Jeremy Huddleston Sequoia
Sorry, I haven't been paying much attention to X11 for the past year or so, so I missed all of this work until it started failing on my build bot. glxstubs.c has conflicting availability attributes. How should we resolve this? If I was doing this for just OSX, I'd remove _X_HIDDEN and just

Re: [PATCH 1/1] xfree86: Fix build without libpciaccess

2013-11-08 Thread Jeremy Huddleston Sequoia
On Nov 8, 2013, at 17:22, Connor Behan connor.be...@gmail.com wrote: On 08/11/13 02:55 PM, Jeremy Huddleston Sequoia wrote: Regression fix from commit 04ab07ca19236d6c9a947e065fb69b0dd0d16639 Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC: Connor Behan connor.be

Re: xserver: Branch 'master' - 11 commits

2013-11-04 Thread Jeremy Huddleston Sequoia
On Nov 4, 2013, at 10:15, Ian Romanick i...@freedesktop.org wrote: On 11/02/2013 10:09 AM, Jeremy Huddleston Sequoia wrote: Why does this now require mesa 9.2.0? = 9.0 doesn't build on OS X, and I haven't had time to address the issue in mesa. I'm wondering if I can just revert this and keep

Fwd: [ANNOUNCE] xtrans 1.3.0

2013-11-03 Thread Jeremy Huddleston Sequoia
Keith, can you please check this out? Begin forwarded message: From: Somchai Smythe buraphalinuxser...@gmail.com Subject: Re: [ANNOUNCE] xtrans 1.3.0 Date: November 3, 2013 at 2:37:08 PST To: x...@lists.freedesktop.org Are you sure about those checksums? $sha256sum xtrans-*

[PATCH 1/1] miext/damage: Partial revert of Only wrap into the GC ops chain if there's a listener (v3)

2013-10-31 Thread Jeremy Huddleston Sequoia
Fixes regression from: 4dc2a76740d921c824a4d8193f39dd373475f02a http://lists.x.org/archives/xorg-devel/2013-May/036241.html https://trac.macports.org/ticket/38993 Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC: Adam Jackson a...@redhat.com CC: Aaron Plattner aplatt...@nvidia.com

[PULL] XQuartz trivial version bump

2013-10-31 Thread Jeremy Huddleston Sequoia
to bb745f2b45768d0936f3960951e1a5cee8b03194: XQuartz: Bump bundle version to 2.7.6 (2013-10-31 08:50:57 -0700) Jeremy Huddleston Sequoia (1): XQuartz: Bump bundle version to 2.7.6 hw/xquartz/bundle/Info.plist.cpp | 4 ++-- 1 file changed

[PULL 1.14] Bump version of XQuartz bundle

2013-10-29 Thread Jeremy Huddleston Sequoia
to a95cab9ec53705f838aa23f067c567b5674f242a: XQuartz: Bump bundle version to 2.7.5 (2013-10-29 11:06:55 -0700) Jeremy Huddleston Sequoia (1): XQuartz: Bump bundle version to 2.7.5 hw/xquartz/bundle/Info.plist.cpp | 4 ++-- 1 file

[PULL] rootless and XQuartz build fixes from 1.14.99.2 API cleanup

2013-10-06 Thread Jeremy Huddleston Sequoia
to 8aae28e3cbdd49bfa8d940a4a517c94a53b94f86: XQuartz: Dont't set screen on __GLXConfig (2013-10-06 09:20:45 -0700) Jeremy Huddleston Sequoia (2): rootless: Use miCopyRegion instead of fbCopyRegion XQuartz: Dont't set screen on __GLXConfig

Re: [REPOST PATCH xauth] Look for FamilyLocal if inet or inet6 address is loopback

2013-09-30 Thread Jeremy Huddleston Sequoia
You had incorrect casting in the IN6_IS_ADDR_* macros. Does Linux (or whatever platform you tested on) cast the arguments to those macros for you (thus correcting / undoing the casting that you provided)? That seems quite dangerous. I initially reverted this but then noticed it was a trivial

[PULL] Minor XQuartz build fixes

2013-09-16 Thread Jeremy Huddleston Sequoia
to 8010d3a48bd0b224dcb0883e39c2351ad364d846: XQuartz: pbproxy: Fix build with -DDEBUG (2013-09-16 07:06:57 -0700) Jeremy Huddleston Sequoia (2): XQuartz: Fix build with moved pseudoramiX XQuartz: pbproxy: Fix build with -DDEBUG hw

[PATCH xquartz 1/2] XQuartz: Fix build with moved pseudoramiX

2013-09-15 Thread Jeremy Huddleston Sequoia
Regression from: e716baedc4d8e52a60f43ef21aba771b340d8c8b Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com CC: Jon TURNEY jon.tur...@dronecode.org.uk --- hw/xquartz/Makefile.am | 1 + hw/xquartz/xpr/Makefile.am | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/xquartz

[PATCH xquartz 2/2] XQuartz: pbproxy: Fix build with -DDEBUG

2013-09-15 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- hw/xquartz/pbproxy/x-selection.m | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/xquartz/pbproxy/x-selection.m b/hw/xquartz/pbproxy/x-selection.m index 57ddb74..f4f4de8 100644 --- a/hw/xquartz/pbproxy/x

regression: xorg-server crash at damageValidateGC

2013-05-15 Thread Jeremy Huddleston Sequoia
Hey ajax, I haven't had the resources to look at many X11 issues these past few months, but someone bisected a crash to one of your changes back in September (see below). It looks like the issue is with the first hunk of

regression: xorg-server crash at damageValidateGC

2013-05-07 Thread Jeremy Huddleston Sequoia
Hey ajax, I haven't had the resources to look at many X11 issues these past few months, but someone bisected a crash to one of your changes back in September (see below). It looks like the issue is with the first hunk of

Re: [PATCH libxcwm 00/15] libxcwm patches

2013-03-05 Thread Jeremy Huddleston Sequoia
For some reason, I don't have 1 or 3, but they seem trivial based on the description in the log below. The others are: Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com Feel free to push, thanks. On Mar 5, 2013, at 6:22 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 05/11/2012

[PULL] Minor cleanup

2013-02-14 Thread Jeremy Huddleston Sequoia
to eda7dbff5a9f35fefe1e3dedacb82daadbf5945e: XORG_TLS: Pick the first option that works (ie: prefer __thread) (2013-02-14 09:20:47 -0800) Jeremy Huddleston Sequoia (3): XQuartz: Ensure dix-config.h is included in capabilities.c os: Ensure

Fwd: [PULL] Minor cleanup

2013-02-14 Thread Jeremy Huddleston Sequoia
Hi Matt, could you please cherry-pick these three into the 1.13 branch? Thanks, Jeremy Begin forwarded message: From: Keith Packard kei...@keithp.com Subject: Re: [PULL] Minor cleanup Date: February 14, 2013 11:06:45 PST To: Jeremy Huddleston Sequoia jerem...@apple.com Cc: X.Org

[PATCH 1/1] XORG_TLS: Pick the first option that works (ie: prefer __thread)

2013-02-09 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- m4/xorg-tls.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/xorg-tls.m4 b/m4/xorg-tls.m4 index 237fdcd..e04f1ff 100644 --- a/m4/xorg-tls.m4 +++ b/m4/xorg-tls.m4 @@ -28,7 +28,7 @@ AC_DEFUN([XORG_TLS

[PATCH 1/2] XQuartz: Ensure dix-config.h is included in capabilities.c

2013-02-09 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- hw/xquartz/GL/capabilities.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/xquartz/GL/capabilities.c b/hw/xquartz/GL/capabilities.c index 4702595..5573629 100644 --- a/hw/xquartz/GL/capabilities.c +++ b/hw/xquartz/GL

[PATCH 2/2] os: Ensure dix-config.h is included in strndup.c

2013-02-09 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia jerem...@apple.com --- os/strndup.c | 4 1 file changed, 4 insertions(+) diff --git a/os/strndup.c b/os/strndup.c index b604b9b..e0eddf1 100644 --- a/os/strndup.c +++ b/os/strndup.c @@ -27,6 +27,10 @@ * SUCH DAMAGE. */ +#ifdef HAVE_DIX_CONFIG_H

Re: Preparing for automake 1.14

2013-01-14 Thread Jeremy Huddleston Sequoia
While it's good to prepare for 1.14, we're still not working with 1.13 yet. libX11 is failing with: nls/Makefile.am:41: error: using '$(srcdir)' in TESTS is currently broken: '$(srcdir)/compose-check.pl' (see http://tinderbox.x.org/builds/2013-01-14-0001/logs/libX11/#configure) and I'm not

Re: Preparing for automake 1.14

2013-01-14 Thread Jeremy Huddleston Sequoia
On Jan 14, 2013, at 1:46 PM, Gaetan Nadon mems...@videotron.ca wrote: On 13-01-14 11:07 AM, Alan Coopersmith wrote: On 01/13/13 11:52 PM, Jeremy Huddleston Sequoia wrote: While it's good to prepare for 1.14, we're still not working with 1.13 yet. libX11 is failing with: nls/Makefile.am

[ANNOUNCE] libXTrap 1.0.1

2013-01-03 Thread Jeremy Huddleston Sequoia
droppings Replace static ChangeLog with dist-hook to generate from git log Jamey Sharp (1): SyncHandle must not be called with the Display lock held. Jeremy Huddleston Sequoia (3): configure.ac: Use AC_CONFIG_HEADERS instead of AM_CONFIG_HEADER for automake 1.13

Re: [PULL 1.13] - XQuartz / Mountain Lion deadlock cherrypick from master

2012-12-19 Thread Jeremy Huddleston Sequoia
) Jeremy Huddleston Sequoia (3): XQuartz: Avoid a possible deadlock with DRI on OS X 10.7.5 and OS X 10.8.2 XQuartz: Add some verbose logging to debug xp_lock_window being unbalanced XQuartz: Don't add the 15bit visual any more hw/xquartz/darwin.c| 16

[PULL 1.13] - XQuartz / Mountain Lion deadlock cherrypick from master

2012-12-18 Thread Jeremy Huddleston Sequoia
to 34fb39a960898f5a0bcc67f76f385ba8a91ea2ba: XQuartz: Add some verbose logging to debug xp_lock_window being unbalanced (2012-12-18 00:31:53 -0800) Jeremy Huddleston Sequoia (2): XQuartz: Avoid a possible deadlock with DRI on OS X 10.7.5

[PULL] XQuartz - Remove support for 15 bit visuals

2012-12-18 Thread Jeremy Huddleston Sequoia
to ba4bb3bc1b87eb57cc34d2ad1f302c9d2a15c847: XQuartz: Don't add the 15bit visual any more (2012-12-18 01:37:27 -0800) Jeremy Huddleston Sequoia (2): XQuartz: Revert some unfortunate auto-indenting mishaps with our super-nested

Re: xserver 1.13 stable branch is open for nominations

2012-11-02 Thread Jeremy Huddleston Sequoia
I'll have an XQuartz pull for you next week. In the mean time, you should probably cherry-pick 1ca096d5e07221025c4c4110528772b7d94f15ee. --Jeremy On Nov 1, 2012, at 11:29, Matt Dew mar...@osource.org wrote: Hi all, The xserver 1.13 stable branch is now open for nominations. I have two

Re: [PULL 1.12] xf86UpdateDesktopDimensions for 1.12

2012-10-14 Thread Jeremy Huddleston Sequoia
I don't have a 1.12.5 scheduled, but I'll probably do one once we've accumulated enough on the branch. 78c7735..01aac1f server-1.12-branch - server-1.12-branch On Oct 11, 2012, at 17:55, Peter Hutterer peter.hutte...@who-t.net wrote: Jeremy, Please pull this change into the 1.12

<    1   2   3   >