Re: what LLVM does mesa need to build "r300" ?

2018-06-11 Thread Tormod Volden
On Mon, Jun 11, 2018 at 1:11 AM, Dennis Clarke wrote: > > The strange magic words "--enable-llvm" issued to ye "build.sh" result > in being told quickly "no, don't do that ... go away" : > > > fs$ ./util/modular/build.sh --clone --autoresume --enable-llvm built.modules > /usr/local/xorg > the

Re: Problems with Xorg

2016-06-08 Thread Tormod Volden
On Wed, Jun 8, 2016 at 1:24 PM, Subrata Sengupta wrote: > Dear Alan, > > Thanks for your reply. I have removed & installed the xorg pkg today by > "apt-get install xorg" but with no luck. Here goes the Xorg.0.log file for > your further scrutiny. To provide a more useful backtrace, you can look

Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-03 Thread Tormod Volden
On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote: On 03.03.2015 05:01, Tormod Volden wrote: mgaDownloadFromScreen(PixmapPtr pSrc, int x, int y, int w, int h, char *dst, int dst_pitch) { +if (!pSrc) + return FALSE; + PMGA(pSrc); char *src

Re: [PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-03 Thread Tormod Volden
On Tue, Mar 3, 2015 at 9:21 PM, Alex Deucher wrote: On Tue, Mar 3, 2015 at 2:21 PM, Tormod Volden wrote: On Tue, Mar 3, 2015 at 3:18 AM, Michel Dänzer wrote: About patch 1, since mgaDownloadFromScreen doesn't do anything fancier than memcpy, you can just remove it altogether and leave pExa

[PATCH 1/2] mga: Fix pixmap pointer in EXA mgaDownloadFromScreen()

2015-03-02 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Thanks to Connor Behan for the fix. This replaces commit e9109a0b which was plain wrong. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- Hoping for remedy for old sins. Only compile-tested. Tormod src/mga_exa.c |2 +- 1 file changed

[PATCH 2/2] exa: Verify non-null pSrc in mgaDownloadFromScreen()

2015-03-02 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Thanks to Connor Behan for the suggestion. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- Also not tested on hardware. Tormod src/mga_exa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mga_exa.c b/src/mga_exa.c index

Re: [PATCH:xf86-video-mga] Fix pointer cast warning.

2015-02-25 Thread Tormod Volden
On Wed, Feb 25, 2015 at 2:01 PM, Mark Kettenis wrote: That pretty much confirms the code doesn't work (before or after your change). Probably the answer is to revert the exaGetPixmapFirstPixel() changes you made (here and in other drivers). Oops, yes, now I see that using

Re: Error encounter when building xorg

2014-03-21 Thread Tormod Volden
On Fri, Mar 21, 2014 at 6:16 PM, Hongze Zhao wrote: Hi All, When building the xorg source code using build.sh provided, I encounter such problem: sis_driver.c: In function 'SISMergedPointerMoved': sis_driver.c:9384:13: error: too few arguments to function 'miPointerSetPosition' Does

Re: xscreensaver and ldap authentication

2014-03-11 Thread Tormod Volden
On Mon, Mar 10, 2014 at 2:54 PM, Yan Seiner wrote: I know this is somewhat OT for this list, but I've run out of options... I am trying to get xscreensaver to work with PAM, and in particular with ldap. I've tried all sorts of things, including saslauthd, and nothing works. There doesn't

Re: Xorg not working on PPC

2014-01-23 Thread Tormod Volden
On Thu, Jan 23, 2014 at 9:48 PM, Andreas Mohr wrote: However very obviously I'd assume PPC handling to be quite a bit different to x86 handling. So, as venerable Alex said, your first stop should be PPC-knowledgeable groups. That said, the lockup / garbled screen might perhaps be caused by

Re: Is this a framebuffer job?

2013-11-07 Thread Tormod Volden
On Thu, Nov 7, 2013 at 9:39 PM, Gene Heskett wrote: 4, throwing away the unwanted pixels should be a few lines of code, essentially free, and by reducing the amount of data to be processed from 5,000,000 pixels to 57,600 pixels gains me only .0868% times the data to process, which gains me

Re: [PATCH 2/8] -pendantic is too pendantic

2013-11-07 Thread Tormod Volden
On Thu, Nov 7, 2013 at 4:45 AM, Keith Packard wrote: Many system headers have warnings when compiled with this flag. Signed-off-by: Keith Packard kei...@keithp.com At the risk of sounding pendantic, is your spelling a pun? Or trap :) Tormod ___

Re: any xserver stable branch nominations?

2013-10-29 Thread Tormod Volden
On Tue, Oct 22, 2013 at 4:51 AM, Matt Dew wrote: Hi Tormod, I only take cherry-picks or pulls. Not individual patches. Keith, Thoughts on applying that to master? Matt On 10/18/2013 05:05 PM, Tormod Volden wrote: Please consider Connor's patch (resent yesterday, Message-Id

[PATCH r128] Do not use int10 or VBE on powerpc

2013-10-25 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com VBE was already skipped in the normal path, but not when setting the PROBE_DETECT flag. Should avoid bus error seen in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622606 and http://lists.x.org/archives/xorg/2012-February/053969.html Signed-off

[PATCH 1/2] Unbreak dual head (xinerama)

2013-10-18 Thread Tormod Volden
From: Andy MacLean andy-...@themacleans.org.uk This patch has been used in Debian, Ubuntu and Gentoo for years. https://bugs.freedesktop.org/show_bug.cgi?id=18472 https://launchpad.net/bugs/292214 https://bugs.gentoo.org/show_bug.cgi?id=265100 Signed-off-by: Andy MacLean

[PATCH 2/2] Fix dual head crash without XAA

2013-10-18 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com https://launchpad.net/bugs/1180986 Signed-off-by: Tormod Volden debian.tor...@gmail.com Reviewed-by: Robert Jacobs robert.n.jac...@gmail.com Tested-by: Robert Jacobs robert.n.jac...@gmail.com --- src/mga_driver.c |2 ++ 1 file changed, 2

Re: any xserver stable branch nominations?

2013-10-18 Thread Tormod Volden
On Fri, Oct 18, 2013 at 1:29 AM, Matt Dew wrote: Today was the nominal 1.14.4-rc2 release. I've gotten no nominations, pull or cherry-pick requests since 1.14.3 was released. Can I assume 1.14.3 has been good to folks or that people are anxiously awaiting the chocolaty goodness of 1.15? Or

[ANNOUNCE] xf86-video-savage 2.3.7

2013-09-24 Thread Tormod Volden
that the xserver does not support XAA anymore. == Changes since 2.3.6 == Alexander Grothe (1): Drop miInitializeBackingStore() call Dave Airlie (2): savage: move compat-api.h down to proper place. savage: fix default accel arch when built with no XAA Tormod Volden (5

Re: (Crowd funded) fix for SiS 671/771 video cards

2013-05-18 Thread Tormod Volden
On Sat, May 18, 2013 at 7:52 PM, Pander wrote: (manual) patch results in [74.465] (II) LoadModule: sisimedia [74.465] (II) Loading /usr/lib/xorg/modules/drivers/sisimedia_drv.so [74.465] (EE) Failed to load /usr/lib/xorg/modules/drivers/sisimedia_drv.so:

Re: (Crowd funded) fix for SiS 671/771 video cards

2013-05-10 Thread Tormod Volden
On Fri, May 10, 2013 at 11:04 AM, Pander wrote: On 05/07/2013 09:24 PM, Connor Behan wrote: SiS drivers support EXA and will probably use that by default when you start one of the newer Xservers that lacks XAA. This could easily crash if the SiS EXA hooks haven't been updated in awhile so

Re: Failure to support 'savage' driver in 1.13.1

2013-03-06 Thread Tormod Volden
On Wed, Mar 6, 2013 at 8:54 AM, Tormod Volden wrote: On Wed, Mar 6, 2013 at 4:17 AM, 52midnight wrote: Dear Xorg [savage driver not working on xorg 1.13] I intend to investigate this further when I find more time. I've been thinking there might be some initialization hook that isn't called

Re: Failure to support 'savage' driver in 1.13.1

2013-03-05 Thread Tormod Volden
On Wed, Mar 6, 2013 at 4:17 AM, 52midnight wrote: Dear Xorg [savage driver not working on xorg 1.13] http://52midnight.com/xorg.html Assistance from the participants on the Gentoo forum provided a successful workaround: http://forums.gentoo.org/viewtopic-t-952908.html but they also

Re: IR remote control as mouse

2012-12-13 Thread Tormod Volden
On Wed, Dec 12, 2012 at 3:32 AM, johnea wrote: On 2012-12-07 21:00, johnea wrote: Hello, I've previously used LIRC for IR remote control of multimedia software, as well as configuring the arrow keys, of the remote, to function as a mouse. Can both of these functions be implemented via

Re: X crashes and suspend fails upon suspend-by-closing-the-lid after 20+ hours of X uptime

2012-08-31 Thread Tormod Volden
On Thu, Aug 30, 2012 at 10:17 AM, Athlion athl...@gmail.com wrote: Hello all! After using my laptop reaches more than about 20 hours of uptime (and I have a couple of suspend/resume cycles in between by closing the lid) the next suspend fails like this: snip after the failed suspend, the

Re: Configure Xorg on 2001 PPC iBook with Debian 6

2012-02-29 Thread Tormod Volden
On Wed, Feb 29, 2012 at 6:08 PM, Mike Mackenna mpmacke...@gmail.com wrote: Added this to the device section as shown below.  The weird part is You missed the Option word. Anyway, I don't think r128 honors that option so never mind. vbe/int10 is disabled on ppc in most of the r128 driver because

Re: [PATCH video-modesetting 13/14] config: layout and comment the top portion of configure.ac

2012-02-19 Thread Tormod Volden
On Sun, Feb 19, 2012 at 2:36 PM, Gaetan Nadon mems...@videotron.ca wrote: Reorder statements to be consistent with other modules so things are easier to find. ... +# Initialize X.Org macros 1.8 or later for MAN_SUBSTS set by XORG_MANPAGE_SECTIONS +m4_ifndef([XORG_MACROS_VERSION], +      

Re: [PATCH savage] Refactor BIOS modes retrieval to only call VBEGetVBEInfo once

2012-02-17 Thread Tormod Volden
On Thu, Feb 16, 2012 at 11:35 PM, Julien Cristau jcris...@debian.org wrote: On Wed, Feb 15, 2012 at 23:07:12 +0100, Tormod Volden wrote: From: Tormod Volden debian.tor...@gmail.com Signed-off-by: Tormod Volden debian.tor...@gmail.com --- The change should be fine by itself, but the reason

[PATCH savage] Refactor BIOS modes retrieval to only call VBEGetVBEInfo once

2012-02-15 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Signed-off-by: Tormod Volden debian.tor...@gmail.com --- The change should be fine by itself, but the reason I changed this is that with the latest stack (upgraded to 1.12RC etc) the second call to VBEGetVBEInfo would return corrupted values. There, I

Re: [PATCH xf86-video-savage] Untangle XF86DRI from the driver-specific DRI define

2012-01-17 Thread Tormod Volden
On Tue, Jan 17, 2012 at 6:35 AM, Peter Hutterer peter.hutte...@who-t.net wrote: XF86DRI is defined by xorg-server.h, so --disable-dri in the driver itself does exactly nothing other than not fill in the CFLAGS and thus stop the driver from compiling. Signed-off-by: Peter Hutterer

Re: [PATCH sis] Untangle XF86DRI from the driver-specific DRI define

2012-01-14 Thread Tormod Volden
,  Peter Other than those two things, Reviewed-by: Tormod Volden debian.tor...@gmail.com Tormod ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xgi] Fix warning: control reaches end of non-void function.

2012-01-13 Thread Tormod Volden
From: Johannes Obermayr johannesoberm...@gmx.de [Tormod: Remove unnecessary else and fix spelling in messages] Signed-off-by: Tormod Volden debian.tor...@gmail.com --- How about this then? For consistency do the same to other functions. Fixed up some glaring spelling mistakes while I

Re: [PATCH xgi] Fix warning: control reaches end of non-void function.

2012-01-13 Thread Tormod Volden
On Fri, Jan 13, 2012 at 10:44 PM, Jeremy Huddleston jerem...@apple.com wrote: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Jan 13, 2012, at 13:18, Tormod Volden wrote: From: Johannes Obermayr johannesoberm...@gmx.de [Tormod: Remove unnecessary else and fix spelling in messages

Re: Patches for xf86-video-{tdfx,trident,xgi}

2012-01-13 Thread Tormod Volden
'. The tdfx patch 0001-Fix-RPMLINT-warning-64bit-portability-issue.patch is Reviewed-by: Tormod Volden debian.tor...@gmail.com and has been pushed it to git. Thanks. (To sum up: The trident patch is obsolete, and the xgi patch was amended and applied.) Tormod

[PATCH s3virge] Do not use deprecated xf86PciInfo.h

2012-01-08 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Signed-off-by: Tormod Volden debian.tor...@gmail.com --- src/s3v.h|3 --- src/s3v_accel.c |1 + src/s3v_dga.c|1 - src/s3v_driver.c |5 +++-- src/s3v_hwcurs.c |1 + src/s3v_i2c.c|1 - src/s3v_pciids.h | 18

[PATCH s3virge] Add missing VERBLEV argument to xf86DrvMsgVerb()

2011-12-26 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Signed-off-by: Tormod Volden debian.tor...@gmail.com --- Fixes build failure here at least. src/s3v_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/s3v_driver.c b/src/s3v_driver.c index 2cc04ce..0440014 100644

[PATCH s3virge] Replace deprecated x(c/re)alloc/xfree with m/c/realloc/free

2011-12-26 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com sed -i 's/xalloc/malloc/g; s/xcalloc/calloc/g; s/xrealloc/realloc/g; s/xfree(/free(/g' Also added a missing unistd.h include for usleep(). Signed-off-by: Tormod Volden debian.tor...@gmail.com --- src/s3v_accel.c |1 + src/s3v_dga.c|6

Re: [PATCH edid-decode 1/3] Do the EDID version parsing before anything else

2011-12-21 Thread Tormod Volden
On Wed, Dec 21, 2011 at 10:23 AM, walter harms wha...@bfs.de wrote: Am 20.12.2011 22:17, schrieb Tormod Volden: From: Tormod Volden debian.tor...@gmail.com So that the version conformance flags can be used in other code. Signed-off-by: Tormod Volden debian.tor...@gmail.com ---  edid

[PATCH edid-decode 1/3] Do the EDID version parsing before anything else

2011-12-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com So that the version conformance flags can be used in other code. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- edid-decode.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git

[PATCH edid-decode 2/3 v2] Fix manufacture/model week/year parsing

2011-12-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com For instance, the handling of week=0xff or week=0 was not working, as could be seen from the data/sharp-* examples. Only EDID version 1.4 requires the year to be 2006 or later. Actually, data/sharp-aquos-hdmi reports 1.3 but seems to use month 0xff

[PATCH edid-decode 3/3] Adjust broken header warning message

2011-12-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Do not check edid pointer since it was already done. Remove commented return statement. Also separate declaration from code, which fixes remaining gcc -pedantic warnings. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- edid-decode.c |8

Re: [PATCH edid-decode v2] Fix manufacture/model week/year parsing

2011-12-19 Thread Tormod Volden
as a follow-up. Cheers, Tormod If you change the 1.4 check (and that matches the spec), or if you remove the 1.4 check, Reviewed-by: Jeremy Huddleston jerem...@apple.com On Dec 17, 2011, at 15:24, Tormod Volden wrote: From: Tormod Volden debian.tor...@gmail.com For instance, the handling

[PATCH edid-decode] Fix manufacture/model week/year parsing

2011-12-17 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com For instance, the handling of week=0xff or week=0 was not working, as could be seen from by the data/sharp-* examples. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- edid-decode.c | 20 +--- 1 files changed, 9 insertions

[PATCH savage 1/2] Do not use the deprecated xf86PciInfo.h from xserver

2011-12-04 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Instead maintain our own list of supported PCI IDs. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- src/savage_dri.c|1 - src/savage_driver.c |1 + src/savage_driver.h |1 - src/savage_hwmc.c |1 - src/savage_i2c.c

[PATCH radeontool 1/5] Clearer error message on fatal errors

2011-12-04 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Let the user know that we actually hit an error. This fixes gcc format-security warnings as well. Also add a missing newline in one error message. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- avivotool.c |2 +- radeonreg.c |2

[PATCH radeontool 2/5] Warn if run without superuser rights

2011-12-04 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Signed-off-by: Tormod Volden debian.tor...@gmail.com --- radeontool.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/radeontool.c b/radeontool.c index de742d1..cb7f051 100644 --- a/radeontool.c +++ b/radeontool.c @@ -2951,6

[PATCH radeontool 3/5] Only print current status in usage() if we are root

2011-12-04 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Otherwise print unknown for dac and backlight status. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- radeontool.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/radeontool.c b/radeontool.c

[PATCH radeontool 4/5] Add --help option to show usage description

2011-12-04 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Signed-off-by: Tormod Volden debian.tor...@gmail.com --- radeontool.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/radeontool.c b/radeontool.c index f9710fc..08b1749 100644 --- a/radeontool.c +++ b/radeontool.c @@ -155,6

[PATCH radeontool 5/5] Fix string format mismatch warnings

2011-12-04 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Consistently use int for register values and long for register offsets. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- atombios_tables.c |2 +- avivotool.c | 18 +- radeonreg.c |4 ++-- radeontool.c

s3switch maintenance

2011-11-10 Thread Tormod Volden
[s3switch is a tool for switching outputs on S3 Savage cards] Hi, Due to popular request, I would like to revive the s3switch tool and maintain it. It is still shipped in Fedora, based on a patch set from Debian and a couple of additional patches, but meanwhile it has ironically been dropped from

Re: [PATCH sis 00/15] a bunch of cleanups, and a taste of things to come

2011-10-30 Thread Tormod Volden
On Wed, Apr 27, 2011 at 10:59 PM, TImo Aaltonen tjaal...@ubuntu.com wrote: On 13.04.2011 18:22, TImo Aaltonen wrote: On 06.04.2011 19:50, Timo Aaltonen wrote: Here's a first set of patches to xf86-video-sis, hoping to narrow down the diff against Thomas Winischofer's 'sisfree' (*) package and

Re: [PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-29 Thread Tormod Volden
On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston jerem...@apple.com wrote: So, what's the point of having all these in common?  Why don't they just live in the drivers?  It seems silly to have these defined in the server's SDK rather than the driver that will consume them, since it means

[PATCH] radeon: do not include xf86PciInfo.h

2011-10-29 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com We already use atipciids.h instead most places. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- Actually, the PCI_VENDOR_ macros could better be maintained in a central location, but I just added the one missing here for now. Tormod src

Re: [PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-29 Thread Tormod Volden
On Sun, Oct 30, 2011 at 12:12 AM, Jeremy Huddleston jerem...@apple.com wrote: On Oct 29, 2011, at 14:01, Tormod Volden wrote: On Mon, Oct 17, 2011 at 10:53 AM, Jeremy Huddleston jerem...@apple.com wrote: So, what's the point of having all these in common?  Why don't they just live

Re: PATCH v4 Document -background none option

2011-10-13 Thread Tormod Volden
On Thu, Oct 13, 2011 at 10:55 PM, Michal Suchanek wrote: v3: reword based in input from Alan Coopersmith To nitpick on the nitpicking (at the risk of bikeshedding): +Asks the driver not to clear the background on startup, if the driver supports that. The other option descriptions start with

Re: [PATCH xserver] check for elevated privileges not uid=0

2011-10-11 Thread Tormod Volden
On Mon, Oct 10, 2011 at 9:04 PM, Antoine Martin wrote: And another blooper, sorry for the spam. Correct patch attached. Need sleep, will pick this up tomorrow. Subject: [PATCH xserver] check for elevated privileges not uid=0 (V3) Couldn't find any reference to it, so I just removed

Re: [PATCH xserver] check for elevated privileges not uid=0 (V2)

2011-10-10 Thread Tormod Volden
On Mon, Oct 10, 2011 at 6:43 PM, Antoine Martin wrote: I have been using this patch for days without any visible side effects. Can I please get some reviewed-by / acks? Any functional issues aside, your patch will need some style polishing before it can get any rubber stamps: Subject: [PATCH

Re: [PATCH xserver] check for elevated privileges rather than just euid=0

2011-10-06 Thread Tormod Volden
On Thu, Oct 6, 2011 at 3:05 PM, Antoine Martin wrote: This allows us to run the server as a normal user whilst still being able to use the -modulepath, -logfile and -config switches We define a xf86PrivsElevated which will do the checks and cache the result in case it is called more than once.

Re: [PATCH] savage: Fix Xv scaling on non-native resolutions

2011-09-18 Thread Tormod Volden
On Sat, Sep 17, 2011 at 5:52 PM, Matt Turner wrote: I don't know the hardware or Xv, but the changes look reasonable. There are enough changes in -savage since the last release to warrant a new one. Once this lands, let's do a new -savage release. Yes, that is my plan. There is a couple of

[PATCH] savage: Warn if broken drm maps are detected

2011-09-18 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Linux kernel 2.6.30 - 2.6.39 had broken drm maps which would result in assorted problems. Leave a message in the log if it looks like the framebuffer map and the aperture map are mixed up. https://bugs.freedesktop.org/show_bug.cgi?id=32511 Signed-off

[PATCH] savage: Fix Xv scaling on non-native resolutions

2011-09-17 Thread Tormod Volden
-by: Hans-Juergen Mauser hjmau...@gmx.net Reviewed-by: Tormod Volden debian.tor...@gmail.com --- src/savage_video.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/savage_video.c b/src/savage_video.c index 9f860c7..7d571ad 100644 --- a/src/savage_video.c +++ b

[PATCH] savage: Avoid unnecessary float calculation in video display

2011-09-17 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com There is no reason to do the division using floats as long as the result is an integer and there is no risk of intermediate overflow. This is in the code for Old chipsets. Integer division was already used in the parallel code for New chipsets. Also

Re: [PATCH] savage: Avoid unnecessary float calculation in video display

2011-09-17 Thread Tormod Volden
On Sat, Sep 17, 2011 at 1:03 PM, walter harms wrote:      if (S3_MOBILE_TWISTER_SERIES(psav-Chipset) -         psav-FPExpansion) { -        drw_w = (((float)(drw_w * psav-XExp1)/(float)psav-XExp2)+1); -        drw_h = (float)(drw_h * psav-YExp1)/(float)psav-YExp2+1; -        dstBox-x1 =

[PATCH] edid-decode: Be explicit about valid checksums

2011-08-29 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Also fix some formatting and typos. --- edid-decode.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index cb6fec2..923556a 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -219,7

[PATCH 1/4] savage: Fix logic in waitHSync

2011-04-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Bit-masking the result of a boolean negation seems pointless, so I guess this is what was intended: Only look at bit 0 of the inStatus result. Signed-off-by: Tormod Volden debian.tor...@gmail.com --- Hi, A few savage patches. Review is appreciated

[PATCH 2/4] savage: New SAVAGEDRIResume function

2011-04-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Move DRI stuff from savage_driver.c to savage_dri.c Signed-off-by: Tormod Volden debian.tor...@gmail.com --- This one should not change any behavior, but prepares for the next patch. It is very much modeled after the function structure of the radeon

[PATCH 3/4] savage: Factor out a SAVAGESetAgpMode and call it on resume

2011-04-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com This should fix resume with AGP. After all these years... https://bugzilla.kernel.org/show_bug.cgi?id=4607 Signed-off-by: Tormod Volden debian.tor...@gmail.com --- This was always the killer bug for my laptop. Wish I were 5 years earlier... It turned

[PATCH 4/4] savage: Make SAVAGESelectBuffer() private (static)

2011-04-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Also clean out some unused prototypes from savage_driver.h Signed-off-by: Tormod Volden debian.tor...@gmail.com --- Cheers, Tormod src/savage_dri.c|2 +- src/savage_driver.h | 14 -- 2 files changed, 1 insertions(+), 15

Re: [PATCH 1/4] savage: Fix logic in waitHSync

2011-04-20 Thread Tormod Volden
On Wed, Apr 20, 2011 at 11:36 PM, Matt Turner wrote: Man, somebody didn't know operator precedence. Probably good that git history doesn't go back that far. :) BTW, I just learned about -Wlogical-op (not part of -Wall) which unfortunately does not catch this issue. But it found some similar

[PATCH] savage: Fix / typo in magical register setup

2011-04-20 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Found with CFLAGS=-Wlogical-op Signed-off-by: Tormod Volden debian.tor...@gmail.com --- I hope I don't break the magic. BTW, LCD_ACTIVE is 0x02. src/savage_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src

Re: [PATCH] savage: More (intermediate) casts to silence warnings

2011-02-13 Thread Tormod Volden
On Sat, Feb 12, 2011 at 10:43 PM, Mark Kettenis wrote: This isn't really the right way to fix things.  At least the casts should use uintptr_t instead of int.  That way you won't truncate addresses on true 64-bit architectures.  Or just leave these warnings there as a reminder of the

Re: [PATCH 2/2] savage: Setup tiled surface registers in SavageEnterVT

2011-01-24 Thread Tormod Volden
On Sun, Jan 23, 2011 at 9:18 PM, Alex Deucher wrote: No, this is part of why UMS sucks.  During suspend the card is powered down, so on resume, the driver has to re-init everything.  All that has to happen in EnterVT.  All of your savage patches look good to me: Reviewed-by: Alex Deucher

[PATCH] savage: Add casts to silence build warnings

2011-01-23 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com savage_exa.c: In function ‘SavageUploadToScreen’: savage_exa.c:545: warning: passing argument 1 of ‘memcpy’ discards qualifiers from pointer target type /usr/include/bits/string3.h:49: note: expected ‘void * restrict’ but argument is of type ‘volatile

[PATCH] savage: Replace deprecated x(c)alloc/xfree with m/calloc/free

2011-01-23 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com sed -i 's/xalloc/malloc/g; s/xcalloc/calloc/g; s/xfree/free/g' Also replace xrealloc with realloc. --- src/savage_dga.c|6 ++-- src/savage_dri.c| 70 +- src/savage_driver.c | 22

[PATCH] savage: More (intermediate) casts to silence warnings

2011-01-23 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com savage_dga.c: In function ‘Savage_OpenFramebuffer’: savage_dga.c:393: warning: cast to pointer from integer of different size savage_dri.c: In function ‘SAVAGEDRIScreenInit’: savage_dri.c:924: warning: cast to pointer from integer of different size

[PATCH] savage: Drop unused variables and functions

2011-01-23 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Silence -Wall warnings. The functions are just #if'ed out, to be left for inspiration. --- src/savage_accel.c |3 ++- src/savage_cursor.c |2 ++ src/savage_exa.c|1 - src/savage_video.c |5 + 4 files changed, 5 insertions

[PATCH] savage: Cast all handles before printing them

2011-01-23 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Removes the last bunch of -Wall build warnings. savage_dri.c:490: warning: format ‘%08lx’ expects type ‘long unsigned int’, but argument 5 has type ‘drm_handle_t’ ... --- The remaining warnings that I see are more tricky, since

[PATCH 2/2] savage: Setup tiled surface registers in SavageEnterVT

2011-01-23 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com These registers are cleared after suspend/resume, so set them up again in EnterVT. --- Is there any other suitable function that is called on resume, where this can be placed? Similar things (registers) are set up in SavageInitialize2DEngine

[PATCH 1/2] savage: Factor out a SAVAGEDRISetupTiledSurfaceRegs function

2011-01-23 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com The tiled surface registers were only setup in SAVAGEDRIScreenInit, however, after suspend/resume these registers must be set up again. So factor it out in a new function so it can be reused. --- The follow-up patch will call this new function

Re: [PATCH build 2/2] Clean up all conditional statements.

2010-09-15 Thread Tormod Volden
On Wed, Sep 15, 2010 at 7:56 AM, Trevor Woerner wrote: -if [ $1 = lib ] [ $2 = libX11 ] [ x$USE_XCB = xNO ]; then +if [ $1 = lib ] [ $2 = libX11 ] [ x${USE_XCB} = xNO ]; then MOD_SPECIFIC=--with-xcb=no fi Any reason to not write just [ $USE_XCB = NO ] ? Then we could

Re: [PATCH build 2/2] Clean up all conditional statements.

2010-09-15 Thread Tormod Volden
On Wed, Sep 15, 2010 at 1:56 PM, Mikhail Gusarov wrote: $ echo $a $ [ zz = $a ] No problem with quotes, you can even put it the intuitive way with the variable first: $ [ $a = zz ] ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH build 2/2] Clean up all conditional statements.

2010-09-15 Thread Tormod Volden
---  build.sh |   65 ++---  1 files changed, 28 insertions(+), 37 deletions(-) diff --git a/build.sh b/build.sh index fa6a321..20aee43 100755 Reviewed-by: Tormod Volden lists.tor...@gmail.com On Wed, Sep 15, 2010 at 2:09 PM, Trevor Woerner

Re: Screen clearing issue when X starts

2009-04-22 Thread Tormod Volden
On Tue, Apr 21, 2009 at 9:36 AM, umang gupta umang@gmail.com wrote: X clears the contents of the framebuffer when it starts, so the display is briefly all black while X starts. Not so in recent xserver AFAICT, for instance the radeon driver was recently fixed to do the above:

Bug#520547: uses bogus panel information

2009-03-21 Thread Tormod Volden
Package: xserver-xorg-video-ati Version: 1:2.2.1-4 The problem appears if a savage laptop chipset is used without a connected LCD panel, for instance in small-form-factor PCs. The driver will extract sync range information from the panel information which is not valid. The fix has been applied

[PATCH] RV350: Add AGPMode quirk for Thinkpad

2009-03-05 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com Bug 15096 (and Ubuntu bug #195051) Signed-off-by: Tormod Volden debian.tor...@gmail.com --- src/radeon_dri.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/radeon_dri.c b/src/radeon_dri.c index 45f79ed..2b7540c 100644

[PATCH] Add AGP quirk for Sony Vaio.

2009-02-28 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com --- src/radeon_dri.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/radeon_dri.c b/src/radeon_dri.c index 7dfbdf2..03fbb8a 100644 --- a/src/radeon_dri.c +++ b/src/radeon_dri.c @@ -744,9 +744,11 @@ static

[PATCH] Janitor: cosmetic clean-up of AGPMode quirk table

2009-02-27 Thread Tormod Volden
From: Tormod Volden debian.tor...@gmail.com --- src/atipciids.h |2 ++ src/radeon_dri.c | 48 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/src/atipciids.h b/src/atipciids.h index 7735e93..4a829c8 100644 --- a/src

[PATCH] Add yet another AGP quirk for RV280

2009-01-13 Thread Tormod Volden
https://bugs.launchpad.net/bugs/312693 reported by warjowuch: AGPMode needed: 4 Model: Self-built computer, MSI K6V-LSR mobo, Sempron 2400+ Host Bridge: 00:00.0 Host bridge [0600]: VIA Technologies, Inc. VT8377 [KT400/KT600 AGP] Host Bridge [1106:3189] (rev 80) Graphics Card:

Bug#435040: xserver-xorg-video-ati: switching VT from console

2008-08-01 Thread Tormod Volden
There are plenty of people having this problem in Ubuntu as well, https://bugs.launchpad.net/bugs/148408, with some reports of old patches that works around it. ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org