Re: [PATCH] GLX: More clearly document the GLX protocol version handling

2009-10-01 Thread Peter Hutterer
On Thu, Oct 01, 2009 at 10:45:16AM -0700, Ian Romanick wrote: > From: Ian Romanick > > --- > glx/glxcmds.c |1 - > glx/glxdri2.c |6 ++ > glx/glxscreens.c| 12 ++-- > glx/glxscreens.h|9 + > include/protocol-ve

[PATCH] dix: force a minimum of 0 for screen coordinates.

2009-10-01 Thread Peter Hutterer
Currently the root coordinates may fall into ]-1..0] if the subpixel remainder is less than 0. Screen coordinates mustn't go below 0, so use miPointerSetPosition to cap off the remainder if the coordinates are below 0. This is cheating a bit, a more comprehensive solution to deal with subpixels co

[PATCH] configure: if xnest was requested but modules weren't found, fail.

2009-10-01 Thread Peter Hutterer
Tested-by: Xavier Chantry Signed-off-by: Peter Hutterer Acked-by: Julien Cristau --- build error fix. Missing check could have resulted in a build error if Xnest was explicitly enabled but the modules didn't meet the requirements. Will go into 1.7.0. configure.ac |3 +++ 1 files changed,

Re: xorg patent issues.

2009-10-01 Thread Corbin Simpson
On 10/01/2009 02:02 PM, Brian Paul wrote: > Greg KH wrote: >> On Thu, Oct 01, 2009 at 04:21:07PM -0400, Zack Rusin wrote: >>> On Thursday 01 October 2009 14:13:15 Greg KH wrote: Hi, As discussed at XDC2009 in your talk about patents and xorg, I talked with the Linux Foundation's

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-01 Thread Dan Nicholson
On Thu, Oct 1, 2009 at 7:54 AM, Julien Cristau wrote: > On Wed, Sep 30, 2009 at 11:34:52 -0700, Dan Nicholson wrote: > >> One thing I was hoping was not to have the options input from the >> device configuration again. Having people migrate their setups to hal >> was not fun, and now they'll have

Re: New release process for 1.8 (READ THIS)

2009-10-01 Thread Peter Hutterer
On Thu, Oct 01, 2009 at 08:04:08AM -0700, Daniel Stone wrote: > On Thu, Oct 01, 2009 at 01:36:39AM -0700, Jeremy Huddleston wrote: > > On Sep 30, 2009, at 19:43, Peter Hutterer wrote: > >> Question: tree on people.fdo or branch on the main repo? > >> branches on the main repo have the advantage of

Re: unwrapping inside the wrapper (xf86Rotate)

2009-10-01 Thread Keith Packard
Excerpts from Dave Airlie's message of Wed Sep 30 17:20:28 -0700 2009: > I just thought about this some more, if you have dynamic block handler > removal outside the block handler, won't the dynamically added/removed > handler always happen last i.e. after the driver one? No, the dynamically adde

Re: [PATCH] Remove static MAXSCREENS limit from Xext/shm.c.

2009-10-01 Thread Jamey Sharp
On Thu, Oct 1, 2009 at 3:08 PM, Keith Packard wrote: > Thanks for giving this a try. The canonical way to do this is to > allocate a screen private index and then allocate memory per-screen > instead of globally, ... Hmm. I think that's what I did? I followed the pattern in miext/damage/damage.c,

Problem in miClipPictureSrc?

2009-10-01 Thread Kim Woelders
Hello, Commit 128cd03eecacc6d5c5903d59a11966dcf3697bf1 causes trouble with clip regions in the e16 WM composite manager (e.g. during fade-out). The problems are fixed by attached patch. Not sure if this is the proper solution though... /Kim >From 48631edb0c008e960dd16c3fc1cddc2337327d00

Re: [PATCH] Remove static MAXSCREENS limit from Xext/shm.c.

2009-10-01 Thread Keith Packard
Excerpts from Jamey Sharp's message of Wed Sep 30 22:29:39 -0700 2009: > --- > Somebody at XDC today said that getting rid of the static MAXSCREENS > limit from the X server would be a Good Thing, and it looked like doing > that to Xext/shm.c would be pretty easy, so I tried it. Thanks for giving

Re: [PATCH] Re-fix DGA removal.

2009-10-01 Thread Keith Packard
Excerpts from Rémi Cardona's message of Thu Oct 01 01:25:25 -0700 2009: > > +if(!(pScreenPriv = (DGAScreenPtr)xalloc(sizeof(DGAScreenRec > ^^ > Isn't that useless these days? yeah, just minimizing code churn (that line was re-indented, but otherwise

Re: xorg patent issues.

2009-10-01 Thread Brian Paul
Greg KH wrote: > On Thu, Oct 01, 2009 at 04:21:07PM -0400, Zack Rusin wrote: >> On Thursday 01 October 2009 14:13:15 Greg KH wrote: >>> Hi, >>> >>> As discussed at XDC2009 in your talk about patents and xorg, I talked >>> with the Linux Foundation's Technical Advisory board about the issues >>> you

Re: xorg patent issues.

2009-10-01 Thread Greg KH
On Thu, Oct 01, 2009 at 04:21:07PM -0400, Zack Rusin wrote: > On Thursday 01 October 2009 14:13:15 Greg KH wrote: > > Hi, > > > > As discussed at XDC2009 in your talk about patents and xorg, I talked > > with the Linux Foundation's Technical Advisory board about the issues > > your raised in your

Re: xorg patent issues.

2009-10-01 Thread Zack Rusin
On Thursday 01 October 2009 14:13:15 Greg KH wrote: > Hi, > > As discussed at XDC2009 in your talk about patents and xorg, I talked > with the Linux Foundation's Technical Advisory board about the issues > your raised in your talk. > > I have a contact at the LF and OIN to put you in contact with

Re: [RFC PATCH] Only open the console if the video driver needs hardware access.

2009-10-01 Thread Mark Kettenis
> Date: Thu, 1 Oct 2009 11:50:42 -0700 > From: Jamey Sharp > > xf86OpenConsole fails as non-root, at least on Linux. Since the > xf86-video-dummy driver works fine without root privileges or console > access, just don't open the console. > --- > I wanted to see how to replace Xvfb and Xfake with

[RFC PATCH] Only open the console if the video driver needs hardware access.

2009-10-01 Thread Jamey Sharp
xf86OpenConsole fails as non-root, at least on Linux. Since the xf86-video-dummy driver works fine without root privileges or console access, just don't open the console. --- I wanted to see how to replace Xvfb and Xfake with an appropriate video driver for the xfree86 DDX, and needing root privile

xorg patent issues.

2009-10-01 Thread Greg KH
Hi, As discussed at XDC2009 in your talk about patents and xorg, I talked with the Linux Foundation's Technical Advisory board about the issues your raised in your talk. I have a contact at the LF and OIN to put you in contact with, but wanted to ask if there was anyone else that wanted in on the

Re: segfault after commit GLX: Enable GLX 1.4 on DRI2

2009-10-01 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Markus Amsler wrote: > After > > commit ad5c0d9efa47476ed5cf75c82265c73919e468b4 > Author: Ian Romanick > Date: Tue Sep 29 16:43:43 2009 -0700 > GLX: Enable GLX 1.4 on DRI2 > > I'm getting segfaults at server startup in glx/glxext.c:373: > >

Re: [PATCH] glx: fixup deref of null pointer when glx screen init fails.

2009-10-01 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dave Airlie wrote: > From: Dave Airlie > > I think this is what the original author wanted. > > Signed-off-by: Dave Airlie Acked-by: Ian Romanick I can't believe this got by Jesse and Kristian when they reviewed the original patch. I need to go

[PATCHv2] Remove static MAXSCREENS limit from Xext/shm.c.

2009-10-01 Thread Jamey Sharp
--- I didn't test my previous patch right. Sorry. This version doesn't seem to crash the server at startup. :-) Review would still be greatly appreciated. Xext/shm.c | 67 +++ 1 files changed, 49 insertions(+), 18 deletions(-) diff --git

[PATCH] GLX: More clearly document the GLX protocol version handling

2009-10-01 Thread Ian Romanick
From: Ian Romanick --- glx/glxcmds.c |1 - glx/glxdri2.c |6 ++ glx/glxscreens.c| 12 ++-- glx/glxscreens.h|9 + include/protocol-versions.h |2 +- 5 files changed, 22 insertions(+), 8 deletions(-) diff --

Re: xserver: Branch 'master'

2009-10-01 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Peter Hutterer wrote: > On Tue, Sep 29, 2009 at 04:49:57PM -0700, Ian Romanick wrote: >> glx/glxcmds.c| 11 --- >> glx/glxdri2.c| 14 ++ >> glx/glxext.c |8 +++- >> glx/glxscreens.c |7 --- >> glx/gl

Re: New release process for 1.8 (READ THIS)

2009-10-01 Thread Ping
On Wed, Sep 30, 2009 at 6:59 PM, Dave Airlie wrote: > On Wed, 2009-09-30 at 18:35 -0700, Daniel Stone wrote: > > Hi all, > > Following on from Peter's email about the 1.8/7.6 release process[0], we > > had a BoF about the same[1] at XDC. Everyone broadly agreed on the > > substance of Peter's m

Re: New release process for 1.8 (READ THIS)

2009-10-01 Thread Daniel Stone
On Thu, Oct 01, 2009 at 10:14:23AM +0200, Michel Dänzer wrote: > On Thu, 2009-10-01 at 11:59 +1000, Dave Airlie wrote: > > So I feel locking down master is going to get messy fast, I agree > > all major developments should be done on branches, but we have many > > incremental improvements in areas

Re: New release process for 1.8 (READ THIS)

2009-10-01 Thread Daniel Stone
Hi, On Thu, Oct 01, 2009 at 01:36:39AM -0700, Jeremy Huddleston wrote: > On Sep 30, 2009, at 19:43, Peter Hutterer wrote: >> Question: tree on people.fdo or branch on the main repo? >> branches on the main repo have the advantage of the commit list which >> provides some chance for patch review. >

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-01 Thread Julien Cristau
On Wed, Sep 30, 2009 at 11:34:52 -0700, Dan Nicholson wrote: > One thing I was hoping was not to have the options input from the > device configuration again. Having people migrate their setups to hal > was not fun, and now they'll have to do it again to udev rules files. > I have a couple patches

segfault after commit GLX: Enable GLX 1.4 on DRI2

2009-10-01 Thread Markus Amsler
After commit ad5c0d9efa47476ed5cf75c82265c73919e468b4 Author: Ian Romanick Date: Tue Sep 29 16:43:43 2009 -0700 GLX: Enable GLX 1.4 on DRI2 I'm getting segfaults at server startup in glx/glxext.c:373: for (p = __glXProviderStack; p != NULL; p = p->next) { __GLXscreen *

Re: [PATCH] dix: make input clipping respect subpixels (#24187)

2009-10-01 Thread Simon Thum
Peter Hutterer wrote: > /me goes and hides in the corner. Come on, it can't be that hard for us to come up with a fix less voluminous than a rewrite. If, and only if, a master dev is supposed to contain the cross-screen 'axis' range (which is the 'co-ord space limit'?) AND we want relative motion

Re: [PATCH] dix: make input clipping respect subpixels (#24187)

2009-10-01 Thread Peter Hutterer
On Thu, Oct 01, 2009 at 12:53:02PM +0200, Simon Thum wrote: > Peter Hutterer wrote: > > @@ -587,16 +587,41 @@ clipAxis(DeviceIntPtr pDev, int axisNum, int *val) > > > > /* If a value range is defined, clip. If not, do nothing */ > A nit: This is no longer true then. > > if (axis->max_va

Re: [PATCH] dix: make input clipping respect subpixels (#24187)

2009-10-01 Thread Simon Thum
Peter Hutterer wrote: > @@ -587,16 +587,41 @@ clipAxis(DeviceIntPtr pDev, int axisNum, int *val) > > /* If a value range is defined, clip. If not, do nothing */ A nit: This is no longer true then. > if (axis->max_value <= axis->min_value) > -return; > +{ > +/* Specia

Re: [PATCH] xkb: check permissions on XKM_OUTPUT_DIR

2009-10-01 Thread Peter Hutterer
On Thu, Oct 01, 2009 at 09:35:01AM +0200, Rémi Cardona wrote: > Le 29/09/2009 19:05, Nirbheek Chauhan a écrit : > > Checking just for root is insufficient since that does not guarantee > > write/read > > permissions in XKM_OUTPUT_DIR (for example with sandbox). > > > > Check if we can write a file

Re: New release process for 1.8 (READ THIS)

2009-10-01 Thread Jeremy Huddleston
On Sep 30, 2009, at 19:43, Peter Hutterer wrote: Development model: xserver master will be closed to general commits; it will be owned by the RM, or one of their delegates. Again, DO NOT COMMIT DIRECTLY TO XSERVER MASTER. Everyone should have their own xserver trees, and/or one per subsyste

Re: [PATCH] Re-fix DGA removal.

2009-10-01 Thread Rémi Cardona
Le 30/09/2009 20:40, Keith Packard a écrit : > Here's an updated patch -- removes the _X_INTERNAL from the .c files, > renames xf86DiDGAInit to _xf86_di_dga_init_internal, and renames > xf86DiDGAReInit to _xf86_di_dga_reinit_internal. > > Thanks for previous review. > > -keith > >> From 894680ec033

Re: New release process for 1.8 (READ THIS)

2009-10-01 Thread Michel Dänzer
On Thu, 2009-10-01 at 11:59 +1000, Dave Airlie wrote: > On Wed, 2009-09-30 at 18:35 -0700, Daniel Stone wrote: > > Hi all, > > Following on from Peter's email about the 1.8/7.6 release process[0], we > > had a BoF about the same[1] at XDC. Everyone broadly agreed on the > > substance of Peter's m

[PATCH] Remove static MAXSCREENS limit from Xext/shm.c.

2009-10-01 Thread Jamey Sharp
--- Somebody at XDC today said that getting rid of the static MAXSCREENS limit from the X server would be a Good Thing, and it looked like doing that to Xext/shm.c would be pretty easy, so I tried it. This is my first server patch, so review gratefully accepted. Xext/shm.c | 60 +++

Re: [PATCH] xkb: check permissions on XKM_OUTPUT_DIR

2009-10-01 Thread Rémi Cardona
Le 29/09/2009 19:05, Nirbheek Chauhan a écrit : > Checking just for root is insufficient since that does not guarantee > write/read > permissions in XKM_OUTPUT_DIR (for example with sandbox). > > Check if we can write a file, as well as read it later. Otherwise, invoke the > fallback to /tmp > > S