Re: [PATCH libX11] No need for req->firstKeyCode to be set twice.

2010-03-17 Thread Peter Hutterer
On Wed, Mar 17, 2010 at 11:53:16PM -0300, Fernando Carrijo wrote: > There is no reason to set req->firstKeyCode twice when a client, wishful > for changing keyboard mappings, calls XChangeKeyboardMapping. This patch > fixes the mistake by making no functional changes to libX11 whatsoever. > > Sign

[PATCH libX11] No need for req->firstKeyCode to be set twice.

2010-03-17 Thread Fernando Carrijo
There is no reason to set req->firstKeyCode twice when a client, wishful for changing keyboard mappings, calls XChangeKeyboardMapping. This patch fixes the mistake by making no functional changes to libX11 whatsoever. Signed-off-by: Fernando Carrijo --- src/SetPntMap.c |1 - 1 files changed,

Geode driver maintain

2010-03-17 Thread Huang, FrankR
Hi, all Since Jordan Crouse left AMD, the geode driver has not been maintained for quite a long time. Many bugs have been reported via the BTS on three linux distribution version. So we prepared to restart our work Jordan has left before. Torres Rigo and I(Frank Huang) want to catc

Re: [PATCH:xdm] Check for allowRootLogin on PAM and non-OpenBSD passwd authentication backends

2010-03-17 Thread Julien Cristau
On Tue, Mar 16, 2010 at 17:01:22 -0700, Alan Coopersmith wrote: > diff --git a/greeter/verify.c b/greeter/verify.c > index 73493ca..6e3f14b 100644 > --- a/greeter/verify.c > +++ b/greeter/verify.c > @@ -350,6 +350,16 @@ Verify (struct display *d, struct greet_info *greet, > struct verify_info *ve

Re: Help fixing csync output with video-ati

2010-03-17 Thread Fernando Carrijo
Hi Arvid! Arvid Brodin wrote: > Hello list-dwellers! > > I have a PAL TV hooked up via RGB to my graphics card. It needs > composite sync: > > $ ./xrandr --newmode "960x...@50i" 18.479 960 991 1078 1183 576 592 601 > 625 interlace -csync > > [+|-]csync is supported by the xrandr application, b

[PATCH app-xdm] lint: option -rdynamic is not valid for the lint program

2010-03-17 Thread Gaetan Nadon
Use xdm_LIBS instead. Tested on Solaris. Signed-off-by: Gaetan Nadon --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 7c1df5e..e59fb53 100644 --- a/Makefile.am +++ b/Makefile.am @@ -180,7 +180,7 @@ ALL_LINT_FLAGS=$(LINT_FLA

Re: Coding standards: Related bug workarounds

2010-03-17 Thread Gaetan Nadon
On Wed, 2010-03-17 at 14:14 +, Matej Urbas wrote: > Hi, > > I hope you don't mind me asking something like this here, but is there a > coding guideline for referencing bugs in related projects for which we > have to do a 'temporary' workaround in our project? > > Here is a description of wha

[PULL] Assorted build fixes

2010-03-17 Thread Yaakov (Cygwin/X)
Keith, This supersedes my previous pull request. It includes the four patches from that batch which were approved, and adds six more which were all just sent and reviewed. The XF86Bigfont warnings fixes will have to wait for now. The following changes since commit 67a8c659f25218904bae64aac6e9

Re: [RFC] Multitouch support, step one

2010-03-17 Thread Peter Hutterer
On Wed, Mar 17, 2010 at 07:58:08PM +0100, Benjamin Tissoires wrote: > Le 16/03/2010 02:58, Peter Hutterer a écrit : > >>An other point for keeping the valuator trackingID. Some device > >>(stantum and magicmouse) send a trackingID different than touch > >>point. i.e. the trackingID is between 1 and

Re: [RFC] Multitouch support, step one

2010-03-17 Thread Peter Hutterer
On Wed, Mar 17, 2010 at 11:51:17AM +0100, Henrik Rydberg wrote: > >> 2. Bandwidth reduction should be made as early as possible > >> > >> The MT events from the kernel are non-filtered, bypassing the normal input > >> filtering by necessity. Duplicating this behavior further into the food > >> cha

Re: [PATCH 6/6] Catch errors in recursive relink targets

2010-03-17 Thread Dan Nicholson
On Wed, Mar 17, 2010 at 3:41 PM, Yaakov (Cygwin/X) wrote: > From: Yaakov Selkowitz > > If make relink fails in a subdirectory, we need to catch the error > otherwise make will continue iterating the 'for' loop. > > Signed-off-by: Yaakov Selkowitz Reviewed-by: Dan Nicholson

Help fixing csync output with video-ati

2010-03-17 Thread Arvid Brodin
Hello list-dwellers! I have a PAL TV hooked up via RGB to my graphics card. It needs composite sync: $ ./xrandr --newmode "960x...@50i" 18.479 960 991 1078 1183 576 592 601 625 interlace -csync [+|-]csync is supported by the xrandr application, but not shown in 'xrandr --help' - also, all csync

[PATCH 6/6] Catch errors in recursive relink targets

2010-03-17 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz If make relink fails in a subdirectory, we need to catch the error otherwise make will continue iterating the 'for' loop. Signed-off-by: Yaakov Selkowitz --- hw/Makefile.am|2 +- hw/kdrive/Makefile.am |2 +- 2 files changed, 2 insertions(+), 2 deletions(-

Re: [PATCH 3/5] Fix relink targets for silent rules

2010-03-17 Thread Dan Nicholson
On Wed, Mar 17, 2010 at 2:43 PM, Julien Cristau wrote: > On Wed, Mar 17, 2010 at 15:11:08 -0500, Yaakov (Cygwin/X) wrote: > >> diff --git a/hw/Makefile.am b/hw/Makefile.am >> index 7409906..92b007a 100644 >> --- a/hw/Makefile.am >> +++ b/hw/Makefile.am >> @@ -38,4 +38,4 @@ SUBDIRS =              

Re: [PATCH] Do not trap access to timer and keyboard

2010-03-17 Thread Samuel Thibault
Adam Jackson, le Wed 17 Mar 2010 17:44:34 -0400, a écrit : > On Sat, 2010-03-13 at 02:26 +0100, Samuel Thibault wrote: > > -ioperm(0x40,4,0); /* trap access to the timer chip */ > > -ioperm(0x60,4,0); /* trap access to the keyboard controller */ > > I'm not sold on this. You really do not

Re: [PATCH] Fix x86emu builds when using non-gnu compilers

2010-03-17 Thread Matt Turner
On Fri, Mar 12, 2010 at 10:20 PM, Alan Coopersmith wrote: > Before this fix, the u64 type would not be defined, causing > x86emu/sys.c to fail to build: > "sys.c", line 102: syntax error before or at: ldq_u > "sys.c", line 102: syntax error before or at: * > > Since 64-bit types are now required b

Re: [PATCH] Fix x86emu builds when using non-gnu compilers

2010-03-17 Thread Adam Jackson
On Fri, 2010-03-12 at 18:20 -0800, Alan Coopersmith wrote: > Before this fix, the u64 type would not be defined, causing > x86emu/sys.c to fail to build: > "sys.c", line 102: syntax error before or at: ldq_u > "sys.c", line 102: syntax error before or at: * > > Since 64-bit types are now required

Re: [PATCH] Do not trap access to timer and keyboard

2010-03-17 Thread Adam Jackson
On Sat, 2010-03-13 at 02:26 +0100, Samuel Thibault wrote: > Some VESA BIOSes need to access to them. > > Signed-off-by: Samuel Thibault > --- > hw/xfree86/os-support/hurd/hurd_video.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/hw/xfree86/os-support/hurd/hurd_

Re: [PATCH 0/5] Various fixes for make relink, EXEEXT, SED

2010-03-17 Thread Julien Cristau
On Wed, Mar 17, 2010 at 15:11:05 -0500, Yaakov (Cygwin/X) wrote: > From: Yaakov Selkowitz > > Yaakov Selkowitz (5): > kdrive: Use $(MAKE) in relink rules > Use EXEEXT in relink rules for portable DDXs > Fix relink targets for silent rules > Respect value of SED from configure > Fix .ma

Re: [PATCH 3/5] Fix relink targets for silent rules

2010-03-17 Thread Julien Cristau
On Wed, Mar 17, 2010 at 15:11:08 -0500, Yaakov (Cygwin/X) wrote: > diff --git a/hw/Makefile.am b/hw/Makefile.am > index 7409906..92b007a 100644 > --- a/hw/Makefile.am > +++ b/hw/Makefile.am > @@ -38,4 +38,4 @@ SUBDIRS = \ > DIST_SUBDIRS = dmx xfree86 vfb xnest xwin xquartz kdriv

Re: [PATCH 0/5] Various fixes for make relink, EXEEXT, SED

2010-03-17 Thread Alan Coopersmith
For the series: Reviewed-by: Alan Coopersmith Yaakov (Cygwin/X) wrote: > From: Yaakov Selkowitz > > Yaakov Selkowitz (5): > kdrive: Use $(MAKE) in relink rules > Use EXEEXT in relink rules for portable DDXs > Fix relink targets for silent rules > Respect value of SED from configure >

Re: [PATCH 1/5] kdrive: Use $(MAKE) in relink rules

2010-03-17 Thread Mikhail Gusarov
Twas brillig at 15:11:06 17.03.2010 UTC-05 when yselkow...@users.sourceforge.net did gyre and gimble: Y(> From: Yaakov Selkowitz Reviewed-by: Mikhail Gusarov -- http://fossarchy.blogspot.com/ pgp17b1PYBTJG.pgp Description: PGP signature ___ x

[PATCH 5/5] Fix .man.N targets for AM_SILENT_RULES

2010-03-17 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz Add $(AM_V_GEN) for sed-based rules so they appear as expected with automake silent rules, and $(AM_V_at) to completely hide cp/ln/rm commands which are not prone to fail. Signed-off-by: Yaakov Selkowitz --- doc/Makefile.am |4 ++-- hw/dmx/Makefile.a

[PATCH 4/5] Respect value of SED from configure

2010-03-17 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz We now use libtool, which calls AC_PROG_SED and sets SED as the path to a fully-functional 'sed' (which may also be called 'gsed' if GNU sed is installed alongside a proprietary version). Therefore we should respect the value of SED so we are sure to use the correct one.

[PATCH 3/5] Fix relink targets for silent rules

2010-03-17 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz Add $(AM_V_at) to all relink make targets to silence them when automake silent rules are in use. Signed-off-by: Yaakov Selkowitz --- Makefile.am |2 +- hw/Makefile.am |2 +- hw/dmx/Makefile.am |2 +- hw/kdrive/Makefile.am

[PATCH 2/5] Use EXEEXT in relink rules for portable DDXs

2010-03-17 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz On Cygwin and MinGW, executables use the .exe suffix. Autoconf and automake set EXEEXT on these platforms, and leave it empty on others where no suffix is used. $(EXEEXT) must be appended to executable names in custom rules for portability: http://www.gnu.org/software/au

[PATCH 1/5] kdrive: Use $(MAKE) in relink rules

2010-03-17 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz Signed-off-by: Yaakov Selkowitz --- hw/kdrive/Makefile.am |2 +- hw/kdrive/ephyr/Makefile.am |2 +- hw/kdrive/fake/Makefile.am |2 +- hw/kdrive/fbdev/Makefile.am |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/kdrive/Makefil

[PATCH 0/5] Various fixes for make relink, EXEEXT, SED

2010-03-17 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz Yaakov Selkowitz (5): kdrive: Use $(MAKE) in relink rules Use EXEEXT in relink rules for portable DDXs Fix relink targets for silent rules Respect value of SED from configure Fix .man.N targets for AM_SILENT_RULES Makefile.am |2 +- cppr

Re: [RFC] Multitouch support, step one

2010-03-17 Thread Benjamin Tissoires
Le 16/03/2010 02:58, Peter Hutterer a écrit : An other point for keeping the valuator trackingID. Some device (stantum and magicmouse) send a trackingID different than touch point. i.e. the trackingID is between 1 and 255 on the stantum, and between 1 and 16 on the magic mouse. I don't know if th

[PATCH xserver] doc: specify 1.6.1 as the minimum version for doxygen.

2010-03-17 Thread Gaetan Nadon
Older versions generate filenames that are different from the ones listed in the Makefile. Signed-off-by: Gaetan Nadon --- configure.ac |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 0579551..78a871e 100644 --- a/configure.ac +++ b

Coding standards: Related bug workarounds

2010-03-17 Thread Matej Urbas
Hi, I hope you don't mind me asking something like this here, but is there a coding guideline for referencing bugs in related projects for which we have to do a 'temporary' workaround in our project? Here is a description of what I mean -- using a (hypothetical) example: int a = getSomeNumber()

Re: [RFC] Multitouch support, step one

2010-03-17 Thread Henrik Rydberg
Peter Hutterer wrote: > On Tue, Mar 16, 2010 at 02:42:15PM +0100, Henrik Rydberg wrote: [...] >> 1. Consistent behavior for all devices >> >> The hardware stack supporting multitouch is diverse, and several different >> mechanisms and abstraction levels exists. The tracking ID is a good example. >

[PATCH v2] os: Prevent backtrace from being stopped in noreturn functions.

2010-03-17 Thread Rami Ylimaki
There are two noreturn functions in the X server: FatalError and AbortServer. Having any of those two functions in the middle of a call stack will prevent unwinding the program properly and stops the backtrace at those functions in gdb. The file containing FatalError and AbortServer, os/log.c, has

Re: [RFC] Multitouch support, step one

2010-03-17 Thread Henrik Rydberg
Daniel Stone wrote: > Hi, > > On Mon, Mar 15, 2010 at 03:41:24PM +0100, Henrik Rydberg wrote: >>> Multi-touch as defined in this proposal is limited to single input-point >>> multi-touch. This is suitable for indirect touch devices (e.g. touchpads) >>> and partially suited for direct touch devices

Re: [PATCH synaptics] After closing the fd, reset it to -1.

2010-03-17 Thread Julien Cristau
On Wed, Mar 17, 2010 at 13:56:15 +1000, Peter Hutterer wrote: > A DeviceOff() followed by DeviceClose() (which calls DeviceOff()) would try > to close the fd twice, in addition to calling various hooks. > > Signed-off-by: Peter Hutterer Reviewed-by: Julien Cristau Cheers, Julien signature.a