Re: Live builds (was: Merged proto package)

On Sun, Apr 18, 2010 at 2:17 PM, Keith Packard wrote: > On Fri, 16 Apr 2010 21:57:47 +0200, wrote: > >> I don't see why other distributions can't provide something similar. >> Even without true live bulids, IMHO this makes the whole point about >> xserver being too hard to build pretty moot. > >

Re: Merged proto package

On Fri, 16 Apr 2010 22:45:02 +0200, wrote: > Hi, > > On Tue, Apr 06, 2010 at 06:43:22PM -0700, Keith Packard wrote: > > > This isn't a git super-module, > > Well, why not? I don't think the wire protocol is a place where we should be encouraging a mix-n-match approach to development or release

Re: Live builds (was: Merged proto package)

On Fri, 16 Apr 2010 21:57:47 +0200, wrote: > I don't see why other distributions can't provide something similar. > Even without true live bulids, IMHO this makes the whole point about > xserver being too hard to build pretty moot. Not really; except for Gentoo, all these kinds of builds ever se

Re: [PATCH] xfree86: check for NULL pointer before dereferences it in parser code

On Fri, 16 Apr 2010 18:42:19 +0300, Tiago Vignatti wrote: > - if (!name || name[0] == '.' || len <= suflen) > + if (!name) > + return 0; > + > + name = de->d_name; You might want to assign name before testing it. -- keith.pack...@intel.com pgp5WPTiJ9EYn.pgp Descripti

[PATCH input-evdev 10/10] man: Use Autoconf provided $(AM_V_GEN)$(SED)

Enables silent rule and use platform appropriate version of sed. Signed-off-by: Gaetan Nadon --- man/Makefile.am |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/man/Makefile.am b/man/Makefile.am index 66c207f..4edafaa 100644 --- a/man/Makefile.am +++ b/man/Makefile.am

[PATCH input-evdev 09/10] include: EXTRA_DIST is not required for header files.

The sdk_HEADERS is sufficient as the "sdk" prefix matches the "dir" suffix in the "sdkdir" variable. Signed-off-by: Gaetan Nadon --- include/Makefile.am |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/Makefile.am b/include/Makefile.am index 58d7c39..0e3fc1b 10064

[PATCH input-evdev 08/10] config: fix warnings, m4 quoting and layout

Fix some m4 quoting Fix some autoconf warnings remove AC_PROG_CC as it overrides AC_PROG_C_C99 from XORG_DEFAULT_OPTIONS Regroup statements per section Add comments Upgrade X.Org macros to 1.4 for INSTALL file copying Signed-off-by: Gaetan Nadon --- configure.ac | 43 ++

[PATCH input-evdev 07/10] config: optional extension check for inputproto not required

The check should be in PKG_CHECK_MODULES permanently. The XORG_DRIVER_CHECK_EXT will add inputproto to PKG_CHECK_MODULES only if the extension is available. By definition, this extension is always available and the evdev driver cannot function without it. This is evidenced by the absence of XINPU

[PATCH input-evdev 06/10] config: replace deprecated INCLUDES with AM_CPPFLAGS

Signed-off-by: Gaetan Nadon --- src/Makefile.am |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 4f0937e..a5c89ac 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -26,13 +26,12 @@ # TODO: -nostdlib/-Bstatic/-lgcc platform mag

[PATCH input-evdev 05/10] config: refactor and comment the sdkdir distcheck workaround

Seperate legitimate sdkdir usage from distcheck workaround. Comment this non obvious workaround. Signed-off-by: Gaetan Nadon --- Makefile.am |2 +- configure.ac | 14 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Makefile.am b/Makefile.am index 47d5e78..00

[PATCH input-evdev 04/10] config: remove unrequired AC_HEADER_STDC

Autoconf says: "This macro is obsolescent, as current systems have conforming header files. New programs need not use this macro". Signed-off-by: Gaetan Nadon --- configure.ac |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 9bce2f0..b1

[PATCH input-evdev 03/10] replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS

Regroup AC statements at the top. Signed-off-by: Gaetan Nadon --- configure.ac |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 2e894cd..9bce2f0 100644 --- a/configure.ac +++ b/configure.ac @@ -27,9 +27,10 @@ AC_INIT([xf86-input-evdev

[PATCH input-evdev 02/10] config: update AC_PREREQ statement to 2.60

Unrelated to the previous patches, the new value simply reflects the reality that the minimum level for autoconf to configure all x.org modules is 2.60 dated June 2006. ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz Signed-off-by: Gaetan Nadon --- configure.ac |2 +- 1 files changed, 1

[PATCH input-evdev 01/10] config: remove AH_TOP autoheader statement

The generated config.h does not need to include xorg-server.h for the content it provides. Add #include in .[hc] files as needed. Signed-off-by: Gaetan Nadon --- configure.ac |1 - src/evdev.c |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure

[PATCH input-evdev 00/10] Configuration upgrades

Patch #1 concept has been reviewed but code is different Patch #7 is a change that has not been reviewed in other patches yet. Other changes have been reviewed in other patches Gaetan Nadon (10): config: remove AH_TOP autoheader statement config: update AC_PREREQ statement to 2.60 replace de

Re: Bell confusion with master vs. slave devices in Xorg 1.7.6

On Fri, 16 Apr 2010, Alan Coopersmith wrote: > Several users have complained to me about their X server bells on > recent builds of OpenSolaris - definitely with Xorg 1.7.x releases, > I don't know if it affected Xorg 1.6.x before that as well. > > The complaints I've gotten are two-fold: the bel

[PATCH] xkb: Fix omissions in geometry initialization #27679

_XkbCopyGeom did not copy all of the data from the source geometry. This resulted in failures when trying to obtain the keymap from a server where the default geometry has not been replaced by a custom configuration. Signed-off-by: Dirk Wallenstein --- xkb/xkbUtils.c | 41 +

Re: Merged proto package

Hi, On Wed, Apr 07, 2010 at 11:02:47AM -0700, Keith Packard wrote: > On Wed, 07 Apr 2010 10:02:54 -0400, Gaetan Nadon > > wrote: > > It may provide the best of both worlds, retaining the desired level > > of granularity while distributing a small number of packages. > > I don't want to deliver

Live builds (was: Merged proto package)

Hi, On Wed, Apr 07, 2010 at 11:32:21AM -0500, Donnie Berkholz wrote: > On 23:14 Tue 06 Apr , Keith Packard wrote: > > The people we're trying to reach with this are those people building > > From source. > > > > For people like me, who really can't rely on a distribution to be up > > to date

The meaning of STABLE (was: X server 1.9 release thoughts)

Hi, On Tue, Apr 06, 2010 at 02:43:01PM -0700, Jeremy Huddleston wrote: > On Apr 6, 2010, at 11:47, Daniel Stone wrote: >> Er, is there no reason hardware enable (even if it's not entirely >> fully-featured) can't be done in point releases? > > Yeah, I thought the 6-week point release schedule was

Re: Merged proto package

Hi, On Tue, Apr 06, 2010 at 06:43:22PM -0700, Keith Packard wrote: > This isn't a git super-module, Well, why not? -antrik- ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH] exa: don't need to check for NULL pointer if we already assumed it has a value

On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti wrote: > the alternative would be to check ps in the beginning of the function. > > Signed-off-by: Tiago Vignatti > --- >  exa/exa.c |    2 -- >  1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/exa/exa.c b/exa/exa.c > index 590d9a5

Re: [PATCH] exa: check for NULL pointer before dereferences it

On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Reviewed-by: Dan Nicholson ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/

Re: [PATCH] mi: check for NULL pointer before dereferences it in miPointerSetPosition

On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Reviewed-by: Dan Nicholson ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/

Re: [PATCH] xkb: check for NULL pointer before dereferences it in XkbWriteXKBSymbols

On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Looking at the xkb coding style again makes me want to drink bleach. Reviewed-by: Dan Nicholson ___ xorg-devel@lists.x.org: X.Org development Archives: http://list

Re: [PATCH] dix: check for NULL pointer before dereferences it in DeviceEnterLeaveEvent

On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti wrote: > Both mouse and mouse->button are already used before their checking were being > performed. So check on the beginning. > > Signed-off-by: Tiago Vignatti Reviewed-by: Dan Nicholson ___ xorg-devel

Re: [PATCH] Xi: check for NULL pointer before dereferences it in ListButtonInfo

On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti wrote: > Both dev and dev->button are already used before their checking were being > performed. So check on the beginning. > > Signed-off-by: Tiago Vignatti > --- >  Xi/xiquerydevice.c |    5 - >  1 files changed, 4 insertions(+), 1 deletions(-

Re: [PATCH] Xi: check for NULL pointer before dereferences it in DeviceFocusEvent

On Fri, Apr 16, 2010 at 8:42 AM, Tiago Vignatti wrote: > Both mouse and mouse->button are already used before their checking were being > performed. So check on the beginning. > > Signed-off-by: Tiago Vignatti > --- >  Xi/exevents.c |    4 +++- >  1 files changed, 3 insertions(+), 1 deletions(-)

Re: [PATCH] Xi: fix not reached code in XSendExtensionEvent

On Fri, Apr 16, 2010 at 7:24 AM, Tiago Vignatti wrote: > Error was introduced in 31a7994a. > > Signed-off-by: Tiago Vignatti > --- >  Xi/sendexev.c |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/Xi/sendexev.c b/Xi/sendexev.c > index 8629dd2..bd96d74 100644 > --- a

Re: [PATCH] xfree86: fix not reached code in parser

On Fri, Apr 16, 2010 at 7:24 AM, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- >  hw/xfree86/parser/read.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/xfree86/parser/read.c b/hw/xfree86/parser/read.c > index 1091be5..4e42b24 100644 > --- a/hw/