Re: [PATCH] dri2: Copy front to fake front in swapbuffer

2010-05-10 Thread Pauli Nieminen
Fixing Keith's address. 2010/5/11 Pauli Nieminen : > 2010/5/10 Kristian Høgsberg : >> If we don't have a fake front, nothing will happen.  The fix was extracted >> from a bigger patch from Francisco Jerez. >> >> https://bugs.freedesktop.org/show_bug.cgi?id=27305 >> Signed-off-by: Kristian Høgsberg

Re: [PATCH] dri2: Copy front to fake front in swapbuffer

2010-05-10 Thread Pauli Nieminen
2010/5/10 Kristian Høgsberg : > If we don't have a fake front, nothing will happen.  The fix was extracted > from a bigger patch from Francisco Jerez. > > https://bugs.freedesktop.org/show_bug.cgi?id=27305 > Signed-off-by: Kristian Høgsberg Reviewed-by: Pauli Nieminen ___

Re: [PATCH] xf86ActivateDevice(): Add "Device Node" property to input devices

2010-05-10 Thread Peter Hutterer
On Wed, May 05, 2010 at 01:56:46PM +0200, Peter Korsgaard wrote: > > "Julien" == Julien Cristau writes: > > Hi, > > >> Add "Device Node" xinput property containing the device node path to > >> all input devices with a device property. This is useful to figure out > >> the relation between

[PULL] dga crasher fix

2010-05-10 Thread Peter Hutterer
(trying again, this time with a subject) Keith, Please pull the patch below into master, it fixes a crasher with DGA for floating slave devices. The following changes since commit 758b8614477b53dc3de2b884fec5ccaf8a736432: David James (1): Fix wrong bracket values when startOver = FALSE

[no subject]

2010-05-10 Thread Peter Hutterer
Keith, Please pull the patch below into master, it fixes a crasher with DGA for floating slave devices. The following changes since commit 758b8614477b53dc3de2b884fec5ccaf8a736432: David James (1): Fix wrong bracket values when startOver = FALSE. are available in the git repository at:

[PATCH input-acecad] config: acecad does not use the input protocol

2010-05-10 Thread Gaetan Nadon
There is no need to PKG_CHECK_MODULES inputproto Signed-off-by: Gaetan Nadon --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 1121e29..34ea96f 100644 --- a/configure.ac +++ b/configure.ac @@ -55,7 +55,7 @@ AC_CHECK_LIB([

Re: please test: Xlib/XCB fixes

2010-05-10 Thread Jamey Sharp
I guess I'm not going to get much review or testing of these patches while they're on a branch, so I've just pushed them to libX11 master. I've been running libX11 patched this way for about three weeks with no apparent problems, and the patches make multi-threaded ico completely work as far as I c

Re: [PATCH] Update list of supported platforms in configure.ac error message

2010-05-10 Thread Gaetan Nadon
On Mon, 2010-05-10 at 13:50 -0700, Alan Coopersmith wrote: > Adds DragonFly BSD, OpenSolaris, & GNU Hurd. > Drops MacOS X, since this is in the section specific to the Xorg/XFree86 DDX. > (Matches the OS patterns the configure script checks for.) > > Also uses m4 macros to fix the spacing/formatt

Re: Multitouch wiki pages?

2010-05-10 Thread Peter Hutterer
On Mon, May 10, 2010 at 09:13:21AM +0300, Micki Balanga wrote: > I had support to the driver not to the server. > Can You send me information or relevant link of the discussion > To implement the MT protocol into server so I can share my thought > And knowledge and participate in the discussion

Re: [PATCH] xserver/Xext/sync.c: Fix wrong bracket values when startOver = FALSE (Bug 27023)

2010-05-10 Thread David James
On Mon, May 10, 2010 at 1:52 PM, Keith Packard wrote: > On Fri, 12 Mar 2010 10:45:22 -0800, David James wrote: > >> Currently, the SyncComputeBracketValues function in >> xserver/Xext/sync.c calculates bracket values incorrectly when >> startOver = FALSE. I have attached a patch to fix this. > >

Re: [PATCH] xserver/Xext/sync.c: Fix wrong bracket values when startOver = FALSE (Bug 27023)

2010-05-10 Thread Keith Packard
On Fri, 12 Mar 2010 10:45:22 -0800, David James wrote: > Currently, the SyncComputeBracketValues function in > xserver/Xext/sync.c calculates bracket values incorrectly when > startOver = FALSE. I have attached a patch to fix this. I'll need a Signed-off-by: line to merge this patch into the ser

[PATCH] Update list of supported platforms in configure.ac error message

2010-05-10 Thread Alan Coopersmith
Adds DragonFly BSD, OpenSolaris, & GNU Hurd. Drops MacOS X, since this is in the section specific to the Xorg/XFree86 DDX. (Matches the OS patterns the configure script checks for.) Also uses m4 macros to fix the spacing/formatting of the resulting message. Signed-off-by: Alan Coopersmith --- c

Re: [PULL] getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Keith Packard
On Mon, 10 May 2010 09:21:53 -0700, Keith Packard wrote: > On Mon, 10 May 2010 14:30:12 +0700, Mikhail Gusarov > wrote: > > > Mikhail Gusarov (6): > > Clean {X,XNF}{alloc,calloc,realloc,free,strdup} from pre-C89 baggage > > Document allocation functions, noting deviations from C lib

Re: [PATCH 3/4] Create separate private key for midispcur cursor bits

2010-05-10 Thread Keith Packard
On Mon, 10 May 2010 14:05:42 +1000, Daniel Stone wrote: > I guess using array indexing rather than pointer arithmetic just isn't > manly enough? :) Yeah, the local style and all. In any case, it all goes away in a commit further along the sequence. -- keith.pack...@intel.com pgpdLz4JnHJXp.pg

Re: [PATCH] xserver/Xext/sync.c: Fix wrong bracket values when startOver = FALSE (Bug 27023)

2010-05-10 Thread Adam Jackson
On Fri, 2010-03-12 at 10:45 -0800, David James wrote: > Currently, the SyncComputeBracketValues function in > xserver/Xext/sync.c calculates bracket values incorrectly when > startOver = FALSE. I have attached a patch to fix this. Man, this code is subtle. Reviewed-by: Adam Jackson - ajax sig

Re: [PATCH] render: Avoid infinite loops in alpha map handling (#23581)

2010-05-10 Thread Keith Packard
On Mon, 10 May 2010 15:34:53 -0400, Adam Jackson wrote: > Don't allow setting the alpha map of a picture to itself, or to a > picture that already has an alpha map, to prevent cycles. > > Signed-off-by: Adam Jackson I'd say that setting an alpha-map to a picture with an alpha-map should use tha

Re: [PATCH 3/4] Create separate private key for midispcur cursor bits

2010-05-10 Thread Keith Packard
On Mon, 10 May 2010 20:05:56 +0300, Tiago Vignatti wrote: > Why increase the number of privates for mandatory components on Xorg? I guess > the idea, which should be stated very loud, is to extensions and drivers only > use private mechanism. The mi software cursor code (mipointer, misprite, mi

[PATCH] render: Avoid infinite loops in alpha map handling (#23581)

2010-05-10 Thread Adam Jackson
Don't allow setting the alpha map of a picture to itself, or to a picture that already has an alpha map, to prevent cycles. Signed-off-by: Adam Jackson --- render/picture.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/render/picture.c b/render/picture.c index 48693

Re: [PATCH 05/14] miPolyPoint bugfix: Check memory allocation before changing the GC.

2010-05-10 Thread Adam Jackson
On Mon, 2010-05-10 at 11:41 -0700, Jamey Sharp wrote: > On Mon, May 10, 2010 at 8:18 AM, Adam Jackson wrote: > > On Sat, 2010-05-08 at 16:39 -0700, Jamey Sharp wrote: > >> miPolyPoint ought to leave the GC unchanged even if it fails. > > > > We have a new winner for the oldest-bug competition! It

[PULL] reviewed cleanups and oldest-bug fix

2010-05-10 Thread Jamey Sharp
Hi Keith, The following changes since commit 946f664b6ab421f69df3dc3213b14b085424c9e4: Adam Jackson (1): mi: Delete wide ellipse arc cache are available in the git repository at: git://people.freedesktop.org/~jamey/xserver for-keith Jamey Sharp (4): Expand macros that are used

Re: [PATCH 05/14] miPolyPoint bugfix: Check memory allocation before changing the GC.

2010-05-10 Thread Jamey Sharp
On Mon, May 10, 2010 at 8:18 AM, Adam Jackson wrote: > On Sat, 2010-05-08 at 16:39 -0700, Jamey Sharp wrote: >> miPolyPoint ought to leave the GC unchanged even if it fails. > > We have a new winner for the oldest-bug competition!  It's actually been > like that since X11R1: > > -rw-r--r--. 1 ajax

Re: [PATCH 1/4] Nuke RCS tags

2010-05-10 Thread Jamey Sharp
For this series: Reviewed-by: Jamey Sharp On Mon, May 10, 2010 at 8:52 AM, Mikhail Gusarov wrote: > Signed-off-by: Mikhail Gusarov > --- >  include/X11/fonts/fontenc.h |    2 -- >  src/encparse.c              |    3 --- >  src/fontenc.c               |    3 --- >  src/fontencI.h              |

Re: [PATCH] vfb: Remove dead variable and header file

2010-05-10 Thread Jamey Sharp
Reviewed-by: Jamey Sharp On Mon, May 10, 2010 at 8:48 AM, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- >  hw/vfb/InitInput.c |    2 - >  hw/vfb/Makefile.am |    1 - >  hw/vfb/lk201kbd.h  |  158 > >  3 files changed, 0 insertions(+

Re: [PATCH 3/4] Create separate private key for midispcur cursor bits

2010-05-10 Thread Tiago Vignatti
Hi, On Sat, May 08, 2010 at 08:19:20AM +0200, ext Keith Packard wrote: > The CursorScreenKey array is supposed to be used by the DDX for cursor > private data, but midispcur was abusing it to hold cursor bits private > information. Create a separate set of privates for the dispcur cursor > bits in

Re: [PULL] getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Keith Packard
On Mon, 10 May 2010 14:30:12 +0700, Mikhail Gusarov wrote: > Mikhail Gusarov (6): > Clean {X,XNF}{alloc,calloc,realloc,free,strdup} from pre-C89 baggage > Document allocation functions, noting deviations from C library This documents that Xstrdup and XNFstrdup accept NULL, when the

Re: [PATCHv2 1/4] dix: Update element count in FreeResource*()

2010-05-10 Thread Keith Packard
On Mon, 10 May 2010 07:33:21 -0400, Kristian Høgsberg wrote: > I can certainly do that. Something like this look ok? Yeah, this looks fine. Reviewed-by: Keith Packard -- keith.pack...@intel.com pgp6DzSnIcaVm.pgp Description: PGP signature ___ x

Re: [PULL libfontenc] Demacrofication

2010-05-10 Thread Mikhail Gusarov
Twas brillig at 04:08:38 08.05.2010 UTC+07 when dotted...@dottedmag.net did gyre and gimble: MG> The following changes since commit 3e00a8c322ea5fd8ea21f83f5861c59aa91ce341: MG> Gaetan Nadon (1): MG> config: update AC_PREREQ statement to 2.60 MG> are available in the git repositor

[PATCH 3/4] Expand xalloc/xrealloc/xfree macros

2010-05-10 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov --- src/encparse.c | 75 +++- src/fontenc.c | 20 ++ 2 files changed, 45 insertions(+), 50 deletions(-) diff --git a/src/encparse.c b/src/encparse.c index 27215df..5e31d9d 100644 --- a/src/encpars

[PATCH 4/4] Nuke unnecessary casts

2010-05-10 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov --- src/encparse.c | 35 --- src/fontenc.c |2 +- 2 files changed, 17 insertions(+), 20 deletions(-) diff --git a/src/encparse.c b/src/encparse.c index 5e31d9d..b288c8c 100644 --- a/src/encparse.c +++ b/src/encparse.c @@ -422,

[PATCH 2/4] unifdef FONTENC_NO_LIBFONT

2010-05-10 Thread Mikhail Gusarov
This symbol was unconditionally defined in Makefile Signed-off-by: Mikhail Gusarov --- src/Makefile.am |3 +-- src/encparse.c |9 - src/fontenc.c |9 - 3 files changed, 1 insertions(+), 20 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 97111ee..9

[PATCH 1/4] Nuke RCS tags

2010-05-10 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov --- include/X11/fonts/fontenc.h |2 -- src/encparse.c |3 --- src/fontenc.c |3 --- src/fontencI.h |2 -- 4 files changed, 0 insertions(+), 10 deletions(-) diff --git a/include/X11/fonts/fontenc.h b/include/X1

[PATCH] vfb: Remove dead variable and header file

2010-05-10 Thread Adam Jackson
Signed-off-by: Adam Jackson --- hw/vfb/InitInput.c |2 - hw/vfb/Makefile.am |1 - hw/vfb/lk201kbd.h | 158 3 files changed, 0 insertions(+), 161 deletions(-) delete mode 100644 hw/vfb/lk201kbd.h diff --git a/hw/vfb/InitInput.c b/hw/

Re: [PATCH input-evdev] make: remove block comment no longer applicable

2010-05-10 Thread Adam Jackson
On Mon, 2010-05-10 at 11:16 -0400, Gaetan Nadon wrote: > On Mon, 2010-05-10 at 10:32 -0400, Adam Jackson wrote: > > On Fri, 2010-05-07 at 20:45 -0400, Gaetan Nadon wrote: > > > The comment implies there are numerous items left to do. > > > The definition of compiler/linker/libtool options > > > ar

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Adam Jackson
On Mon, 2010-05-10 at 07:17 -0700, Alan Coopersmith wrote: > Tiago Vignatti wrote: > > On 05/08/2010 01:23 PM, Matthieu Herrb wrote: > >> If someone wants to be able to experiment with different malloc > >> implementations in X, then we should keep wrappers to make it easier. > > > > then ld's our

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Alan Coopersmith
Mikhail Gusarov wrote: > Twas brillig at 07:19:51 10.05.2010 UTC-07 when alan.coopersm...@oracle.com > did gyre and gimble: > > AC> While I've been looking at the pull requests, I'd also prefer > AC> patches to the list for all X.Org modules (and am not the only > AC> person who should be look

Re: [PATCH 05/14] miPolyPoint bugfix: Check memory allocation before changing the GC.

2010-05-10 Thread Adam Jackson
On Sat, 2010-05-08 at 16:39 -0700, Jamey Sharp wrote: > miPolyPoint ought to leave the GC unchanged even if it fails. Probably > nobody has ever seen it fail--this bug has been in X.org since at least > the beginning of git history--but might as well fix it. We have a new winner for the oldest-bug

Re: [PATCH input-evdev] make: remove block comment no longer applicable

2010-05-10 Thread Gaetan Nadon
On Mon, 2010-05-10 at 10:32 -0400, Adam Jackson wrote: > On Fri, 2010-05-07 at 20:45 -0400, Gaetan Nadon wrote: > > The comment implies there are numerous items left to do. > > The definition of compiler/linker/libtool options > > are usually not documented in the makefile. > > Hah. I wrote most

Re: [PATCH 03/14] miwideline: Factor out span buffer allocation.

2010-05-10 Thread Adam Jackson
On Sat, 2010-05-08 at 16:39 -0700, Jamey Sharp wrote: > Signed-off-by: Jamey Sharp I suspect that, at one point in time, this may have been manually inlined for performance. Not that I care, just that it's likely. Might be good to compare runs of x11perf -wline{10,100,500}. Of course, in that

Re: [PATCH 5/5] Replace dixChangeGC with calls directly to the right variant.

2010-05-10 Thread Adam Jackson
On Fri, 2010-05-07 at 20:24 -0700, Jamey Sharp wrote: > Signed-off-by: Jamey Sharp Reviewed-by: Adam Jackson - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lis

Re: [PATCH 2/5] Kill ChangeGC in favor of dixChangeGC.

2010-05-10 Thread Adam Jackson
On Fri, 2010-05-07 at 20:23 -0700, Jamey Sharp wrote: > diff --git a/dix/dixfonts.c b/dix/dixfonts.c > index 6dc8193..7dbccaf 100644 > --- a/dix/dixfonts.c > +++ b/dix/dixfonts.c > @@ -1261,7 +1261,7 @@ doPolyText(ClientPtr client, PTclosurePtr c) > { > if (pFont != c->pGC-

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Mikhail Gusarov
Twas brillig at 07:19:51 10.05.2010 UTC-07 when alan.coopersm...@oracle.com did gyre and gimble: AC> While I've been looking at the pull requests, I'd also prefer AC> patches to the list for all X.Org modules (and am not the only AC> person who should be looking at library patches, even if I'

Re: [PATCH input-evdev] make: remove block comment no longer applicable

2010-05-10 Thread Adam Jackson
On Fri, 2010-05-07 at 20:45 -0400, Gaetan Nadon wrote: > The comment implies there are numerous items left to do. > The definition of compiler/linker/libtool options > are usually not documented in the makefile. Hah. I wrote most of that, for the video drivers, where you really do have to install

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Alan Coopersmith
Mikhail Gusarov wrote: > Twas brillig at 08:58:07 10.05.2010 UTC+10 when peter.hutte...@who-t.net did > gyre and gimble: > > PH> Please send patches to the list, it'd make it a lot easier to > PH> review than having to copy from the repo. > > [/me notes: X server patches to list, libraries usu

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Alan Coopersmith
Tiago Vignatti wrote: > On 05/08/2010 01:23 PM, Matthieu Herrb wrote: >> If someone wants to be able to experiment with different malloc >> implementations in X, then we should keep wrappers to make it easier. > > then ld's our friend and let us do this in a cleaner way: > > http://people.freedes

[PATCH] dri2: Copy front to fake front in swapbuffer

2010-05-10 Thread Kristian Høgsberg
If we don't have a fake front, nothing will happen. The fix was extracted from a bigger patch from Francisco Jerez. https://bugs.freedesktop.org/show_bug.cgi?id=27305 Signed-off-by: Kristian Høgsberg --- hw/xfree86/dri2/dri2.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-)

[PATCHv2 1/4] dix: Update element count in FreeResource*()

2010-05-10 Thread Kristian Høgsberg
FreeResource() keeps clientTable[cid].elements up to date with the number of resources allocated to the client. The other free resource functions (FreeResourceByType(), FreeClientNeverRetainResources() and FreeClientResources()) don't maintain this invariant. Typically, the only consequence is th

[PULL] getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Mikhail Gusarov
The following changes since commit 946f664b6ab421f69df3dc3213b14b085424c9e4: mi: Delete wide ellipse arc cache (2010-05-07 22:03:09 -0700) are available in the git repository at: git://anongit.freedesktop.org/~dottedmag/xserver no-xalloc Mikhail Gusarov (6): Clean {X,XNF}{alloc,callo

Re: Multitouch wiki pages?

2010-05-10 Thread Henrik Rydberg
Rafi Rubin wrote: [..] > We should probably have a link to Henrik's kernel mt protocol doc > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/input/multi-touch-protocol.txt;hb=HEAD This is the official version tree, which ought to be the best link for the

Re: RFC: getting rid of Xalloc/Xfree/... in server

2010-05-10 Thread Peter Hutterer
On Mon, May 10, 2010 at 01:51:35PM +0700, Mikhail Gusarov wrote: > > Twas brillig at 08:58:07 10.05.2010 UTC+10 when peter.hutte...@who-t.net did > gyre and gimble: > > PH> Please send patches to the list, it'd make it a lot easier to > PH> review than having to copy from the repo. > > [/me n