Re: [PATCH 0/3] Xserver internals doc patches

Alan Coopersmith wrote: > Due to the extreme size of these patches (over 1Mb), I've posted the first > two at: > http://people.freedesktop.org/~alanc/Xserver-docs/ > > I've also posted there the current resulting DocBook/XML files and the > HTML & Text conversions of those built after applyi

[PATCH 5/5] XFree86 Design doc: Convert LinuxDoc ``quotes'' to standard XML entities

Signed-off-by: Alan Coopersmith --- hw/xfree86/doc/sgml/DESIGN.xml | 90 1 files changed, 45 insertions(+), 45 deletions(-) diff --git a/hw/xfree86/doc/sgml/DESIGN.xml b/hw/xfree86/doc/sgml/DESIGN.xml index e40a251..5b31cb0 100644 --- a/hw/xfree86/doc/s

[PATCH 3/5] Show Xserver release/version date in DIX & DDX docs

Signed-off-by: Alan Coopersmith --- Adds xserver.ent to CLEANFILES in hw/xfree86/doc/sgml/Makefile.am (I'm still open to finding a better way to include XML entity files from another directory without the symlink if someone can figure one out.) configure.ac|2 ++ doc/

[PATCH:makedepend 2/2] Convert testcase from bug 28045 into automake "make check" test

Signed-off-by: Alan Coopersmith --- Makefile.am| 20 tests/28045/foo.cpp|2 ++ tests/28045/makedep.sh | 28 3 files changed, 50 insertions(+), 0 deletions(-) create mode 100644 tests/28045/foo.cpp create mode 100755 tests

[PATCH:makedepend 1/2] Bug 28045 - makedepend fails on directory named like an include file

From: Martin Pärtel Signed-off-by: Alan Coopersmith --- include.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include.c b/include.c index e40c26c..0a4ad2a 100644 --- a/include.c +++ b/include.c @@ -264,7 +26

[PATCH:libfontenc 1/2] Replace malloc(strlen()) + strcpy() with strdup()

Now that we use malloc directly instead of xalloc, we can use strdup directly too. Signed-off-by: Alan Coopersmith --- src/encparse.c | 12 src/fontenc.c |3 +-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/encparse.c b/src/encparse.c index b288c8c..33e

[PATCH:libfontenc 2/2] Don't need to check if pointer is NULL before calling free()

Signed-off-by: Alan Coopersmith --- src/encparse.c | 12 +--- src/fontenc.c |9 +++-- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/src/encparse.c b/src/encparse.c index 33e0a05..5b4cefb 100644 --- a/src/encparse.c +++ b/src/encparse.c @@ -745,20 +745,19 @@ er

Re: [PATCH 1/4] Nuke RCS tags

Jamey Sharp wrote: > For this series: > > Reviewed-by: Jamey Sharp Looks good to me too - pushed to git master. -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System ___ xorg-d

[PULL] platform support fixes (getifaddrs on OpenSolaris, Xorg platform list in configure.ac)

The following changes since commit c6613cfc26e76b296e620640bf33e756eb4ae178: Jamey Sharp (1): test/xi2: Initialize predefined atoms before XInputExtensionInit. are available in the git repository at: git+ssh://al...@people.freedesktop.org/~alanc/xserver.git master Alan Coopersmith (

Re: [PATCH 0/3] Xserver internals doc patches

Dan Nicholson wrote: > How sad. I wasted like two weeks of my life doing the same conversion, > but hadn't finished the cleanup to post the patches. DESIGN.sgml -> > DESIGN.xml was a total beast. Oh well. At least there's someone else > familiar with the source now that can check it. :) Sorry - I

Re: [PATCH 3/3] Show Xserver release/version date in DIX & DDX docs

Dan Nicholson wrote: > Not sure this would work, but instead of copying the entity file to > the current directory, can you just pass --searchpath to xmlto? I.e., > in xmlrules.in: > > XMLTO_FLAGS = --searchpath $(top_builddir)/doc/xml > > .xml.html: > @rm -f $@ > $(AM_V_GEN)$(XMLTO)

Re: [PATCH 1/4] Fix a couple of compiler warnings

On Fri, 14 May 2010 17:45:00 -0700, Jamey Sharp wrote: > The comment suggests that after unwrapping, pGC->funcs->ChangeClip is > miChangeClip. I just tried tracing through the layers of function > pointers and I *think* that's true. After miChangeClip returns, > clientClipType can only be either

Re: [PATCH 1/4] Fix a couple of compiler warnings

On Wed, 12 May 2010 21:38:05 +0200, Julien Cristau wrote: > On Wed, May 12, 2010 at 10:53:18 -0700, Dan Nicholson wrote: > The attached seems to build without warnings on master. Are you guys happy with this version now? It appears to be all nicely reviewed and ready to merge. Any reason to thin

Re: [PATCH 1/4] Fix a couple of compiler warnings

On Fri, May 7, 2010 at 11:19 PM, Keith Packard wrote: > diff --git a/hw/dmx/dmxgc.c b/hw/dmx/dmxgc.c > index eb21d3c..40f312f 100644 > --- a/hw/dmx/dmxgc.c > +++ b/hw/dmx/dmxgc.c > @@ -382,6 +382,7 @@ void dmxChangeClip(GCPtr pGC, int type, pointer pvalue, > int nrects) >        } >        break;

Re: [PATCH 1/7] Fix a couple of compiler warnings

On Thu, 13 May 2010 09:49:45 -0400, Kristian Høgsberg wrote: > > This works for me and seems like a better way to fix those warnings: > > diff --git a/include/input.h b/include/input.h > index 63f981e..eba4292 100644 > --- a/include/input.h > +++ b/include/input.h > @@ -212,10 +212,10 @@ typede

Re: [PATCH 2/7] Check pixmap allocation return value when creating glyphs

Reviewed-by: Jamey Sharp On Wed, May 12, 2010 at 2:45 PM, Keith Packard wrote: > --- >  render/render.c |    7 +++ >  1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/render/render.c b/render/render.c > index c9d3e8e..a3e96c0 100644 > --- a/render/render.c > +++ b/render/ren

Re: [PATCH 0/3] Xserver internals doc patches

On Fri, 14 May 2010 16:45:54 -0700, Alan Coopersmith wrote: > The recent flurry of ABI changing cleanups reminded me that I've been > meaning for a while to finish the move of the X DDX porting doc which > documents many of those functions from the xorg-docs module to xserver, > so it can be kep

Re: [PATCH 3/3] Show Xserver release/version date in DIX & DDX docs

On Fri, May 14, 2010 at 4:45 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- >  configure.ac                    |    2 ++ >  doc/xml/Makefile.am             |    2 ++ >  doc/xml/Xserver-spec.xml        |    4 +++- >  doc/xml/xserver.ent.in          |    3 +++ >  hw/xfree86/doc

Re: [PATCH 0/3] Xserver internals doc patches

On Fri, May 14, 2010 at 4:45 PM, Alan Coopersmith wrote: > The recent flurry of ABI changing cleanups reminded me that I've been > meaning for a while to finish the move of the X DDX porting doc which > documents many of those functions from the xorg-docs module to xserver, > so it can be kept in

[PATCH 3/3] Show Xserver release/version date in DIX & DDX docs

Signed-off-by: Alan Coopersmith --- configure.ac|2 ++ doc/xml/Makefile.am |2 ++ doc/xml/Xserver-spec.xml|4 +++- doc/xml/xserver.ent.in |3 +++ hw/xfree86/doc/sgml/DESIGN.xml |4 +++- hw/xfree86/doc/sgml/Makefile.am |6 ++

[PATCH 0/3] Xserver internals doc patches

The recent flurry of ABI changing cleanups reminded me that I've been meaning for a while to finish the move of the X DDX porting doc which documents many of those functions from the xorg-docs module to xserver, so it can be kept in sync with the code it's documenting. Unfortunately, the xorg-macr

Re: [PATCH] xfree86: Add option parsing for percent options.

> "PH" == Peter Hutterer writes: PH> One question is of course if we should allow the values to be floats PH> instead of ints, not sure if we need something like 0.2% but I guess PH> it might not hurt, either. Since it is only used in a slow path, even boxen w/o hw fp should not have problem

Re: [PATCH 1/2 libX11] xcb: Add TCP fallback

On May 14, 2010, at 13:35, Jamey Sharp wrote: > This patch looks fine to me: > > Reviewed-by: Jamey Sharp > > I have some nitpicks and suggestions though. The big suggestion is > that it seems like it should be easier to write this loop in > _XConnectXCB instead of directly in OpenDisplay. For

Re: [PATCH] Device init: Don't crash when CreateGC fails.

On May 14, 2010, at 12:47, Jamey Sharp wrote: > On Fri, May 14, 2010 at 12:40 PM, Jeremy Huddleston > wrote: >> Thanks Jamey! >> >> Reviewed-by: Jeremy Huddleston > > No problem! Out of curiousity, did you just review the patch, or also > test it? I'd be inclined to add a tested-by line as w

Re: [PATCH] Device init: Don't crash when CreateGC fails.

On Fri, 14 May 2010 12:47:06 -0700, Jamey Sharp wrote: > On Fri, May 14, 2010 at 12:40 PM, Jeremy Huddleston > wrote: > > Thanks Jamey! > > > > Reviewed-by: Jeremy Huddleston > > No problem! Out of curiousity, did you just review the patch, or also > test it? I'd be inclined to add a tested-by

[PATCH input-mouse 14/14] config: let AC_PROG_SED find the best value for $SED

Signed-off-by: Gaetan Nadon --- man/Makefile.am |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/man/Makefile.am b/man/Makefile.am index 0d56ef3..a2514d8 100644 --- a/man/Makefile.am +++ b/man/Makefile.am @@ -31,8 +31,6 @@ EXTRA_DIST = mousedrv.man CLEANFILES = $(drive

[PATCH input-mouse 13/14] README: keep the text version of README, discard the sgml version

The linuxdoc doc tool is deprecated. README files are exclusively text files. The file had not been updated for 5 years. Signed-off-by: Gaetan Nadon --- Makefile.am |7 - README.sgml | 1122 -- configure.ac |1 - 3 files changed,

[PATCH input-mouse 12/14] config: fix warnings, m4 quoting and layout

Fix some m4 quoting Fix some autoconf warnings remove AC_PROG_CC as it overrides AC_PROG_C_C99 from XORG_DEFAULT_OPTIONS Regroup statements per section Add comments Signed-off-by: Gaetan Nadon --- configure.ac | 49 +++-- 1 files changed, 27 insertio

[PATCH input-mouse 11/14] config: Upgrade X.Org macros to 1.4 for INSTALL file copying

Signed-off-by: Gaetan Nadon --- configure.ac |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 75c079e..c5b855e 100644 --- a/configure.ac +++ b/configure.ac @@ -29,10 +29,10 @@ AC_CONFIG_SRCDIR([Makefile.am]) AC_CONFIG_HEADERS([conf

[PATCH input-mouse 10/14] config: remove AC_PROG_CC as it overrides AC_PROG_C_C99

XORG_STRICT_OPTION from XORG_DEFAULT_OPTIONS calls AC_PROG_C_C99. This sets gcc with -std=gnu99. If AC_PROG_CC macro is called afterwards, it resets CC to gcc. Signed-off-by: Gaetan Nadon --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/con

[PATCH input-mouse 09/14] config: remove unrequired AC_HEADER_STDC

Autoconf says: "This macro is obsolescent, as current systems have conforming header files. New programs need not use this macro". Signed-off-by: Gaetan Nadon --- configure.ac |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b423afe..7a

[PATCH input-mouse 08/14] config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS

Regroup AC statements at the top. Signed-off-by: Gaetan Nadon --- configure.ac |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 8b09446..b423afe 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,9 @@ AC_INIT([xf86-input-mous

[PATCH input-mouse 07/14] config: update AC_PREREQ statement to 2.60

Unrelated to the previous patches, the new value simply reflects the reality that the minimum level for autoconf to configure all x.org modules is 2.60 dated June 2006. ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz Signed-off-by: Gaetan Nadon --- configure.ac |2 +- 1 files changed, 1

[PATCH input-mouse 06/14] config: optional extension check for inputproto not required

The check should be in PKG_CHECK_MODULES permanently. The XORG_DRIVER_CHECK_EXT will add inputproto to PKG_CHECK_MODULES only if the extension is available. By definition, this extension is an integral part of the server and is always present. The server always sets XINPUT macro to 1. The conditi

[PATCH input-mouse 05/14] config: remove extension check for unused RANDR extension

The randr protocol is not used, no randr*.h are included. Signed-off-by: Gaetan Nadon --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 389318a..407b499 100644 --- a/configure.ac +++ b/configure.ac @@ -57,7 +57,6 @@ inputd

[PATCH input-mouse 04/14] config: remove AH_TOP autoheader statement

The generated config.h does not need to include xorg-server.h for the content it provides. Add #include in .[hc] files as needed. Signed-off-by: Gaetan Nadon --- configure.ac |2 -- src/hurd_mouse.c |1 + src/lnx_mouse.c |1 + src/mouse.c |1 + src/pnp.c|1

[PATCH input-mouse 03/14] Remove unused SCO driver files

The SCO driver has never been enabled since its original commit Signed-off-by: Gaetan Nadon --- src/sco_mouse.c | 258 --- 1 files changed, 0 insertions(+), 258 deletions(-) delete mode 100644 src/sco_mouse.c diff --git a/src/sco_mouse.c b/s

[PATCH input-mouse 02/14] README: update text content from sgml content

Signed-off-by: Gaetan Nadon --- README | 297 +++- 1 files changed, 145 insertions(+), 152 deletions(-) diff --git a/README b/README index 1f54753..984814f 100644 --- a/README +++ b/README @@ -1,4 +1,4 @@ - Mouse Support in X11R6.8 +

[PATCH input-mouse 01/14] README: fix linuxdoc content

defs.ent are located under X11 directory ident tag is not a Linuxdoc tag replace docbook email tag with linuxdoc email tag replace with which preserves tabs Signed-off-by: Gaetan Nadon --- README.sgml | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) d

[PATCH input-mouse 00/14] Upgrade configuration

Other than the usual, the README.sgml is removed in favor of the text README file after being updated. This will later be done in: xf86-video-i128 xf86-video-s3virge xf86-video-sis xf86-video-chips xf86-video-i740 xf86-video-apm xf86-video-tga xf86-video-rendition xf86-video-newport Gaetan Nadon

Re: [PATCH 2/2 libxcb] xcb_open: Improve protocol/host parsing

I *think* this patch makes sense... Frankly, xcb_util.c has suffered pretty badly as the different wacky DISPLAY formats have been implemented. If anybody can see how to make it less crazy I'd sure appreciate patches. :-) Until then, Reviewed-by: Jamey Sharp Jamey On Fri, May 14, 2010 at 1:10 P

Re: [Xcb] [PATCH 1/2 libX11] xcb: Add TCP fallback

On Fri, May 14, 2010 at 13:10:36 -0700, Jeremy Huddleston wrote: > @@ -164,10 +164,32 @@ XOpenDisplay ( > > #if USE_XCB > if(!_XConnectXCB(dpy, display, &fullname, &iscreen)) { > + /* Try falling back on other transports if no transport > specified */ > + const ch

Re: [PATCH 1/2 libX11] xcb: Add TCP fallback

This patch looks fine to me: Reviewed-by: Jamey Sharp I have some nitpicks and suggestions though. The big suggestion is that it seems like it should be easier to write this loop in _XConnectXCB instead of directly in OpenDisplay. For the nitpicks: On Fri, May 14, 2010 at 1:10 PM, Jeremy Huddle

[PATCH 2/2 libxcb] xcb_open: Improve protocol/host parsing

Support scenarios where host is not set and protocol is. eg: DISPLAY=tcp/:0 as well as the "inet" and "inet6" alias for "tcp" for compatability with Xlib Signed-off-by: Jeremy Huddleston --- src/xcb_util.c | 30 ++ 1 files changed, 18 insertions(+), 12 deletions(

[PATCH 1/2 libX11] xcb: Add TCP fallback

If we fail to connect to a UNIX socket and the transport isn't specified, fallback on TCP. This matches behavior with the xtrans codepath and the Xlib spec. http://lists.x.org/archives/xorg-devel/2010-April/007915.html Signed-off-by: Jeremy Huddleston --- src/OpenDis.c | 30 +

Re: [PATCH] Device init: Don't crash when CreateGC fails.

That looks good to me. Sorry I for introducing this! - Pierre-Loup On 05/14/2010 11:37 AM, Jamey Sharp wrote: ActivateDevice was ignoring errors from DeviceCursorInitialize, so cursor-related calls failed later. Jeremy Huddleston saw that crash in miPointerConstrainCursor, while with Xvfb I saw

Re: [PATCH] Device init: Don't crash when CreateGC fails.

On Fri, May 14, 2010 at 12:40 PM, Jeremy Huddleston wrote: > Thanks Jamey! > > Reviewed-by: Jeremy Huddleston No problem! Out of curiousity, did you just review the patch, or also test it? I'd be inclined to add a tested-by line as well for you if you did, in fact, test. :-) Also I'm really hop

Re: [PATCH] Device init: Don't crash when CreateGC fails.

Thanks Jamey! Reviewed-by: Jeremy Huddleston On May 14, 2010, at 11:37, Jamey Sharp wrote: > ActivateDevice was ignoring errors from DeviceCursorInitialize, so > cursor-related calls failed later. Jeremy Huddleston saw that crash in > miPointerConstrainCursor, while with Xvfb I saw it in > miSp

Re: [PATCH] test/xi2: Initialize predefined atoms before XInputExtensionInit.

On Fri, 14 May 2010 10:36:13 -0700, Jamey Sharp wrote: > XInputExtensionInit calls MakeAtom, which doesn't work without the atoms > table initialized. > > Signed-off-by: Jamey Sharp > Cc: Peter Hutterer Tested-by: Keith Packard -- keith.pack...@intel.com pgppmUiUAyqbj.pgp Description: PGP

Re: [PATCH] dri2: Send out event when auxillary buffers are invalidated

On Fri, 14 May 2010 10:14:29 -0700, Dan Nicholson wrote: > It seems like there could be more than one person looking at a pull > request, checking the review status of the patches, judging if there > isn't anything inherently wrong with the patchset, and seeing if they > merge properly. I think

Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

On Fri, May 14, 2010 at 12:15 PM, Jeremy Huddleston wrote: > Gah!  I'm an idiot.  I can't believe I spent over an hour debugging something > because of confusing --i and i-- when editing gc.c I still feel pretty dumb for letting the original patch go out with the bug in it in the first place. ;-

Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

Gah! I'm an idiot. I can't believe I spent over an hour debugging something because of confusing --i and i-- when editing gc.c When I merge your branch rather than relying on my lack of ability to edit a one line change in a file, it works correctly Tested-by: Jeremy Huddleston Do you have

[PATCH] Device init: Don't crash when CreateGC fails.

ActivateDevice was ignoring errors from DeviceCursorInitialize, so cursor-related calls failed later. Jeremy Huddleston saw that crash in miPointerConstrainCursor, while with Xvfb I saw it in miSpriteRealizeCursor. miDCDeviceCleanup frees any non-NULL GCs. miDCDeviceInitialize calls Cleanup on any

Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

On Fri, May 14, 2010 at 11:27 AM, Jeremy Huddleston wrote: > On May 14, 2010, at 11:19, Jamey Sharp wrote: >> I'd expect to see this result with yesterday's master. Are you sure >> you're testing with my patch? :-) > > Yep: > > 443         for (i = Ones(mask); --i; ) That's... not *my* patch. Tha

Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

On May 14, 2010, at 11:19, Jamey Sharp wrote: >> (gdb) print vals >> $3 = {{ >>val = 2750440, >>ptr = 0x10029f7e8 >> }, { >>val = 0, >>ptr = 0x1 >> }, ...} > > vals[1].val correctly got set to FALSE, but vals[0].val did not get > set to IncludeInferiors (1). > > I'd ex

Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

On Fri, May 14, 2010 at 11:00 AM, Jeremy Huddleston wrote: > Well, the issue is still persistent for my case.  The problem is difficult to > discover because multiple points along the route have poor error handling. Yeah, I'm noticing that. > 1) ActivateDevice needs to handle the case where miP

Re: [PATCH 4/7] Create xfixes invisible cursor only when it is first used.

On Fri, 14 May 2010 18:53:31 +0300, Tiago Vignatti wrote: > On Wed, May 12, 2010 at 11:45:08PM +0200, ext Keith Packard wrote: > > This mostly ensures that the cursor is created after the server is up > > and running with all of the DevPrivate keys initialized. However, it > > will also save a ti

Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

Well, the issue is still persistent for my case. The problem is difficult to discover because multiple points along the route have poor error handling. 1) ActivateDevice needs to handle the case where miPointerDeviceInitialize returns FALSE or we will crash in miPointerConstrainCursor. 271

[PULL] unbreak master

Sorry. :-( The following changes since commit 795432d4a92ed5b9fa4d9163e73c8e4fe4c74534: Keith Packard (1): Merge remote branch 'jamey/cleanups' are available in the git repository at: git://people.freedesktop.org/~jamey/xserver for-keith Jamey Sharp (1): Bugfix for "Pre-valida

Re: [PATCH input-keyboard 02/13] Missing #ifdef for PCCONS

On Fri, May 14, 2010 at 10:35 AM, Gaetan Nadon wrote: > On Fri, 2010-05-14 at 06:35 -0700, Dan Nicholson wrote: > > On Wed, May 12, 2010 at 10:11 AM, Gaetan Nadon wrote: >> Compiling this BSD file under Linux finds errors in conditional code. >> PCCONS is undefined and should be protected with PC

[PATCH] test/xi2: Initialize predefined atoms before XInputExtensionInit.

XInputExtensionInit calls MakeAtom, which doesn't work without the atoms table initialized. Signed-off-by: Jamey Sharp Cc: Peter Hutterer --- test/xi2/protocol-common.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/test/xi2/protocol-common.c b/test/xi2/protocol-common

Re: [PATCH input-keyboard 02/13] Missing #ifdef for PCCONS

On Fri, 2010-05-14 at 06:35 -0700, Dan Nicholson wrote: > On Wed, May 12, 2010 at 10:11 AM, Gaetan Nadon wrote: > > Compiling this BSD file under Linux finds errors in conditional code. > > PCCONS is undefined and should be protected with PCCONS_SUPPORT > > Why would the bsd sources get compiled

Re: [PATCH] dri2: Send out event when auxillary buffers are invalidated

On Fri, May 14, 2010 at 9:31 AM, Jamey Sharp wrote: > It seems to me that the big problem is a lack of reviewers. More > people to push changes to master won't change that. No disagreement here. > I think Keith's been doing a fine job processing pull requests. In my > opinion, if your complaint

[PATCH v2] configure: force new xproto version dependency

commit bca85e2e127a8a23e3a2debcfeb3ae07cd3c66ac introduced it. Signed-off-by: Tiago Vignatti --- Although 7.0.17 wasn't released yet I have powers to preview the future (kudos to Julien). configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/conf

Re: [PULL] use LRMI for real-mode calls

On Fri, May 14, 2010 at 06:03:43PM +0200, ext Julien Cristau wrote: > On Wed, Apr 28, 2010 at 20:58:58 +0300, Tiago Vignatti wrote: > > > Keith, > > > > All int10 module went to libx86, which in turn is accessed by a shiny new > > lrmi. It became very easy to create real mode contexts now; for in

Re: [PATCH] configure: force new xproto version dependency

On Fri, May 14, 2010 at 19:00:42 +0300, Tiago Vignatti wrote: > commit bca85e2e127a8a23e3a2debcfeb3ae07cd3c66ac introduced it. > > Signed-off-by: Tiago Vignatti > --- > configure.ac |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure.ac b/configure.ac > ind

Re: [PATCH] dri2: Send out event when auxillary buffers are invalidated

It seems to me that the big problem is a lack of reviewers. More people to push changes to master won't change that. I think Keith's been doing a fine job processing pull requests. In my opinion, if your complaint is that Keith isn't pushing patches to master fast enough, you should try sending pu

[PATCH] configure: force new xproto version dependency

commit bca85e2e127a8a23e3a2debcfeb3ae07cd3c66ac introduced it. Signed-off-by: Tiago Vignatti --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index a25b1f4..7b9233d 100644 --- a/configure.ac +++ b/configure.ac @@ -793,7 +793,7

Re: [PULL] use LRMI for real-mode calls

On Wed, Apr 28, 2010 at 20:58:58 +0300, Tiago Vignatti wrote: > Keith, > > All int10 module went to libx86, which in turn is accessed by a shiny new > lrmi. It became very easy to create real mode contexts now; for instance all X > server code has ~60 lines only. And the cool thing is that the AP

Re: [PATCH 4/7] Create xfixes invisible cursor only when it is first used.

On Wed, May 12, 2010 at 11:45:08PM +0200, ext Keith Packard wrote: > This mostly ensures that the cursor is created after the server is up > and running with all of the DevPrivate keys initialized. However, it > will also save a tiny amount of memory on systems where the invisible > cursor is never

Re: [PATCH] dri2: Send out event when auxillary buffers are invalidated

Hi, On Fri, May 14, 2010 at 02:59:16PM +0200, ext Dan Nicholson wrote: > 2010/5/14 Michel Dänzer : > > On Don, 2010-05-13 at 07:23 -0400, Kristian Høgsberg wrote: > >> > >> It would be nice if you could reply to a patch early on with what the > >> status is, like "need more reviews", "looks good,

Re: [PULL] getting rid of Xalloc/Xfree/... in server

Michel Dänzer wrote: > How are drivers supposed to deal with the resulting warnings? If a > driver is converted to use malloc and friends directly, will it still > work with older servers? You will probably lose compatibility with servers built from the monolithic tree (i.e. XFree86 4.x, Xorg 6.x)

Re: [PATCH] dri2: Fix xserver crash if dri2 buffer allocation fails.

On Fri, May 14, 2010 at 9:25 AM, Pauli Nieminen wrote: > If driver fails to allocate memory for dri2 buffer server would crash > in send_buffers_reply. > > Solution is to handle the allocation failure and return BadAlloc to > client. > > Signed-off-by: Pauli Nieminen Looks good, Reviewed-by: Kr

Re: [PATCH] dri2: Fix xserver crash if dri2 buffer allocation fails.

On Fre, 2010-05-14 at 16:25 +0300, Pauli Nieminen wrote: > If driver fails to allocate memory for dri2 buffer server would crash > in send_buffers_reply. > > Solution is to handle the allocation failure and return BadAlloc to > client. > > Signed-off-by: Pauli Nieminen Reviewed-by: Michel Dänz

Re: [PATCH input-keyboard 02/13] Missing #ifdef for PCCONS

On Wed, May 12, 2010 at 10:11 AM, Gaetan Nadon wrote: > Compiling this BSD file under Linux finds errors in conditional code. > PCCONS is undefined and should be protected with PCCONS_SUPPORT Why would the bsd sources get compiled on linux? > > Signed-off-by: Gaetan Nadon > --- >  src/bsd_kbd.c

Re: [PATCH synaptics] Remove psmcomm.h header - superfluous.

On Tue, May 11, 2010 at 5:28 PM, Peter Hutterer wrote: > Don't need a full header file for 3 include directives of system headers. > > Signed-off-by: Peter Hutterer Wow. Reviewed-by: Dan Nicholson ___ xorg-devel@lists.x.org: X.Org development Archive

[PATCH] dri2: Fix xserver crash if dri2 buffer allocation fails.

If driver fails to allocate memory for dri2 buffer server would crash in send_buffers_reply. Solution is to handle the allocation failure and return BadAlloc to client. Signed-off-by: Pauli Nieminen --- hw/xfree86/dri2/dri2.c| 69 + hw/xfree86/d

Re: [PULL] getting rid of Xalloc/Xfree/... in server

Twas brillig at 14:10:02 14.05.2010 UTC+02 when mic...@daenzer.net did gyre and gimble: MD> How are drivers supposed to deal with the resulting warnings? If a MD> driver is converted to use malloc and friends directly, will it MD> still work with older servers? Yes. X* functions were just a

Re: [PATCH 1/4] Fix a couple of compiler warnings

On Fri, May 14, 2010 at 06:08:00 -0700, Dan Nicholson wrote: > On Wed, May 12, 2010 at 09:38:05PM +0200, Julien Cristau wrote: > > diff --git a/include/input.h b/include/input.h > > index 63f981e..aadcdf1 100644 > > --- a/include/input.h > > +++ b/include/input.h > > @@ -212,10 +212,10 @@ typedef

Re: [PATCH 1/4] Fix a couple of compiler warnings

On Wed, May 12, 2010 at 09:38:05PM +0200, Julien Cristau wrote: > On Wed, May 12, 2010 at 10:53:18 -0700, Dan Nicholson wrote: > > > Yeah, clearly libudev has it's own copies of the strings that it will > > keep until we unref the udev_device. So, here's a patch that makes the > > InputAttributes

Re: [PATCH] dri2: Send out event when auxillary buffers are invalidated

2010/5/14 Michel Dänzer : > On Don, 2010-05-13 at 07:23 -0400, Kristian Høgsberg wrote: >> Keith, are you waiting for more reviews on this one?  We already >> discussed the basic idea at great length prior to the 1.8 release and >> it got bumped only because it was a new feature too close to the >>

Re: [PATCH] dri2: Send out event when auxillary buffers are invalidated

On Don, 2010-05-13 at 07:23 -0400, Kristian Høgsberg wrote: > Keith, are you waiting for more reviews on this one? We already > discussed the basic idea at great length prior to the 1.8 release and > it got bumped only because it was a new feature too close to the > release date. I've update the

Re: [PATCH] Fix DRI2Connect line encoding to match existing code

For the series: Reviewed-by: Julien Cristau Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

Hi, Your patch fixes the git master xserver for me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: xlib/libxi crash

ext Peter Hutterer wrote: On Wed, May 12, 2010 at 11:02:10AM +0300, Rami Ylimäki wrote: ext Daniel Stone wrote: On Wed, May 12, 2010 at 11:59:57AM +1000, Peter Hutterer wrote: Have a look at commit c34f76f475bc632490122e67b5a82575d69d5569 Pull down extra bytes when reading a

Re: [PATCH v2 util/modular] build.sh: Simplify checks for ACLOCAL, PKG_CONFIG_PATH, etc.

On Fri, May 14, 2010 at 11:06:18 +1000, Peter Hutterer wrote: > # Set the library path so that locally built libs will be found by apps > -if test x"$LD_LIBRARY_PATH" = x; then > -LD_LIBRARY_PATH=${DESTDIR}${PREFIX}/${LIBDIR} > -else > -LD_LIBRARY_PATH=${DESTDIR}${PREFIX}/${LIBDIR}:${LD_L

Re: X-JHBuild: A thin JHBuild wrapper with plug-ins.

Just a quick follow-up because this should now run with Python-3. -- Dirk commit 23909a6376e14722cb0585bb6f08d523d1ea2cc8 Author: Dirk Wallenstein Date: Thu May 13 19:28:13 2010 Some Python-3 conformance changes Honor the removal of dict.has_key and execfile in Python-3. Use

[PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.

Signed-off-by: Jamey Sharp --- Well, that's thoroughly embarrassing. Does this fix the regression for you, Jeremy? dix/gc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/gc.c b/dix/gc.c index 00b63bd..5a0d00d 100644 --- a/dix/gc.c +++ b/dix/gc.c @@ -439,7 +439,7 @