Re: [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

2010-05-17 Thread Oliver McFadden
On Tue, 2010-05-18 at 08:34 +0200, ext Keith Packard wrote: > On Tue, 18 May 2010 08:44:27 +0300, Oliver McFadden > wrote: > > > I suppose for HW cursor it doesn't really matter since we wouldn't take > > damage on that, right? We just draw everything normally, then tell the > > HW to draw a spr

Re: [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

2010-05-17 Thread Keith Packard
On Tue, 18 May 2010 08:44:27 +0300, Oliver McFadden wrote: > I suppose for HW cursor it doesn't really matter since we wouldn't take > damage on that, right? We just draw everything normally, then tell the > HW to draw a sprite at X,Y? (Again, haven't looked at HW cursor code so > perhaps I'm to

[PATCH xrandr] Add --brightness option to --help message

2010-05-17 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov --- xrandr.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xrandr.c b/xrandr.c index 5858813..abe36dc 100644 --- a/xrandr.c +++ b/xrandr.c @@ -131,6 +131,7 @@ usage(void) fprintf(stderr, " --crtc \n"); fprintf(stderr, "

Re: [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

2010-05-17 Thread Oliver McFadden
On Mon, 2010-05-17 at 18:43 +0200, ext Keith Packard wrote: > On Mon, 17 May 2010 07:50:25 +0300, Oliver McFadden > wrote: > > Previously the cursor code would be called even with a "hidden" cursor. > > This was because the X server used an invisible 1x1 cursor sprite, > > rather than a NULL curs

Re: [PATCH] os: include dix-config.h, not xorg-config.h

2010-05-17 Thread Peter Hutterer
On Mon, May 17, 2010 at 07:39:54PM +0200, Julien Cristau wrote: > os/strlc{at,py}.c were trying to include xorg-config.h, which is not > available in dix. > > Signed-off-by: Julien Cristau Acked-by: Peter Hutterer > --- > os/strlcat.c |4 ++-- > os/strlcpy.c |4 ++-- > 2 files changed

[PATCH:x11proto] Add Sun cc 5.9 & later to compilers supporting noreturn attribute

2010-05-17 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- Xfuncproto.h.in |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 96a585c..0177119 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -117,7 +117,8 @@ in this Software without prior written aut

[PATCH 3/5 v3] Show Xserver release/version date in DIX & DDX docs

2010-05-17 Thread Alan Coopersmith
Uses a catalog file to provide the path to an entity file in a different directory than the xml sources. Signed-off-by: Alan Coopersmith --- configure.ac |2 ++ doc/xml/Makefile.am|5 - doc/xml/Xserver-spec.xml |4 +++- doc/xml/xmlrules.in

[PATCH 1.5/5] Use docbook2{html,txt,pdf} instead of xmlto

2010-05-17 Thread Alan Coopersmith
I can't get xmlto to accept catalogs, but docbook2* takes them fine. I can't get builddir != srcdir builds to work without catalogs to specify the *.ent files are in a different directory than the .xml src files. On the bright side, this avoids having to link/copy the .ent files to every directo

[PATCH 5/5] XFree86 Design doc: Convert LinuxDoc ``quotes'' to DocBook tags

2010-05-17 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- hw/xfree86/doc/sgml/DESIGN.xml | 90 1 files changed, 45 insertions(+), 45 deletions(-) diff --git a/hw/xfree86/doc/sgml/DESIGN.xml b/hw/xfree86/doc/sgml/DESIGN.xml index a9e241b..5fa08ba 100644 --- a/hw/xfree86/doc/s

RE: Composite Quesiton

2010-05-17 Thread Huang, FrankR
Morton, thanks. I have used OVER operation to produce what I want on RS690 platform. But in the geode driver, I found that it can not do the SRC and OVER rendering correctly. I am now firstly focusing the SRC operation. From your explanation, a (1,0,1,0) to (0,0,0,0) transfer is done outside the

Re: [PATCH] xfree86: fix typo in optionTypeToSting.

2010-05-17 Thread Dan Nicholson
On Mon, May 17, 2010 at 6:15 PM, Peter Hutterer wrote: > Because we don't want anyone to get hurt. > > Signed-off-by: Peter Hutterer > --- >  hw/xfree86/common/xf86Configure.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/xfree86/common/xf86Configure.c > b/h

Re: [PATCH v3] xfree86: Add option parsing for percent options.

2010-05-17 Thread Dan Nicholson
On Mon, May 17, 2010 at 6:12 PM, Peter Hutterer wrote: > In some cases, an option of "50%" would be preferable over fixed value > configuration - especially if the actual values are autoprobed. > Add a new set of functions to parse percent values from configurations. > > The percent value parsing

Re: [PATCH 5/5] XFree86 Design doc: Convert LinuxDoc ``quotes'' to standard XML entities

2010-05-17 Thread Dan Nicholson
On Mon, May 17, 2010 at 4:44 PM, Alan Coopersmith wrote: > Dan Nicholson wrote: >> On Fri, May 14, 2010 at 10:25 PM, Alan Coopersmith >> wrote: >>> Signed-off-by: Alan Coopersmith >>> --- >>>  hw/xfree86/doc/sgml/DESIGN.xml |   90 >>> >>>  1 files change

Re: [PATCH] Only link Xorg with libconfig.la

2010-05-17 Thread Dan Nicholson
On Sun, May 16, 2010 at 12:29 PM, Julien Cristau wrote: > Other DDXs don't use input hotplugging since config_init was moved to > the DDX in commit d33adcdf03c69407d151e732fa0cf9947151eb19, so there's > no need to link this in. > > Signed-off-by: Julien Cristau Acked-by: Dan Nicholson _

Re: [PATCH] xfree86: fix typo in optionTypeToSting.

2010-05-17 Thread Matt Turner
On Mon, May 17, 2010 at 9:15 PM, Peter Hutterer wrote: > Because we don't want anyone to get hurt. > > Signed-off-by: Peter Hutterer > --- >  hw/xfree86/common/xf86Configure.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/xfree86/common/xf86Configure.c > b/h

[PATCH] xfree86: fix typo in optionTypeToSting.

2010-05-17 Thread Peter Hutterer
Because we don't want anyone to get hurt. Signed-off-by: Peter Hutterer --- hw/xfree86/common/xf86Configure.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/common/xf86Configure.c b/hw/xfree86/common/xf86Configure.c index 1573cc6..c34ef1d 100644 --- a/hw/

[PATCH v3] xfree86: Add option parsing for percent options.

2010-05-17 Thread Peter Hutterer
In some cases, an option of "50%" would be preferable over fixed value configuration - especially if the actual values are autoprobed. Add a new set of functions to parse percent values from configurations. The percent value parsing differs slightly - if the option is not to marked as used (e.g. x

Re: [PATCH 5/5] XFree86 Design doc: Convert LinuxDoc ``quotes'' to standard XML entities

2010-05-17 Thread Alan Coopersmith
Dan Nicholson wrote: > On Fri, May 14, 2010 at 10:25 PM, Alan Coopersmith > wrote: >> Signed-off-by: Alan Coopersmith >> --- >> hw/xfree86/doc/sgml/DESIGN.xml | 90 >> >> 1 files changed, 45 insertions(+), 45 deletions(-) >> >> diff --git a/hw/xfree86/

[PATCH video-sis] Remove unnecessary mibank.h include.

2010-05-17 Thread Robert Hooker
Not used by the driver and no longer exists in xserver >= 1.8.99.0. Signed-off-by: Robert Hooker --- src/sis_driver.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/sis_driver.c b/src/sis_driver.c index d19cf17..22646d2 100644 --- a/src/sis_driver.c +++ b/src/sis_dr

Re: Server Interpreted "localuser" Authentication using SO_PEERCRED interferes with SSH

2010-05-17 Thread Tavis Ormandy
On Mon, May 17, 2010 at 07:56:33AM -0700, Alan Coopersmith wrote: > Tavis Ormandy wrote: > > The problem is, if I'm using xhost +si:localuser:taviso, once the > > timeout has expired, X will fall back to SO_PEERCRED verification. As > > openssh opened the connection, the credentials check out and I

[PATCH] dri2: Fix NULL check in allocation error handling

2010-05-17 Thread Kristian Høgsberg
1461b31e40a3e44f6327199d23cf2ab70d8f5176 tests to see if the allocation of buffer[i] failed after i has been incremented, causing it to look at the wrong pointer. Signed-off-by: Kristian Høgsberg --- Argh, the previous patch was wrong, I was testing [i - 1] but decided to just move the increment

[PATCH] dri2: Fix NULL check in allocation error handling

2010-05-17 Thread Kristian Høgsberg
1461b31e40a3e44f6327199d23cf2ab70d8f5176 tests to see if the allocation of buffer[i] failed after i has been incremented, causing it to look at the wrong pointer. Signed-off-by: Kristian Høgsberg --- hw/xfree86/dri2/dri2.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff -

Re: [PATCH v2] Fix build without XACE

2010-05-17 Thread Robert Hooker
On Mon, May 17, 2010 at 1:23 PM, Julien Cristau wrote: > dix/colormap.c and dix/gc.c now dereference a ClientPtr, so they need to > include dixstruct.h.  Regression introduced by commit > 11c69880c7c48ef9e755c4e09fadef7a629d7bc7. > > Reported-by: Robert Hooker > Signed-off-by: Julien Cristau > -

[PATCH util-macros] XORG_MANPAGE_SECTIONS: add MAN_SUBSTS automake variable

2010-05-17 Thread Gaetan Nadon
It will replace the 155 copies in package makefiles Signed-off-by: Gaetan Nadon --- xorg-macros.m4.in | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index 5e89dd1..98e3307 100644 --- a/xorg-macros.m4.in +++ b/xorg-m

Re: [PATCH] dix: explicit use ClientRec declaration from its header

2010-05-17 Thread Jamey Sharp
On Mon, May 17, 2010 at 11:00 AM, Tiago Vignatti wrote: > Fix "dereferencing pointer to incomplete type" errors on both colormap.c and > gc.c > > Signed-off-by: Tiago Vignatti > --- > I found this weird, because tinderbox seems to be okay but not my machine. Julien submitted this patch too. You'

Re: [PATCH v2] Fix build without XACE

2010-05-17 Thread Jamey Sharp
Reviewed-by: Jamey Sharp On Mon, May 17, 2010 at 10:23 AM, Julien Cristau wrote: > dix/colormap.c and dix/gc.c now dereference a ClientPtr, so they need to > include dixstruct.h.  Regression introduced by commit > 11c69880c7c48ef9e755c4e09fadef7a629d7bc7. > > Reported-by: Robert Hooker > Signed

[PATCH] dix: explicit use ClientRec declaration from its header

2010-05-17 Thread Tiago Vignatti
Fix "dereferencing pointer to incomplete type" errors on both colormap.c and gc.c Signed-off-by: Tiago Vignatti --- I found this weird, because tinderbox seems to be okay but not my machine. dix/colormap.c |1 + dix/gc.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH] os: include dix-config.h, not xorg-config.h

2010-05-17 Thread Julien Cristau
os/strlc{at,py}.c were trying to include xorg-config.h, which is not available in dix. Signed-off-by: Julien Cristau --- os/strlcat.c |4 ++-- os/strlcpy.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/os/strlcat.c b/os/strlcat.c index 91ceabb..7d53b0a 100644 --

Re: Server Interpreted "localuser" Authentication using SO_PEERCRED interferes with SSH

2010-05-17 Thread Alan Coopersmith
Tavis Ormandy wrote: > On Mon, May 17, 2010 at 07:56:33AM -0700, Alan Coopersmith wrote: >> Tavis Ormandy wrote: >>> But it turns out this doesnt work with si:localuser authentication, as even >>> though the cookie should be rejected, X falls back to peer credentials. I'm >>> not >>> sure this was

[PATCH v2] Fix build without XACE

2010-05-17 Thread Julien Cristau
dix/colormap.c and dix/gc.c now dereference a ClientPtr, so they need to include dixstruct.h. Regression introduced by commit 11c69880c7c48ef9e755c4e09fadef7a629d7bc7. Reported-by: Robert Hooker Signed-off-by: Julien Cristau --- Actually tested a full build this time... dix/colormap.c |1

Re: [PATCH] Fix build without XACE

2010-05-17 Thread Robert Hooker
On Mon, May 17, 2010 at 12:25 PM, Julien Cristau wrote: > dix/colormap.c now dereferences a ClientPtr, so it needs to include > dixstruct.h.  Regression introduced by commit > 11c69880c7c48ef9e755c4e09fadef7a629d7bc7. > > Reported-by: Robert Hooker > Signed-off-by: Julien Cristau > --- >  dix/co

Re: [PATCH util-macros] XORG_WITH_LINT: rework and extend platform coverage

2010-05-17 Thread Alan Coopersmith
Gaetan Nadon wrote: > On Mon, 2010-05-17 at 08:07 -0700, Alan Coopersmith wrote: >> Gaetan Nadon wrote: >> > Guess the lint program name by platform. >> > Use ARG variable for user input values. >> > Provide default flags per platform. >> >> So when I want to check with sparse on Solaris, instead o

Re: [PATCH util-macros] XORG_WITH_LINT: rework and extend platform coverage

2010-05-17 Thread Gaetan Nadon
On Mon, 2010-05-17 at 08:07 -0700, Alan Coopersmith wrote: > Gaetan Nadon wrote: > > Guess the lint program name by platform. > > Use ARG variable for user input values. > > Provide default flags per platform. > > So when I want to check with sparse on Solaris, instead of --with-lint=sparse > now

Re: [PATCH] Fix build without XACE

2010-05-17 Thread Keith Packard
On Mon, 17 May 2010 18:25:59 +0200, Julien Cristau wrote: > dix/colormap.c now dereferences a ClientPtr, so it needs to include > dixstruct.h. Regression introduced by commit > 11c69880c7c48ef9e755c4e09fadef7a629d7bc7. xace.h includes selection.h which includes dixstruct.h when XACE is defined,

Re: [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

2010-05-17 Thread Keith Packard
On Mon, 17 May 2010 07:50:25 +0300, Oliver McFadden wrote: > Previously the cursor code would be called even with a "hidden" cursor. > This was because the X server used an invisible 1x1 cursor sprite, > rather than a NULL cursor. > > This will help performance when XDefineCursor() is never call

Re: [PATCH v2] xfree86: Add option parsing for percent options.

2010-05-17 Thread Keith Packard
On Mon, 17 May 2010 12:52:47 +1000, Peter Hutterer wrote: > hw/xfree86/common/xf86Opt.h|4 +++ > hw/xfree86/common/xf86Option.c | 47 > Just looking at how other OPTV_ values are used, I don't see a patch to optionTypeToString in xf86Configure

[PATCH] Fix build without XACE

2010-05-17 Thread Julien Cristau
dix/colormap.c now dereferences a ClientPtr, so it needs to include dixstruct.h. Regression introduced by commit 11c69880c7c48ef9e755c4e09fadef7a629d7bc7. Reported-by: Robert Hooker Signed-off-by: Julien Cristau --- dix/colormap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) dif

Re: [PATCH util-macros] XORG_LINT_LIBRARY: rework to match XORG_WITH_LINT

2010-05-17 Thread Alan Coopersmith
Gaetan Nadon wrote: > XORG_LINT_LIBRARY has implementations dependencies on XORG_WITH_LINT > The library name can no longer be set by overloading the semantic > of --enable-lint-library. > If this function is required it should be added using an AC_ARG_VAR. > > Signed-off-by: Gaetan Nadon > --- >

Re: [PATCH util-macros] XORG_WITH_LINT: rework and extend platform coverage

2010-05-17 Thread Alan Coopersmith
Gaetan Nadon wrote: > Guess the lint program name by platform. > Use ARG variable for user input values. > Provide default flags per platform. So when I want to check with sparse on Solaris, instead of --with-lint=sparse now I have to do --with-lint LINT=SPARSE ? I guess I can learn to type that

Re: Server Interpreted "localuser" Authentication using SO_PEERCRED interferes with SSH

2010-05-17 Thread Alan Coopersmith
Tavis Ormandy wrote: > The problem is, if I'm using xhost +si:localuser:taviso, once the > timeout has expired, X will fall back to SO_PEERCRED verification. As > openssh opened the connection, the credentials check out and I'm > authenticated. This is bad, because now the remote (possibly compromi

[PATCH util-macros] XORG_RELEASE_VERSION: remove option --with-release-version #24816

2010-05-17 Thread Gaetan Nadon
The short story: - this option has never been used by OS builders as intended - the implementation changes automake internals - the implementation breaks a few makefiles (if used) - one less option for the user to be confused with on all 240 xorg modules The long story: https://bugs.freedesktop.or

Re: Composite Quesiton

2010-05-17 Thread Jonathan Morton
On Mon, 2010-05-17 at 17:39 +0800, Huang, FrankR wrote: > You can imagine the result of this test. I attached the > result of this application. I can understand the green part , but for > the black part, I have no idea. Is it all solid to black??? The (src IN mask) part essentially mod

[PATCH util-macros] XORG_LINT_LIBRARY: rework to match XORG_WITH_LINT

2010-05-17 Thread Gaetan Nadon
XORG_LINT_LIBRARY has implementations dependencies on XORG_WITH_LINT The library name can no longer be set by overloading the semantic of --enable-lint-library. If this function is required it should be added using an AC_ARG_VAR. Signed-off-by: Gaetan Nadon --- xorg-macros.m4.in | 29 +

[PATCH util-macros] XORG_WITH_LINT: rework and extend platform coverage

2010-05-17 Thread Gaetan Nadon
Guess the lint program name by platform. Use ARG variable for user input values. Provide default flags per platform. Signed-off-by: Gaetan Nadon --- xorg-macros.m4.in | 77 + 1 files changed, 54 insertions(+), 23 deletions(-) diff --git a/xo

Composite Quesiton

2010-05-17 Thread Huang, FrankR
Hi, all I want to ask you guys a question about composite. A condition: dest: a 100x100 picture(all white color) source: a 1x1 picture with repeat parameter (PICT_x8r8g8b8, color green)