Re: include/list.h

2010-06-11 Thread Keith Packard
On Fri, 11 Jun 2010 15:24:47 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: isn't the whole point of the list macros that we don't have dozens of different list implementations, all with their own bugs? you're just moving the problem, not fixing it. For a singly linked list which is

Re: [PATCH] xfixes: avoid double-free of CursorScreenRec

2010-06-11 Thread Keith Packard
On Fri, 11 Jun 2010 14:26:57 +1000, Ben Skeggs skeg...@gmail.com wrote: Without resetting the private's pointer to NULL, we can end up freeing the struct twice: ==11188== Invalid free() / delete / delete[] ==11188==at 0x4C24D72: free (vg_replace_malloc.c:325) ==11188==by 0x42D8A3:

Re: include/list.h

2010-06-11 Thread Peter Hutterer
On Thu, Jun 10, 2010 at 11:04:20PM -0700, Keith Packard wrote: On Fri, 11 Jun 2010 15:24:47 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: isn't the whole point of the list macros that we don't have dozens of different list implementations, all with their own bugs? you're just

Re: [PATCH] xfixes: avoid double-free of CursorScreenRec

2010-06-11 Thread Ben Skeggs
On Thu, 2010-06-10 at 23:08 -0700, Keith Packard wrote: On Fri, 11 Jun 2010 14:26:57 +1000, Ben Skeggs skeg...@gmail.com wrote: Without resetting the private's pointer to NULL, we can end up freeing the struct twice: ==11188== Invalid free() / delete / delete[] ==11188==at

Re: Another approach to multitouch handling

2010-06-11 Thread Carlos Garnacho
Hi!, been thinking a while about this... On Mon, 2010-06-07 at 01:20 -0400, Rafi Rubin wrote: snip So are you saying you actually want to be able to subscribe to events from a mt finger in window that's next to the window with the rest of the fingers? Is that really a good idea? I

Re: Performance improvement to vga arbitration

2010-06-11 Thread Tiago Vignatti
Henry, Thanks for bring up this idea to the community. I'm cc-ing Benjamin and nVidia guys who were recently discussing more in-depth improvements on this area (I'm not exactly working on it; just doing some fixes here and there). Anyway, I'll post some comments bellow. On Thu, Jun 10, 2010 at

[PULL v2] Memory cleanups

2010-06-11 Thread Mikhail Gusarov
The following changes since commit 620ca54aaa0b363fcf68cec1bd6c37e68c988352: Merge remote branch 'alanc/master' (2010-06-10 19:18:53 -0700) are available in the git repository at: git://anongit.freedesktop.org/~dottedmag/xserver for-keithp Matt Turner (2): record: move

[PATCH 1/2 v2] Use one single function to register fpe functions

2010-06-11 Thread Tiago Vignatti
X server doesn't need to understand fpe internals, so let it transparent turning all registration functions in a single one. For that, fill the already existent register_fpe_functions(). Some X servers don't want font server support, so this patch also sets font server support to be configured in

[PATCH 2/2 v2] configure: don't check xfont always for each server

2010-06-11 Thread Tiago Vignatti
It's already defined inside REQUIRED_LIBS and all DDX are getting it already. No semantical changes. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Alex Deucher alexdeuc...@gmail.com --- Just clean-up configure.ac |8

[PATCH 1/2 v2] dix: use one single function to register fpe fonts

2010-06-11 Thread Tiago Vignatti
X server doesn't need to understand fpe internals, so use register_fpe_functions from libXfont. It's required to get new version of libXfont, therefore adjust it to be passed to autoconf. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net

[PATCH 2/2 v2] libXfont 1.4.2

2010-06-11 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- changes from v1: - Do not bump -version-number, because we're not breaking old compatibility (kudos to Daniel Stone). configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac

Re: [PATCH 1/2 v2] Use one single function to register fpe functions

2010-06-11 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Fri, Jun 11, 2010 at 02:35:23PM +0200, Vignatti Tiago (Nokia-D/Helsinki) wrote: X server doesn't need to understand fpe internals, so let it transparent turning all registration functions in a single one. For that, fill the already existent register_fpe_functions(). Some X servers don't

Re: [PATCH] exa: fix ExaCheckCopyNtoN for exa_classic when source = dest

2010-06-11 Thread Michel Dänzer
On Fre, 2010-06-11 at 00:03 +0200, Éric Piel wrote: This patch originally written by Yves fixes this bug: https://bugs.freedesktop.org/show_bug.cgi?id=28077 Could someone review and apply it? I already reviewed it on the bug report, so Reviewed-by: Michel Dänzer mic...@daenzer.net

Re: include/list.h

2010-06-11 Thread Tiago Vignatti
On Fri, Jun 11, 2010 at 08:41:44AM +0200, ext Peter Hutterer wrote: On Thu, Jun 10, 2010 at 11:04:20PM -0700, Keith Packard wrote: On Fri, 11 Jun 2010 15:24:47 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: isn't the whole point of the list macros that we don't have dozens of

Re: include/list.h

2010-06-11 Thread Dan Nicholson
On Thu, Jun 10, 2010 at 10:13 PM, Keith Packard kei...@keithp.com wrote: Argh! A recent commit to the xf86 config parsing code added list.h to xf86Parser.h, which is included by drivers to look stuff up. Because of this, the intel driver no longer builds against master (would that the drivers

Re: [PATCH] mi: do not use X11/extensions/shape.h header from libXext

2010-06-11 Thread Dan Nicholson
On Fri, Jun 11, 2010 at 6:21 AM, Mikhail Gusarov dotted...@dottedmag.net wrote: Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Dan Nicholson dbn.li...@gmail.com or Tested-by: Dan Nicholson dbn.li...@gmail.com ___

[PATCH 1/2] mi: do not use X11/extensions/shape.h header from libXext

2010-06-11 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net Tested-by: Dan Nicholson dbn.li...@gmail.com --- mi/miwindow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mi/miwindow.c b/mi/miwindow.c index 51c5cc8..25dd1c0 100644 --- a/mi/miwindow.c +++ b/mi/miwindow.c @@

Re: include/list.h

2010-06-11 Thread Daniel Stone
On Fri, Jun 11, 2010 at 06:50:27AM -0700, Dan Nicholson wrote: On Thu, Jun 10, 2010 at 10:13 PM, Keith Packard kei...@keithp.com wrote: Argh! A recent commit to the xf86 config parsing code added list.h to xf86Parser.h, which is included by drivers to look stuff up. Because of this, the

Re: [PATCH 1/2 v2] dix: use one single function to register fpe fonts

2010-06-11 Thread Julien Cristau
On Fri, Jun 11, 2010 at 15:35:25 +0300, Tiago Vignatti wrote: @@ -810,6 +811,9 @@ LIBGLIB=glib-2.0 = 2.16 LIBUDEV=libudev = 143 LIBSELINUX=libselinux = 2.0.86 +PKG_CHECK_MODULES([XFONT], $LIBXFONT) +REQUIRED_LIBS=$REQUIRED_LIBS $LIBXFONT + if test x$CONFIG_UDEV = xyes { test

[PATCH input-evdev 1/2] config: upgrade to util-macros 1.8 for additional man page support

2010-06-11 Thread Gaetan Nadon
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS The value of MAN_SUBST is the same for all X.Org packages. Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS The existing statement can now be removed from the configuration file. Use Automake $() for variables in Makefile.am Signed-off-by:

[PATCH input-evdev 2/2] config: use AC_PROG_INSTALL now supplied by XORG_DEFAULT_OPTIONS

2010-06-11 Thread Gaetan Nadon
It depends on util-macros 1.8 The existing statement can now be removed from the configuration file. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index aa7ba18..63460b7

Re: DRI2 fixes for 1.8-branch

2010-06-11 Thread Jesse Barnes
On Fri, 11 Jun 2010 11:23:53 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: I've got a few DRI2 cherry-picks for 1.8 on git://people.freedesktop.org/~whot/xserver.git server-1.8-branch Cherry-picking them was more complicated than I hoped for since we had one of the patches reverted,

[PATCH] mi: Remove unused overlay support

2010-06-11 Thread Mikhail Gusarov
The only reference to it in server and drivers is in XAA overlay code which would segfault as no miInitOverlay is called ever. Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- hw/xfree86/loader/sdksyms.sh |2 - hw/xfree86/xaa/xaaOverlay.c | 10 +- mi/Makefile.am |

[PATCH input-keyboard 4/4] config: restore inputdir automake variable

2010-06-11 Thread Gaetan Nadon
All input drivers use this variable to set the installation path of the input module. For this driver, it was changed in commit 708ecbf8557d9e676e3bb07c1f83170f6d9f7cd7. One way or another is fine, but breaking a pattern is error prone. Also restore the use of DRIVER_NAME variable. Signed-off-by:

[PATCH 5/5] os: Remove unused dev_tty_from_init variable

2010-06-11 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- os/utils.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/os/utils.c b/os/utils.c index 7523d9e..84136bd 100644 --- a/os/utils.c +++ b/os/utils.c @@ -205,8 +205,6 @@ int auditTrailLevel = 1; #define

[PATCH 0/5] mi,os: Dead code removal

2010-06-11 Thread Mikhail Gusarov
Removing obviously dead code with no users in server or drivers hosted on fd.o. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 3/5] os: Remove unused lockit function

2010-06-11 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- os/utils.c | 17 - 1 files changed, 0 insertions(+), 17 deletions(-) diff --git a/os/utils.c b/os/utils.c index 2678d24..f6bcecb 100644 --- a/os/utils.c +++ b/os/utils.c @@ -1858,20 +1858,3 @@ error: free(list);

[PATCH 2/5] os: Remove unused pread/pwrite functions

2010-06-11 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- os/utils.c | 33 - 1 files changed, 0 insertions(+), 33 deletions(-) diff --git a/os/utils.c b/os/utils.c index 92bfad3..2678d24 100644 --- a/os/utils.c +++ b/os/utils.c @@ -1874,37 +1874,4 @@ lockit

[PATCH 4/5] os: remove unused set_font_authorizations function

2010-06-11 Thread Mikhail Gusarov
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- include/os.h |5 os/utils.c | 67 -- 2 files changed, 0 insertions(+), 72 deletions(-) diff --git a/include/os.h b/include/os.h index efa202c..6f79ddc 100644 ---

[PATCH 1/5] mi: Remove unused overlay support

2010-06-11 Thread Mikhail Gusarov
The only reference to it in server and drivers is in XAA overlay code which would segfault as no miInitOverlay is called ever. Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- hw/xfree86/loader/sdksyms.sh |2 - hw/xfree86/xaa/xaaOverlay.c | 29 +- mi/Makefile.am |

[PATCH] Bug 25874 - coredump on X -showopts

2010-06-11 Thread Alan Coopersmith
Don't try walking the xf86ConfigLayout.screens table if it's empty https://bugs.freedesktop.org/show_bug.cgi?id=25874 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/common/xf86Helper.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 1/5] mi: Remove unused overlay support

2010-06-11 Thread Jamey Sharp
On Fri, Jun 11, 2010 at 11:22 AM, Mikhail Gusarov dotted...@dottedmag.net wrote: The only reference to it in server and drivers is in XAA overlay code which would segfault as no miInitOverlay is called ever. Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net ---  

Re: [PATCH input-keyboard 4/4] config: restore inputdir automake variable

2010-06-11 Thread Julien Cristau
On Fri, Jun 11, 2010 at 14:06:41 -0400, Gaetan Nadon wrote: All input drivers use this variable to set the installation path of the input module. For this driver, it was changed in commit 708ecbf8557d9e676e3bb07c1f83170f6d9f7cd7. One way or another is fine, but breaking a pattern is error

Re: [PATCH 4/5] os: remove unused set_font_authorizations function

2010-06-11 Thread Alan Coopersmith
Sorry, but set_font_authorizations is used - it's called from libXfont. (Well, it's used in theory - I don't think anyone ever really used the font server license/authorization checking support.) -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform

Re: [PATCH 2/5] os: Remove unused pread/pwrite functions

2010-06-11 Thread Jamey Sharp
Reviewed-by: Jamey Sharp ja...@minilop.net I'd suggest squashing the deletion of lockit into this patch too, so the entire __SCO__ block goes away together. It looks like the last use of pread in xserver was deleted when xprint went away, and I can't find any uses of pwrite in the git history.

Re: [PATCH 4/5] os: remove unused set_font_authorizations function

2010-06-11 Thread Thomas Dickey
On Fri, 11 Jun 2010, Alan Coopersmith wrote: Sorry, but set_font_authorizations is used - it's called from libXfont. (Well, it's used in theory - I don't think anyone ever really used the font server license/authorization checking support.) It used to be one of the nuisances in installing

Re: [PATCH 5/5] os: Remove unused dev_tty_from_init variable

2010-06-11 Thread Jamey Sharp
This has apparently never been used at any point in the xserver git history. Reviewed-by: Jamey Sharp ja...@minilop.net On Fri, Jun 11, 2010 at 11:22 AM, Mikhail Gusarov dotted...@dottedmag.net wrote: Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net ---  os/utils.c |    5 +  1

Re: [PATCH input-keyboard 4/4] config: restore inputdir automake variable

2010-06-11 Thread Gaetan Nadon
On Fri, 2010-06-11 at 20:31 +0200, Julien Cristau wrote: On Fri, Jun 11, 2010 at 14:06:41 -0400, Gaetan Nadon wrote: All input drivers use this variable to set the installation path of the input module. For this driver, it was changed in commit 708ecbf8557d9e676e3bb07c1f83170f6d9f7cd7.

Re: [PATCH 1/5] mi: Remove unused overlay support

2010-06-11 Thread Mikhail Gusarov
Twas brillig at 11:29:26 11.06.2010 UTC-07 when ja...@minilop.net did gyre and gimble: JS It wasn't obvious to me that the patch was correct, because you JS pretend that miOverlayCopyUnderlay returns false instead of JS crashing. But on further inspection I see that XAACopyWindow8_32 JS

Re: [PATCH 4/5] os: remove unused set_font_authorizations function

2010-06-11 Thread Alan Coopersmith
Thomas Dickey wrote: On Fri, 11 Jun 2010, Alan Coopersmith wrote: Sorry, but set_font_authorizations is used - it's called from libXfont. (Well, it's used in theory - I don't think anyone ever really used the font server license/authorization checking support.) It used to be one of the

Re: [PATCH 4/5] os: remove unused set_font_authorizations function

2010-06-11 Thread Thomas Dickey
On Fri, 11 Jun 2010, Alan Coopersmith wrote: Thomas Dickey wrote: On Fri, 11 Jun 2010, Alan Coopersmith wrote: Sorry, but set_font_authorizations is used - it's called from libXfont. (Well, it's used in theory - I don't think anyone ever really used the font server license/authorization

Re: include/list.h

2010-06-11 Thread Dan Nicholson
On Thu, Jun 10, 2010 at 10:13 PM, Keith Packard kei...@keithp.com wrote: Argh! A recent commit to the xf86 config parsing code added list.h to xf86Parser.h, which is included by drivers to look stuff up. Because of this, the intel driver no longer builds against master (would that the drivers

Re: performance of USB mouse initialization on startup

2010-06-11 Thread Mikhail Gusarov
Twas brillig at 12:26:34 09.06.2010 UTC-07 when jrbarne...@chromium.org did gyre and gimble: RB Any advice on this? Just use the evdev driver instead. It relies on Linux kernel drivers. xf86-input-mouse is mostly for backward compatibility (e.g. serial mice which don't have evdev kernel

Re: [PATCH] mi: Remove unused overlay support

2010-06-11 Thread Jamey Sharp
On Fri, Jun 11, 2010 at 12:33 PM, Andy Ritger arit...@nvidia.com wrote: Hi Mikhail, The NVIDIA X driver uses the X server's mi overlay support (I believe NVIDIA engineers contributed the mi overlay code, originally).  Perhaps the FireGL driver uses it, too?  Overlays are still compelling for

Re: [PATCH 4/5] os: remove unused set_font_authorizations function

2010-06-11 Thread Mikhail Gusarov
Twas brillig at 11:38:39 11.06.2010 UTC-07 when alan.coopersm...@oracle.com did gyre and gimble: AC Sorry, but set_font_authorizations is used - it's called from libXfont. Argh, I always forget that not only drivers rummage in server's guts, but libraries too. I have removed this patch. --

(no) xkbcomp in server -- simpler solution?

2010-06-11 Thread Mikhail Gusarov
Hi, Removal of xkbcomp fork/exec on servert startup is quite hard task -- why not shift responsibility to client side: start server with some predefined keymap and make running xkbcomp the responsibility of session scripts? This change will make xkb data completely client-side (though given

Re: Smooth scrolling - results!

2010-06-11 Thread Max Schwarz
Hi, results! I'm finally content with how the code looks and feels :-) Comparison: before: http://c-palb.de/~max/before.ogg after: http://c-palb.de/~max/after.ogg The videos don't do the change justice, it feels _much_ more natural. I had to patch the respective input drivers, the server

Re: (no) xkbcomp in server -- simpler solution?

2010-06-11 Thread Daniel Stone
Hi, On Sat, Jun 12, 2010 at 04:27:41AM +0700, Mikhail Gusarov wrote: Removal of xkbcomp fork/exec on servert startup is quite hard task -- why not shift responsibility to client side: start server with some predefined keymap and make running xkbcomp the responsibility of session scripts?

Re: (no) xkbcomp in server -- simpler solution?

2010-06-11 Thread Mikhail Gusarov
Twas brillig at 23:56:14 11.06.2010 UTC+01 when dan...@fooishbar.org did gyre and gimble: This change will make xkb data completely client-side (though given clients may connect from different hosts xkb introspection cannot be dropped from protocol). It should be easy enough (much

Re: [PATCH xfs] Clean up some pointer signedness warnings

2010-06-11 Thread Alan Coopersmith
Found this buried in my patches-todo folder, so finally pushed it to git master. Thanks for the fix and sorry for the months of delay. -alan- Jeff Smith wrote: Signed-off-by: Jeff Smith whydo...@yahoo.com --- difs/difsutils.c |2 +- 1 files changed, 1 insertions(+), 1

x.org documentation (extension tutorial)

2010-06-11 Thread Matt Dew
Hi all, Tapani Palli over at maemo has a nice little extension tutorial over at: http://wiki.maemo.org/X11_Extension_tutorial It's moving to Xorg's wiki here: http://www.x.org/wiki/X11_Extension_tutorial I'm not knowledgable enough (yet. ;) ) to help update this page. Can people fill in the