Re: [PATCH] exa: fix ExaCheckCopyNtoN for exa_classic when source = dest

2010-06-12 Thread Éric Piel
Op 11-06-10 15:13, Michel Dänzer schreef: On Fre, 2010-06-11 at 00:03 +0200, Éric Piel wrote: This patch originally written by Yves fixes this bug: https://bugs.freedesktop.org/show_bug.cgi?id=28077 Could someone review and apply it? I already reviewed it on the bug report, so

Re: [PATCH] xephyr: Re-enabled Xnest fix for focus in + modifier bug.

2010-06-12 Thread Xiaoyang Yu (Max)
-Original Message- From: Mikhail Gusarov [mailto:dotted...@dottedmag.net] Sent: 2010年6月7日 14:55 To: Yu, Max A Cc: xorg-devel@lists.x.org Subject: Re: [PATCH] xephyr: Re-enabled Xnest fix for focus in + modifier bug. Twas brillig at 10:24:26 07.06.2010 UTC+08 when

Re: [PATCH] xephyr: Re-enabled Xnest fix for focus in + modifier bug.

2010-06-12 Thread Mikhail Gusarov
Twas brillig at 15:22:15 12.06.2010 UTC+08 when max.a...@intel.com did gyre and gimble: Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net XY Is this mean that my patch is accepted? I checked the git tree XY frequently but have not see my patch there. It's reviewed :) XY Should I do

[PATCH] Re-enabled Xnest fix for focus in + modifier bug.

2010-06-12 Thread Xiaoyang Yu (Max)
Signed-off-by: Xiaoyang Yu (Max) max.a...@intel.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net --- hw/kdrive/ephyr/ephyr.c | 107 --- 1 files changed, 45 insertions(+), 62 deletions(-) diff --git a/hw/kdrive/ephyr/ephyr.c

Re: [PATCH] xephyr: Re-enabled Xnest fix for focus in + modifier bug.

2010-06-12 Thread Fernando Carrijo
Xiaoyang Yu (Max) wrote: Is this mean that my patch is accepted? I checked the git tree frequently but have not see my patch there. Should I do anything else? Or just wait is okay? By the way, some people prefer to subscribe to xorg-commit instead of frequently fetching the latest changes of

[no subject]

2010-06-12 Thread Huang, FrankR
Morton, After I fix the PictOpOver operation, the geode still has another rendering issue. That is also serious. I attached a picture, please take a look. I have not find the root cause. I use this simple gtk program to reproduce. When I move the mouse on the button, some green

Rendering in geode

2010-06-12 Thread Huang, FrankR
Resend it. Forget the subject. -Original Message- From: Huang, FrankR Sent: 2010?6?12? 17:43 To: 'jonathan.mor...@movial.com' Cc: 'xorg-devel@lists.x.org'; xorg-driver-ge...@lists.x.org Subject: Morton, After I fix the PictOpOver operation, the geode still has another

Re: Smooth scrolling - results!

2010-06-12 Thread Simon Thum
Am 12.06.2010 00:33, schrieb Max Schwarz: Hi, results! I'm finally content with how the code looks and feels :-) Comparison: before: http://c-palb.de/~max/before.ogg after: http://c-palb.de/~max/after.ogg The videos don't do the change justice, it feels _much_ more natural. I

Re: [PATCH 5/5] os: Remove unused dev_tty_from_init variable

2010-06-12 Thread Tiago Vignatti
On Fri, Jun 11, 2010 at 08:22:51PM +0200, ext Mikhail Gusarov wrote: Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- os/utils.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/os/utils.c b/os/utils.c index 7523d9e..84136bd 100644 --- a/os/utils.c

Re: [PATCH 5/5] os: Remove unused dev_tty_from_init variable

2010-06-12 Thread Julien Cristau
On Sat, Jun 12, 2010 at 15:34:50 +0300, Tiago Vignatti wrote: On Fri, Jun 11, 2010 at 08:22:51PM +0200, ext Mikhail Gusarov wrote: @@ -879,8 +877,7 @@ ProcessCommandLine(int argc, char *argv[]) } else if (strncmp (argv[i], tty, 3) == 0) { and why keep checking for this

Re: [PATCH] Bug 25874 - coredump on X -showopts

2010-06-12 Thread Tiago Vignatti
On Fri, Jun 11, 2010 at 08:29:25PM +0200, ext Alan Coopersmith wrote: Don't try walking the xf86ConfigLayout.screens table if it's empty https://bugs.freedesktop.org/show_bug.cgi?id=25874 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/common/xf86Helper.c |7

[PATCH] mi: delete unused code

2010-06-12 Thread Tiago Vignatti
pBSReg is always NULL, so the statement after the conditional will never be reached. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- mi/miwindow.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/mi/miwindow.c b/mi/miwindow.c index 51c5cc8..d461eff 100644

Re: [PATCH] mi: delete unused code

2010-06-12 Thread Mikhail Gusarov
Twas brillig at 16:59:58 12.06.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: TV pBSReg is always NULL, so the statement after the conditional will never be TV reached. TV Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov

[PATCH] dix: fix NULL pointer dereferenced in memset

2010-06-12 Thread Tiago Vignatti
Apparently memset doesn't complain if the memory area is null (addr) and something is being written there. Even though, this patch guarantees that nothing is written at 0x0 memory address. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Honestly I didn't check if the code surrounding

Re: [PATCH] Bug 25874 - coredump on X -showopts

2010-06-12 Thread Alan Coopersmith
Tiago Vignatti wrote: On Fri, Jun 11, 2010 at 08:29:25PM +0200, ext Alan Coopersmith wrote: Don't try walking the xf86ConfigLayout.screens table if it's empty https://bugs.freedesktop.org/show_bug.cgi?id=25874 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---

Re: [PATCH] dix: fix NULL pointer dereferenced in memset

2010-06-12 Thread Jamey Sharp
Hi Tiago! On Sat, Jun 12, 2010 at 7:39 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Apparently memset doesn't complain if the memory area is null (addr) and something is being written there. Even though, this patch guarantees that nothing is written at 0x0 memory address. I'm confused

Re:

2010-06-12 Thread Alex Deucher
On Sat, Jun 12, 2010 at 5:43 AM, Huang, FrankR frankr.hu...@amd.com wrote: Morton,        After I fix the PictOpOver operation, the geode still has another rendering issue. That is also serious. I attached a picture, please take a look. I have not find the root cause.        I use this

[PATCH] Delete unused lastWinOrg field from GCs.

2010-06-12 Thread Jamey Sharp
Signed-off-by: Jamey Sharp ja...@minilop.net --- dix/gc.c |4 fb/fbgc.c |3 --- hw/xnest/GC.c |2 -- include/gcstruct.h |1 - 4 files changed, 0 insertions(+), 10 deletions(-) diff --git a/dix/gc.c b/dix/gc.c index 6da243e..83bb524 100644 ---

[PATCH] fb: Delete unused oneRect private field.

2010-06-12 Thread Jamey Sharp
Signed-off-by: Jamey Sharp ja...@minilop.net --- fb/fb.h |1 - fb/fbgc.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fb/fb.h b/fb/fb.h index a06f98b..c290ebf 100644 --- a/fb/fb.h +++ b/fb/fb.h @@ -666,7 +666,6 @@ typedef struct { FbBits bgand,

Re: [PATCH] dix: fix NULL pointer dereferenced in memset

2010-06-12 Thread Vignatti Tiago (Nokia-D/Helsinki)
Hey Jamey, On Sat, Jun 12, 2010 at 05:23:09PM +0200, ext Jamey Sharp wrote: On Sat, Jun 12, 2010 at 7:39 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: Apparently memset doesn't complain if the memory area is null (addr) and something is being written there. Even though, this patch

Re: [PATCH] fb: Delete unused oneRect private field.

2010-06-12 Thread Mikhail Gusarov
Twas brillig at 08:53:03 12.06.2010 UTC-07 when ja...@minilop.net did gyre and gimble: JS Signed-off-by: Jamey Sharp ja...@minilop.net Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpwAGfx0C7IA.pgp Description: PGP signature

Re: Smooth scrolling - results!

2010-06-12 Thread Max Schwarz
Hi Simon, You'll have to rebase them against git master to get into mainline. Why didn't you use git master to start with? That's because I like to work with the versions I have installed. Otherwise I would need to compile the whole Xorg stack, this way I can just change one component at a

Re: x.org documentation (extension tutorial)

2010-06-12 Thread Alan Coopersmith
Matt Dew wrote: Hi all, Tapani Palli over at maemo has a nice little extension tutorial over at: http://wiki.maemo.org/X11_Extension_tutorial It's moving to Xorg's wiki here: http://www.x.org/wiki/X11_Extension_tutorial Cool, thanks to both of you for working on this. I'm not

Filling Trapezoids with XRender

2010-06-12 Thread Sunny Sachanandani
I have this small section of code: XRenderColor foreground = {0x, 0x, 0x, 0x}; Picture fill = XRenderCreateSolidFill(dpy, foreground); XTrapezoid trap; trap.top = trap.left.p1.y = trap.right.p1.y = XDoubleToFixed(0.25); trap.bottom = trap.left.p2.y =

Re: [PATCH] Use new server API to find the root window.

2010-06-12 Thread Chris Ball
Ping -- could someone help resolve this regression, please? On Fri, Jun 04, 2010 at 04:23:45PM -0700, Jamey Sharp wrote: Signed-off-by: Jamey Sharp ja...@minilop.net --- Um, yeah. I even made a note in the commit message to remind myself to find out how to handle ABI changes in the drivers.

Re: [Xcb] x.org documentation (extension tutorial)

2010-06-12 Thread Vincent Torri
On Sat, 12 Jun 2010, Alan Coopersmith wrote: Matt Dew wrote: Hi all, Tapani Palli over at maemo has a nice little extension tutorial over at: http://wiki.maemo.org/X11_Extension_tutorial It's moving to Xorg's wiki here: http://www.x.org/wiki/X11_Extension_tutorial Cool, thanks to both

[PATCH 1/3] xcompmgr: implement -b to set default root fill color

2010-06-12 Thread Forest Bond
A color name can be passed to specify the background fill color to use if no root window pixmap is set. If it is not specified, the previous default (a gray) is used. Signed-off-by: Forest Bond for...@alittletooquiet.net --- xcompmgr.c | 34 -- 1 files changed,

[PATCH 3/3] xcompmgr: fix window adding with re-used window ids

2010-06-12 Thread Forest Bond
The X server can re-use window ids once a window has been destroyed. However, xcompmgr does not forget about window ids until after the window has finished fading out. If a window is destroyed and a new window with the same id is added before the first window fades out, the new window never

[PATCH 2/3] xcompmgr: prevent flicker on root background pixmap change

2010-06-12 Thread Forest Bond
Changes to the root background pixmap would previously cause the new image to flicker into visibility briefy before windows were redrawn over it. This patch fixes this by dropping a XClearWindow call and providing a new function (damage_screen) to force a redraw of the entire screen.

[PATCH] Delete unused devPrivate field from GCFuncs and GCOps.

2010-06-12 Thread Jamey Sharp
Signed-off-by: Jamey Sharp ja...@minilop.net --- hw/xfree86/common/xf86VGAarbiter.c |1 - hw/xfree86/shadowfb/shadow.c |1 - hw/xfree86/xaa/xaaFallback.c |1 - hw/xfree86/xaa/xaaGC.c |1 - include/gcstruct.h |3 --- miext/damage/damage.c

Re: [PATCH 1/3] xcompmgr: implement -b to set default root fill color

2010-06-12 Thread Forest Bond
Hi, Please disregard this patch. I will resend with adjustments tomorrow. Sorry for the noise. Thanks, Forest On Sat, Jun 12, 2010 at 06:38:52PM -0400, Forest Bond wrote: A color name can be passed to specify the background fill color to use if no root window pixmap is set. If it is not

Re: [PATCH 2/3] xcompmgr: prevent flicker on root background pixmap change

2010-06-12 Thread Forest Bond
Hi, Please disregard this patch. I will resend with adjustments tomorrow. Sorry for the noise. Thanks, Forest On Sat, Jun 12, 2010 at 06:39:47PM -0400, Forest Bond wrote: Changes to the root background pixmap would previously cause the new image to flicker into visibility briefy before

Re: [PATCH 3/3] xcompmgr: fix window adding with re-used window ids

2010-06-12 Thread Forest Bond
Hi, Please disregard this patch. I will resend with adjustments tomorrow. Sorry for the noise. Thanks, Forest On Sat, Jun 12, 2010 at 06:39:59PM -0400, Forest Bond wrote: The X server can re-use window ids once a window has been destroyed. However, xcompmgr does not forget about window ids

Re: [PATCH] exa: fix ExaCheckCopyNtoN for exa_classic when source = dest

2010-06-12 Thread Peter Hutterer
On Sat, Jun 12, 2010 at 08:57:00AM +0200, Éric Piel wrote: Op 11-06-10 15:13, Michel Dänzer schreef: On Fre, 2010-06-11 at 00:03 +0200, Éric Piel wrote: This patch originally written by Yves fixes this bug: https://bugs.freedesktop.org/show_bug.cgi?id=28077 Could someone review and