[PATCH] xfree86: parser: Fix using heap memory for driver names. (Fixes #17438)

2010-08-04 Thread Jesse Adkins
I also put this patch in bugzilla, in case it might help somebody in the future. While I'm at it, can I get some thoughts about logging this as a warning or informational. What about deprecating this feature? From e82132c1d1a6a182d2844ae3de30eb1409e3505c Mon Sep 17 00:00:00 2001 From: Jesse Adkins

[PATCH] xfree86: Proper fixing of leaks in OpenConfigFile and OpenConfigDir.

2010-08-04 Thread Jesse Adkins
Previous versions of this patch had whitespace damage (I expected everything was fine, since I was using git send-email), and had a missing semicolon. I've attached the patch, so it can escape gmail's mangling until I can figure something else out. I'm sending this patch mostly because of the seco

Re: [PATCH 2/2] dix: Fix indentation in WaitForSomething

2010-08-04 Thread Fernando Carrijo
>From 2aa4c74e43556c227ac8c4966689e178c9cbbe40 Mon Sep 17 00:00:00 2001 From: Fernando Carrijo Date: Wed, 4 Aug 2010 23:39:21 -0300 Subject: [PATCH 2/2] dix: Fix indentation in WaitForSomething Reviewed-by: Jamey Sharp Reviewed-by: Tiago Vignatti Signed-off-by: Fernando Carrijo --- os/WaitFor

Re: [PATCH 1/2] dix: Better document Dispatch, WaitForInput and friends

2010-08-04 Thread Fernando Carrijo
>From fb429c58c113d6a2d38324644239e08b103d6c37 Mon Sep 17 00:00:00 2001 From: Fernando Carrijo Date: Wed, 4 Aug 2010 23:34:24 -0300 Subject: [PATCH 1/2] dix: Better document Dispatch, WaitForSomething and friends Wrote this patch more as an exercise than anything else. And while I realize that th

[PATCH v3] dix: Better document Dispatch, WaitForInput and friends

2010-08-04 Thread Fernando Carrijo
In the previous version of this patch series, Tiago recommended a minor stylistic modification in the comment created for SmartScheduleClient(). That's what I've done here. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archi

[PATCH 1/4] Let CheckPassiveGrabsOnWindow callers check if device is already grabbed.

2010-08-04 Thread Jamey Sharp
CheckDeviceGrabs checked all the ancestors of the window containing this device's pointer even if no new grabs could possibly apply due to the device already being grabbed. ActivateFocusInGrab and ActivateEnterGrab already checked whether they should break an existing grab, and then set up an even

[PATCH 3/4] Move replay-window check from ComputeFreezes to CheckDeviceGrabs.

2010-08-04 Thread Jamey Sharp
This just simplifies ComputeFreezes, eliminating some duplicated code and a goto. Signed-off-by: Jamey Sharp Cc: Peter Hutterer --- dix/events.c | 43 ++- include/dix.h |2 +- 2 files changed, 19 insertions(+), 26 deletions(-) diff --git a/dix/eve

[PATCH 2/4] CheckDeviceGrabs: Delete redundant pWin->optional test.

2010-08-04 Thread Jamey Sharp
CheckPassiveGrabsOnWindow returns FALSE if pWin->optional is NULL, because wPassiveGrabs uses wUseDefault, so don't bother checking at the caller. Signed-off-by: Jamey Sharp Cc: Peter Hutterer --- dix/events.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dix/eve

[PATCH 4/4] Use GetCurrentRootWindow or equivalent instead of spriteTrace[0].

2010-08-04 Thread Jamey Sharp
Signed-off-by: Jamey Sharp Cc: Peter Hutterer --- dix/devices.c|2 +- dix/enterleave.c | 13 - dix/events.c |2 +- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/dix/devices.c b/dix/devices.c index ac5806a..12ce890 100644 --- a/dix/devices.c +++ b/d

minor input cleanups or optimizations

2010-08-04 Thread Jamey Sharp
I found the spriteTrace and focus trace arrays weird and confusing, so I put some thought into killing them with minimal performance impact. I haven't managed to do that, but I did find some code improvements along the way. Those follow. Peter, please pull these into your input-next tree if you lik

Re: Select() failing with EAGAIN?

2010-08-04 Thread Fernando Carrijo
Adam Jackson wrote: > On Tue, 2010-08-03 at 17:28 -0300, Fernando Carrijo wrote: > > The Open Group documentation for Select does not mention it failing with > > EAGAIN. > > > > http://opengroup.org/onlinepubs/007908775/xsh/select.html > > > > Even so, we check for this error after Select is

Re: [RFC] configure/makefile cleanup

2010-08-04 Thread Tomas Carnecky
On 8/4/10 6:28 PM, Tiago Vignatti wrote: > Hi Tomas, > > On Tue, Aug 03, 2010 at 10:34:09PM +0200, ext Tomas Carnecky wrote: >> The gloal of this patchset is to simplify the configure.ac script and >> the makefiles, especially the definitions of variables which hold the >> set of libraries linked

Re: [PATCH 1/6] Add MAIN_LIB as the first library to server libs

2010-08-04 Thread Tomas Carnecky
On 8/4/10 6:06 PM, Tiago Vignatti wrote: > On Tue, Aug 03, 2010 at 10:34:10PM +0200, ext Tomas Carnecky wrote: >> MAIN_LIB only implements the main() method and doesn't provide anything >> that other libraries would depend on. So it can go as the very first >> into the set of libraries linked to ea

Re: [RFC] configure/makefile cleanup

2010-08-04 Thread Gaetan Nadon
On Wed, 2010-08-04 at 19:28 +0300, Tiago Vignatti wrote: > Also, RENDER is an extension that right now is mandatory to be > built (28b7b2b8) but some systems may not want to build this (e.g. > MeeGo + QT > 4.7 will do everything through GL) One more thing to watch for, this was recently added in

Re: [RFC] configure/makefile cleanup

2010-08-04 Thread Tiago Vignatti
Hi Tomas, On Tue, Aug 03, 2010 at 10:34:09PM +0200, ext Tomas Carnecky wrote: > The gloal of this patchset is to simplify the configure.ac script and > the makefiles, especially the definitions of variables which hold the > set of libraries linked to each server. > > There are libraries which eac

Re: [PATCH 1/6] Add MAIN_LIB as the first library to server libs

2010-08-04 Thread Tiago Vignatti
On Tue, Aug 03, 2010 at 10:34:10PM +0200, ext Tomas Carnecky wrote: > MAIN_LIB only implements the main() method and doesn't provide anything > that other libraries would depend on. So it can go as the very first > into the set of libraries linked to each server. > One exception is darwin/xquartz w

Re: [PATCH 2/6] xfree86: Remove prototypes for non-existant functions.

2010-08-04 Thread Tiago Vignatti
On Wed, Aug 04, 2010 at 07:32:50AM +0200, ext Matt Turner wrote: > > Unless someone else has a -next tree set up, I'll create one and > vacuum up these patches. please do so Matt. And Patchwork would probably be useful for you then: http://patchwork.freedesktop.org/project/Xorg/list/ Thanks

Re: [PATCH 1/2] dix: Better document Dispatch(), WaitForSomething() and alike

2010-08-04 Thread Vignatti Tiago (Nokia-MS/Helsinki)
On Wed, Aug 04, 2010 at 08:41:11AM +0200, ext Fernando Carrijo wrote: > Tiago Vignatti wrote: > > > > --- a/dix/dispatch.c > > > +++ b/dix/dispatch.c > > > @@ -240,6 +240,20 @@ long SmartLastPrint; > > > voidDispatch(void); > > > voidInitProcVectors(void); > > > > > >

Re: Generating HDMI 1.4 compliant 3D images?

2010-08-04 Thread Barry Scott
On Thursday 15 July 2010 09:35:46 Florian Echtler wrote: > Hello everyone, > > here at the university, we've recently acquired a 3D plasma display > which supports 3D data compliant to HDMI 1.4. Sending 3D data in 1080p > side-by-side format is pretty simple, however, you lose half of the > horizo

Re: [PATCH] os: Turn off the scheduler alarm after an arbitrary length of time

2010-08-04 Thread Vignatti Tiago (Nokia-MS/Helsinki)
On Mon, Aug 02, 2010 at 07:34:57PM +0200, ext Adam Jackson wrote: > On Mon, 2010-08-02 at 17:40 +0300, Tiago Vignatti wrote: > > just wondering what made you think 10 is a good number? > > I'd be lying if I said I thought very hard about it. The way the > defaults work out, the maximum timeslice

Re: Select() failing with EAGAIN?

2010-08-04 Thread Adam Jackson
On Tue, 2010-08-03 at 17:28 -0300, Fernando Carrijo wrote: > The Open Group documentation for Select does not mention it failing with > EAGAIN. > > http://opengroup.org/onlinepubs/007908775/xsh/select.html > > Even so, we check for this error after Select is called in WaitForSomething. > > An

Re: [PATCH 6/6] Clean up Xext/Makefile.am

2010-08-04 Thread Tomas Carnecky
On 8/3/10 7:27 PM, Jamey Sharp wrote: > One note on this patch: > > On Sun, Aug 01, 2010 at 09:28:23PM +0200, Tomas Carnecky wrote: >> -INCLUDES = -I$(top_srcdir)/hw/xfree86/dixmods/extmod @XORG_INCS@ >> +INCLUDES = @XORG_INCS@ > > Doesn't this change belong in the earlier patch that deletes the

Re: [PATCH 5/6] Make the SELinux extension builtin

2010-08-04 Thread Tomas Carnecky
On 8/4/10 3:40 AM, Peter Hutterer wrote: > the problem is that other DDXs don't have a config file and xf86FindOption > would be undefined or at least meaningless. This is the reason why all this > is split into DIX/DDX code, by moving this in - even with the ifdefs in > place you're losing this di

Re: [RFC] configure/makefile cleanup

2010-08-04 Thread Tomas Carnecky
On 8/3/10 10:34 PM, Tomas Carnecky wrote: > Especially difficult was to figure out which extensions depend on what, > as you see in patch 3, OS_LIB depends on FIXES_LIB (EnabledCursor). > Then also RENDER_LIB depends on OS_LIB (x_sha1_* methods) and there > may be other dependencies which I'm not a

Re: [PATCH 2/6] Make the DPMS, ScreenSaver and Res extensions builtin

2010-08-04 Thread Tomas Carnecky
On 8/4/10 3:39 AM, Peter Hutterer wrote: > On Sun, Aug 01, 2010 at 09:28:19PM +0200, Tomas Carnecky wrote: >> The change is trivial: simply move the ExtensionModule definitions from >> hw/xfree/dixmods/extmod/modinit.c to mi/miinitext.c. Then also make sure >> the required sources for those extensi

Re: [PATCH] rootless: fix uninitialized private key assert in non-rootless modes on cygwin

2010-08-04 Thread Colin Harrison
Hi, I've reviewed and tested this patch, but only using the XWin DDX. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 4/6] xfree86: Fix leaks in OpenConfigFile and OpenConfigDir

2010-08-04 Thread Mark Kettenis
> From: Jesse Adkins > Date: Tue, 3 Aug 2010 18:21:31 -0700 This still has the indentation messed up. > Signed-off-by: Jesse Adkins > --- > hw/xfree86/parser/scan.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/sca

Re: [PATCH 3/6] xfree86: Simplify xf86Msg{,Verb}

2010-08-04 Thread Mark Kettenis
> From: Jesse Adkins > Date: Tue, 3 Aug 2010 18:21:30 -0700 > > Previously, the functions would call xf86VDrvMsgVerb with a screen of -1 > despite their comments saying they were for "non-driver messages". > They now call LogVMessageVerb, which is what xf86VDrvMsgVerb does anyway > when it has