Re: [PATCH app-xdm 00/23] Review xdm configuration - Part 2

2010-09-01 Thread Gaetan Nadon
On Wed, 2010-09-01 at 15:54 -0700, Alan Coopersmith wrote: > BTW, this check fails to find getifaddrs() on Solaris releases that > have it: > > +AC_CHECK_FUNCS(mkstemp getifaddrs getspnam) > > You need to move the XTRANS_CONNECTION_FLAGS before it so that the > required > libraries for the socket

Re: [PATCH app-xdm 00/23] Review xdm configuration - Part 2

2010-09-01 Thread Alan Coopersmith
Gaetan Nadon wrote: > Mostly platform checks, defines and functions I can't speak for the other platforms, but it builds fine on Solaris with the Sun compilers, and I don't see anything I'd object to. I'd like to hear if the people building for those platforms see any problems. A few comments:

Re: removing PCI dependency from xserver

2010-09-01 Thread Mark Kettenis
> Date: Wed, 1 Sep 2010 18:00:57 +0300 > From: Tiago Vignatti > > Hi all, > > Right now, we have two impediments preventing me to put libpciaccess optional > in xserver: > > 1. fbdevhw module, which is PCI tied > 2. IOADDRESS type (weird) definition > > My last attempt to get rid of PCI in fbd

Re: [PATCH 3/3] dix: ddx: Lift input handling duties from xf86 to dix

2010-09-01 Thread Alan Coopersmith
Fernando Carrijo wrote: >> (You could either try >> to work out which one applies based on the XFree86 cvs history or just take >> the easy way out and copy both, since both are licenses we already have all >> over the tree.) > > I'm a bit confused, Alan. > > I thought both licenses applied. Don'

[PATCH app-xdm 23/23] config: look for PAM support on darwin as well

2010-09-01 Thread Gaetan Nadon
There is an assumption that PAM support is not available on darwin. A quick browse on the net indicates otherwise. It won't hurt to do an AC_SEARCH_LIBS to find out. Signed-off-by: Gaetan Nadon --- configure.ac | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/c

[PATCH app-xdm 22/23] config: use AC_CHECK_FUNCS for mkstemp, getifaddrs ans getspnam

2010-09-01 Thread Gaetan Nadon
AC_CHECK_FUNCS adds an AC_DEFINE of HAVE_XXX in addition of checking for the functions. It has a consistent naming convention. Signed-off-by: Gaetan Nadon --- auth.c | 14 +++--- configure.ac | 13 + greet.h |6 +++--- greeter/greet.c |4 ++

[PATCH app-xdm 21/23] config: removed unused XDM_OS_LIBS

2010-09-01 Thread Gaetan Nadon
Using AC_SEARCH_LIBS in previous patches removes the need for this. The libraries, e.g -lutil are added to LIBS. Signed-off-by: Gaetan Nadon --- configure.ac |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 707d8a4..1906d5c 100644 --- a

[PATCH app-xdm 20/23] config: use AC_SEARCH_LIBS and AC_CHECK_FUNCS for setusercontext

2010-09-01 Thread Gaetan Nadon
It does the same thing, but on one line. Only difference is that -lutil is added to LIBS so it is available to all targets. This is done elsewhere for PAM and selinux checks. Signed-off-by: Gaetan Nadon --- configure.ac | 10 +- dm.h |2 +- session.c| 12 ++--

[PATCH app-xdm 19/23] config: use AC_SEARCH_LIBS and AC_CHECK_FUNCS for setprocttile

2010-09-01 Thread Gaetan Nadon
It does the same thing, but on one line. Added "bsd" on the libs search list for Debian. Only difference is that -lutil is added to LIBS so it is available to all targets. This is done elsewhere for PAM and selinux checks. Signed-off-by: Gaetan Nadon --- choose.c |2 +- configure.ac |

[PATCH app-xdm 18/23] config: replace platform check with compiler defines for SU

2010-09-01 Thread Gaetan Nadon
The intent for the platform check for SU is to use "su -m" for BSD-like systems. The compiler already provide defines for such systems. Signed-off-by: Gaetan Nadon --- config/Makefile.am|2 +- config/xdm-config.cpp |7 ++- configure.ac | 24 3

[PATCH app-xdm 17/23] config: remove unused OS_CFLAGS variable

2010-09-01 Thread Gaetan Nadon
Now unused as a result of previous patches Signed-off-by: Gaetan Nadon --- configure.ac |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 579988e..f01b1ee 100644 --- a/configure.ac +++ b/configure.ac @@ -152,23 +152,18 @@ fi cas

[PATCH app-xdm 16/23] config: use AC_CHECK_HEADERS for sys/param.h

2010-09-01 Thread Gaetan Nadon
This is the FreeBSD porting guide recommended method to check for BSD 4.3 Net2 or newer systems. Signed-off-by: Gaetan Nadon --- auth.c | 10 ++ chooser.c| 10 ++ configure.ac |2 +- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/auth.c b/auth.c

[PATCH app-xdm 15/23] config: definition of CSRG_BASED in configure.ac is flawed and redundant

2010-09-01 Thread Gaetan Nadon
CSRG_BASED is defined in both the xserver using platform checks and in Xosdefs.h using compiler macros. The one from X11/Xosdefs.h will be used through already included headers: # if defined(__OpenBSD__) || defined(__NetBSD__) || defined(__FreeBSD__) \ || defined(__APPLE__) || defined(__Dr

[PATCH app-xdm 14/23] config: remove unused define NO_LASTLOG for Darwin

2010-09-01 Thread Gaetan Nadon
This would be used to support lasltlog as sessreg does, however no code makes use of it. A code search shows that this is a macro only defined in app/sessreg. No such macros could be found in Darwin OS. Signed-off-by: Gaetan Nadon --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1

[PATCH app-xdm 13/23] config: use libtool -export-dynamic option for reverse dependencies

2010-09-01 Thread Gaetan Nadon
This replaces -rdynamic which is a GNU/Linux only solution. "If symbols from your executable are needed to satisfy unresolved references in a library you want to dlopen you will have to use the flag -export-dynamic. You should use -export-dynamic while linking the executable that calls dlopen." I

[PATCH app-xdm 12/23] config: AC_LIBTOOL_DLOPEN is required for dynamic linking

2010-09-01 Thread Gaetan Nadon
It adds the following tests in the configuration : checking for shl_load... no checking for shl_load in -ldld... no checking for dlopen... no checking for dlopen in -ldl... yes checking whether a program can dlopen itself... yes checking whether a statically linked program can dlopen itself... no

[PATCH app-xdm 00/23] Review xdm configuration - Part 2

2010-09-01 Thread Gaetan Nadon
Mostly platform checks, defines and functions Gaetan Nadon (12): config: AC_LIBTOOL_DLOPEN is required for dynamic linking config: use libtool -export-dynamic option for reverse dependencies config: remove unused define NO_LASTLOG for Darwin config: definition of CSRG_BASED in configure.ac

Re: [PATCH 3/3] dix: ddx: Lift input handling duties from xf86 to dix

2010-09-01 Thread Fernando Carrijo
Alan Coopersmith wrote: > Fernando Carrijo wrote: > > From: Fernando Carrijo > > > > Signed-off-by: Fernando Carrijo > > Signed-off-by: Tiago Vignatti > > --- > > dix/inputhandler.c | 109 ++-- > > hw/xfree86/common/xf86Events.c | 122 > > +++---

Re: removing PCI dependency from xserver

2010-09-01 Thread Vignatti Tiago (Nokia-MS/Helsinki)
On Wed, Sep 01, 2010 at 06:17:58PM +0200, ext Gaetan Nadon wrote: > On Wed, 2010-09-01 at 18:00 +0300, Tiago Vignatti wrote: > > > Please, I need feedback here to keep with this work. Mark, do you have > > some > > suggestions how to proceed? Once I've done with 1. and .2 I can roll > > my > > bus

Re: removing PCI dependency from xserver

2010-09-01 Thread Alan Coopersmith
Gaetan Nadon wrote: > On Wed, 2010-09-01 at 18:00 +0300, Tiago Vignatti wrote: >> Please, I need feedback here to keep with this work. Mark, do you have >> some >> suggestions how to proceed? Once I've done with 1. and .2 I can roll my >> bus-cleanup-take3 tree [2] again and conditionalize libpciac

Re: removing PCI dependency from xserver

2010-09-01 Thread Gaetan Nadon
On Wed, 2010-09-01 at 18:00 +0300, Tiago Vignatti wrote: > Please, I need feedback here to keep with this work. Mark, do you have > some > suggestions how to proceed? Once I've done with 1. and .2 I can roll > my > bus-cleanup-take3 tree [2] again and conditionalize libpciaccess from > the > serve

Re: [PATCH v2 app-xdm 4/4] man: build man page using sed rather than the C preprocessor

2010-09-01 Thread Alan Coopersmith
Thanks - Reviewed-by: Alan Coopersmith Gaetan Nadon wrote: > This fixes misalignments to correctly display \n and \ for sample file. > No source code changes needed to fix that. > > Replace XCOMM IMakefile comment with #. > > Replace #if with: > .if !'x.VARNAME'x.' .ig > [man page text] > .. >

removing PCI dependency from xserver

2010-09-01 Thread Tiago Vignatti
Hi all, Right now, we have two impediments preventing me to put libpciaccess optional in xserver: 1. fbdevhw module, which is PCI tied 2. IOADDRESS type (weird) definition My last attempt to get rid of PCI in fbdevhw [0] was only commented by Mark Kettenis. He mainly pointed the existence of fb

Re: Xephyr with DRI/DRI2

2010-09-01 Thread Tiago Vignatti
Hi Haitao, On Mon, Aug 30, 2010 at 08:41:47AM +0200, ext Feng, Haitao wrote: > > In May I have submitted code patches to enable DRI2 extension for Xephyr. In > that patch, I have preferred to use DRI extension to get OpenGL acceleration, > and if there is no DRI extension, I will use DRI2 extensi