Re: [PATCH] composite: only update window contents when using automatic redirection

Hey Jesse, On 09/07/2010 12:48 PM, Jesse Barnes wrote: > Brian pointed this out awhile back but the fix was never merged. So > here's a real patch. Would be nice to get into 1.9.x as well if it > proves ok in master. Thanks for picking this up again. For what it's worth, we've been running wit

Re: [PATCH 15/19] xfree86: don't export xf86InputDevs.

Peter Hutterer wrote: > On Tue, Sep 07, 2010 at 11:37:33PM -0300, Fernando Carrijo wrote: > > Peter Hutterer wrote: > > > > > Use xf86FirstLocalDevice() instead (but don't get me started on the naming > > > of that one...) > > > > Yeah, a poorly chosen name indeed. > > > > > Signed-off-by: Pe

Re: [PATCH 15/19] xfree86: don't export xf86InputDevs.

On Tue, Sep 07, 2010 at 11:37:33PM -0300, Fernando Carrijo wrote: > Peter Hutterer wrote: > > > Use xf86FirstLocalDevice() instead (but don't get me started on the naming > > of that one...) > > Yeah, a poorly chosen name indeed. > > > Signed-off-by: Peter Hutterer > > Reviewed-by: Fernando C

Re: [PATCH 15/19] xfree86: don't export xf86InputDevs.

Peter Hutterer wrote: > Use xf86FirstLocalDevice() instead (but don't get me started on the naming > of that one...) Yeah, a poorly chosen name indeed. > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.h |2 +- > 1 files changed, 1 inser

Re: [PATCH 13/19] xfree86: remove XI_PRIVATE macro, unused.

Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > hw/xfree86/common/xf86Xinput.h |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.h b/hw/xfree86/common/xf86Xinput.h > index a0791d1..499528e 100644 > --- a/hw/xfree86/common/

Re: [PATCH 12/19] xfree86: update comment for xf86DeleteInput

Peter Hutterer wrote: > We have a driver hook - it's UnInit. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/c

Re: [PATCH 10/19] xfree86: plug minor memory leak.

Peter Hutterer wrote: > When no identifier for the device was specified, the allocated IDevRec (and > its associated fields) need to be freed. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |3 ++- > 1 files changed, 2 insertions(+

Re: [PATCH 1/3] os/xfree86: remove macro checking for POSIX symbols

Hi! On Tue, 2010-09-07 at 15:39:17 +0300, Tiago Vignatti wrote: > We assume already that our X implementation is POSIX compliant anyway. So > remove those redundant checking. Well POSIX-1.2001, some of these are still XSI extensions, namely SIGSYS, SIGVTALRM, SIGXCPU, SIGXFSZ (which only switched

Re: [PATCH 07/19] xfree86: remove some ifdef 0 code.

Peter Hutterer wrote: > InputInfoRec hasn't had a free function pointer since the git import. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/hw/xfree86

Re: [PATCH 06/19] xfree86: move a declaration down to the block it is used in.

Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c > index 1b986e3..b27798

Re: [PATCH 05/19] xfree86: minor comment fix. HAL → config backend

Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c > index d5d03e9..1b986e3

Re: [PATCH 04/19] xfree86: skip a few NULL initialization, calloc does it for us.

Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c > index 538a98b..d5d0

Re: [PATCH 03/19] xfree86: remove conversion procs and close proc from InputInfoRec.

Peter Hutterer wrote: > None of them are called by the server. > > Signed-off-by: Peter Hutterer Reviewed-by: Fernando Carrijo > --- > hw/xfree86/common/xf86Xinput.c |3 --- > hw/xfree86/common/xf86Xinput.h |8 > 2 files changed, 0 insertions(+), 11 deletions(-) > > diff --

Re: [PATCH 1/3] os/xfree86: remove macro checking for POSIX symbols

Hi, On Tue, Sep 07, 2010 at 03:39:17PM +0300, Tiago Vignatti wrote: > -#ifdef SA_SIGINFO > OsSigHandler(int signo, siginfo_t *sip, void *unused) > -#else > -OsSigHandler(int signo) > -#endif Please leave the SA_SIGINFO stuff in for now: SA_SIGINFO is unfortunately still not implemented on the H

Re: [PATCH libXext] sync declarations/definitions of xgeExtRegister()

On Tue, Sep 07, 2010 at 01:31:20PM -0700, Alan Coopersmith wrote: > Shouldn't this just go into an internal .h instead of trying to keep > definitions > in sync between multiple *.c files? > > -alan- > > Rémi Cardona wrote: > > src/extutil.c has _X_HIDDEN while src/Xge.c didn't. This appar

Re: [PATCH 02/19] Remove atom field from InputInfoRec.

On Tue, Sep 07, 2010 at 01:40:49PM -0700, Alan Coopersmith wrote: > Peter Hutterer wrote: > > This field was only used in one location where we can use a local variable. > > -Atom atom; > > The mouse & vmmouse drivers seem to use this in a debug message that would > need to be fi

Re: [PATCH 2/6] mi: change GE extension name to something painless for registry parsing

On Tue, Sep 07, 2010 at 08:17:21AM -0700, Aaron Plattner wrote: > On Tue, Sep 07, 2010 at 05:50:23AM -0700, Tiago Vignatti wrote: > > in the next commit this changes will makes more sense. > > > > Signed-off-by: Tiago Vignatti > > --- > > mi/miinitext.c |2 +- > > 1 files changed, 1 insertio

Re: [PATCH] composite: only update window contents when using automatic redirection

On Tue, 7 Sep 2010 12:48:32 -0700, Jesse Barnes wrote: > Brian pointed this out awhile back but the fix was never merged. So > here's a real patch. Would be nice to get into 1.9.x as well if it > proves ok in master. Looks like there are additional optimizations available here -- we're doing

Re: [PATCH] mouse wheel acceleration

Am 07.09.2010 17:44, schrieb Albert Zeyer: > Hi Simon, Tiago and list, > > Simon Thum: >> Hi Albert, >> >> the code looks good to me in general. Besides some technicalities, >> there may be a larger problem: There is an effort to support wheels with >> higher precision (github.com/x-quadraht/pscr

Re: [PATCH 3/4] xfree86: fbdevhw: remove superfluous pci pointer from probe function

> From: Tiago Vignatti > Date: Tue, 7 Sep 2010 15:18:48 +0300 > > The only drivers using this function are fbdev and glint. Though those driver > initialize with NULL argument. Other drivers do some kind of implicit probe > using fbdevHWInit instead. > > API break. Sorry, but I really fail to

Re: [PATCH 02/19] Remove atom field from InputInfoRec.

Peter Hutterer wrote: > This field was only used in one location where we can use a local variable. > -Atom atom; The mouse & vmmouse drivers seem to use this in a debug message that would need to be fixed: #ifdef EXTMOUSEDEBUG ErrorF("assigning %p atom=%d name=%s\n",

Re: [PATCH libXext] sync declarations/definitions of xgeExtRegister()

Shouldn't this just go into an internal .h instead of trying to keep definitions in sync between multiple *.c files? -alan- Rémi Cardona wrote: > src/extutil.c has _X_HIDDEN while src/Xge.c didn't. This apparently went > unnoticed by most compilers for a while, but not on Gentoo-prefix/am

[PATCH] composite: only update window contents when using automatic redirection

Brian pointed this out awhile back but the fix was never merged. So here's a real patch. Would be nice to get into 1.9.x as well if it proves ok in master. This change can significantly improve performance on machines with low memory bandwidth. Reported-by: "Brian J. Tarricone" Signed-off-by:

Re: [PATCH] xace: don't export symbols

Tiago Vignatti wrote: > All hook entry points are supposed to be used internally. > > /* Entry point for hook functions. Called by Xserver. > * Required by libdbe and libextmod > */ The comment in the code disagrees with your explanation. Are there no extensions left in loadable modules?

Re: [PATCH] mouse wheel acceleration

Hi Simon, Tiago and list, Simon Thum: Hi Albert, the code looks good to me in general. Besides some technicalities, there may be a larger problem: There is an effort to support wheels with higher precision (github.com/x-quadraht/pscroll). Ah, quite interesting. While my solution worked quite f

Re: [PATCH 2/3] os: remove useless smart scheduler macros

On 07/09/2010 13:39, Tiago Vignatti wrote: Signed-off-by: Tiago Vignatti --- os/utils.c | 21 ++--- 1 files changed, 2 insertions(+), 19 deletions(-) diff --git a/os/utils.c b/os/utils.c index 547acfc..bf3d615 100644 --- a/os/utils.c +++ b/os/utils.c @@ -1116,17 +1116,9 @@

Re: [PATCH 1/6] xext: remove unused header

Reviewed-by: Jeremy Huddleston On Sep 7, 2010, at 05:50, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- > Xext/geext.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/Xext/geext.c b/Xext/geext.c > index e61989c..8319c92 100644 > --- a/Xext/geext.c > ++

Re: [PATCH 2/2] dix: remove proc tables initialization

Could you add some more counters (like the /* 120 */) along the way? On Sep 7, 2010, at 05:48, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- > dix/dispatch.c | 20 --- > dix/main.c |4 - > dix/tables.c | 508 ++-- > 3 fi

Re: [PATCH 3/3] os: simplify smart scheduler init process

Reviewed-by: Jeremy Huddleston On Sep 7, 2010, at 05:39, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- > include/dixstruct.h |2 +- > os/osinit.c |4 +--- > os/utils.c |9 - > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/incl

Re: [PATCH 2/3] os: remove useless smart scheduler macros

Reviewed-by: Jeremy Huddleston On Sep 7, 2010, at 05:39, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- > os/utils.c | 21 ++--- > 1 files changed, 2 insertions(+), 19 deletions(-) > > diff --git a/os/utils.c b/os/utils.c > index 547acfc..bf3d615 100644 > --- a/os

Re: [PATCH 1/3] os/xfree86: remove macro checking for POSIX symbols

Reviewed-by: Jeremy Huddleston On Sep 7, 2010, at 05:39, Tiago Vignatti wrote: > We assume already that our X implementation is POSIX compliant anyway. So > remove those redundant checking. > > Signed-off-by: Tiago Vignatti > --- > hw/xfree86/common/xf86Init.c | 10 -- > hw/xfree86/pa

Re: Fixing effective touch point position inside the touched area

Hi Chase, On 7 September 2010 16:35, Chase Douglas wrote: >> Touching a screen with a finger usually produces quite a big area of >> touch and the problem raises is what is the effective touch point >> inside the area - as I can see it supposed to be somewhere in the top >> part of the touched ar

Re: [PATCH 2/6] mi: change GE extension name to something painless for registry parsing

On Tue, Sep 07, 2010 at 05:50:23AM -0700, Tiago Vignatti wrote: > in the next commit this changes will makes more sense. > > Signed-off-by: Tiago Vignatti > --- > mi/miinitext.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mi/miinitext.c b/mi/miinitext.c > inde

Re: Fixing effective touch point position inside the touched area

On Tue, 2010-09-07 at 14:05 +0200, Denis Dzyubenko wrote: > Hello guys, Hi Denis, > While looking through the drafts on the XInput2.1 specification as > published by Daniel Stone and Peter Hutterer, I've noticed one thing > that might be missing there. > > Touching a screen with a finger usually

[PATCH 6/6 HACK] dix: introduce a hack for logging server workload

I don't expect this patch to be applied to vanilla xserver. It logs X11 requests and their time spent being processed, writing in a file. Also the input processing is recorded. This all can be used for characterization of the workload. X Registery code is used to get the name (parsing protocol.tx

[PATCH 1/6] xext: remove unused header

Signed-off-by: Tiago Vignatti --- Xext/geext.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/Xext/geext.c b/Xext/geext.c index e61989c..8319c92 100644 --- a/Xext/geext.c +++ b/Xext/geext.c @@ -28,7 +28,6 @@ #endif #include "windowstr.h" #include -#include "registry.

[PATCH 4/6] dix: update DRI2 requests to protocol.txt

Signed-off-by: Tiago Vignatti --- dix/protocol.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dix/protocol.txt b/dix/protocol.txt index 81f500e..be9c7fd 100644 --- a/dix/protocol.txt +++ b/dix/protocol.txt @@ -124,6 +124,11 @@ R004 DRI2:DestroyDrawable R005 DRI2

[PATCH 2/6] mi: change GE extension name to something painless for registry parsing

in the next commit this changes will makes more sense. Signed-off-by: Tiago Vignatti --- mi/miinitext.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mi/miinitext.c b/mi/miinitext.c index a7441c9..179cb9f 100644 --- a/mi/miinitext.c +++ b/mi/miinitext.c @@ -477,7 +477

[PATCH 5/6] dix: remove dead extensions to protocol.txt

lbx and mbe. Signed-off-by: Tiago Vignatti --- dix/protocol.txt | 59 -- 1 files changed, 0 insertions(+), 59 deletions(-) diff --git a/dix/protocol.txt b/dix/protocol.txt index be9c7fd..6127a61 100644 --- a/dix/protocol.txt +++ b/dix/protoc

[PATCH 3/6] dix: update GE request to protocol.txt

Signed-off-by: Tiago Vignatti --- dix/protocol.txt |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dix/protocol.txt b/dix/protocol.txt index 8e152ed..81f500e 100644 --- a/dix/protocol.txt +++ b/dix/protocol.txt @@ -132,6 +132,7 @@ R002 FontCache:ChangeCacheSettings R003

[PATCH 2/2] dix: remove proc tables initialization

Signed-off-by: Tiago Vignatti --- dix/dispatch.c | 20 --- dix/main.c |4 - dix/tables.c | 508 ++-- 3 files changed, 492 insertions(+), 40 deletions(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index 0e5aced..17f308c 100644 ---

[PATCH 1/2] xserver: delete pervasively use of DISPATCH_PROC

Some functions had to be moved around due some missing static definitions. Another minor clean up like inexistent function declarations and etc were made also. Part of this patch was cooked using: sed -i -e '/static DISPATCH_PROC*.*;/d' `git ls-files` Signed-off-by: Tiago Vignatti --- Xext/bigr

[PATCH 1/3] os/xfree86: remove macro checking for POSIX symbols

We assume already that our X implementation is POSIX compliant anyway. So remove those redundant checking. Signed-off-by: Tiago Vignatti --- hw/xfree86/common/xf86Init.c | 10 -- hw/xfree86/parser/write.c|4 os/osinit.c | 17 - os/utils.c

[PATCH 3/3] os: simplify smart scheduler init process

Signed-off-by: Tiago Vignatti --- include/dixstruct.h |2 +- os/osinit.c |4 +--- os/utils.c |9 - 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/include/dixstruct.h b/include/dixstruct.h index efa2577..8547b16 100644 --- a/include/dixstruct.h

[PATCH 2/3] os: remove useless smart scheduler macros

Signed-off-by: Tiago Vignatti --- os/utils.c | 21 ++--- 1 files changed, 2 insertions(+), 19 deletions(-) diff --git a/os/utils.c b/os/utils.c index 547acfc..bf3d615 100644 --- a/os/utils.c +++ b/os/utils.c @@ -1116,17 +1116,9 @@ XNFstrdup(const char *s) return ret; }

[PATCH] xace: don't export symbols

All hook entry points are supposed to be used internally. Signed-off-by: Tiago Vignatti --- Xext/xace.c |2 +- Xext/xace.h | 18 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Xext/xace.c b/Xext/xace.c index c757cad..669a03e 100644 --- a/Xext/xace.c +++

[PATCH fbdev driver] fbdevhw: adjust new probing interface

Signed-off-by: Tiago Vignatti --- src/fbdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fbdev.c b/src/fbdev.c index c97ce1c..afa0934 100644 --- a/src/fbdev.c +++ b/src/fbdev.c @@ -248,7 +248,7 @@ static Bool FBDevPciProbe(DriverPtr drv, int entity_num,

[PATCH 4/4] xfree86: fbdevhw: simplify fbdev_open_pci function

delete unused namep. Signed-off-by: Tiago Vignatti --- hw/xfree86/fbdevhw/fbdevhw.c | 20 1 files changed, 4 insertions(+), 16 deletions(-) diff --git a/hw/xfree86/fbdevhw/fbdevhw.c b/hw/xfree86/fbdevhw/fbdevhw.c index d57e07e..f2035f8 100644 --- a/hw/xfree86/fbdevhw/fbde

[PATCH glint driver] fbdevhw: adjust new probing interface

Signed-off-by: Tiago Vignatti --- src/glint_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glint_driver.c b/src/glint_driver.c index ffafc39..1f4aa44 100644 --- a/src/glint_driver.c +++ b/src/glint_driver.c @@ -518,7 +518,7 @@ GLINTProbe(DriverPtr drv, int

[PATCH 3/4] xfree86: fbdevhw: remove superfluous pci pointer from probe function

The only drivers using this function are fbdev and glint. Though those driver initialize with NULL argument. Other drivers do some kind of implicit probe using fbdevHWInit instead. API break. Signed-off-by: Tiago Vignatti --- hw/xfree86/fbdevhw/fbdevhw.c |7 ++- hw/xfree86/fbdevhw/f

[PATCH 1/4] xfree86: fbdevhw: remove unused cmap fields from main structure

It was never used since first git revision and probably no one cares for it. ABI break. Signed-off-by: Tiago Vignatti --- hw/xfree86/fbdevhw/fbdevhw.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/hw/xfree86/fbdevhw/fbdevhw.c b/hw/xfree86/fbdevhw/fbdevhw.c inde

[PATCH 2/4] xfree86: fbdevhw: remove unnecessary debug code

It very likely no one will want to print all functions of this file for debugging purposes. If this is the case, then a mix of ctags + cpp + gdb can do the same job. Signed-off-by: Tiago Vignatti --- hw/xfree86/fbdevhw/fbdevhw.c | 35 --- 1 files changed, 0 inse

[PATCH 0/4 v3] fbdevhw cleanup

Hi, In version #3 of this series, I removed the last two patches in which I got comments from Mark Kettenis. Mark didn't like the approach I used to scatter code concerning only Linux and PCI outside fbdevhw module. IMHO this is more a matter of personal codying style, but I'm okay with it. Discus

Re: [PATCH v2] xfree86: remove IDevRec, replace with InputInfoRec.

On Tue, Sep 07, 2010 at 01:42:47AM +0200, ext Peter Hutterer wrote: > This struct is superfluous, maintaining the same info as the InputInfoRec > (with the exception of the driver name). > > This is a rather large commit with the majority of changes being a rename > from the fields of the IDevRec

Re: [PATCH 16/19] xfree86: remove {Dont}SendCoreEvents defines

Hi, On Mon, Sep 06, 2010 at 07:06:22PM +0200, ext Julien Cristau wrote: > I don't think anybody said that, and there are plenty of > counter-examples. Where did you get that quote? refer below, Julien. On Tue, Sep 07, 2010 at 12:03:59AM +0200, ext Peter Hutterer wrote: > On Mon, Sep 06, 2010

Fixing effective touch point position inside the touched area

Hello guys, While looking through the drafts on the XInput2.1 specification as published by Daniel Stone and Peter Hutterer, I've noticed one thing that might be missing there. Touching a screen with a finger usually produces quite a big area of touch and the problem raises is what is the effect